| pslestang | hey all | 09:12 |
|---|---|---|
| pslestang | dansmith: thanks for the review of https://review.opendev.org/c/openstack/glance-specs/+/836132 | 09:13 |
| pslestang | I have some points I'd like to disucss | 09:14 |
| pslestang | first one https://review.opendev.org/c/openstack/glance-specs/+/836132/6/specs/zed/approved/glance/glance-download-import.rst#59 | 09:14 |
| pslestang | when designing the specs, we were thinking that It was a good idea to not copy the metadata on plugin side as the image must be created before the import | 09:17 |
| pslestang | so we let the responsability to the enduser to be in charge of that | 09:18 |
| pslestang | but we could have an option in the plugin that would copy the matadata if the enduser explicitly ask for | 09:19 |
| pslestang | regarding this comment https://review.opendev.org/c/openstack/glance-specs/+/836132/6/specs/zed/approved/glance/glance-download-import.rst#66 | 09:30 |
| pslestang | I agree that I could go more into details, your take out idea sounds good and might be included | 09:31 |
| pslestang | I also know that jokke_ has an idea in mind (I don't know in details) and that we should talk about this week with alistarle | 09:34 |
| opendevreview | Felix Huettner proposed openstack/glance master: Fix deletion of disabled images https://review.opendev.org/c/openstack/glance/+/778951 | 12:40 |
| *** timburke_ is now known as timburke | 13:04 | |
| idjoshua | Hi @mrjoshi and @croelandt. Is it at all possible to successfully run the entire test suite for glance or glanceclient on a local machine? Based off @croelandt's suggestion from last week, I've been able to run the unit tests on glance, glanceclient and glance_store with tox against the "env" on my local machine. But when I tried to run the entire test suite from project root folder, only the pep8 style check succeeded. Py39, i | 14:52 |
| idjoshua | n particular, returns 31 failed runs. Or maybe I've been doing something wrong. P.S: I'm running a ubuntu20.04 OS sitting on top of a VM on Windows PC. | 14:52 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: DNM Test https://review.opendev.org/c/openstack/glance-specs/+/836368 | 15:07 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Remove setup.py and setup.cfg https://review.opendev.org/c/openstack/glance-specs/+/836373 | 15:37 |
| abhishekk | croelandt, rosmaita, dansmith ^^ this will unblock glance-specs failure | 15:45 |
| rosmaita | abhishekk: didn't realize it was even broken! | 15:45 |
| abhishekk | :D | 15:46 |
| dansmith | abhishekk: I'm not sure why there was even setup.py stuff in there in the first place, but is this what others are doing as well? | 16:33 |
| abhishekk | dansmith, yes | 16:33 |
| dansmith | aha, I see, already gone from nova-specs | 16:34 |
| dansmith | cool | 16:34 |
| abhishekk | right | 16:34 |
| abhishekk | approving it now as this is blocking others | 16:34 |
| opendevreview | Merged openstack/glance-specs master: Remove setup.py and setup.cfg https://review.opendev.org/c/openstack/glance-specs/+/836373 | 16:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!