*** EugenMayer4 is now known as EugenMayer | 01:54 | |
whoami-rajat | croelandt, what time is it? | 04:09 |
---|---|---|
whoami-rajat | if there is no conflict and not too late for my tz, will join :) | 04:09 |
opendevreview | Abhishek Kekane proposed openstack/glance master: [DNM] Glance rally create and delete image scenario with Ceph https://review.opendev.org/c/openstack/glance/+/840576 | 05:56 |
opendevreview | Abhishek Kekane proposed openstack/glance master: [DNM] Glance rally create and delete image scenario with Ceph https://review.opendev.org/c/openstack/glance/+/840576 | 06:05 |
opendevreview | Abhishek Kekane proposed openstack/glance master: [DNM] Glance rally create and delete image scenario with Ceph https://review.opendev.org/c/openstack/glance/+/840576 | 07:16 |
opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: [WIP] Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 08:22 |
opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 08:53 |
opendevreview | Merged openstack/glance_store master: Cinder: Correct exception logging during attach https://review.opendev.org/c/openstack/glance_store/+/838335 | 13:34 |
pslestang | dansmith: abhishekk thanks for the review, I think that I should fix the missing default metadata here: https://review.opendev.org/c/openstack/glance-specs/+/836132/18/specs/zed/approved/glance/glance-download-import.rst#225 (missing os_type, os_distro, os_secure_boot) and by the way I will fix what you noticed, do you agree to +2 again after that? | 13:49 |
abhishekk | pslestang, yep | 13:49 |
abhishekk | rosmaita, jokke_, dansmith, croelandt, mrjoshi, pslestang, today we are meeting virtually | 13:50 |
abhishekk | #link https://meet.google.com/xdq-mnpm-iyw | 13:51 |
rosmaita | abhishekk: i will have to be irc-only | 13:51 |
abhishekk | ack, I doubt we will be able to continue at both at the same time | 13:51 |
opendevreview | Pierre-Samuel Le Stang proposed openstack/glance-specs master: [APIImpact] Add a new glance-download import method https://review.opendev.org/c/openstack/glance-specs/+/836132 | 13:52 |
dansmith | abhishekk: that link is expired | 13:59 |
abhishekk | https://meet.google.com/djw-xajs-wxj | 13:59 |
dansmith | also, I have something else going on so might be distracted and have a conflict for the second hour, just FYI | 13:59 |
abhishekk | yes, croelandt created the new one | 13:59 |
abhishekk | The meeting will be at https://meet.google.com/djw-xajs-wxj | 14:00 |
rosmaita | abhishekk: croelandt: do you have an etherpad or something where you are tracking suggested reviews? or do we just review whatever we want? | 14:08 |
abhishekk | rosmaita, https://etherpad.opendev.org/p/glance-review-party-zed-m1 | 14:10 |
rosmaita | ty | 14:11 |
abhishekk | np! | 14:13 |
abhishekk | rosmaita, https://review.opendev.org/c/openstack/glance/+/839786 | 14:19 |
croelandt | rosmaita: can you join the review party later? | 14:19 |
abhishekk | could you please have a look at it | 14:19 |
rosmaita | i am reviewing now | 14:19 |
rosmaita | just reviewed https://review.opendev.org/c/openstack/glance_store/+/834155 | 14:19 |
rosmaita | will look at 839786 now | 14:20 |
abhishekk | cool | 14:20 |
croelandt | rosmaita: why don't you join us? Are you in another meeting? | 14:20 |
rosmaita | yes, and trying to do 2 gmeets at once would kill my system | 14:20 |
rosmaita | abhishekk: left a comment on https://review.opendev.org/c/openstack/glance/+/839786 | 14:34 |
abhishekk | rosmaita, ack, thank you | 14:34 |
rosmaita | don't thank me! you can go ahead and approve it, and i'll put up another patch after it merges | 14:35 |
rosmaita | i would have done that already, but i thought the original dude who proposed the patch would fix it, but he decided not to | 14:35 |
abhishekk | ack :D | 14:35 |
opendevreview | mitya-eremeev-2 proposed openstack/glance master: glance-manage can purge all deleted rows https://review.opendev.org/c/openstack/glance/+/813691 | 14:36 |
abhishekk | that was quick review meeting :D | 14:42 |
croelandt | ok, next time it'll be 5 hours | 14:43 |
abhishekk | haha | 14:48 |
abhishekk | pslestang, https://docs.openstack.org/hacking/latest/user/hacking.html | 14:48 |
abhishekk | these are some basic standards we do follow | 14:48 |
pslestang | abhishekk: thx, I'll have a look and correct the code | 14:55 |
abhishekk | pslestang, cool | 14:55 |
jokke_ | abhishekk: ref 828232, the inconsistencies between the commit message talking only Centos issue and the change itself also bringing dpkg change with it are not solved, do you want to elaborate how dep dependency is required for centos? | 15:02 |
abhishekk | jokke_, ack | 15:03 |
jokke_ | abhishekk: also there is no clarification as of yet if suse is impacted or not (so if the rpm is correct tag or if it should be redhat) | 15:03 |
abhishekk | ok, i totally missed that part | 15:04 |
jokke_ | dependency changes are pretty big nono in the stable branches so we should be very careful we do only the changes necessary for the platform which is broken, not affect everyone | 15:08 |
abhishekk | ++ | 15:10 |
opendevreview | Elod Illes proposed openstack/glance master: [CI] Add upper constraints to install command https://review.opendev.org/c/openstack/glance/+/839786 | 15:18 |
opendevreview | Merged openstack/glance master: Remove Babel requirement https://review.opendev.org/c/openstack/glance/+/832333 | 15:32 |
opendevreview | Merged openstack/glance master: Add grenade-skip-level irrelevant-files config https://review.opendev.org/c/openstack/glance/+/831437 | 15:32 |
opendevreview | Merged openstack/glance_store master: Remove redundant try except around volume create https://review.opendev.org/c/openstack/glance_store/+/834155 | 15:51 |
opendevreview | Merged openstack/python-glanceclient master: glance help <subcommand>: Clearly specify which options are mandatory https://review.opendev.org/c/openstack/python-glanceclient/+/797779 | 16:00 |
opendevreview | Merged openstack/python-glanceclient master: Documentation: Add options for "glance image-import" https://review.opendev.org/c/openstack/python-glanceclient/+/754895 | 16:01 |
opendevreview | Merged openstack/glance_store stable/yoga: Correct retry interval during attach volume https://review.opendev.org/c/openstack/glance_store/+/839203 | 16:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!