opendevreview | Cyril Roelandt proposed openstack/glance_store master: Remove Python 2 support https://review.opendev.org/c/openstack/glance_store/+/769682 | 02:48 |
---|---|---|
rosmaita | whoami-rajat: what do you think of this: https://review.opendev.org/c/openstack/devstack/+/843287 | 13:43 |
rosmaita | then you don't need to worry about the default name at all | 13:44 |
whoami-rajat | rosmaita, that looks cool but are there cases where we require more than 2 images? we set 2 images variables here https://review.opendev.org/c/openstack/devstack/+/843287/1/lib/tempest#252 | 13:47 |
rosmaita | whoami-rajat: i don't know, seems like there could be ... btw, i think you wind up with >2 images on your current test patch -- your 2 plus the default images | 13:53 |
whoami-rajat | yes, there are 3 images but supplying a non-existent DEFAULT_IMAGE_NAME creates only the no of images specified in IMAGE_URLS | 13:54 |
whoami-rajat | which could be >2 | 13:54 |
whoami-rajat | I was thinking we should not need to override the DEFAULT_IMAGE_NAME for every job, it should only be set when we explicitly supply it | 13:57 |
opendevreview | Merged openstack/glance master: Bump Image API version to 2.16 https://review.opendev.org/c/openstack/glance/+/843028 | 15:25 |
rosmaita | jokke_: do i need to squash https://review.opendev.org/c/openstack/glance/+/843028 into https://review.opendev.org/c/openstack/glance/+/841278, or can i just cherry-pick it to stable/yoga ? | 15:28 |
jokke_ | rosmaita: I think it's big enough change to go on it's own unless you want to squash them | 15:54 |
jokke_ | as there was other versioning fixes in it as well | 15:54 |
rosmaita | jokke_: no, i'd rather keep them separate | 15:54 |
jokke_ | ++ | 15:55 |
rosmaita | i'll go ahead and cherry-pick it | 15:55 |
rosmaita | thanks! | 15:55 |
opendevreview | Brian Rosmaita proposed openstack/glance stable/yoga: Bump Image API version to 2.16 https://review.opendev.org/c/openstack/glance/+/843208 | 15:55 |
rosmaita | dansmith: croelandt: https://review.opendev.org/c/openstack/glance/+/841135 is finally ready for a +W, if one of you wants to do the honors | 19:29 |
opendevreview | Brian Rosmaita proposed openstack/glance stable/yoga: Bump Image API version to 2.16 https://review.opendev.org/c/openstack/glance/+/843208 | 19:38 |
croelandt | ^ These version bump patches always look so weird | 20:21 |
*** timburke__ is now known as timburke | 20:59 | |
*** tosky_ is now known as tosky | 21:49 | |
opendevreview | Merged openstack/glance master: Remove workaround for python_exec cannot be None https://review.opendev.org/c/openstack/glance/+/841135 | 22:29 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!