| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 07:14 |
|---|---|---|
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 07:17 |
| pslestan1 | hello | 07:18 |
| pslestan1 | abhishekk: I pushed some fixes about glance-download plugin | 07:19 |
| abhishekk | pslestan1, ack, i will have a look at it, I think you can now start fixing failing tests | 07:19 |
| pslestan1 | Will you or someone else have time to implement/help for writing tests? | 07:20 |
| opendevreview | Pranali Deore proposed openstack/glance master: Remove dead code of auth and policy layers https://review.opendev.org/c/openstack/glance/+/845114 | 09:49 |
| abhishekk | pslestang, Lets meet in today's meeting to talk about it | 09:53 |
| opendevreview | Pranali Deore proposed openstack/glance master: Remove dead code of auth and policy layers https://review.opendev.org/c/openstack/glance/+/845114 | 11:59 |
| *** croeland1 is now known as croelandt | 12:24 | |
| opendevreview | Merged openstack/glance master: Modify wrong file path in README https://review.opendev.org/c/openstack/glance/+/568428 | 13:31 |
| abhishekk | rosmaita, jokke_, dansmith, croelandt, pslestang, alistarle, mrjoshi glance weekly meeting in 15 minutes at #openstack-meeting | 13:47 |
| rosmaita | i thought we cancelled this week? | 13:47 |
| dansmith | I kinda thought so too | 13:48 |
| dansmith | I'm woefully behind on stuff because of what's going on this week | 13:48 |
| rosmaita | me too, i will have nothing to contribute today | 13:48 |
| abhishekk | don't worry we don't have much on the agenda so if you guys skipped then no issue at all | 13:49 |
| rosmaita | ok, thanks! | 13:50 |
| abhishekk | just when you get time then have a look at https://review.opendev.org/c/openstack/glance/+/845114 | 13:50 |
| abhishekk | and dansmith please look at immediate caching patch once you became free from summit work | 13:50 |
| abhishekk | s/work/workload | 13:50 |
| dansmith | abhishekk: oh god, sorry | 13:51 |
| abhishekk | no worries :D | 13:51 |
| dansmith | I've had the api locations thing open all week trying to get to that | 13:51 |
| abhishekk | we still have enough time | 13:51 |
| abhishekk | yep, I know and that is why didn't pinged you in between (next week is also ok) | 13:52 |
| alistarle | abhishekk About unit test we experience issue with UT due to the config not well loaded: oslo_config.cfg.NoSuchGroupError: no such group [glance_store], we struggle to figure out how it can have worked before before it is never mocked, do you have any idea ? | 15:36 |
| dansmith | alistarle: you're not alone, it's a frustrating thing | 15:51 |
| dansmith | alistarle: can you upload what you have and/or show a pastebin of the error? | 15:51 |
| dansmith | I always have to re-figure this out when I add test classes | 15:51 |
| dansmith | if it's a simple unit test I think you need to inherit from base.IsolatedUnitTest, and then call stores.create_stores() in your setUp() | 15:53 |
| dansmith | it's a combination of actual config and generated config from the latter I think | 15:53 |
| alistarle | actually we are just move the test_web_download.py class to test_case_download.py one, when updating the imports | 16:04 |
| alistarle | *test_web_download.py to test_base_download.py, sorry | 16:05 |
| alistarle | So I think a IsolatedUnitTest is not a solution, it should work like before in the web_download case, we basically just rename the class and the test class also | 16:07 |
| pslestang | dansmith: https://paste.openstack.org/show/bwCaztaIb6Eqd62FbUsb/ | 16:09 |
| dansmith | pslestang: okay, but what does BaseDownload look like? | 16:13 |
| dansmith | oh, sorry, | 16:13 |
| dansmith | that's not the test class | 16:13 |
| pslestang | dansmith: https://review.opendev.org/c/openstack/glance/+/840318 | 16:14 |
| dansmith | right, sorry, I was reading the indents wrong and thought that was your test class | 16:14 |
| pslestang | dansmith: yes it is the test class | 16:15 |
| dansmith | so TestWebDownload is the class you renamed and am using that? | 16:15 |
| pslestang | exactly | 16:15 |
| dansmith | well, based on just that it seems like it should be fine.. can you pastebin the whole git diff from the latest rev you have in gerrit? | 16:18 |
| pslestang | dansmith: https://paste.openstack.org/show/bixnYRLMHBpvUP7fDpOs/ | 16:28 |
| pslestang | dansmith: we need to go, we will work on it tomorrow morning (UTC+2) | 16:29 |
| dansmith | pslestang: ack | 16:29 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!