| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Refactor rbac metadef tests structure https://review.opendev.org/c/openstack/glance-tempest-plugin/+/842117 | 07:27 |
|---|---|---|
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 08:38 |
| opendevreview | Pierre-Samuel Le Stang proposed openstack/glance master: Implement glance-download internal plugin https://review.opendev.org/c/openstack/glance/+/840318 | 09:49 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Refactor rbac metadef tests structure https://review.opendev.org/c/openstack/glance-tempest-plugin/+/842117 | 09:56 |
| abhishekk | pslestang, I am sorry I missed the point earlier which I added in the latest patch set, but other than that I think the patch looks good | 14:46 |
| pslestang | abhishekk: no problem I updated accordingly your comments | 15:16 |
| abhishekk | pslestang, thank you! | 15:16 |
| pslestang | I just read you latest comment about throwing 400 code, let me check what we are doing | 15:17 |
| abhishekk | ack | 15:27 |
| pslestang | abhishekk: it would be the first plugin where we check for parameter presence in body, and I expect that get_flow fails when trying to get the parameters which is not present in the body | 15:37 |
| abhishekk | no,if you see the controller import method you can see lots of validation is performed for import methods | 15:38 |
| abhishekk | this is called as fail safe validation | 15:38 |
| *** timburke__ is now known as timburke | 21:01 | |
| *** timburke is now known as timburke__ | 21:39 | |
| *** timburke__ is now known as timburke | 21:40 | |
| opendevreview | Merged openstack/glance master: [APIImpact] Correct API response code for DELETE cache APIs https://review.opendev.org/c/openstack/glance/+/847877 | 23:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!