opendevreview | Cyril Roelandt proposed openstack/glance master: Add paste_deploy config_file option for glance-api.conf https://review.opendev.org/c/openstack/glance/+/668475 | 02:31 |
---|---|---|
opendevreview | Cyril Roelandt proposed openstack/python-glanceclient stable/yoga: Check if stdin has isatty attribute https://review.opendev.org/c/openstack/python-glanceclient/+/849058 | 02:38 |
opendevreview | Cyril Roelandt proposed openstack/python-glanceclient stable/xena: Check if stdin has isatty attribute https://review.opendev.org/c/openstack/python-glanceclient/+/849059 | 02:39 |
opendevreview | Pranali Deore proposed openstack/glance stable/xena: Fix failing namespace list delete race https://review.opendev.org/c/openstack/glance/+/848994 | 07:30 |
opendevreview | Merged openstack/glance master: Remove unicode literal strings https://review.opendev.org/c/openstack/glance/+/768984 | 07:55 |
opendevreview | Mridula Joshi proposed openstack/glance master: Extending stores-detail API https://review.opendev.org/c/openstack/glance/+/842045 | 08:28 |
*** pdeore is now known as pdeore|Afk | 08:57 | |
*** tosky_ is now known as tosky | 11:11 | |
jokke_ | sorry croelandt | 12:04 |
jokke_ | pslestang: sorry for dropping the review at this late Friday. On this pass I really had one actual concern around the metadata revert. The formattings would be nice to have if you're spinning new rev anyways and if my comment around the copyring does not make sense feel free to ignore I was just wondering | 12:58 |
jokke_ | copyright | 12:58 |
opendevreview | Merged openstack/python-glanceclient stable/yoga: Check if stdin has isatty attribute https://review.opendev.org/c/openstack/python-glanceclient/+/849058 | 13:43 |
croelandt | jokke_: 6 years ago https://review.opendev.org/c/openstack/glance/+/351848 sounded like a good idea, but I'm not sure I see why. Is this still something we might want to do? | 14:35 |
opendevreview | Cyril Roelandt proposed openstack/glance master: CONF.paste_deploy.config_file: Remove misleading note https://review.opendev.org/c/openstack/glance/+/849121 | 14:54 |
jokke_ | croelandt: I don't know about you, but I'm happy to keep my -2 there ;) | 14:55 |
croelandt | haha | 14:56 |
croelandt | ok we discussed it with Abhishek yesterday | 14:56 |
croelandt | I wanted to remove it, but I thought "eh, Erno seemed to like the idea, so maybe it makes sense" | 14:56 |
jokke_ | Config-as-code was pretty much as idiotic idea in end user pserpective as microversions for clients. Removes a very little development overhead but multiplies the overhead for end user trying to figure things out | 15:08 |
jokke_ | Like if you want to see example config file from say stable/train without us shipping the examples in tree, you gotta clone the whole git repo, install all requirements and test requirements to be able to run the tox -egenconfig just to get bunch of text files that takes us 5min per cycle to keep up to date and ship on tree where they can be referenced when ever either online or if you have the | 15:11 |
jokke_ | repo cloned offline | 15:11 |
opendevreview | Merged openstack/python-glanceclient stable/xena: Check if stdin has isatty attribute https://review.opendev.org/c/openstack/python-glanceclient/+/849059 | 15:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!