opendevreview | Abhishek Kekane proposed openstack/glance master: Add documentation for glance-download plugin https://review.opendev.org/c/openstack/glance/+/853928 | 05:53 |
---|---|---|
opendevreview | Abhishek Kekane proposed openstack/glance master: [glance-download] Add missing config options to config list https://review.opendev.org/c/openstack/glance/+/854501 | 05:53 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Refresh Glance example configs for zed milestone 3 https://review.opendev.org/c/openstack/glance/+/854495 | 05:53 |
opendevreview | Abhishek Kekane proposed openstack/glance master: DNM: Test glance-download with tempest https://review.opendev.org/c/openstack/glance/+/852609 | 05:54 |
opendevreview | Merged openstack/glance master: Fix a deprecation warning about threading.Thread https://review.opendev.org/c/openstack/glance/+/853874 | 09:39 |
opendevreview | Erno Kuvaja proposed openstack/glance master: Remove 'glance-download' from default import methods https://review.opendev.org/c/openstack/glance/+/854772 | 11:30 |
opendevreview | Erno Kuvaja proposed openstack/python-glanceclient master: Bump default pagesize https://review.opendev.org/c/openstack/python-glanceclient/+/854773 | 11:50 |
rosmaita | jokke_: left a comment for you on https://review.opendev.org/c/openstack/glance/+/854772 | 12:37 |
rosmaita | good catch, btw | 12:37 |
jokke_ | rosmaita: good points, thanks! Will respin it in a minute | 12:43 |
rosmaita | ty | 12:43 |
opendevreview | Erno Kuvaja proposed openstack/glance master: Remove 'glance-download' from default import methods https://review.opendev.org/c/openstack/glance/+/854772 | 12:46 |
jokke_ | rosmaita: added little comment on the top of that test as well to clarify it's testing just te defaults | 12:46 |
jokke_ | darn review priority is not sticky anymore ... need to figure that out | 12:47 |
rosmaita | yeah, i'm not sure it ever was tbh | 12:49 |
jokke_ | oh | 12:50 |
jokke_ | kk | 12:50 |
jokke_ | thanks for quick review ;) | 12:50 |
rosmaita | jokke_: https://review.opendev.org/c/openstack/project-config/+/854781 | 13:51 |
opendevreview | Pranali Deore proposed openstack/python-glanceclient master: Add support for glance-download import method https://review.opendev.org/c/openstack/python-glanceclient/+/854784 | 13:53 |
*** pdeore is now known as pdeore|afk | 13:54 | |
*** amorin_ is now known as amorin | 14:00 | |
jokke_ | rosmaita: the tests are failing with """Exception: Unrecognized key in line: "copyCondition = changekind:REWORK"""" | 14:28 |
jokke_ | So that has something gerrit does not like | 14:29 |
rosmaita | jokke_: could be 'change-kind', the gerrit docs were ambiguous | 14:31 |
rosmaita | hmmm ... doesn't like that either | 14:53 |
jokke_ | abhishekk: \o | 15:55 |
abhishekk | o/ | 15:55 |
abhishekk | jokke_, o/ | 15:56 |
opendevreview | Erno Kuvaja proposed openstack/glance master: Remove 'glance-download' from default import methods https://review.opendev.org/c/openstack/glance/+/854772 | 15:57 |
jokke_ | There was actual pep8 failure ... my vim plugins messes the indents in some cases and I tend to forget to double check those in these very quick respins | 15:58 |
abhishekk | ack | 15:58 |
abhishekk | i am operating from mobile, so overlooked it as other failure | 15:59 |
abhishekk | good catch | 16:00 |
opendevreview | Merged openstack/glance master: Remove 'glance-download' from default import methods https://review.opendev.org/c/openstack/glance/+/854772 | 19:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!