| opendevreview | Cyril Roelandt proposed openstack/glance master: Fix E741 issues https://review.opendev.org/c/openstack/glance/+/849725 | 11:16 |
|---|---|---|
| croelandt | abhishekk: so basically Zuul is failing on 100% of our patches now? | 14:36 |
| croelandt | following your comment on https://review.opendev.org/c/openstack/glance/+/849725 | 14:37 |
| abhishekk | croelandt, yes, since we tagged m2 | 14:37 |
| abhishekk | Safe way out is to remove that job now and decide later to add it back or not | 14:37 |
| croelandt | is the "Update migration constant" not ready? I see it's still a WIP | 14:38 |
| abhishekk | it is ready I kept it WIP to get initial review(s) | 14:39 |
| croelandt | ok | 14:40 |
| croelandt | because well, we cannot merge a single patch, that sounds a bit critical :) | 14:40 |
| abhishekk | yep | 14:42 |
| abhishekk | and that is why I am saying to remove this job as this test logic is now flaky | 14:42 |
| abhishekk | WE just need to make sure to change the db version at the start of every cycle | 14:43 |
| croelandt | so how do we make sure we do not forget to do that? :) | 14:43 |
| abhishekk | that is the task for PTL :P | 14:44 |
| croelandt | So do we already have a patch up for the removal of that job? | 14:45 |
| abhishekk | So way forward is patch 1 remove the job and test patch 2 change the db version | 14:46 |
| abhishekk | no | 14:46 |
| abhishekk | if you are busy with other work then I can work on the patch 1 | 14:47 |
| croelandt | Guess it's just about removing the job from .zuul.yaml | 14:50 |
| abhishekk | submitting it in a minute | 14:51 |
| croelandt | oh ok :) | 14:51 |
| croelandt | go ahead then | 14:51 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Remove migration constant job and test https://review.opendev.org/c/openstack/glance/+/870549 | 14:54 |
| abhishekk | croelandt, rosmaita, jokke_, dansmith ^^ | 14:54 |
| dansmith | I don't really understand why glance has this problem and nobody else does | 14:55 |
| dansmith | but not having to worry about that test seems nice | 14:55 |
| rosmaita | dansmith: i think it's because glance was an alembic early adopter | 14:57 |
| abhishekk | those people who worked on alembic migrations are not around now :( | 14:57 |
| dansmith | and there's something about how it was done that means we can't get on the right track? | 14:58 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Update migration constant https://review.opendev.org/c/openstack/glance/+/861752 | 14:58 |
| dansmith | neutron was too, AFAIK, and have release names in their migrations | 14:58 |
| abhishekk | dansmith, need to spend time on it | 15:00 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Refactor/restructure glance cinder store https://review.opendev.org/c/openstack/glance_store/+/843103 | 17:42 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Cinder: Add support to extend attached volumes https://review.opendev.org/c/openstack/glance_store/+/868742 | 17:42 |
| opendevreview | Rajat Dhasmana proposed openstack/glance-specs master: Cinder: Add support for extending attached volumes https://review.opendev.org/c/openstack/glance-specs/+/868901 | 17:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!