opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: do_image_import: fix argument retrieval https://review.opendev.org/c/openstack/python-glanceclient/+/880696 | 01:31 |
---|---|---|
opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: do_image_import: always pass remote_* to gc.images.image_import https://review.opendev.org/c/openstack/python-glanceclient/+/880697 | 01:31 |
croelandt | Do we know anything about the failure at https://review.opendev.org/c/openstack/python-glanceclient/+/880696 ? | 14:58 |
croelandt | https://zuul.opendev.org/t/openstack/build/d3e621939d7f45ba9380c58b41a08ba9 | 14:58 |
croelandt | FileNotFoundError: [Errno 2] No such file or directory: '/home/zuul/src/opendev.org/openstack/python-glanceclient/.tox/functional/bin/glance' | 14:58 |
croelandt | looks like glanceclient somehow is not installed in the venv | 14:59 |
opendevreview | Brian Rosmaita proposed openstack/glance_store master: Run cinder driver unit tests https://review.opendev.org/c/openstack/glance_store/+/880762 | 15:33 |
rosmaita | croelandt: have you had any ideas? | 15:43 |
croelandt | rosmaita: well locally it works :/ | 15:43 |
rosmaita | check what tox version you have | 15:43 |
croelandt | so I'm not sure what might be happening here | 15:43 |
rosmaita | it's running tox 4.4.11 or something in the gate | 15:44 |
croelandt | 3.28 | 15:44 |
croelandt | oh | 15:44 |
rosmaita | my guess is that tox 4 installs things differently | 15:44 |
rosmaita | you may want to pin tox and see what happens | 15:44 |
rosmaita | try something like this: https://review.opendev.org/c/openstack/python-cinderclient/+/869264 | 15:45 |
croelandt | Can I see when that switch to tox4 happened? | 15:46 |
rosmaita | no, there's no data from the last previously passing glanceclient test | 15:52 |
croelandt | gr8 | 15:53 |
croelandt | ok trying to install tox4 on my env | 15:53 |
croelandt | which creates new issues, nice | 15:54 |
croelandt | ok, rerunning with tox4 | 15:57 |
rosmaita | can i get a priority review on https://review.opendev.org/c/openstack/glance_store/+/880762 ? | 15:58 |
rosmaita | the patch has passed everything but tempest so far: https://zuul.openstack.org/status#880762 | 15:58 |
rosmaita | it has no impact on tempest | 15:58 |
rosmaita | dansmith^^ croelandt^^ | 15:58 |
croelandt | danm it works with 4.4.12 | 15:58 |
croelandt | rosmaita: ping me again when the CI is done working | 15:59 |
rosmaita | ok | 16:00 |
opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: DNM: dummy change to debug CI failures https://review.opendev.org/c/openstack/python-glanceclient/+/880765 | 16:02 |
dansmith | croelandt: why? it's not going to merge if it doesn't pass, why hold it up? | 16:02 |
dansmith | unless you want to second-guess the CI results because of some nuance, I don't think there's much point, and this seems pretty straightforward to me | 16:02 |
croelandt | yeah you're right | 16:06 |
opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: DNM: dummy change to debug CI failures https://review.opendev.org/c/openstack/python-glanceclient/+/880765 | 18:02 |
opendevreview | Merged openstack/glance_store master: Run cinder driver unit tests https://review.opendev.org/c/openstack/glance_store/+/880762 | 18:41 |
rosmaita | \o/ | 18:55 |
croelandt | \o/ | 18:59 |
croelandt | and I think the functional test issue is related to the skipsdist thingy we fixed in glance/glance_store already | 18:59 |
croelandt | not sure how that works internally but eh | 18:59 |
opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: Tox4: remove skipsdist https://review.opendev.org/c/openstack/python-glanceclient/+/880765 | 20:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!