opendevreview | Merged openstack/glance master: Release notes for Bobcat Milestone 1 https://review.opendev.org/c/openstack/glance/+/882499 | 01:59 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/glance master: Refactor pipeline definition https://review.opendev.org/c/openstack/glance/+/802180 | 03:36 |
opendevreview | OpenStack Proposal Bot proposed openstack/glance master: Imported Translations from Zanata https://review.opendev.org/c/openstack/glance/+/882648 | 03:37 |
opendevreview | Brian Rosmaita proposed openstack/glance_store master: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882834 | 14:35 |
dansmith | croelandt: ^ | 14:38 |
croelandt | reviewed | 14:44 |
opendevreview | Gorka Eguileor proposed openstack/glance_store stable/2023.1: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882851 | 14:53 |
opendevreview | Gorka Eguileor proposed openstack/glance_store stable/zed: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882853 | 14:53 |
opendevreview | Gorka Eguileor proposed openstack/glance_store stable/yoga: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882854 | 14:53 |
opendevreview | Pranali Deore proposed openstack/glance master: Add new add location api https://review.opendev.org/c/openstack/glance/+/881940 | 14:53 |
opendevreview | Pranali Deore proposed openstack/glance master: Add new get location api https://review.opendev.org/c/openstack/glance/+/882498 | 14:53 |
opendevreview | Gorka Eguileor proposed openstack/glance_store stable/xena: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882855 | 14:53 |
opendevreview | Cyril Roelandt proposed openstack/glance master: Bump eventlet to a version that fixes #632[1] https://review.opendev.org/c/openstack/glance/+/882873 | 15:38 |
dansmith | croelandt: see my reply? | 15:40 |
croelandt | dansmith: yep sorry | 15:47 |
croelandt | we do have another call fixed in stable/zed, and it looks exactly like thecode we have in master | 15:47 |
croelandt | not sure if we end up calling the base or not | 15:47 |
dansmith | okay I'm missing something | 15:48 |
dansmith | rosmaita: ^ | 15:48 |
rosmaita | there was refactoring between zed and 2023.1 | 15:49 |
croelandt | It might be me :) | 15:49 |
croelandt | so in attachement_state_manager.py, "conn.disconnect_volume" <- is "conn" not the same type in zed & 2023.1? | 15:50 |
croelandt | do we end up calling the base in one case but not the other? | 15:50 |
rosmaita | https://review.opendev.org/c/openstack/glance_store/+/843103 | 15:50 |
rosmaita | croelandt: ^^ that's where the change happened | 15:51 |
croelandt | ok Imma trust you | 15:52 |
croelandt | here you go! | 15:54 |
opendevreview | Merged openstack/glance stable/yoga: Fix unintentional exception inspecting VMDK https://review.opendev.org/c/openstack/glance/+/864909 | 17:41 |
dansmith | croelandt: finally ^ | 17:44 |
croelandt | hell yeah | 17:45 |
opendevreview | Merged openstack/glance_store stable/2023.1: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882851 | 17:55 |
opendevreview | Merged openstack/glance_store master: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882834 | 18:09 |
dansmith | rosmaita: should I get a glance-store release proposed? | 18:29 |
rosmaita | no, i think we need os-brick releases first and then update the setup.cfg in each glance_store branch before releasing | 18:30 |
rosmaita | also, i have the basic release | 18:31 |
rosmaita | patch ready locally | 18:31 |
dansmith | okay I'm not sure why we need brick first but, cool | 18:31 |
rosmaita | well, because we want to make sure glance_store is using that version of os-brick that has the FC fix | 18:31 |
dansmith | you mean you want a test on it? or you're going to raise the required version of brick in glance_store? | 18:32 |
rosmaita | raise the version in glance_store | 18:32 |
dansmith | okay | 18:32 |
dansmith | rosmaita: I'm not arguing, but glance_store will pass the arg and it will just be ignored if brick is not new enough right? | 18:35 |
rosmaita | yeah, but what's the point of upgrading your glance_store if you have the wrong brick? | 18:35 |
rosmaita | you won't even know it's not working properly | 18:35 |
dansmith | if you're not on FC then there's no point :) | 18:36 |
dansmith | I mean for the same reason that nova isn't raising its brick requirement | 18:36 |
dansmith | anyway, no rush and fine to do them together regardless, just trying to understand | 18:36 |
rosmaita | well, i thought that os-brick patches would be merged by now, so why not? | 18:37 |
rosmaita | never thought glance would be the first to get everything done :) | 18:37 |
dansmith | yep, fully on board with "why not" :) | 18:38 |
dansmith | haha | 18:38 |
pdeore | rosmaita, dansmith there is a glance_store release patch for m1 already up for review, so we just need to update the hash after os_brick release | 19:20 |
pdeore | https://review.opendev.org/c/openstack/releases/+/882606 | 19:20 |
rosmaita | pdeore: ack | 19:26 |
opendevreview | Brian Rosmaita proposed openstack/glance_store stable/2023.1: Update 'extras' for cinder driver https://review.opendev.org/c/openstack/glance_store/+/882892 | 19:52 |
opendevreview | Merged openstack/glance_store stable/zed: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882853 | 20:46 |
opendevreview | Merged openstack/glance_store stable/yoga: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882854 | 21:25 |
opendevreview | Merged openstack/glance_store stable/xena: Add force to os-brick disconnect https://review.opendev.org/c/openstack/glance_store/+/882855 | 21:25 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!