opendevreview | Merged openstack/glance_store master: RBD: Trash image when snapshots prevent deletion https://review.opendev.org/c/openstack/glance_store/+/884524 | 08:35 |
---|---|---|
*** croeland1 is now known as croelandt | 09:55 | |
opendevreview | Merged openstack/glance master: Handle case for multiple cirros images https://review.opendev.org/c/openstack/glance/+/886071 | 11:59 |
dansmith | croelandt: perhaps we keep up the inertia with this, which has been waiting a while: | 13:34 |
dansmith | https://review.opendev.org/c/openstack/glance_store/+/883670 | 13:34 |
dansmith | previously merged and approved, but it had a problem which was causing gate failures.. we reverted and I fixed | 13:35 |
dansmith | the failure wasn't initially noticed because it wasn't running the ceph job voting on glance_store, but as you see in the patch below, it now is :) | 13:35 |
croelandt | h I thought I merged this | 14:50 |
croelandt | dansmith: wait it's from May? Wasn't there a similar patch by rajat a while ago? | 14:50 |
croelandt | oh it was reverted | 14:52 |
croelandt | https://review.opendev.org/c/openstack/glance_store/+/861191 | 14:52 |
croelandt | ok it was mentioned in your commit message | 14:54 |
croelandt | let's go! | 14:54 |
dansmith | and also: | 14:59 |
dansmith | [06:35:09] <dansmith> previously merged and approved, but it had a problem which was causing gate failures.. we reverted and I fixed | 14:59 |
dansmith | croelandt: ^ | 14:59 |
dansmith | but yeah, thanks :) | 15:00 |
croelandt | yeah I am stupid so I stopped reading after getting the link | 15:08 |
croelandt | then wrote stuff | 15:08 |
croelandt | then read the rest of the history | 15:08 |
dansmith | hehe | 15:11 |
croelandt | If I read everything first, there is a risk that I forget to go back to the patch | 15:18 |
croelandt | #dumb | 15:18 |
opendevreview | Merged openstack/glance_store master: RBD: Wrap RBD calls in native threads https://review.opendev.org/c/openstack/glance_store/+/883670 | 16:18 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!