whoami-rajat | dansmith, IIUC, we set the os_glance_import_task property in image for the particular task and use it as a lock? | 05:38 |
---|---|---|
abhishekk | yeah, that needs to be set here as well | 06:41 |
abhishekk | and unset it as soon as image is set to active | 06:41 |
whoami-rajat | ack, sounds good | 06:42 |
abhishekk | dansmith, croelandt when you get some time, kindly review store-weight patch | 14:12 |
abhishekk | https://review.opendev.org/c/openstack/glance/+/886811/6 | 14:13 |
dansmith | ah, sorry didn't see it was updated | 14:13 |
abhishekk | no problem | 14:14 |
dansmith | abhishekk: nit inline, I can fix myself and +2 if you don't have time, | 14:15 |
dansmith | but probably should address it | 14:15 |
abhishekk | looking | 14:15 |
dansmith | "one of your stores is missing, but I won't tell you which one!" is an unfortunate log message :) | 14:16 |
abhishekk | :D | 14:16 |
abhishekk | will fix it in 5-10 mins and push a new revision, thank you!! | 14:17 |
dansmith | ack, I'll stand by for +2 | 14:17 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Sort locations based on store weight https://review.opendev.org/c/openstack/glance/+/886811 | 14:25 |
abhishekk | thank you!! | 14:25 |
dansmith | done | 14:31 |
abhishekk | thanks!! | 14:46 |
croelandt | Guess we're merging this one then :) | 16:23 |
croelandt | Would be nice to take a look at stephenfin's patches as well :) | 16:24 |
abhishekk | +1 | 16:48 |
abhishekk | thanks @croelandt | 16:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!