opendevreview | Abhishek Kekane proposed openstack/glance-specs master: [Spec Lite] Deprecate location strategy https://review.opendev.org/c/openstack/glance-specs/+/899804 | 05:54 |
---|---|---|
opendevreview | Abhishek Kekane proposed openstack/glance-specs master: [Spec Lite] Deprecate cachemanage middleware https://review.opendev.org/c/openstack/glance-specs/+/899805 | 06:05 |
opendevreview | Pranali Deore proposed openstack/glance master: DNM: Test Image status to 'importing' after hash calculation https://review.opendev.org/c/openstack/glance/+/899812 | 07:12 |
opendevreview | Pranali Deore proposed openstack/glance master: DNM: Test Image status to 'importing' after hash calculation https://review.opendev.org/c/openstack/glance/+/899812 | 07:12 |
*** JqckB_ is now known as JqckB | 08:57 | |
*** TheJulia_ is now known as TheJulia | 08:57 | |
*** simondodsley_ is now known as simondodsley | 08:57 | |
opendevreview | Abhishek Kekane proposed openstack/glance-specs master: [Spec] Use Centralized database for cache operations https://review.opendev.org/c/openstack/glance-specs/+/899367 | 09:41 |
opendevreview | Pranali Deore proposed openstack/glance-specs master: Repropose Spec for the Glance part of Image Encryption (Caracal) https://review.opendev.org/c/openstack/glance-specs/+/899856 | 12:39 |
opendevreview | Pranali Deore proposed openstack/glance-specs master: Caracal project priorities https://review.opendev.org/c/openstack/glance-specs/+/899857 | 12:45 |
pranali | rosmaita, during caracal PTG, we have discussed 2 deprecation topics, 1. Remove location startegy 2. Deprecate cachemanage middleware, for which we decided to highlight on openstack-discuss about the deprecation. | 13:06 |
pranali | so do we need to submit the releasenote first about the deprecation and then send an email to ML? or only releasenote is enough ? | 13:07 |
rosmaita | pranali: it's probably a good idea to send an email to the ML, you can include a link to the gerrit review containing the release note. That way people who have a problem with the proposal can leave comments | 13:09 |
pranali | rosmaita, ack , are there any guidelines about such deprecation emails ? | 13:11 |
pranali | the problem statement and solution along with the deprecation spec-lite and releasenotes would be sufficient ? | 13:12 |
rosmaita | pranali: yes, that sounds correct, plus a timeline for when the thing will be removed | 13:13 |
pranali | rosmaita, ok cool, thanks !! :) | 13:13 |
*** dansmith_ is now known as dansmith | 13:40 | |
opendevreview | Abhishek Kekane proposed openstack/glance master: Deprecate sqlite cache driver https://review.opendev.org/c/openstack/glance/+/899868 | 14:58 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Add new tables for cache operations https://review.opendev.org/c/openstack/glance/+/899869 | 14:58 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Add required database API(s) for cache https://review.opendev.org/c/openstack/glance/+/899870 | 14:58 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Introduce centralized database driver for image cache https://review.opendev.org/c/openstack/glance/+/899871 | 14:58 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Read global config file for cache utilities https://review.opendev.org/c/openstack/glance/+/899872 | 14:58 |
abhishekk | note, pending testing and migration part | 14:59 |
*** sfinucan is now known as stephenfin | 16:15 | |
abhishekk | stephenfin, around? | 17:05 |
abhishekk | could you please help to sort out failure of sqlalchemy job, https://review.opendev.org/c/openstack/glance/+/899872 | 17:06 |
abhishekk | origin is this patch, https://review.opendev.org/c/openstack/glance/+/899869/1 | 17:07 |
abhishekk | may be .with_variant(Integer, "sqlite") is not required | 17:08 |
stephenfin | abhishekk: the types should be identical between migration and model for one, so you need to add the .with_variant stuff to the migrations | 17:31 |
stephenfin | There's also a failure with the columns using the 'REAL' type. The only difference I can see is that you're initalizing the type in the migration (REAL()) but not the model (REAL). I don't think that matters though... | 17:33 |
stephenfin | I assume you have a local MySQL instance configured to run these tests locally? There's nothing SQLAlchemy 2.0 specific going on there since other functional tests are also failing | 17:33 |
abhishekk | yeah, I don't think it matters for REAL | 17:34 |
abhishekk | because same I am doing with hits (Integer and Integer()) | 17:34 |
abhishekk | I have it configured for 3.8 | 17:34 |
abhishekk | it is failing for 3.9 and 3.10 | 17:35 |
abhishekk | dansmith, do you know how to run functional tests against mysql database ? at the moment it is getting skipped | 18:17 |
stephenfin | you need an openstack_citest database and user configured locally https://docs.openstack.org/oslo.db/ocata/contributing.html#how-to-run-unit-tests | 18:20 |
stephenfin | (same for any project that uses the opportunistic database fixtures from oslo.db) | 18:21 |
abhishekk | thank you, looking | 18:21 |
abhishekk | thanks, it worked | 18:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!