| *** tkajinam is now known as Guest1349 | 01:24 | |
| opendevreview | Pranali Deore proposed openstack/glance master: Add Location Import task flow https://review.opendev.org/c/openstack/glance/+/886749 | 10:17 |
|---|---|---|
| opendevreview | Pranali Deore proposed openstack/glance master: Add new add location api https://review.opendev.org/c/openstack/glance/+/881940 | 10:17 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add functional tests for new add-location API https://review.opendev.org/c/openstack/glance/+/886947 | 10:17 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add new get location api https://review.opendev.org/c/openstack/glance/+/882498 | 10:17 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add api-ref and documentation for new location apis https://review.opendev.org/c/openstack/glance/+/890508 | 10:17 |
| opendevreview | Pranali Deore proposed openstack/glance master: Bump Images API version to 2.17 https://review.opendev.org/c/openstack/glance/+/890509 | 10:17 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add Location Import task flow https://review.opendev.org/c/openstack/glance/+/886749 | 11:03 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add new add location api https://review.opendev.org/c/openstack/glance/+/881940 | 11:03 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add functional tests for new add-location API https://review.opendev.org/c/openstack/glance/+/886947 | 11:03 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add new get location api https://review.opendev.org/c/openstack/glance/+/882498 | 11:03 |
| opendevreview | Pranali Deore proposed openstack/glance master: Add api-ref and documentation for new location apis https://review.opendev.org/c/openstack/glance/+/890508 | 11:03 |
| opendevreview | Pranali Deore proposed openstack/glance master: Bump Images API version to 2.17 https://review.opendev.org/c/openstack/glance/+/890509 | 11:03 |
| opendevreview | Pranali Deore proposed openstack/glance master: Release notes for Caracal Milestone 3 https://review.opendev.org/c/openstack/glance/+/910202 | 11:36 |
| opendevreview | Pranali Deore proposed openstack/glance master: Refresh Glance example configs for caracal m3 https://review.opendev.org/c/openstack/glance/+/910203 | 11:36 |
| *** tosky_ is now known as tosky | 11:48 | |
| pranali | abhishekk, rosmaita, dansmith, croelandt, mrjoshi glance weekly meeting in 15 minutes at #openstack-meeting | 13:46 |
| abhishekk | dansmith, need your suggestion | 14:28 |
| abhishekk | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0cd/881940/73/check/openstack-tox-py311/0cd8be0/testr_results.html | 14:28 |
| abhishekk | this is failing in gate, but works in local | 14:28 |
| abhishekk | SO is it advisable to use sqlite3 db in unit test or I should mock it to rule out these kind of fialures | 14:29 |
| dansmith | we use sqlite in lots of other unit tests right? | 14:33 |
| abhishekk | yes, but I am not sure why it is failing to create cache_images table for one test :/ | 14:36 |
| dansmith | which patch this this on? | 14:36 |
| dansmith | oh this is the merged cache stuff on the locations set? | 14:37 |
| abhishekk | yes | 14:37 |
| abhishekk | I am looping py311 in local for 30 times, and see if it fails or not | 14:40 |
| dansmith | so this must be a case where we're re-using a file that hasn't had the new migration applied to add the table? | 14:41 |
| abhishekk | I am creating that table in the test itself | 14:41 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/900419/20/glance/tests/unit/test_sqlite_migration.py#51 | 14:42 |
| dansmith | abhishekk: can cache.db be used and then deleted by any other test running in another worker thread? probably best to mkstemp() that filename and use that | 14:45 |
| abhishekk | ++ | 14:45 |
| abhishekk | I think that is the reason | 14:45 |
| dansmith | oh, it's the assume name I guess that the runtime code uses? | 14:45 |
| dansmith | if so you might need to mock the name somewhere to make it use a private temporary file | 14:45 |
| abhishekk | ack | 14:46 |
| croelandt | pranali: I +2ed the release notes patch, but indeed I think we should wait to merge it | 14:50 |
| croelandt | Can I push the config refresh patch though? | 14:51 |
| abhishekk | it has dependency | 14:51 |
| abhishekk | and since now we are not tagging m3 we have two weeks to get those in | 14:51 |
| abhishekk | no rush I mean now | 14:51 |
| croelandt | oh yeah they are together | 14:52 |
| croelandt | yeah but I might as well +2/+1 the configrefresh right now | 14:52 |
| pranali | croelandt, yeah you can +2 it | 14:53 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Fix flaky test related to cache migration https://review.opendev.org/c/openstack/glance/+/910640 | 15:36 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Fix flaky test related to cache migration https://review.opendev.org/c/openstack/glance/+/910640 | 15:43 |
| * abhishekk signing out for the day | 15:55 | |
| rosmaita | following up on today's meeting discussion, I have proposed giving pranali some more powers in gerrit: | 15:55 |
| rosmaita | https://review.opendev.org/c/openstack/project-config/+/910641 | 15:55 |
| rosmaita | abhishekk: croelandt: dansmith: ^^ | 15:55 |
| abhishekk | rosmaita, where were you when I was the PTL :D | 15:55 |
| abhishekk | ack | 15:55 |
| dansmith | lol | 15:55 |
| rosmaita | hiding! | 15:56 |
| abhishekk | ;) | 15:56 |
| dansmith | abhishekk: so I should recheck your patch a few times today yeah? | 15:58 |
| abhishekk | makes sense, | 15:58 |
| dansmith | as long as it works, I see no reason not to merge it though, so maybe we just put it in without rechecks? | 15:58 |
| abhishekk | Also to be specific before this change I ran it 30 times and if failed 2 times for py311 with this change it passed all the time | 15:59 |
| dansmith | ah cool | 15:59 |
| abhishekk | I am ok, with both the ways | 15:59 |
| dansmith | well, I'll try to rope rosmaita into +2ing with me once it passes | 15:59 |
| rosmaita | what's the deal with py311? i've been seeing weird things in cinder, too | 15:59 |
| rosmaita | some kind of eventlet/fixtures thing, but only very occasionally | 16:00 |
| abhishekk | very mysterious things are happening lately with py311 | 16:00 |
| rosmaita | ... and with that comment, abhishekk drops the mic and goes home | 16:00 |
| abhishekk | :d, yeah still in office, need to rush | 16:01 |
| abhishekk | bye o/ | 16:01 |
| dansmith | rosmaita: can you +W this? https://review.opendev.org/c/openstack/glance/+/910640 | 20:22 |
| dansmith | it's just a test flakiness fix for some fails we saw | 20:22 |
| rosmaita | looking now | 20:22 |
| dansmith | basically re-using the same db file which is no bueno when multiple threads might be using/deleting the same one | 20:22 |
| dansmith | rosmaita: oh dang hold on | 20:26 |
| dansmith | I just realized he's leaking an fd there | 20:26 |
| dansmith | lemme fix | 20:27 |
| rosmaita | ok, ping me when ready | 20:27 |
| dansmith | sorry I reviewed that this morning, but post coffee and lunch I realize | 20:29 |
| opendevreview | Dan Smith proposed openstack/glance master: Fix flaky test related to cache migration https://review.opendev.org/c/openstack/glance/+/910640 | 20:35 |
| dansmith | rosmaita: ^ | 20:35 |
| rosmaita | ack | 20:35 |
| dansmith | I dunno why I can't run that locally, some oslo lockutils failure I don't understand far away from that change, but it fails for me with no change, which obviously doesn't match zuul, | 20:39 |
| dansmith | so idk | 20:39 |
| rosmaita | weird | 20:39 |
| opendevreview | Brian Rosmaita proposed openstack/glance master: Set a lock_path for tests https://review.opendev.org/c/openstack/glance/+/910666 | 21:46 |
| rosmaita | dansmith: ^^ | 21:47 |
| dansmith | rosmaita: oh jeez, okay.. it was passing in zuul already but maybe because of a lower pin on lockutils? | 21:48 |
| rosmaita | i guess ... i just checked, and the py311 job passed on 910640 just now, so i'm not sure why it didn't fail | 21:49 |
| dansmith | yeah me either | 21:49 |
| dansmith | thanks for looking into it, too much to do today to worry about it if it was passing in zuul | 21:49 |
| rosmaita | the upper constraints change merged on feb 26, so there's been plenty of time | 21:49 |
| rosmaita | btw, good on you for catching that fd leak, i would have completely missed it | 21:51 |
| dansmith | ask me how I know :P | 21:51 |
| dansmith | okay well, if this fails a gate run or something we can swap the patch ordering I guess | 21:52 |
| rosmaita | may have to squash, when my patch was at head of master, i hit the "flaky" problem that abhishekk fixed | 21:53 |
| dansmith | orly | 21:54 |
| dansmith | interesting he had a hard time hitting it | 21:54 |
| dansmith | but yeah, ack | 21:54 |
| rosmaita | yeah, i hit it right out of the gate ... i'm lucky that way, i guess | 21:54 |
| dansmith | hgh | 21:55 |
| dansmith | er, heh even | 21:55 |
| *** jph6 is now known as jph | 22:24 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!