| opendevreview | Takashi Kajinami proposed openstack/glance master: Require more specific exception https://review.opendev.org/c/openstack/glance/+/911041 | 05:00 |
|---|---|---|
| *** mklejn_ is now known as mklejn | 07:56 | |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Use normal credentials for legacy image update https://review.opendev.org/c/openstack/glance_store/+/911005 | 12:19 |
| croelandt | abhishekk: I think rosmaita might like a few +2/+1 on these https://review.opendev.org/q/topic:%22accesskey%22 | 14:38 |
| abhishekk | ack, looking | 14:38 |
| abhishekk | for unmaintained i don't have +2 +w | 14:46 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Use normal credentials for legacy image update https://review.opendev.org/c/openstack/glance_store/+/911005 | 15:09 |
| croelandt | abhishekk: yeah unmaintained is not up to us | 16:23 |
| opendevreview | Merged openstack/glance_store stable/zed: Do not show access_key in s3 driver https://review.opendev.org/c/openstack/glance_store/+/907736 | 16:29 |
| opendevreview | Merged openstack/glance_store stable/2023.1: Do not show access_key in s3 driver https://review.opendev.org/c/openstack/glance_store/+/907733 | 16:29 |
| opendevreview | Merged openstack/glance_store stable/2023.2: Do not show access_key in s3 driver https://review.opendev.org/c/openstack/glance_store/+/906484 | 16:29 |
| abhishekk | croelandt, https://review.opendev.org/c/openstack/glance/+/901429 can you +w on this? | 16:31 |
| croelandt | done | 16:36 |
| abhishekk | thank you! | 16:38 |
| croelandt | tons of reviews these days, I think some of them are in a "double +2" state, so don't hesitate to ping me here if you need some of them pushed | 16:43 |
| abhishekk | ++, thanks | 16:58 |
| opendevreview | Merged openstack/glance master: Use centralized_db cache driver in tempest jobs https://review.opendev.org/c/openstack/glance/+/901429 | 18:37 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Make `centralized_db` cache driver default https://review.opendev.org/c/openstack/glance/+/907111 | 18:39 |
| abhishekk | dansmith, please have a look when you get time, thank you! | 18:43 |
| dansmith | abhishekk: okay so the grenade job will not test sqlite->centralized because we hard-code the driver in both old and new right? | 18:53 |
| dansmith | do you have a job (even if DNM) that enables caching but doesn't set the driver so we can see that it handles the default change gracefully? | 18:53 |
| abhishekk | wait | 18:53 |
| abhishekk | since devstack merged, I guess now it will set centeralized db to both old and new | 18:56 |
| abhishekk | but before that, https://fb3330539b69de0bdc86-643409a283e79db7e81f738ea775c76a.ssl.cf1.rackcdn.com/901649/26/check/glance-grenade-centralized-cache/a29da32/controller/logs/grenade_save/etc.glance/glance-api_conf.txt | 18:56 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/901649 | 18:57 |
| dansmith | I gotta disconnect now for another meeting, back in a bit, sorry | 18:57 |
| abhishekk | ack | 18:58 |
| abhishekk | I thought this will always set old glance to sqlite, https://review.opendev.org/c/openstack/glance/+/901649/26/.zuul.yaml#281 | 18:59 |
| dansmith | abhishekk: okay I'm done | 19:22 |
| dansmith | abhishekk: oh yep, that's what I'm looking for | 19:23 |
| abhishekk | done with meeting or done with centalized_db :D | 19:23 |
| dansmith | basically sqlite on old, centralized on new, either because the default is changing or because you set it that way | 19:23 |
| dansmith | so cool, let me look through those logs | 19:24 |
| abhishekk | yep | 19:24 |
| dansmith | abhishekk: hah, no, done with meeting :P | 19:24 |
| abhishekk | :) | 19:24 |
| abhishekk | https://fb3330539b69de0bdc86-643409a283e79db7e81f738ea775c76a.ssl.cf1.rackcdn.com/901649/26/check/glance-grenade-centralized-cache/a29da32/controller/logs/screen-g-api.txt | 19:24 |
| abhishekk | this is new log | 19:24 |
| dansmith | are there cached images in the oldside though? | 19:24 |
| abhishekk | Mar 02 15:50:08.563376 np0036938600 devstack@g-api.service[151371]: DEBUG glance.sqlite_migration [None req-4315570b-27b4-4ec3-8a3d-68f48ff78aa9 None None] Migrated 1 records from SQLite db to Centralized db {{(pid=151371) migrate /opt/stack/new/glance/glance/sqlite_migration.py:141}} | 19:25 |
| dansmith | oh must be | 19:25 |
| dansmith | okay yeah cool | 19:26 |
| abhishekk | it helped me to not add a script to create and cache images on old glance | 19:26 |
| abhishekk | also the logs has old and new glance sql queries as well | 19:28 |
| abhishekk | * I don't think so that grenade change is required, since I am setting driver for old and new glance in above change | 19:29 |
| dansmith | abhishekk: couple comments on the default patch, let me know what you think | 19:31 |
| abhishekk | looking | 19:31 |
| abhishekk | 1st comment agree, 2nd in test I need to check locally by removing mock | 19:33 |
| abhishekk | regarding 2nd comment, I am setting driver to sqlite in functional tests and not in unit | 19:39 |
| abhishekk | So since unit has default "centralized_db" set it does not finds the sqlite db in migrate_if_required function and fails there, | 19:42 |
| abhishekk | So to avoid mock, I need to set sqlite as cache driver in each test which is failing or set image_cache_sqlite_db to cache.db | 19:47 |
| dansmith | abhishekk: right but, hang on | 19:52 |
| dansmith | oh heh, okay, | 19:52 |
| dansmith | I was thinking you were mocking out the whole migrate, but you're mocking the "can_migrate" thing which is what I was going to suggest | 19:52 |
| dansmith | okay cool | 19:52 |
| dansmith | you'll move the config help item up in a follow up or do it here? if here, I can +2+W when you do | 19:53 |
| abhishekk | ack, doing it now | 19:53 |
| * dansmith standing by | 19:53 | |
| abhishekk | already done, just running pep8 checks | 19:53 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Make `centralized_db` cache driver default https://review.opendev.org/c/openstack/glance/+/907111 | 19:55 |
| abhishekk | done! | 19:55 |
| abhishekk | thank you! | 19:55 |
| dansmith | abhishekk: done, thanks | 19:56 |
| abhishekk | \o/ | 19:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!