| opendevreview | Merged openstack/glance master: Fix import job to provide valid disk-formats list to tempest https://review.opendev.org/c/openstack/glance/+/923321 | 00:23 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance stable/2024.1: Fix import job to provide valid disk-formats list to tempest https://review.opendev.org/c/openstack/glance/+/923339 | 01:46 |
| abhishek_ | dansmith: ^^ | 01:47 |
| dansmith | abhishek_: it is too late for you to be up | 01:49 |
| opendevreview | Abhishek Kekane proposed openstack/glance stable/2023.2: Fix import job to provide valid disk-formats list to tempest https://review.opendev.org/c/openstack/glance/+/923340 | 01:49 |
| dansmith | abhishek_: also I don't have core on glance stable | 01:49 |
| abhishek_ | put +1 and I will approve | 01:50 |
| dansmith | if you do I think it's reasonable to self-approve, it's just a job change | 01:50 |
| dansmith | done | 01:50 |
| opendevreview | Abhishek Kekane proposed openstack/glance stable/2023.1: Fix import job to provide valid disk-formats list to tempest https://review.opendev.org/c/openstack/glance/+/923341 | 01:50 |
| abhishek_ | ack, thank you! | 01:50 |
| dansmith | oh, it's actually so late it's early for you, sheesh | 01:50 |
| abhishek_ | :d | 01:51 |
| dansmith | got them all | 01:51 |
| abhishek_ | cool, will approve it one by one, I guess I should avoid recheck until nova patch merges | 01:52 |
| dansmith | yeah | 01:52 |
| abhishek_ | should I initiate backport for nova if you are not around? | 01:52 |
| dansmith | sure, sean may be around to hit them earlier but if not I'll do it when I get up unless more stuff explodes overnight | 01:53 |
| dansmith | here, let me just do it real quick so they're ready | 01:54 |
| dansmith | no reason not to | 01:54 |
| abhishek_ | ++ | 01:56 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Reject qcow files with data-file attributes https://review.opendev.org/c/openstack/glance/+/923248 | 05:55 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Extend format_inspector for QCOW safety https://review.opendev.org/c/openstack/glance/+/923249 | 05:55 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add VMDK safety check https://review.opendev.org/c/openstack/glance/+/923250 | 05:55 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Reject unsafe qcow and vmdk files https://review.opendev.org/c/openstack/glance/+/923251 | 05:55 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add QED format detection to format_inspector https://review.opendev.org/c/openstack/glance/+/923252 | 05:55 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add file format detection to format_inspector https://review.opendev.org/c/openstack/glance/+/923253 | 05:55 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add safety check and detection support to FI tool https://review.opendev.org/c/openstack/glance/+/923254 | 05:55 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: DNM Import test failing check https://review.opendev.org/c/openstack/glance/+/923353 | 05:55 |
| opendevreview | Merged openstack/glance stable/2023.1: Fix import job to provide valid disk-formats list to tempest https://review.opendev.org/c/openstack/glance/+/923341 | 07:31 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: DNM Import test failing check https://review.opendev.org/c/openstack/glance/+/923353 | 08:30 |
| *** gaudenz_ is now known as gaudenz | 13:49 | |
| *** whoami-rajat_ is now known as whoami-rajat | 14:00 | |
| opendevreview | Dan Smith proposed openstack/glance master: WIP Add safety check and detection support to FI tool https://review.opendev.org/c/openstack/glance/+/923254 | 15:52 |
| abhishek_ | not so optimistic about getting glance patches in quickly | 16:29 |
| abhishek_ | lots of dependencies to unblock gate, two tempest patches for master then frequent timeouts on other jobs :/ | 16:31 |
| abhishek_ | also not s | 16:31 |
| abhishek_ | also not sure whether tempest patches are allowed to backport till antelope, if not then need to find other workaround | 16:31 |
| abhishek_ | just wondering is it possible to disable tempest jobs and get those patches in and fix tempest and then enable the jobs again? | 16:33 |
| abhishek_ | dansmith: any suggestions? | 16:41 |
| frickler | we were just having a slightly similar discussion in #-nova. with the amount of rechecks that has been done and always different jobs failing, I'd also consider just force-merging be a valid option | 16:50 |
| dansmith | force merge will break further gating in this scenario | 16:51 |
| dansmith | abhishek_: might be best to skip the tempest tests in glance patches if we need to, especially for the backports | 16:51 |
| dansmith | and maybe queue a patch to re-enable them that depends-on the tempest fix to make sure we re-enable those later | 16:51 |
| abhishek_ | problem is we don't have the list of tests which are failing, for example some tests are causing timeouts | 16:52 |
| dansmith | I meant for the image_conversion qcow/raw issue | 16:53 |
| dansmith | for the timeouts, we're all struggling with those | 16:53 |
| dansmith | if we want to force merge those then that might be fine, but I wouldn't force merge when we have blocking fails like the qcow/raw thing | 16:53 |
| abhishek_ | Ok, I think we can skip the import tests then | 16:54 |
| dansmith | right | 16:55 |
| dansmith | we *cannot* forget to fix those though since those are exercising the thing we're changing here | 16:55 |
| abhishek_ | So ideally I should create blacklist file or submit a patch in tempest to skip those? | 16:55 |
| dansmith | abhishek_: do you have tempest fixes up that we just need to get mergeD? maybe force merge of those would be best | 16:55 |
| dansmith | gmann: ^ | 16:55 |
| abhishek_ | dansmith: yes those are up | 16:56 |
| dansmith | abhishek_: let's go to qe and beg for fast merge and maybe frickler or fungi can put those in the gate queue | 16:56 |
| abhishek_ | https://review.opendev.org/c/openstack/tempest/+/923357 and https://review.opendev.org/c/openstack/tempest/+/923352 | 16:56 |
| abhishek_ | already asked in qe | 16:57 |
| fungi | following up in the qa channel then | 16:59 |
| opendevreview | Rajat Dhasmana proposed openstack/glance master: Increase timeout for tempest-integrated-storage-import job https://review.opendev.org/c/openstack/glance/+/923431 | 17:17 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Skip import related tests from tempest run https://review.opendev.org/c/openstack/glance/+/923433 | 17:31 |
| abhishek_ | dansmith: ^ | 17:31 |
| dansmith | oof | 17:32 |
| dansmith | abhishek_: want +2+W or should we loop in another? | 17:32 |
| abhishek_ | NO this is enough to skip tests IMO for jobs other than nova-ceph-multistore | 17:33 |
| abhishek_ | I just hope skip expression is correct | 17:33 |
| dansmith | so "no" means "yes +2+W" ? | 17:34 |
| abhishek_ | yeah | 17:35 |
| dansmith | okay I'll queue for nova | 17:35 |
| dansmith | it'll take me a bit | 17:36 |
| abhishek_ | ack | 17:36 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Make import jobs non-voting https://review.opendev.org/c/openstack/glance/+/923433 | 17:42 |
| abhishek_ | need to put +2W again | 17:43 |
| dansmith | done | 17:47 |
| abhishek_ | ack, thanks | 17:49 |
| abhishek_ | fungi: ^^ | 17:49 |
| fungi | working on it | 17:54 |
| abhishek_ | thank you! | 17:54 |
| fungi | dansmith: abhishek_: it's enqueued into the gate now, should that change be pushed to the front of the queue as well? | 17:58 |
| dansmith | fungi: probs, if you don't mind | 17:58 |
| abhishek_ | good if done, otherwise, I put hold on glance rechecks for now | 17:59 |
| dansmith | abhishek_: so once glance patches merge with that through nova will start failing ceph-multistore right? I dunno if nova will want to skip that | 17:59 |
| fungi | i'll give that requirements change at the top of the gate a minute to wrap up, its only remaining job is uploading logs now | 18:00 |
| dansmith | I pinged kopecmartin downstream in case it happens to get more attention | 18:01 |
| fungi | if there's any other reordering desired in the gate, now would be the time to do it since every change's builds are going to get restarted | 18:01 |
| abhishek_ | I have made nova-ceph-multistore non voting as well | 18:01 |
| fungi | going once... twice... | 18:01 |
| abhishek_ | sold!! | 18:02 |
| fungi | yep, done now | 18:02 |
| fungi | 923433,2 is at the front of the queue | 18:03 |
| abhishek_ | ++ thank you | 18:03 |
| abhishek_ | even though tempest change merges I think we should keep some jobs non voting for time being, until we get timeout sorted | 18:15 |
| * abhishek_ signing out for the day | 18:17 | |
| opendevreview | Merged openstack/glance stable/2024.1: Fix import job to provide valid disk-formats list to tempest https://review.opendev.org/c/openstack/glance/+/923339 | 20:13 |
| fungi | dansmith: do you know whether there's a reasonable expectation that the glance master changes for ossa-2024-001 would pass now behind the other adjustments already in the gate? | 22:48 |
| dansmith | fungi: I believe that all the deps have merged yeah so I assume we're just fighting the flaky stuff | 22:49 |
| dansmith | lemme just have a survey and check hang on | 22:50 |
| fungi | no problem, just wondering if i should enqueue them directly to the gate or whether you wanted to wait for another round in check to complete | 22:50 |
| dansmith | so the top one hasn't even had a clean check run because of the tempest import thing.. we're expecting it to pass, but .. you know | 22:52 |
| dansmith | fungi: also the top-most two patches in the glance series are not required, | 22:52 |
| dansmith | I included them at some point for clarity since I was using them in nova and people were yanking the detection parts into cinder, | 22:53 |
| dansmith | but they're not actually required for glance | 22:53 |
| dansmith | so I could -2 those for clarity until the storm blows over if you want, or you can just ignore them, whatever you want | 22:53 |
| fungi | it's 8 changes total across all 4 branches, so not that many in the grand scheme of things | 22:54 |
| dansmith | yep just sayin' | 22:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!