| abhishekk | rosmaita, dansmith as and when you will get time, or we should wait for direct use of format inspector from oslo.utils? | 17:10 |
|---|---|---|
| abhishekk | I think if we get this in then I can backport it till Antelope upstream | 17:11 |
| dansmith | abhishekk: I've already started on doing this for nova and it isn't hard.. I was going to propose something against glance as well | 17:12 |
| dansmith | but I'm not going to backport it in nova, and I think we should leave glance stable alone as well | 17:13 |
| dansmith | we'd be adding a new library requirement for those backports, which would be uncool | 17:13 |
| abhishekk | ack | 17:13 |
| abhishekk | then should I abandon that or wait until your work is up for review? | 17:14 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/923676 | 17:15 |
| abhishekk | I was talking about this patch, sorry missed to add it in 1st line :facepalm: | 17:15 |
| dansmith | oh sorry are you asking about iso? | 17:15 |
| dansmith | gotcha haha | 17:15 |
| dansmith | we should go ahead with this yeah, lemme look | 17:15 |
| abhishekk | ack, thank you! | 17:16 |
| dansmith | abhishekk: so I thought you were going to block iso for conversion entirely? | 17:17 |
| dansmith | running convert on an iso and telling qemu it's a raw won't really do much useful I think | 17:17 |
| dansmith | I think nova will want to see that it's an iso to do proper cdrom boot, so changing the disk_format afterwards will also be bad | 17:18 |
| abhishekk | it will not run conversion in this patch | 17:18 |
| abhishekk | it will return from line 185 | 17:19 |
| dansmith | if I have target_format=qcow2, it looks to me like it will treat the iso as raw, convert to qcow2 and set disk_format to qcow2 no? | 17:19 |
| abhishekk | hmm | 17:20 |
| dansmith | only if raw | 17:20 |
| abhishekk | then there I need to check if source_format is iso and target_format is raw then treat it as raw | 17:21 |
| dansmith | I think it needs to do: "if disk_format==iso and format_inspector==iso: return without any action" right? | 17:21 |
| abhishekk | else perform the converson | 17:21 |
| dansmith | I think you should never convert iso at all, just make it an exclusion | 17:21 |
| dansmith | and leave it as disk_format=iso | 17:21 |
| abhishekk | OK | 17:21 |
| dansmith | *but* only do that if format_inspector agrees it is an iso | 17:21 |
| abhishekk | makes sense, | 17:22 |
| dansmith | otherwise you could hide stuff claiming its an iso and have it not be converted | 17:22 |
| dansmith | I'll comment | 17:22 |
| abhishekk | thanks, will do those changes tomorrow and push a new PS | 17:22 |
| dansmith | cool | 17:23 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add iso file format inspector https://review.opendev.org/c/openstack/glance/+/923676 | 18:59 |
| opendevreview | Goutham Pacha Ravi proposed openstack/glance master: DNM: Test dependency on devstack-plugin-ceph changes https://review.opendev.org/c/openstack/glance/+/918955 | 23:45 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!