| croelandt | dansmith: Do you know if we test "distributed image import" + "property protection"? I think https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L385 triggers https://github.com/openstack/glance/blob/master/glance/api/property_protections.py#L116 and I wonder if that's tested in the upstream CI | 15:46 |
|---|---|---|
| dansmith | croelandt: nope not sure if we test it (guess not) | 15:47 |
| dansmith | os_glance should be in the reserved prefix, so we probably shouldn't even be applying PP to that prefix since it's excluded by the API always | 15:47 |
| croelandt | Yeah, it seems to happen downstream, so I wonder if that's a regression | 15:49 |
| croelandt | but I guess even downstream we never tested it before | 15:49 |
| dansmith | yeah idk | 15:50 |
| croelandt | but yeah I guess if the property starts with 'os_glance' we should not even check whether it's protected, the API should be allowed to create/update/delete it | 15:50 |
| dansmith | yes and the user is *always* barred from modifying those by the api already | 15:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!