opendevreview | Stephen Finucane proposed openstack/glance master: Add new glance.wsgi module https://review.opendev.org/c/openstack/glance/+/932701 | 09:40 |
---|---|---|
opendevreview | Cyril Roelandt proposed openstack/glance master: WIP: Use the 'native' thread model instead of 'eventlet'. https://review.opendev.org/c/openstack/glance/+/928095 | 15:58 |
croelandt | tkajinam: isn't it an issue to use time.sleep instead of eventlet.sleep since that's going to become a blocking call? | 16:05 |
tkajinam | croelandt, my understanding is that as long as monkey_patch is called timely time.sleep is already replaced by eventlet.sleep | 16:05 |
tkajinam | https://github.com/eventlet/eventlet/blob/master/eventlet/patcher.py#L281-L290 | 16:06 |
tkajinam | quite old eventlet didn't such active patching but they eventually added the default set of modules patched by monkey_patch | 16:07 |
croelandt | oh ok so you are still using eventlet, but not directly | 16:07 |
tkajinam | yeah | 16:08 |
croelandt | ok, great | 16:10 |
tkajinam | croelandt, https://paste.opendev.org/show/bFfaPZpZzrp8udJk7KaF/ | 16:11 |
tkajinam | just fyi | 16:11 |
tkajinam | a minor problem with replacing eventlet.sleep by time.sleep is that time.sleep requires sleep time while eventlet.sleep has default (0) set | 16:17 |
croelandt | indeed | 16:28 |
opendevreview | Cyril Roelandt proposed openstack/glance_store master: Use time.sleep() instead of eventlet.sleep() https://review.opendev.org/c/openstack/glance_store/+/932928 | 18:26 |
opendevreview | Ghanshyam proposed openstack/glance master: Update gate jobs as per the 2025.1 cycle testing runtime https://review.opendev.org/c/openstack/glance/+/932933 | 20:10 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!