| opendevreview | Pranali Deore proposed openstack/glance-specs master: Update image encryption spec https://review.opendev.org/c/openstack/glance-specs/+/927819 | 06:46 |
|---|---|---|
| pdeore | abhishekk, rosmaita, croelandt glance weekly meeting in 10 minutes at #openstack-meeting | 13:51 |
| abhishekk | ack! | 13:51 |
| rosmaita | pdeore: i have a conflict, but ping me if you need me ... and welcome back! | 13:53 |
| pdeore | ack, np ! Thank you !! | 13:54 |
| croelandt | So, does anyone know how we use bindep? | 14:27 |
| croelandt | I was talking with amorin about https://review.opendev.org/c/openstack/glance/+/936954 and I wonder whether we install all packages in there as "runtime" dependencies even when they are not part of a specific profile | 14:28 |
| amorin | yes, I dont know how we can figure that out | 14:31 |
| amorin | we rely on bindep here but maybe it's wrong | 14:31 |
| croelandt | hm bindep crashes on my machine, lovely | 14:34 |
| croelandt | tosky: do you use bindep to set up envs in the CI? | 14:34 |
| tosky | croelandt: uh? | 14:34 |
| tosky | follow the flow of the jobs, it should be the case | 14:35 |
| tosky | iirc there is a tox role for bindep | 14:35 |
| croelandt | of which ones? :) | 14:37 |
| croelandt | There is indeed a tox -ebindep but it just prints out info if I'm not mistaken | 14:37 |
| tosky | croelandt: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e72/936954/1/check/openstack-tox-py39/e724db7/job-output.txt | 14:39 |
| tosky | check for TASK [Install binary dependencies] | 14:39 |
| tosky | that's from the same https://review.opendev.org/c/openstack/glance/+/936954 | 14:40 |
| tosky | so yes, we do use bindep | 14:40 |
| croelandt | It's interesting that we do not run "bindep test" which yields a different set of packages (that are... test-specific, yeah) | 14:45 |
| croelandt | amorin: what if you install "bindep" (no profile specified) in addition to "bindep test"? | 14:45 |
| amorin | that sounds like a trick to me | 14:46 |
| croelandt | hm | 14:46 |
| croelandt | I really don't get it | 14:46 |
| amorin | the fact is the units tests are relying on qemu-img, so we need that | 14:47 |
| croelandt | there is a bunch of dependencies in thisfile that have no profile linked to them | 14:47 |
| croelandt | yeah but qemu-img is a runtime dep as well so it should be installed anyway :D | 14:47 |
| amorin | bindep -b -f bindep.txt test | xargs | 14:48 |
| amorin | this is what we do | 14:48 |
| croelandt | ok postgresql-client is listed in both "bindep" and "bindep test" I don't get it | 14:52 |
| croelandt | ok that's because it is from the platform I'm running on | 14:53 |
| croelandt | oh ok I get it now, if you add a profile then it no longer is listed in "runtime" deps | 14:56 |
| croelandt | amorin: so I think we might want all qemu packages in bindep.txt to be part of the test profile, right? | 15:01 |
| croelandt | and also the runtime profile | 15:01 |
| croelandt | wtf | 15:01 |
| croelandt | OK I +2ed https://review.opendev.org/c/openstack/glance-specs/+/927819 but I think only pdeore can merge it | 15:23 |
| abhishekk | yes | 15:31 |
| opendevreview | Merged openstack/glance_store master: Add interface to get store weight from memory https://review.opendev.org/c/openstack/glance_store/+/934362 | 15:38 |
| croelandt | abhishekk: so do you know if https://review.opendev.org/c/openstack/glance/+/926295 is ready for review? | 15:44 |
| croelandt | I think it's the only patch under review related to encryption | 15:45 |
| abhishekk | @croelandt yes, few suggestions but its all in there | 17:39 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!