| *** elodille1 is now known as elodilles | 07:57 | |
| croelandt | abhishek_: are we going to remove single store support one day? | 13:38 |
|---|---|---|
| abhishek_ | ideally we should | 13:39 |
| croelandt | ok I was thinking about this because ofthe single store mention in the eventletpatches :) | 13:41 |
| abhishek_ | Till then we have to support it :? | 13:52 |
| croelandt | yep | 13:52 |
| croelandt | abhishekk: I'm about to +2 https://review.opendev.org/c/openstack/glance/+/948292/4 but are you sure that test_dir is removed? | 14:20 |
| croelandt | All I can find is glance/tests/functional/v2/test_images.py:6121: os.rmdir(self.test_dir + "/images_3") | 14:21 |
| abhishekk | croelandt: yes | 14:25 |
| abhishekk | I have verified it | 14:25 |
| croelandt | but how? :) | 14:29 |
| croelandt | is there some magic I'm missing? | 14:29 |
| abhishekk | see the definition of useFixture method which is used to create the test_dir | 14:31 |
| abhishekk | self.test_dir = self.useFixture(fixtures.TempDir()).path | 14:31 |
| abhishekk | """Use fixture in a test case. | 14:31 |
| abhishekk | The fixture will be setUp, and self.addCleanup(fixture.cleanUp) called. | 14:31 |
| abhishekk | :param fixture: The fixture to use. | 14:31 |
| abhishekk | :return: The fixture, after setting it up and scheduling a cleanup for | 14:31 |
| abhishekk | it. | 14:31 |
| abhishekk | """ | 14:31 |
| croelandt | oh it's a TempDir, ofc | 14:32 |
| abhishekk | yes | 14:33 |
| opendevreview | Cyril Roelandt proposed openstack/glance stable/2024.2: Harden copy bust lock test https://review.opendev.org/c/openstack/glance/+/948810 | 15:00 |
| opendevreview | Cyril Roelandt proposed openstack/glance stable/2024.1: Harden copy bust lock test https://review.opendev.org/c/openstack/glance/+/948812 | 15:02 |
| croelandt | abhishekk: while I have you, is Thursday a bank holiday in India as well? | 15:02 |
| opendevreview | Merged openstack/glance stable/2024.1: Fix broken metadata function calls https://review.opendev.org/c/openstack/glance/+/948665 | 15:41 |
| abhishekk | croelandt: no, we are working this thursday | 16:00 |
| abhishekk | croelandt: So are we going to remove glance/common/wsgi.py which is eventlet based or convert it to use thread based server? | 16:01 |
| JayF | https://opendev.org/openstack/ironic-python-agent/commit/c03021fee25f47ccd2c04e0d91341cd829c9e600 IPA is using cheroot to build a wsgi server | 16:10 |
| JayF | if you're looking to keep the existing pattern in some what | 16:10 |
| abhishekk | ack | 16:21 |
| abhishekk | sounds interesting, we will discuss this in our weekly meeting | 16:27 |
| abhishekk | thank you JayF!! | 16:27 |
| JayF | it's cid's code, toss him a o/ if you end up using that pattern | 16:28 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!