| *** mhen_ is now known as mhen | 01:24 | |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add task cancellation tracker utility https://review.opendev.org/c/openstack/glance/+/951031 | 11:20 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance master: [WIP] Cancel hasing operation if image is deleted https://review.opendev.org/c/openstack/glance/+/950853 | 11:20 |
| croelandt | abhishekk: do I let you chair tomorrow's meeting or do I cancel it? | 14:33 |
| abhishekk | I will chair it, wait for sometime if anyone shows, else end it early | 14:34 |
| croelandt | You could have a meeting with yourself | 14:40 |
| croelandt | best time to vote on stuff | 14:40 |
| abhishekk | :D | 14:54 |
| croelandt | rosmaita: https://review.opendev.org/c/openstack/glance-specs/+/947423 Francesco and Dan are fine with it, so it merges in a couple of hours :) | 14:57 |
| rosmaita | ack | 14:58 |
| rosmaita | will take a quick look now | 14:58 |
| abhishekk | @dansmith just to double check, as per your comment at line #73 for using os.exists instead of is_canceled in cancel_operation function, it means we need to send signal_finished before calling cacnel_operation | 15:08 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/951031/2/glance/task_cancellation_tracker.py#73 | 15:08 |
| abhishekk | Please ignore | 15:33 |
| rosmaita | croelandt: abhishekk: left some comments on https://review.opendev.org/c/openstack/glance-specs/+/947423 | 15:34 |
| abhishekk | rosmaita: replied to comment | 15:37 |
| abhishekk | I think during PTG we decided that rather than creating the lite-specs just mention the changes we are going to do for client in main spec, So I will keep these action items as is | 15:38 |
| abhishekk | AND also add a lite-spec for python-glanceclient | 15:38 |
| rosmaita | it's fine to keep it all as one, i think the main thing is to make clear that you're not going to allow the new header on the POST /v2/images call | 15:40 |
| abhishekk | ACK I will change the spec accordingly, but will take some time :/ | 15:44 |
| croelandt | ok, holding off on merging this | 15:48 |
| croelandt | Is there a specific deadline for spec freezes in Glance? I don't see it in https://releases.openstack.org/flamingo/schedule.html | 15:49 |
| abhishekk | m2 | 15:49 |
| rosmaita | abhishekk: sorry to be a PITA | 15:56 |
| abhishekk | rosmaita: no worries, it is better to mention about no impact to POST call | 15:56 |
| abhishekk | Right, my preference is not adding it to the body to keep it simple avoiding multiple changes including schema and lot more | 16:18 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add task cancellation tracker utility https://review.opendev.org/c/openstack/glance/+/951031 | 16:19 |
| croelandt | dansmith: thanks for the reward, btw! | 17:54 |
| croelandt | SO I'm gonna be gone until the 9th, if there's anything urgent now's the time :) | 17:54 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add task cancellation tracker utility https://review.opendev.org/c/openstack/glance/+/951031 | 18:12 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: [WIP] Cancel hasing operation if image is deleted https://review.opendev.org/c/openstack/glance/+/950853 | 18:12 |
| * abhishekk signing off for the day | 18:15 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org is temporarily unreachable due to an ongoing issue in the hosting provider where it resides | 22:07 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!