| *** mhen_ is now known as mhen | 02:03 | |
| *** tosky_ is now known as tosky | 09:49 | |
| croelandt | abhishekk: https://review.opendev.org/c/openstack/glance/+/951031/8/glance/tests/unit/test_task_cancellation_tracker.py#26 Not gonna hold up the patch for that, but it's weird to have a method that just calls the parent method, I'm pretty sure that happens automagically anyway | 13:29 |
|---|---|---|
| opendevreview | Josephine Seifert proposed openstack/glance master: Standardization of encrypted images https://review.opendev.org/c/openstack/glance/+/926295 | 13:35 |
| abhishekk | croelandt: right | 13:38 |
| opendevreview | Josephine Seifert proposed openstack/glance master: migrate cinder_encryption* to os_encrypt* in db for Image Encryption https://review.opendev.org/c/openstack/glance/+/926905 | 13:38 |
| dansmith | croelandt: answered your "where are we signaling" question | 13:48 |
| croelandt | dansmith: thanks! abhishekk also cleared it up this morning | 13:54 |
| croelandt | https://review.opendev.org/c/openstack/glance/+/950853/10/glance/api/v2/images.py#265 | 13:54 |
| croelandt | abhishekk: ^ is there any way that host could be None here? :) | 13:54 |
| dansmith | oh sorry | 13:55 |
| croelandt | dansmith: np np | 13:55 |
| croelandt | 2 explanations are better than 1! | 13:55 |
| abhishekk | croelandt: no | 13:55 |
| croelandt | abhishekk: in other parts of images.py we *do* check the return value of is_proxyable though | 13:55 |
| abhishekk | croelandt: there is no scenario where it will be None | 13:56 |
| dansmith | well, croelandt has a good point | 13:57 |
| dansmith | the method can clearly return None, and now that he brings it up... | 13:57 |
| dansmith | won't it always be none for images that weren't imported? | 13:57 |
| croelandt | and if it must not return None, maybe the good design decision is to have an exception raised? | 13:58 |
| abhishekk | In that case it will not call proxy request call | 13:58 |
| abhishekk | Check line No 865 | 13:59 |
| dansmith | oh right right | 13:59 |
| croelandt | I see | 13:59 |
| croelandt | it's getting a bit hard to follow, but ok :D | 13:59 |
| abhishekk | croelandt: We don't want to raise anything, here we don't want to proxy the request if it is None | 14:00 |
| abhishekk | dansmith: regarding your comment on tempest for allowing it to single host as well, I will fix in once gmaan have a look at it | 14:01 |
| dansmith | abhishekk: yep, I saw | 14:01 |
| abhishekk | related to alternate_endpoint check | 14:01 |
| abhishekk | ack | 14:01 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Fix incomplete migration to datetime.fromtimestamp https://review.opendev.org/c/openstack/glance/+/952682 | 15:07 |
| opendevreview | Takashi Kajinami proposed openstack/python-glanceclient master: Replace deprecated datetime.utcfromtimestamp https://review.opendev.org/c/openstack/python-glanceclient/+/952688 | 15:28 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Fix incomplete migration to datetime.fromtimestamp https://review.opendev.org/c/openstack/glance/+/952682 | 15:29 |
| opendevreview | Merged openstack/glance master: Add task cancellation tracker utility https://review.opendev.org/c/openstack/glance/+/951031 | 15:41 |
| opendevreview | Merged openstack/glance master: Cancel hashing operation if image is deleted https://review.opendev.org/c/openstack/glance/+/950853 | 16:16 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Functional test migration test_wsgi.py https://review.opendev.org/c/openstack/glance/+/948536 | 17:12 |
| dansmith | gmaan: sorry to nag, but I really want to make sure this approach is reasonable: https://review.opendev.org/c/openstack/tempest/+/951592 | 17:14 |
| dansmith | gmaan: need not merge right away or anything, just want to make sure the approach is sane, since we're starting a thread for an http server | 17:14 |
| gmaan | dansmith: I kept it open and then my system got crashed and lost all open tabs. I will check this now | 17:16 |
| dansmith | gmaan: ack, thanks, and sorry to nag | 17:16 |
| dansmith | the feature is merged now so I just hope we'll be able to test it :D | 17:17 |
| abhishekk | dansmith: added recheck here as well, https://review.opendev.org/c/openstack/nova/+/950623 | 17:27 |
| gmaan | dansmith: approach (as long as we stop the http server carefully) is ok to me but I have not reviewed it all at least to check how it monitor the hash calculation | 17:40 |
| dansmith | abhishekk: we need a few rechecks of the revert right? | 17:40 |
| dansmith | gmaan: cool thanks | 17:40 |
| gmaan | I will check details later or tomorrow | 17:40 |
| abhishekk | dansmith: yep, if possible could you please add 2nd recheck today? I will continue watching it tomorrow morning | 17:41 |
| dansmith | I'll try to remember | 17:43 |
| abhishekk | ack | 17:44 |
| opendevreview | Merged openstack/glance master: Functional test migration test_wsgi.py https://review.opendev.org/c/openstack/glance/+/948536 | 19:15 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!