| opendevreview | Takashi Kajinami proposed openstack/glance_store master: Fix missing dependency on retrying https://review.opendev.org/c/openstack/glance_store/+/954192 | 00:55 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/glance master: DNM: Reproduce the test failure caused by missing retrying https://review.opendev.org/c/openstack/glance/+/954309 | 05:14 |
| opendevreview | Merged openstack/glance master: Replace deprecated assertItemsEqual https://review.opendev.org/c/openstack/glance/+/953583 | 07:36 |
| croelandt | mhen: hey, I'm looking at your LUKS patches. I think you'll also need to deprecate cinder_encryption_* in Nova, right? | 14:01 |
| mhen | croelandt: thanks for having a look | 14:03 |
| mhen | I guess you are referring to | 14:03 |
| mhen | https://github.com/openstack/nova/blob/1c034293379f4a319b65c52e5ee4fe332f83f34d/nova/compute/api.py#L738 | 14:04 |
| mhen | and | 14:04 |
| mhen | https://github.com/openstack/nova/blob/1c034293379f4a319b65c52e5ee4fe332f83f34d/nova/compute/utils.py#L65 | 14:04 |
| mhen | ? | 14:04 |
| mhen | I was not aware that Nova had any interest in Cinder's image key attributes but now that I look at these code snippets it does make sense for those edge cases. | 14:05 |
| mhen | Would it be appropriate to add some adjustments to these code parts to https://review.opendev.org/c/openstack/nova/+/926326 or do you think a separate patchset is necessary? | 14:06 |
| mhen | croelandt: ? | 14:16 |
| croelandt | hm I think you should ask Nova devs directly | 14:33 |
| croelandt | maybe dansmith when he's back next week | 14:33 |
| croelandt | I'm not sure exactly why Nova looks at those attributes either :D | 14:34 |
| mhen | understood, I will talk to them | 15:29 |
| mhen | thank you for pointing this out, I missed those attribute uses in Nova | 15:29 |
| croelandt | mhen: do you know about codesearch/beagle? | 15:35 |
| mhen | no | 15:35 |
| croelandt | it's a piece of software that allows you to "git grep" in multiple repos | 15:37 |
| croelandt | we do have an OpenStack instance | 15:37 |
| croelandt | so | 15:37 |
| croelandt | $ beagle --server-url http://codesearch.openstack.org search -f table --repo-pattern openstack/* "cinder_encryption_key_id" | 15:37 |
| croelandt | (with $ pipx install beagle) | 15:37 |
| clarkb | you can also use the web ui at https://codesearch.opendev.org | 15:38 |
| croelandt | it's pretty useful when making changes that may affect other projects | 15:38 |
| mhen | that's cool | 15:43 |
| mhen | thanks for the hint! | 15:43 |
| croelandt | mhen: ok I did another pass at the patch, it's pretty good | 16:27 |
| croelandt | got some questions and I want dansmith to be able to answer you before we merge though | 16:28 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!