Tuesday, 2025-07-08

opendevreviewTakashi Kajinami proposed openstack/glance_store master: Fix missing dependency on retrying  https://review.opendev.org/c/openstack/glance_store/+/95419200:55
opendevreviewTakashi Kajinami proposed openstack/glance master: DNM: Reproduce the test failure caused by missing retrying  https://review.opendev.org/c/openstack/glance/+/95430905:14
opendevreviewMerged openstack/glance master: Replace deprecated assertItemsEqual  https://review.opendev.org/c/openstack/glance/+/95358307:36
croelandtmhen: hey, I'm looking at your LUKS patches. I think you'll also need to deprecate cinder_encryption_* in Nova, right?14:01
mhencroelandt: thanks for having a look14:03
mhenI guess you are referring to14:03
mhenhttps://github.com/openstack/nova/blob/1c034293379f4a319b65c52e5ee4fe332f83f34d/nova/compute/api.py#L73814:04
mhenand14:04
mhenhttps://github.com/openstack/nova/blob/1c034293379f4a319b65c52e5ee4fe332f83f34d/nova/compute/utils.py#L6514:04
mhen?14:04
mhenI was not aware that Nova had any interest in Cinder's image key attributes but now that I look at these code snippets it does make sense for those edge cases.14:05
mhenWould it be appropriate to add some adjustments to these code parts to https://review.opendev.org/c/openstack/nova/+/926326 or do you think a separate patchset is necessary?14:06
mhencroelandt: ?14:16
croelandthm I think you should ask Nova devs directly14:33
croelandtmaybe dansmith when he's back next week14:33
croelandtI'm not sure exactly why Nova looks at those attributes either :D14:34
mhenunderstood, I will talk to them15:29
mhenthank you for pointing this out, I missed those attribute uses in Nova15:29
croelandtmhen: do you know about codesearch/beagle?15:35
mhenno15:35
croelandtit's a piece of software that allows you to "git grep" in multiple repos15:37
croelandtwe do have an OpenStack instance15:37
croelandtso 15:37
croelandt$ beagle --server-url http://codesearch.openstack.org search  -f table --repo-pattern openstack/* "cinder_encryption_key_id" 15:37
croelandt(with $ pipx install beagle)15:37
clarkbyou can also use the web ui at https://codesearch.opendev.org15:38
croelandtit's pretty useful when making changes that may affect other projects15:38
mhenthat's cool15:43
mhenthanks for the hint!15:43
croelandtmhen: ok I did another pass at the patch, it's pretty good16:27
croelandtgot some questions and I want dansmith to be able to answer you before we merge though16:28

Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!