| opendevreview | Abhishek Kekane proposed openstack/glance master: Update API reference to mention x-openstack-image-size header https://review.opendev.org/c/openstack/glance/+/956628 | 07:32 |
|---|---|---|
| croelandt | abhishekk: can we merge https://review.opendev.org/c/openstack/python-glanceclient/+/923628 | 14:09 |
| croelandt | We have 3 patches fixing the same issue currently open :) | 14:09 |
| abhishekk | looking | 14:09 |
| abhishekk | we don't have py13 to verify it :/ | 14:13 |
| croelandt | you have it on your machine :)à | 14:14 |
| croelandt | I sent a patch, 2 other people sent patches, they're gonna keep coming up | 14:15 |
| croelandt | people are packing glanceclient for their distros and hitting issues when running tests :/ | 14:15 |
| abhishekk | I have added one comment | 14:16 |
| abhishekk | hope that makes sense | 14:17 |
| croelandt | makes a lot of sense actually :) | 14:19 |
| tkajinam | croelandt abhishekk, https://review.opendev.org/c/openstack/glance_store/+/940614 passed CI. can it get +A now ? | 14:20 |
| croelandt | OK I'm an idiot | 14:21 |
| croelandt | abhishekk: that's not the patch I wanted you to read :D | 14:21 |
| croelandt | https://review.opendev.org/c/openstack/python-glanceclient/+/924620 | 14:21 |
| croelandt | That's this one ^ | 14:21 |
| croelandt | where we don't check the value of Python3 by avoiding looking at too much internal stuff | 14:21 |
| croelandt | which is imho much better | 14:21 |
| croelandt | I just need to change the subject | 14:21 |
| abhishekk | tkajinam: looking | 14:22 |
| abhishekk | croelandt: ack :D | 14:22 |
| tkajinam | (sorry if I interrupt but I was too eager to post it now before I leave from my laptop | 14:22 |
| abhishekk | croelandt: looks good to me, your change | 14:23 |
| abhishekk | tkajinam: np, done!! | 14:23 |
| tkajinam | thx :-) | 14:23 |
| opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: Python 3.13: https://review.opendev.org/c/openstack/python-glanceclient/+/924620 | 14:24 |
| opendevreview | Cyril Roelandt proposed openstack/python-glanceclient master: Python 3.13: fix tests https://review.opendev.org/c/openstack/python-glanceclient/+/924620 | 14:24 |
| croelandt | abhishekk: yep, that's the one ^ | 14:25 |
| croelandt | I updated the commit message, if you want to +2 I'll abandon the other 2 | 14:25 |
| abhishekk | yep, I think looks good, I will +2 the patch shortly | 14:25 |
| abhishekk | croelandt: I made changes as per your suggestion, https://review.opendev.org/c/openstack/glance/+/948903 | 14:27 |
| clarkb | abhishekk: "we don't have py13 to verify it" is not entirely accurate. You can install python 3.13 using pyenv in zuul jobs (I've got a change up testing python 3.13 against zuul itself that does this for example) or you can use the new debian trixie test nodes which only come with python3.13 | 15:01 |
| abhishekk | clarkb: ack, thanks for the input | 15:02 |
| croelandt | is 3.13 going to be officially supported by OpenStack? | 15:07 |
| croelandt | abhishekk: oh tehre was also exception_to_unicode that I missed | 15:11 |
| croelandt | would be nice to have a check in the CI that is just a shell script with a bunch of git greps | 15:12 |
| abhishekk | +1 | 15:19 |
| croelandt | I'm not sure how easily we could plug that | 15:22 |
| opendevreview | Merged openstack/glance master: Remove installation guide for openSUSE/SLES https://review.opendev.org/c/openstack/glance/+/949867 | 15:40 |
| opendevreview | Merged openstack/glance_store master: Replace oslo_utils.encodeutils.exception_to_unicode https://review.opendev.org/c/openstack/glance_store/+/940614 | 16:58 |
| opendevreview | Merged openstack/python-glanceclient master: Python 3.13: fix tests https://review.opendev.org/c/openstack/python-glanceclient/+/924620 | 17:39 |
| opendevreview | Merged openstack/glance master: Read image size from request header https://review.opendev.org/c/openstack/glance/+/948903 | 20:02 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!