| *** mhen_ is now known as mhen | 02:01 | |
| opendevreview | Merged openstack/glance master: Remove legacy update tests https://review.opendev.org/c/openstack/glance/+/962445 | 09:12 |
|---|---|---|
| croeland1 | sfinucan: Hey! https://review.opendev.org/c/openstack/glance/+/961465 is still under review. In this patch you remove the use of wsgi-file from the INI config. In https://review.opendev.org/c/openstack/glance/+/963294 abhishekk use wsgi-file in the doc. Can we come to an agreement regarding how this is supposed to be configured? | 15:28 |
| croeland1 | (maybe this can be part of tomorrow's meeting if you're available) | 15:30 |
| *** croeland1 is now known as croelandt | 15:41 | |
| *** sfinucan is now known as stephenfin | 15:44 | |
| stephenfin | croelandt: Yeah, that's wrong. abhishekk should be using module. That's what DevStack uses https://github.com/openstack/devstack/blob/a3e37c86cab4ec43a4a6d1c1386abf12bc034db7/lib/apache#L335-L337 | 15:46 |
| stephenfin | croelandt: and wrt coming to an agreement, https://governance.openstack.org/tc/goals/completed/2025.2/migrate-from-wsgi-scripts-to-module-paths.html | 15:47 |
| croelandt | oh, nice! I did not know about that documentation, thanks a lot! | 15:49 |
| stephenfin | croelandt: while I have you, can you take another look at https://review.opendev.org/c/openstack/glance/+/961466. the tl;dr: is that we don't want to change those things yet | 15:51 |
| croelandt | stephenfin: so when should we merge this patch? | 16:10 |
| stephenfin | now | 16:10 |
| stephenfin | flamingo is out so no time like the present. We will come back to it one the license situation is resolved | 16:10 |
| stephenfin | *once | 16:10 |
| stephenfin | (there'll have to be a bulk update across most projects) | 16:11 |
| croelandt | "the tl;dr is that we don't want to change those things yet" <- I don't get it then | 16:11 |
| croelandt | or do you mean that was the tl;dr a few weeks ago? | 16:11 |
| stephenfin | oh, sorry, we don't want to make the changes you suggested yet | 16:11 |
| stephenfin | namely, using license-files and removing the license classifier | 16:12 |
| croelandt | oh ok | 16:13 |
| croelandt | sure this can always be done later | 16:13 |
| stephenfin | yep | 16:13 |
| croelandt | I love that we have to keep a 2 line setup.cfg | 16:14 |
| croelandt | is it setuptools that requires this or pbr? | 16:14 |
| stephenfin | pbr, unfortunately. pbr needs the package name to kick of the rest of its machinery and doesn't know about pyproject.toml itself yet | 16:15 |
| stephenfin | I have WIP patches to resolve that but finding time to complete it has been challenging | 16:16 |
| croelandt | I see | 16:16 |
| stephenfin | likewise for setup.py: that shouldn't be needed once 'pbr' is in build-requires in pyproject.toml | 16:17 |
| stephenfin | but pbr needs more smarts. soon | 16:17 |
| stephenfin | Also, if you could grab the last change in that series, that'd be great :) (if you're not on it already) https://review.opendev.org/c/openstack/glance/+/961467 | 16:19 |
| opendevreview | Merged openstack/glance_store master: Cinder: Standardize volume GET calls https://review.opendev.org/c/openstack/glance_store/+/962398 | 16:48 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!