| *** mhen_ is now known as mhen | 01:56 | |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Update "Eliminate Redundant Downloads" proposal https://review.opendev.org/c/openstack/glance-specs/+/962651 | 06:51 |
|---|---|---|
| dansmith | tkajinam: asking you here because I think you probably know.. we really can't bump deps in a maintained branch even if we need it to fix a bug right? | 14:15 |
| dansmith | there's a bug reported in glance which is asking to cover a case for format detection that needs a newer oslo.utils in order to do it, but it looks like glance hasn't had that version in the reqs even up to current master | 14:17 |
| dansmith | maybe it's allowable if that version of oslo.utils was released in the coordinated release? | 14:17 |
| *** croeland1 is now known as croelandt | 14:28 | |
| dansmith | Looks like the oslo.utils I need is 7.4.0, which was released with epoxy, which means the proper master fix will be backportable to epoxy, not to dalmation (which isn't a slurp) and caracal is about to go to unmaintained | 14:32 |
| croelandt | stephenfin: Hey, you probably know this. I'm always a bit puzzled regarding the init of the OpenStack SDK. For instance https://review.opendev.org/c/openstack/ceilometer/+/963632 gives me "keystoneauth1.exceptions.auth_plugins.MissingAuthPlugin: An auth plugin is required to determine endpoint URL" whereas https://review.opendev.org/c/openstack/manila/+/935835 just works . Is there a | 14:37 |
| croelandt | definitive guide on how to properly init the SDK? | 14:37 |
| opendevreview | Dan Smith proposed openstack/glance master: Handle images detected as ISO+GPT https://review.opendev.org/c/openstack/glance/+/963868 | 15:25 |
| stephenfin | croelandt: There isn't a definitive guide, unfortunately. That error message usually pops up if you haven't provided a pre-configured session object to the Connection. Given you've done that, I suspect your issue is that the session is missing configuration | 15:27 |
| croelandt | oh so there is some kind of specific configuration to pass? | 15:28 |
| stephenfin | yeah, you'll want to configure all of the things that it would otherwise need a clouds.yaml file for: auth_url, username/password (or other credentials) etc. | 15:30 |
| stephenfin | if you look at the manila code, you'll see they're building a Session object from oslo.config config options. Those options are all coming from 'manila/image/glance.py' | 15:31 |
| stephenfin | where they call 'register_session_conf_options' | 15:31 |
| croelandt | for glance_opts | 15:32 |
| croelandt | so region_name/endpoint_type seem to be enough, right? | 15:32 |
| dansmith | stephenfin: you probably know the answer to my question to tkajinam above | 15:33 |
| stephenfin | croelandt: Nah, the rest of them are registered via the ks_loading calls https://github.com/openstack/manila/blob/master/manila/image/glance.py#L48-L49 | 15:34 |
| stephenfin | ceilometer is making the same calls https://github.com/openstack/ceilometer/blob/master/ceilometer/keystone_client.py#L33-L37 so my _guess_ is that you're simply not actually setting them in your devstack plugin? | 15:35 |
| croelandt | hm | 15:37 |
| croelandt | I mean, the unit tests don't usethe devstack plugin, right? | 15:37 |
| stephenfin | dansmith: I usually defer to elodilles and the release team for that kind of question, but does your bump require a change to upper-constraints? If not, can you make the bug fix conditional on the version? | 15:37 |
| dansmith | stephenfin: I suspect not because I assume u-c had the current version of oslo-utils in it for epoxy, but I'll check | 15:38 |
| stephenfin | croelandt: Oh, yeah, it's unit tests. So that means you'll want to set things in your ConfFixture | 15:39 |
| * stephenfin looks at what Manila is doing | 15:39 | |
| stephenfin | croelandt: Well it's not pretty https://github.com/openstack/manila/blob/master/manila/test.py#L244 | 15:44 |
| croelandt | not even sure I get it tbh | 15:46 |
| croelandt | they just patch keystoneauth1.loading.load_auth_from_conf_options ? | 15:47 |
| stephenfin | Yeah. I'm guessing here, but I think that means the generated Auth object is going to be mock.Mock object, which will return a Mock value for all attributes | 15:53 |
| stephenfin | including plugin-related attributes | 15:53 |
| croelandt | OpenStack and mocks testing mocks <3 | 15:55 |
| stephenfin | croelandt: If you do the same thing in ceilometer you'll get further along, though of course it would be better to use a proper fixture like the keystoneauth | 15:55 |
| stephenfin | https://paste.opendev.org/show/bFoCmKBYzBcwlCTKj3zU/ | 15:55 |
| stephenfin | for example | 15:55 |
| croelandt | and then having fake return value for that? | 15:57 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Lazy update S3 URL on credential rotation https://review.opendev.org/c/openstack/glance/+/963875 | 17:29 |
| opendevreview | Alexey proposed openstack/glance master: Correct read function in _UWSGIChunkFile not to exceed length https://review.opendev.org/c/openstack/glance/+/963732 | 18:43 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!