| *** mhen_ is now known as mhen | 02:30 | |
| croelandt | rosmaita: hey, you're good at phrasing stuff in English, as if you were a native speaker or something | 14:25 |
|---|---|---|
| croelandt | In https://review.opendev.org/c/openstack/glance-specs/+/963239 we can specify "?stores=ceph,s3&preference=only" to ask the API to download an image from either Ceph or S3, and fail if the image is not in either store | 14:26 |
| croelandt | and we can specify "?stores=ceph,s3&preference=oneof" to ask the API to download an image from either Ceph or S3, and download it from the default store (NFS, for instance) if the image is not in either store | 14:27 |
| croelandt | but "oneof" sounds weird to me for this use case | 14:27 |
| croelandt | wdyt? | 14:27 |
| rosmaita | croelandt: thinking | 14:35 |
| croelandt | you're telling me when you're thinking now, just like Claude Code... We should have seen it, you're rosmAIta | 14:44 |
| rosmaita | :D | 14:47 |
| rosmaita | ok, left a comment on the review | 14:47 |
| rosmaita | a comment that i wrote myself! | 14:47 |
| croelandt | I think you did not push the button | 14:48 |
| rosmaita | you are correct, sir | 14:48 |
| croelandt | echo "- Do not forget to press the button" >> .rosmaita.md | 14:50 |
| croelandt | who's Erno? :D | 14:51 |
| womax | good morning/afternoon glance | 15:06 |
| womax | I recently did a quick patchs on my end in ironic to allow for boot for image stored in a s3 backend. Doing this patch I used quite a bit of code from glance_store to do config parsing to get credentials necessary for temp_url generation | 15:08 |
| womax | Such changes lead to a bit of code and config duplication between glance and ironic. I discussed a bit yesterday with ironic team to get their opinion of moving temp url generation for object storage backend in glance and they were interested. So on your end, do you think that is something that would be interesting / doable or do you think it is something that should stay in ironic code? | 15:11 |
| croelandt | do you have a proof of concept? | 15:37 |
| womax | on glance no, I only have what I have done in ironic | 15:42 |
| croelandt | do you have a link to that? | 15:46 |
| womax | Neither, change are still on private repos and on an old openstack version | 15:48 |
| womax | I guess i could generate patch file and send them if thats work with you | 15:49 |
| croelandt | please make that public | 15:49 |
| womax | https://gist.github.com/AntoninRuan/b0598cb581f187829120aaab5df4df31 | 15:55 |
| womax | patch is from ironic in stein version | 15:56 |
| croelandt | so why does Ironic need to download an image without auth? | 16:00 |
| womax | From what I understand, ironic agent running on baremetal node that is in charge of installing the server at creation does not have any configuration and thus does not have any credentials either and so it need an no auth url | 16:03 |
| womax | But i did not really dig deep on why, I needed to make it work for s3 and inspired myself strongly from what was already done for swift | 16:05 |
| womax | Maybe it is another reason that justify no auth url, i didn't really find any info on this, it just a conclusion I drawn from my basic understanding of ironic architecture | 16:06 |
| croelandt | ok so if Swift does it, it's already something | 16:20 |
| croelandt | Does Swift generate a temp URL in the glance_store code? | 16:21 |
| womax | Didn't fully check but I don't think so | 16:21 |
| womax | At least when i greped the _drivers/swift folder of glance_store there were no occurence of "temp_url" | 16:23 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Update image size after image decompression https://review.opendev.org/c/openstack/glance/+/968351 | 17:24 |
| abhishekk | I have found multiple issues while testing image decompression plugin :/ Reporting it one by one as those are dependent | 17:32 |
| abhishekk | above one is the first base issue | 17:32 |
| abhishekk | @croelandt ^^ FYI | 17:32 |
| abhishekk | decompression works with gzip and web-download but failing for glance-direct for gzip, zip and lha formats, it will also fail with zip and lha for web-download (I have not tested web-download with these formats but from glance-direct testing it looks like it will fail) | 17:35 |
| croelandt | ouch | 18:09 |
| croelandt | sounds bad | 18:09 |
| dansmith | decompression of zip at all seems weird to me, since it's both a compression format and a container of multiple things.. are we really expecting glance _should_ do that? | 18:14 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Fix LHA file decompression context manager issue https://review.opendev.org/c/openstack/glance/+/968365 | 18:29 |
| abhishekk | I am also not in favor of zip but as it is there we need to fix it :/ | 18:31 |
| abhishekk | I think at this moment I will fix the issue with a doc note and then we can decide on whether keep it or remove it during next PTG | 18:34 |
| opendevreview | Alexey proposed openstack/glance master: Correct read function in _UWSGIChunkFile not to exceed length https://review.opendev.org/c/openstack/glance/+/963732 | 18:57 |
| opendevreview | Alexey proposed openstack/glance master: Correct read function in _UWSGIChunkFile not to exceed length https://review.opendev.org/c/openstack/glance/+/963732 | 18:58 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!