| opendevreview | Mitsuhiro Tanino proposed openstack/glance master: Enhance schema loading to support required properties https://review.opendev.org/c/openstack/glance/+/969967 | 00:29 |
|---|---|---|
| opendevreview | Mitsuhiro Tanino proposed openstack/glance master: Enhance schema loading to support required properties https://review.opendev.org/c/openstack/glance/+/969967 | 00:34 |
| *** mhen_ is now known as mhen | 02:15 | |
| opendevreview | Mitsuhiro Tanino proposed openstack/glance master: Enhance schema loading to support required properties https://review.opendev.org/c/openstack/glance/+/969967 | 03:57 |
| mtanino | https://review.opendev.org/c/openstack/glance/+/969967 | 07:08 |
| mtanino | Hi Glance team members. I'm trying to propose above change (Enhance schema loading to support required properties) into Gerrit. I'd appreciate if someone take a look the change. | 07:10 |
| mtanino | rosmaita: Thanks for your help of code review. Based on your comment, I tested schema-image.json and I believe there is an issue to support "required" property. | 07:27 |
| mtanino | Above my commit contains fix for this issue, so please help for the review whenever you have chance. Thanks. | 07:27 |
| croelandt | tkajinam: ok so in d6d49f1060 you move the 312 jobs to Noble, but you also remove the same jobs in 69cff4e700 ? | 13:26 |
| rosmaita | mtanino: thanks for the quick revision, took a quick look and i think you are on the right track ... will do a "real" review either later today or early tomorrow | 14:20 |
| tkajinam | croelandt, I wasn't too sure if there is no other reason to keep py312 jobs so I made less controversial change separate, but if removing py312 is something we can agree then I can squash these two (to remove py312 job directly) | 14:33 |
| mtanino | rosmaita: Thanks for the quick check! I'm glad to hear that I'm on the right track. I look forward to your full review. | 14:40 |
| tkajinam | croelandt, another slight benefit of these separate steps is that we can backport that noble migration patch, but I don't know how much we need that | 14:52 |
| opendevreview | Max proposed openstack/glance-specs master: spec-lite: image multipart download https://review.opendev.org/c/openstack/glance-specs/+/970136 | 15:07 |
| croelandt | tkajinam: ok, makes sense then | 15:20 |
| croelandt | I'll take another look | 15:20 |
| croelandt | abhishekk: I look at your decompression patches | 15:20 |
| croelandt | could you take a look at https://review.opendev.org/c/openstack/glance_store/+/959201 ? | 15:20 |
| abhishekk | croelandt: ack | 15:23 |
| tkajinam | croelandt, thanks ! | 15:27 |
| tkajinam | abhishekk, croelandt do you mind merging https://review.opendev.org/c/openstack/glance-tempest-plugin/+/966364 and https://review.opendev.org/c/openstack/glance-tempest-plugin/+/961254 to update the stable branch jobs in g-t-p ? | 15:28 |
| abhishekk | tkajinam: ack | 15:28 |
| tkajinam | while these jobs are stable... | 15:28 |
| tkajinam | abhishekk, thx ! | 15:29 |
| abhishekk | tkajinam: np! | 15:29 |
| croelandt | abhishekk is too fast! | 15:34 |
| abhishekk | those were straight forward :D | 15:34 |
| opendevreview | Max proposed openstack/glance-specs master: spec-lite: image multipart download https://review.opendev.org/c/openstack/glance-specs/+/970136 | 15:37 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Update image size after image decompression https://review.opendev.org/c/openstack/glance/+/968351 | 15:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Fix LHA file decompression context manager issue https://review.opendev.org/c/openstack/glance/+/968365 | 15:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Fix ZIP file extraction in image_decompression plugin https://review.opendev.org/c/openstack/glance/+/968432 | 15:46 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add functional tests for image decompression plugin https://review.opendev.org/c/openstack/glance/+/969282 | 15:46 |
| opendevreview | Vishnu C proposed openstack/glance master: Fix S3 image download errors from credential rotation where forward slash in credentials corrupts URLs in DB. https://review.opendev.org/c/openstack/glance/+/970048 | 15:53 |
| opendevreview | Merged openstack/glance-tempest-plugin master: Update stable branch jobs https://review.opendev.org/c/openstack/glance-tempest-plugin/+/966364 | 16:11 |
| opendevreview | Merged openstack/glance-tempest-plugin master: Add stable/2025.2 job https://review.opendev.org/c/openstack/glance-tempest-plugin/+/961254 | 16:12 |
| opendevreview | Max proposed openstack/glance_store master: feat: s3 add range capability https://review.opendev.org/c/openstack/glance_store/+/969482 | 16:14 |
| opendevreview | Merged openstack/glance master: Add missing image properties https://review.opendev.org/c/openstack/glance/+/959227 | 16:22 |
| mhen | rosmaita you around? | 16:27 |
| rosmaita | hello | 16:28 |
| mhen | hi :) | 16:28 |
| mhen | regarding image encryption, last meeting you said "we'll have to be careful on image download, for legacy images that are luks but also compressed" | 16:28 |
| mhen | what case did you have in mind? | 16:28 |
| mhen | I've been looking at the Cinder code: | 16:29 |
| mhen | https://opendev.org/openstack/cinder/src/branch/master/cinder/image/image_utils.py#L1121-L1199 | 16:29 |
| mhen | and I have not been able to construct a scenario where Cinder would've created a compressed and luks-encrypted image in this code | 16:29 |
| mhen | because container_format must not be compressed, it must be bare for encrypted volumes (according to the current API spec) | 16:30 |
| mhen | and the only spot where the compress flag plays a role is in the qemu conversion call but that doesn't happen because it's raw to raw afaict | 16:30 |
| mhen | (raw disk_format that is) | 16:31 |
| rosmaita | ok, i will have to look again ... i thought the compression accelerator was called last in the upload chain, and near the beginning of download | 16:33 |
| mhen | the accelerator is guarded behind a `image_meta.get('container_format') == 'compressed'` | 16:33 |
| mhen | but the os-volume_upload_image Cinder API for container_format says "(Note: Volumes of an encrypted volume type must use a bare container format.)" | 16:34 |
| mhen | https://docs.openstack.org/api-ref/block-storage/v3/index.html#upload-volume-to-image | 16:34 |
| mhen | https://opendev.org/openstack/cinder/src/branch/master/cinder/api/contrib/volume_actions.py#L221-L228 | 16:35 |
| opendevreview | Merged openstack/glance_store master: tox: Drop basepython https://review.opendev.org/c/openstack/glance_store/+/961008 | 16:59 |
| rosmaita | mhen: ok, that volume_actions code is more recent than the hardware accelerator, and it's rejecting 'compressed' container_format at the cinder REST api layer, so i believe that you are correct that this is not a concern | 16:59 |
| opendevreview | Vishnu C proposed openstack/glance master: Fix S3 image download errors from credential rotation where forward slash in credentials corrupts URLs in DB. https://review.opendev.org/c/openstack/glance/+/970048 | 18:49 |
| *** jgwentworth is now known as melwitt | 19:01 | |
| *** melwitt is now known as jgwentworth | 22:31 | |
| *** jgwentworth is now known as melwitt | 22:32 | |
| opendevreview | Vishnu C proposed openstack/glance master: Fix S3 URL corruption on secret rotation https://review.opendev.org/c/openstack/glance/+/970198 | 22:38 |
| opendevreview | Vishnu C proposed openstack/glance master: Fix S3 URL corruption on secret rotation https://review.opendev.org/c/openstack/glance/+/970048 | 22:40 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!