| rosmaita | vischan2: approved, but left a comment for you on your patch | 00:06 |
|---|---|---|
| vischan2 | rosmaita: thank you very much for your time and the approval. I will also follow through on your suggestion to open a follow-up patch. | 01:19 |
| rosmaita | sounds good! | 01:19 |
| opendevreview | Merged openstack/glance master: Fix S3 URL corruption on secret rotation https://review.opendev.org/c/openstack/glance/+/970048 | 02:10 |
| *** mhen_ is now known as mhen | 02:10 | |
| opendevreview | Josephine Seifert proposed openstack/glance master: migrate cinder_encryption* to os_encrypt* in db for Image Encryption https://review.opendev.org/c/openstack/glance/+/926905 | 09:36 |
| abhishek_ | luzi glad it worked, let me know if you need help in adding functional tests | 09:40 |
| opendevreview | Max proposed openstack/glance-specs master: spec-lite: image multipart download https://review.opendev.org/c/openstack/glance-specs/+/970136 | 10:00 |
| croelandt | I'm wondering if anyone can help with https://review.opendev.org/c/openstack/glance/+/968351 and friends | 13:42 |
| croelandt | I could ninja approve it but it feels a bit wrong | 13:43 |
| croelandt | rosmaita: ^ | 13:43 |
| croelandt | dansmith: ^ | 13:43 |
| croelandt | and also let me check why the gate is unhappy | 13:43 |
| croelandt | oh probably just because I removed the +W | 13:44 |
| rosmaita | yeah, i think that was it | 13:44 |
| rosmaita | croelandt: the decompression is being done by this line??? globals()[key](src_path, self.dest_path, self.image_id) | 13:54 |
| rosmaita | could that be any more obscure? | 13:54 |
| croelandt | yeah I made a mental note of looking into this and not using globals() if possible | 13:56 |
| croelandt | but I think it's mostly an internal improvement | 13:56 |
| croelandt | that could go into a separate patch | 13:56 |
| croelandt | especially after we get better tests thanks to this patch series | 13:56 |
| rosmaita | croelandt: left a +1, but you can +W if you think my nit is stupid | 14:25 |
| croelandt | I was going to ask abhishek :-( | 14:31 |
| croelandt | rosmaita: but this does give you time to review the other patches in the series! | 14:31 |
| * croelandt grabs his whip | 14:31 | |
| rosmaita | well, the "globals()[key](src_path, self.dest_path, self.image_id)" has pretty much blown my mind for today | 14:33 |
| croelandt | hahaha | 14:38 |
| croelandt | I think having a dict of name->methods would be better | 14:39 |
| croelandt | but imagine if we ever add a method, we'd have to also update the dict! | 14:39 |
| croelandt | so inefficient | 14:39 |
| dansmith | croelandt: that failed to merge due to a dep, but I don't see what dep? | 15:39 |
| croelandt | dansmith: I think it's because I set +W by mistake, then took it away | 16:01 |
| dansmith | ah | 16:01 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily at 20:00 UTC (approximately 55 minutes from now) for a project rename maintenance: https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/message/ZPIV7CTPXZUYKUCBYMQ3OKQZDXOSOQGF/ | 19:09 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily for a project rename maintenance: https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/message/ZPIV7CTPXZUYKUCBYMQ3OKQZDXOSOQGF/ | 20:01 | |
| opendevreview | Merged openstack/glance master: Update image size after image decompression https://review.opendev.org/c/openstack/glance/+/968351 | 20:34 |
| croelandt | frickler: just approved https://review.opendev.org/c/openstack/glance/+/963294 | 23:32 |
| opendevreview | Merged openstack/glance master: Document Uwsgi support for production https://review.opendev.org/c/openstack/glance/+/963294 | 23:59 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!