| *** mhen_ is now known as mhen | 02:19 | |
| *** JayF_ is now known as JayF | 03:48 | |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: [Spec] Parallel image import https://review.opendev.org/c/openstack/glance-specs/+/967046 | 13:17 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Add RBD Erasure-Coded Pools Support specification https://review.opendev.org/c/openstack/glance-specs/+/863110 | 13:19 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Auto detect NFS for filesystem driver https://review.opendev.org/c/openstack/glance-specs/+/962570 | 13:21 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Add spec for S3 boto3 checksum behavior configuration https://review.opendev.org/c/openstack/glance-specs/+/962248 | 13:23 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Update "Eliminate Redundant Downloads" proposal https://review.opendev.org/c/openstack/glance-specs/+/962651 | 13:25 |
| *** croeland1 is now known as croelandt | 13:26 | |
| croelandt | abhishekk: Should I ninja approve the specs? :) | 13:26 |
| abhishekk | :D | 13:46 |
| abhishekk | EC pools ans s3 for sure | 13:46 |
| croelandt | abhishekk: https://review.opendev.org/c/openstack/glance-specs/+/863110 there is a component by fpantano, please address this and I'll merge | 13:55 |
| abhishekk | ack, will do it later tonight | 13:56 |
| opendevreview | Merged openstack/glance-specs master: Add spec for S3 boto3 checksum behavior configuration https://review.opendev.org/c/openstack/glance-specs/+/962248 | 14:03 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Add RBD Erasure-Coded Pools Support specification https://review.opendev.org/c/openstack/glance-specs/+/863110 | 14:20 |
| zigo | Can this patch be reviewed please ? https://review.opendev.org/c/openstack/glance_store/+/971886 (trivial small test fix...) | 14:24 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Update "Eliminate Redundant Downloads" proposal https://review.opendev.org/c/openstack/glance-specs/+/962651 | 14:28 |
| dansmith | croelandt: are you ninjaing specs? I don't want to review any that are going to get ninja'd but I was just settling back into the EC one | 15:29 |
| dansmith | I don't remember if it was mostly settled or not | 15:29 |
| croelandt | I think the EC one is the one I talked to abhishekk about earlier | 15:31 |
| croelandt | I want the comment by fpantano addressed | 15:31 |
| croelandt | dansmith: otherwise feel free to look at specs, we want to merge them by M2 (Thursday) | 15:31 |
| croelandt | so the S3 one being really easy I ninja'ed it :) | 15:31 |
| dansmith | ack | 15:32 |
| dansmith | I just re-reviewed the NFS timeout one | 15:32 |
| dansmith | croelandt: abhishekk: on the EC one the only real thing I see is that cinder and nova support seems darn near mandatory.. is the assumption that such support will materialize in this cycle? | 16:00 |
| abhishekk | dansmith: I don't think we are assuming that this support will be added in nova and cinder this cycle | 16:11 |
| dansmith | oh okay.. so.. it will be useful only for ceph-backed glance where nova/cinder don't share the pool? | 16:12 |
| abhishekk | atm yeah | 16:12 |
| dansmith | how common of an arrangement is that? | 16:12 |
| abhishekk | you mean cinder and nova sharing the same pool? | 16:14 |
| dansmith | no, I mean.. how common is it to have a ceph-backed glance where nova and or cinder do not share the pool? | 16:14 |
| dansmith | either way, probably just need to make sure there's a strongly-worded reno warning people not to turn this on in glance and expect it to work in nova/cinder if they share the pool | 16:15 |
| abhishekk | ack, I will add that in the sepc as well | 16:15 |
| croelandt | I'm looking at amorin's bugfix: https://review.opendev.org/c/openstack/glance/+/967371 . I'm confusing, do we have to register_opt for keystone_authtoken that we do not use ourselves? Like in https://review.opendev.org/c/openstack/glance/+/479047 ? | 16:18 |
| * amorin sneaking in | 16:20 | |
| amorin | I agree this sounds weird | 16:21 |
| amorin | I think this is because of the lines 109-110, which is loading the keystone auth | 16:23 |
| amorin | and needs some options to be registered | 16:23 |
| amorin | maybe that needs to be done differently, but I was not ready to do a heavy change | 16:24 |
| amorin | I just wanted my prod to be fixed | 16:24 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Add RBD Erasure-Coded Pools Support specification https://review.opendev.org/c/openstack/glance-specs/+/863110 | 16:25 |
| croelandt | amorin: yes, I figured this out | 16:25 |
| croelandt | I'd like to understand what is happening before merging anything | 16:26 |
| croelandt | amorin: do you know where the exception is actually happening? Like, what code is actually trying to access those config options? | 16:26 |
| amorin | AFAIR each time a new glance image is created (e.g. a nova snapshot), then you will have the issue logged | 16:27 |
| abhishekk | amorin: are these options defined somewhere in keystone as well? | 16:28 |
| amorin | you mean in glance-api conf? | 16:28 |
| amorin | it's not mandatory to have them defined in glance conf (we dont) | 16:29 |
| amorin | but it's mandatory for them to be registered | 16:30 |
| abhishekk | Why register them in glance is what I am thinking about | 16:31 |
| croelandt | I think we define them by doing IntOpt('split_loggers'), don't we? | 16:31 |
| croelandt | I just don't understand why *we* define them if keystoneauth1 uses them | 16:32 |
| abhishekk | yep, same question | 16:34 |
| amorin | https://github.com/openstack/keystoneauth/blob/0a7914b70f80ab8a469bda53f49d5494e308b566/keystoneauth1/loading/session.py#L148-L158 | 16:34 |
| croelandt | the previous patch from 2017 mentions "recommended usage of keystoneauth" but I don't see a link | 16:34 |
| abhishekk | then I can see, cinder has this option in default section "split_loggers" | 16:35 |
| amorin | there is the register function there: https://github.com/openstack/keystoneauth/blob/0a7914b70f80ab8a469bda53f49d5494e308b566/keystoneauth1/loading/session.py#L238 | 16:35 |
| * abhishekk brb | 16:36 | |
| amorin | so maybe we should call this instead? | 16:36 |
| croelandt | ok so these are our options in the [keystone_authtoken] seciton of glance-api.conf | 16:37 |
| croelandt | what's the IRC channel for keystoneauth? :) | 16:39 |
| croelandt | I think we should ask them about this | 16:40 |
| * croelandt needs to leave for a little while | 16:40 | |
| amorin | openstack-keystone maybe? or opesntack-oslo | 16:41 |
| abhishekk | unless these options are left for service specific I think those should be part of keystoneauth1 | 16:43 |
| opendevreview | Merged openstack/glance master: Handle glance_store.Invalid exception in upload method https://review.opendev.org/c/openstack/glance/+/971516 | 16:50 |
| opendevreview | Merged openstack/glance master: Remove configurable metadata DB backend entrypoint https://review.opendev.org/c/openstack/glance/+/961467 | 18:00 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!