| *** mhen_ is now known as mhen | 03:02 | |
| opendevreview | OpenStack Proposal Bot proposed openstack/glance master: Imported Translations from Zanata https://review.opendev.org/c/openstack/glance/+/972617 | 03:04 |
|---|---|---|
| opendevreview | OpenStack Proposal Bot proposed openstack/glance_store master: Imported Translations from Zanata https://review.opendev.org/c/openstack/glance_store/+/972620 | 03:28 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Enhanced filesystem driver with timeout protection https://review.opendev.org/c/openstack/glance-specs/+/962570 | 05:43 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Migrate functional tests to SynchronousAPIBase https://review.opendev.org/c/openstack/glance/+/972643 | 09:07 |
| opendevreview | Mathieu Tortuyaux proposed openstack/glance master: glance/utils: override urllib 'User-agent' header https://review.opendev.org/c/openstack/glance/+/972507 | 10:50 |
| opendevreview | Fernando Ferraz proposed openstack/glance_store master: Cinder: Fix race conditions on mount/umount operations https://review.opendev.org/c/openstack/glance_store/+/967626 | 12:56 |
| opendevreview | Mathieu Tortuyaux proposed openstack/glance master: glance/utils: override urllib 'User-agent' header https://review.opendev.org/c/openstack/glance/+/972507 | 13:15 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: DNM Test v3applicationcredentiali without keystone fix https://review.opendev.org/c/openstack/glance/+/972677 | 13:17 |
| croelandt | #startmeeting glance | 14:00 |
| opendevmeet | Meeting started Thu Jan 8 14:00:47 2026 UTC and is due to finish in 60 minutes. The chair is croelandt. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'glance' | 14:00 |
| croelandt | Happy New Year! | 14:00 |
| croelandt | #topic roll call | 14:00 |
| abhishekk | o/ | 14:00 |
| mhen | o/ | 14:00 |
| abhishekk | Happy New Year!! | 14:01 |
| croelandt | I think dansmith won't be here, and rosmaita is probably in another meeting | 14:01 |
| pdeore__ | Happy New Year ! \o/ | 14:01 |
| *** pdeore__ is now known as pdeore | 14:01 | |
| croelandt | oh and pdeore__ is back! | 14:01 |
| croelandt | #topic Release/periodic job updates | 14:01 |
| croelandt | so openstack-tox-py312-with-oslo-master is failing | 14:02 |
| rosmaita | indeed i am, happy new year, and welcome back pdeore__ | 14:02 |
| croelandt | I see some changes in olso.concurrency that mght be related to this, so I'm going to try and reproduce it locally | 14:02 |
| pdeore | Thanks :) | 14:02 |
| croelandt | #topic Important Zuul patches | 14:02 |
| croelandt | tkajinam sent us a lot of patches | 14:03 |
| abhishekk | Do you have link for openstack-tox-py312-with-oslo-master failures? | 14:03 |
| croelandt | oh yeah | 14:03 |
| croelandt | #link https://zuul.opendev.org/t/openstack/build/b4e16ec722e748de826f1e1a3a79cddc/logs | 14:03 |
| abhishekk | thanks | 14:03 |
| croelandt | but yeah I see a commit changing args to execute() for prlimits | 14:03 |
| croelandt | so anyway, zuul patches | 14:03 |
| croelandt | #link https://review.opendev.org/c/openstack/glance/+/970053/ | 14:04 |
| croelandt | #link https://review.opendev.org/c/openstack/glance/+/970054/ | 14:04 |
| croelandt | #link https://review.opendev.org/c/openstack/glance/+/970059/ | 14:04 |
| croelandt | #link https://review.opendev.org/c/openstack/glance/+/970060/ | 14:04 |
| croelandt | I will probably merge these sooner or later if there are no objections | 14:04 |
| croelandt | these patches keep us up to date with recent versions of Python | 14:04 |
| abhishekk | +1 | 14:04 |
| croelandt | remove old jobs that are not that useful anymore | 14:05 |
| croelandt | etc. | 14:05 |
| abhishekk | wait | 14:05 |
| croelandt | #topic M3 will release today | 14:05 |
| croelandt | ok go on :) | 14:05 |
| abhishekk | I think we need fix for oslo failure else if we merge this https://review.opendev.org/c/openstack/glance/+/970053 then our gate might be broken? | 14:05 |
| croelandt | why is that? | 14:06 |
| croelandt | i think the issue comes from oslo master | 14:07 |
| croelandt | oh yeah | 14:07 |
| abhishekk | its not failing on the patch because we don't have py312 unit in our check jobs? | 14:07 |
| croelandt | ok there is an oslo-tips here :) | 14:07 |
| croelandt | oh taht is interesting, it is not failing with oslo master | 14:07 |
| croelandt | hm | 14:07 |
| croelandt | ok I'll hold off before merging these then | 14:07 |
| abhishekk | ack | 14:07 |
| croelandt | fix the periodic job issue first | 14:07 |
| abhishekk | yep | 14:08 |
| croelandt | #topic M3 will release today | 14:08 |
| croelandt | #link https://review.opendev.org/c/openstack/releases/+/972584 | 14:08 |
| croelandt | I might also release M2 for glance_store since it has one bugfix | 14:08 |
| abhishekk | M2? you mean? | 14:08 |
| abhishekk | in topic | 14:09 |
| croelandt | yeah M2 sorry | 14:09 |
| * croelandt cannot type on a keyboard | 14:09 | |
| croelandt | the keys are all so close to one another! | 14:09 |
| abhishekk | np :) | 14:10 |
| croelandt | #topic Open Discussion | 14:11 |
| croelandt | OK, anything else for today? | 14:11 |
| mhen | small update on image encryption | 14:11 |
| mhen | before the holidays dansmith left an extensive review on the glance patchset | 14:11 |
| mhen | which I addressed as best as I could | 14:12 |
| mhen | also a few days ago there was a review on the scenario tests for the image encryption which are in the barbican-tempest-plugin | 14:12 |
| mhen | I fixed all the things mentioned in the tests | 14:12 |
| croelandt | do you need more reviews? | 14:13 |
| abhishekk | I have updated the spec which we discussed yesterday, https://review.opendev.org/c/openstack/glance-specs/+/962570 | 14:15 |
| mhen | croelandt: would be great as there are no applicable votes on the current iteration yet | 14:16 |
| croelandt | mhen: ok | 14:17 |
| croelandt | abhishekk: I'll take another look at the FS one, and also the lite specs | 14:17 |
| abhishekk | cool, thank you | 14:17 |
| croelandt | I think that's all for today? | 14:17 |
| croelandt | Thanks for joining! | 14:18 |
| croelandt | #endmeeting | 14:18 |
| opendevmeet | Meeting ended Thu Jan 8 14:18:29 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:18 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/glance/2026/glance.2026-01-08-14.00.html | 14:18 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/glance/2026/glance.2026-01-08-14.00.txt | 14:18 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/glance/2026/glance.2026-01-08-14.00.log.html | 14:18 |
| tkajinam | hm seems like https://review.opendev.org/c/openstack/oslo.concurrency/+/967408 is causing that test failure | 14:20 |
| tkajinam | which indicates it affects oslo-master job regardless of base python version | 14:20 |
| croelandt | so why are our checks not failing? :) | 14:21 |
| tkajinam | because tips job is not run in check/gate | 14:22 |
| tkajinam | it's run only in experimental and periodic | 14:22 |
| * tkajinam is re-reading the job definition | 14:22 | |
| croelandt | we do have something with oslo master though, don't we? | 14:22 |
| croelandt | oh no -tips is only for periodic? | 14:23 |
| croelandt | ok ok | 14:23 |
| tkajinam | https://opendev.org/openstack/glance/src/branch/master/.zuul.yaml#L484-L485 | 14:23 |
| tkajinam | so updating tips job definition should have no effect | 14:23 |
| tkajinam | just fyi | 14:24 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Avoid asserting internal processutils.execute call https://review.opendev.org/c/openstack/glance/+/972713 | 14:34 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: DNM: Testing oslo tips job https://review.opendev.org/c/openstack/glance/+/972714 | 14:39 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: DNM: Testing oslo tips job https://review.opendev.org/c/openstack/glance/+/972714 | 14:40 |
| dansmith | abhishekk: around? | 14:52 |
| abhishekk | dansmith: yes | 14:52 |
| dansmith | abhishekk: I meant to ask yesterday... "get() - wraps file open() and initial read" I assumed means "open the file and read the first chunk, if that works, assume we can read the rest of the file in the request/main thread ? | 14:53 |
| abhishekk | yes | 14:55 |
| dansmith | okay so if the mount goes away while we're reading, we'll still hang without recovery | 14:56 |
| abhishekk | I need to verify whether to wrap entire get call or not, but I assumed if file is opened then it will be accessible | 14:56 |
| abhishekk | OK, i will rephrase it to cover entire get call | 14:57 |
| dansmith | well, hang on | 14:57 |
| dansmith | what's your plan for wrapping the whole call? | 14:57 |
| abhishekk | something like threadpool.execute(call) ? | 14:59 |
| dansmith | well, what I mean is.. you can't read the whole image into memory at once and then return it from the thread | 15:00 |
| abhishekk | if timeout is greater than 0 then ^^^ else process as it is normmal flow | 15:01 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: DNM: Testing oslo tips job https://review.opendev.org/c/openstack/glance/+/972714 | 15:01 |
| abhishekk | right | 15:01 |
| dansmith | so I think either you do what you have here, which is "test" the first read of a chunk and then let the main thread do the rest, | 15:02 |
| dansmith | or you need to create an object that we can read from that delegates the reads to the thread and queues the blocks so the other thread can get/return them | 15:02 |
| dansmith | right? | 15:02 |
| abhishekk | I didn't undestood other thread can get/return them | 15:04 |
| dansmith | glance_store returns a generator that produces the data chunks that the request thread iterates and itself yields or writes to the response right? | 15:06 |
| abhishekk | yes | 15:07 |
| dansmith | https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L576 | 15:07 |
| abhishekk | So if we go with 1st "test" the first read of a chunk and then let the main thread do the rest we still have a limitation | 15:08 |
| dansmith | this ^ is how we get data returned from downloading the image right? we have to provide an iterator/generator that the request thread (which called us) will iterate over to get the chunks | 15:08 |
| abhishekk | yes | 15:08 |
| dansmith | the only way to make that work but have the data be read in another thread is to create a special wrapper that will read from a memory queue (with a timeout) and that the producing thread (worker) will push chunks into as there is space | 15:09 |
| dansmith | well, the only way _I_ know to make it work, I should say | 15:09 |
| dansmith | which is doable I think, I just wondered what your plan was there | 15:10 |
| dansmith | "test read and return the rest in the main thread" still requires a wrapper I think, but is much simpler.. but yes, will still hang if the mount hangs | 15:10 |
| dansmith | based on "initial read" I assumed the latter is what you were planning to do, and just take the risk that you're not in the middle of reading when the mount goes down | 15:11 |
| abhishekk | honestly I was thinking https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/filesystem.py#L616 wrapping this function in threadpool.execute | 15:11 |
| dansmith | assuming you don't consume all available api workers, one request will get stuck but others will timeout and so mostly the correct behavior | 15:11 |
| abhishekk | ack | 15:12 |
| dansmith | abhishekk: that's just the open and getsize but not any read right? | 15:12 |
| dansmith | actually not even the open I think | 15:12 |
| abhishekk | no, not open in this case | 15:14 |
| dansmith | ...okay | 15:15 |
| dansmith | okay well, perhaps we should just go with what you have knowing that we need to figure out how to at least do the "open and initial read"? | 15:16 |
| dansmith | or we could just say that it's limited to metadata operations at the moment (getsize, stat, delete) but not the actual data? | 15:17 |
| abhishekk | I think later makes more sense | 15:18 |
| dansmith | okay, let me commit my nit comments | 15:18 |
| abhishekk | ack | 15:19 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Enhanced filesystem driver with timeout protection https://review.opendev.org/c/openstack/glance-specs/+/962570 | 15:45 |
| abhishekk | croelandt: I am wondering why our specs does not catch trailing white spaces or change in template issues | 15:52 |
| dansmith | abhishekk: looks good thanks! | 16:01 |
| dansmith | I can help try to come up with a creative threaded iterator for the data stuff | 16:01 |
| dansmith | (when the time comes) | 16:03 |
| abhishekk | \o/ | 16:04 |
| croelandt | abhishekk: in the spec lites, does "AC credentials" mean "Application Credentials credentials"? | 16:09 |
| croelandt | abhishekk: we could run doc8 if you'd like :) | 16:20 |
| croelandt | doc8 fails with symlinks though, that is annoying, had to work around that | 16:20 |
| croelandt | nope, we have broken symlinks, nice | 16:39 |
| JayF | How difficult is it to get a new image property added? I'm looking at an Ironic feature which would allow us, when presented with an image with proper metadata, to boot it as a ramdisk instead of as a disk image. That requires Ironic reconfiguration. Triggering that reconfiguration based on some property of the image seemed ideal. (see https://bugs.launchpad.net/ironic/+bug/2130646 for a similar, non-glance RFE) | 16:44 |
| JayF | (and given we already have driver-specific properties, e.g. vmware_*, it seems like it'd be potentially OK to add ironic_[something] to perform this effect) | 16:46 |
| JayF | We don't pass on full image metadata in the virt driver patcher; only really image_source | 16:54 |
| JayF | https://opendev.org/openstack/nova/src/commit/4b90fdf9af8de53fb6536d27b8fc654a0c011e2f/nova/virt/ironic/patcher.py#L61 | 16:54 |
| JayF | Which means we must be roundtripping glance ourself for metadata | 16:54 |
| JayF | which is good news for not having to modify nova (if we're OK to fudge the instance_info ourselves at deploy time) | 16:54 |
| JayF | oh, ECHAN, those last 4 lines were for #openstack-ironic | 16:55 |
| abhishek_ | croelandt: yeah :/ | 16:55 |
| opendevreview | Cyril Roelandt proposed openstack/glance-specs master: Fix symlinks for Xena templates https://review.opendev.org/c/openstack/glance-specs/+/972759 | 16:56 |
| opendevreview | Elod Illes proposed openstack/glance_store master: DNM: gate health test https://review.opendev.org/c/openstack/glance_store/+/972760 | 16:57 |
| croelandt | abhishek_: "yeah we have broken symlinks" or "yeah ac credentials means application credentials credentials"? | 17:00 |
| abhishek_ | for the later :D | 17:00 |
| dansmith | JayF: image properties are mostly unconstrained in glance.. are you actually asking about nova? | 17:03 |
| JayF | I was reading https://docs.openstack.org/glance/latest/admin/useful-image-properties.html and ensuring that I didn't need Glance approval or spec to create/use one :) | 17:04 |
| JayF | trying to be a good citizen and not just backdoor something Ironic into the world | 17:04 |
| croelandt | abhishek_: ok that's weird but I'll pretend I did not see it :D | 17:05 |
| dansmith | JayF: glance has/holds image property metadefs that tries to be the source of truth for things like horizon (only, AFAIK) | 17:05 |
| abhishek_ | me neither | 17:05 |
| JayF | nice, so I would expect I can just create/use the property, and get a small glance doc update merged to useful-image-properties (assuming folks agree it's useful) | 17:05 |
| dansmith | JayF: but my point is, if you want something plumbed through image properties to virt/ironic then you'll need it to be in nova | 17:06 |
| JayF | Ironic does it's own roundtrip to Glance already for properties | 17:06 |
| JayF | the only thing Nova sends over is the image uuid | 17:06 |
| dansmith | JayF: okay, so then not nova (which is good because we'll want it to be generic if possible) | 17:06 |
| JayF | ++ yep exactly this is the ideal case, all the complexity is inside ironic and the user knob is (after admin has configured Ironic) "upload image with ironic_ramdisk=True in properties" | 17:07 |
| opendevreview | Merged openstack/glance master: Functional tests migration - test_gzip_middleware.py https://review.opendev.org/c/openstack/glance/+/968203 | 17:51 |
| opendevreview | Merged openstack/glance master: Avoid asserting internal processutils.execute call https://review.opendev.org/c/openstack/glance/+/972713 | 17:51 |
| dansmith | croelandt: I assume you're going to +W this tomorrow right? https://review.opendev.org/c/openstack/glance-specs/+/962570 | 22:12 |
| -opendevstatus- NOTICE: Zuul will be shutdown for maintenance work. See https://lists.opendev.org/archives/list/service-announce@lists.opendev.org/thread/WBBLBI6ZS6FA6Q5ZMH4C2MWPL3WG3H24/ for more details. | 23:43 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!