| *** mhen_ is now known as mhen | 02:40 | |
| opendevreview | Liron Kuchlani proposed openstack/glance-tempest-plugin master: Add concurrency tests for glance operations https://review.opendev.org/c/openstack/glance-tempest-plugin/+/970302 | 08:22 |
|---|---|---|
| opendevreview | Liron Kuchlani proposed openstack/glance-tempest-plugin master: Add concurrency tests for glance operations https://review.opendev.org/c/openstack/glance-tempest-plugin/+/970302 | 09:19 |
| mtanino | Hi Glance team, could someone please review https://review.opendev.org/c/openstack/glance/+/969967 ? This patch enhances the schema loading logic to support structured JSON (including 'required' lists) in schema-image.json. | 09:32 |
| mtanino | It allows defining mandatory properties directly in the schema file while maintaining backward compatibility. It currently has one +2 and needs a second core review. Thanks! | 09:32 |
| opendevreview | Liron Kuchlani proposed openstack/glance-tempest-plugin master: Add concurrency tests for glance operations https://review.opendev.org/c/openstack/glance-tempest-plugin/+/970302 | 10:34 |
| opendevreview | Mathieu Tortuyaux proposed openstack/glance master: glance/utils: override urllib 'User-agent' header https://review.opendev.org/c/openstack/glance/+/972507 | 14:00 |
| croelandt | rosmaita: Didn't you say last week you'd review https://review.opendev.org/c/openstack/glance/+/969967 ? :) | 15:12 |
| croelandt | It's the "extended JSON schema" patch that looks good, but I'd like not to ninja-approve that | 15:13 |
| rosmaita | croelandt: i did, but didn't, will look now | 15:20 |
| croelandt | rosmaita: thanks! | 15:52 |
| croelandt | abhishek_: so what are the bits of Glance that still use eventlet? You were talking about this earlier | 15:53 |
| abhishek_ | croelandt: https://github.com/openstack/glance/blob/master/glance/tests/__init__.py#L23 | 16:32 |
| abhishek_ | this one is major change | 16:32 |
| croelandt | oh but it's test only, right? Nothing runs on eventlet in production? | 16:32 |
| abhishek_ | No, but I thought verifying will include running functional tests as well | 16:35 |
| croelandt | ok ok | 16:35 |
| croelandt | you're right | 16:35 |
| croelandt | I was just worried we still had something eventlet-related in production | 16:36 |
| abhishek_ | ack, sorry for the confusion | 16:38 |
| croelandt | np np | 16:40 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!