| opendevreview | OpenStack Proposal Bot proposed openstack/glance master: Imported Translations from Zanata https://review.opendev.org/c/openstack/glance/+/972617 | 03:00 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/python-glanceclient master: Fix unit tests with new urllib3 https://review.opendev.org/c/openstack/python-glanceclient/+/979440 | 08:34 |
| opendevreview | Takashi Kajinami proposed openstack/python-glanceclient master: Fix unit tests with urllib3 2.x https://review.opendev.org/c/openstack/python-glanceclient/+/979440 | 08:35 |
| opendevreview | Takashi Kajinami proposed openstack/python-glanceclient master: Fix unit tests with urllib3 2.x https://review.opendev.org/c/openstack/python-glanceclient/+/979440 | 08:37 |
| opendevreview | Takashi Kajinami proposed openstack/python-glanceclient master: Fix unit tests with urllib3 2.x https://review.opendev.org/c/openstack/python-glanceclient/+/979440 | 09:52 |
| tkajinam | we need ^^^ in master and stable/2026.2 to fix CI broken by urllib3 2.x | 09:53 |
| opendevreview | Mathieu Tortuyaux proposed openstack/glance master: glance/utils: override urllib 'User-agent' header https://review.opendev.org/c/openstack/glance/+/972507 | 10:41 |
| abhishekk | @croelandt I think we need a patch for glance-specs for 2026.2 directory structure | 13:20 |
| tkajinam | abhishekk, croelandt could you review https://review.opendev.org/c/openstack/python-glanceclient/+/979440 when you have time ? We need to backport it to 2026.1 to fix broken tests. | 14:43 |
| abhishekk | ack | 14:43 |
| tkajinam | (see https://review.opendev.org/c/openstack/python-glanceclient/+/979188 for context | 14:44 |
| abhishekk | tkajinam: added one inline question | 14:48 |
| tkajinam | abhishekk, thanks and replied to your comment :-) | 14:53 |
| abhishekk | ack | 14:54 |
| opendevreview | Cyril Roelandt proposed openstack/glance-specs master: Add 2026.2 directory for specs https://review.opendev.org/c/openstack/glance-specs/+/979675 | 14:56 |
| croelandt | abhishekk: ^ | 14:57 |
| abhishekk | thank you!! | 14:57 |
| opendevreview | Takashi Kajinami proposed openstack/python-glanceclient stable/2026.1: Fix unit tests with urllib3 2.x https://review.opendev.org/c/openstack/python-glanceclient/+/979678 | 15:03 |
| croelandt | tkajinam: where is prepare.sh used? | 15:08 |
| tkajinam | croelandt, that's the shell to regenerate the files under the var directory | 15:10 |
| tkajinam | I pre-generated the files and added these so the shell don't have to be run every time | 15:10 |
| croelandt | ok so this is for documentation purposes | 15:11 |
| tkajinam | maybe we can move it to tools | 15:11 |
| tkajinam | yeah | 15:11 |
| croelandt | yes | 15:11 |
| croelandt | and can you add a comment at the top that lists the files generated by this | 15:11 |
| croelandt | and states that this is not run | 15:11 |
| croelandt | but we're keeping the script around if we ever need to regen keys/do a slight change to accomodate tools? | 15:12 |
| tkajinam | I'll update the change. give me a few moments | 15:15 |
| opendevreview | Takashi Kajinami proposed openstack/python-glanceclient master: Fix unit tests with urllib3 2.x https://review.opendev.org/c/openstack/python-glanceclient/+/979440 | 15:24 |
| opendevreview | Takashi Kajinami proposed openstack/python-glanceclient master: Fix unit tests with urllib3 2.x https://review.opendev.org/c/openstack/python-glanceclient/+/979440 | 15:26 |
| tkajinam | croelandt, I've updated the change according to the suggestion ^^^ | 15:27 |
| opendevreview | Cyril Roelandt proposed openstack/glance-specs master: Remove sphinxcontrib*diag extensions https://review.opendev.org/c/openstack/glance-specs/+/979689 | 15:39 |
| croelandt | abhishekk: ^ not sure about this one but I truly don't think we use all these extensions :D | 15:40 |
| abhishekk | ack, will have a look | 15:41 |
| clarkb | I think there was an earlier incompatibility with some blockdiag dependencies that maybe caused things to be half cleaned up | 15:42 |
| croelandt | yeah right now it is annoying because it depends on pkg_resources, which is being deprecated | 15:43 |
| croelandt | (though I can still "import pkg_resources" in a Python console) | 15:43 |
| croelandt | but I think we also have a lot of cargo cult code from the early days of OpenStack, so might as well get rid of it | 15:44 |
| tkajinam | croelandt, I proposed the same earlier so I agree with that removal :-) https://review.opendev.org/c/openstack/glance-specs/+/927247 | 15:56 |
| croelandt | oh damn | 15:56 |
| tkajinam | hmmm it seems we also have to squash it with https://review.opendev.org/c/openstack/glance-specs/+/974072 to unblock that py313 job failure | 15:56 |
| croelandt | missed it | 15:56 |
| tkajinam | oh, wait. that's not mine | 15:57 |
| tkajinam | it's stephenfin's | 15:57 |
| croelandt | oh I cannot even bypass the CI here | 15:57 |
| tkajinam | I was confused by mine proposed to the other repos | 15:57 |
| croelandt | ok recheching just to be sure | 15:57 |
| croelandt | then I'll squash stephenfin's patch and your PCRE patch | 15:57 |
| * croelandt internally screaming | 15:58 | |
| tkajinam | yeah that's probably the right approach | 15:58 |
| tkajinam | I now remember that I had to rebase it to resolve conflicts | 15:58 |
| tkajinam | that's why I'm the last uploader | 15:59 |
| opendevreview | Cyril Roelandt proposed openstack/glance-specs master: Fix the CI https://review.opendev.org/c/openstack/glance-specs/+/979697 | 16:39 |
| croelandt | tkajinam: ^ | 16:40 |
| croelandt | abhishekk: ^ | 16:40 |
| croelandt | this should be it | 16:40 |
| croelandt | if this merges I'll abandon other patches | 16:40 |
| tkajinam | it looks good but I'll see how CI says :-) | 16:41 |
| abhishekk | ack | 16:41 |
| croelandt | The build succeeded \o/ | 16:47 |
| croelandt | Hooray | 16:47 |
| croelandt | Could we also merge https://review.opendev.org/c/openstack/glance-specs/+/973271 to have pep8 there | 16:48 |
| tkajinam | \o/ | 16:57 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!