| opendevreview | Dmitriy Rabotyagov proposed openstack/glance master: [doc] Mention Hyper-V Enlightenments for os_type https://review.opendev.org/c/openstack/glance/+/969999 | 12:01 |
|---|---|---|
| zigo | I get a build failure of Glance rc1 after patching for OSSA-2026-004: https://buildd.debian.org/status/fetch.php?pkg=glance&arch=all&ver=2%3A32.0.0~rc1-3&stamp=1773938482&file=log | 12:46 |
| zigo | Is there a better patch? Am I missing something? | 12:46 |
| zigo | abhishekk: I get a build failure of Glance rc1 after patching for OSSA-2026-004: https://buildd.debian.org/status/fetch.php?pkg=glance&arch=all&ver=2%3A32.0.0~rc1-3&stamp=1773938482&file=log | 12:48 |
| zigo | And same in Debian Unstable: https://buildd.debian.org/status/fetch.php?pkg=glance&arch=all&ver=2%3A31.0.0-3&stamp=1773937192&file=log | 12:49 |
| abhishekk | python version? | 12:52 |
| opendevreview | Brian Rosmaita proposed openstack/glance stable/2025.1: [stable-only] non-voting grenade-skip-level-always https://review.opendev.org/c/openstack/glance/+/981510 | 12:53 |
| abhishekk | PYTHON=python3.14, I haven't checked it with python3.14, will take some time (out of station and travelling) | 12:54 |
| zigo | Oh, you think it probably is a Python 3.14 issue? | 12:57 |
| zigo | That's possible, because in my backport to Trixie (ie: Python 3.13) I had no problem. | 12:57 |
| opendevreview | Brian Rosmaita proposed openstack/glance stable/2025.1: [stable-only] non-voting grenade-skip-level-always https://review.opendev.org/c/openstack/glance/+/981510 | 12:57 |
| rosmaita | zigo: 2026.1 doesn't support python 3.14: https://governance.openstack.org/tc/reference/runtimes/2026.1.html | 12:59 |
| zigo | rosmaita: While this type of re-occuring sentence is often right, it doesn't help me at all. I cannot choose what version of Python interpreter is in Debian unstable, and unstable is where one uploads in Debian. If there's a 3.14 issue, then it shall be patched. Best is with help of upstream, otherwise, I may carry a debian-specific patch and attempt to contribute it to upstream OpenStack. However, in this case, I have no clue what's going on | 13:08 |
| zigo | yet ... (didn't investigate). | 13:08 |
| abhishekk | zigo, py314 and ubuntu works for me, will this be env specific issue? | 13:21 |
| zigo | Probably. | 13:21 |
| zigo | And what's weird, is that it built fine on my laptop. | 13:21 |
| zigo | (which is unstable and experimental too...) | 13:21 |
| zigo | I'll try again. | 13:22 |
| abhishekk | ack | 13:24 |
| opendevreview | Brian Rosmaita proposed openstack/glance stable/2025.1: [stable-only] fix stable/2025.1 gate jobs https://review.opendev.org/c/openstack/glance/+/981510 | 13:34 |
| zigo | abhishekk: I think I know. The test will likely attempt to resolve foo.com, no ? | 13:40 |
| zigo | If so, this will fail in the Debian buildd, because no network or DNS access... | 13:40 |
| abhishekk | ahh, yes | 13:42 |
| zigo | Let me export RES_OPTIONS=attempts:0 to make sure (this makes libc refuse to query DNS). | 13:42 |
| zigo | Hum... no, not happening. | 13:46 |
| opendevreview | Brian Rosmaita proposed openstack/glance stable/2025.1: Fix SSRF vulnerabilities in image import API https://review.opendev.org/c/openstack/glance/+/981298 | 13:53 |
| zigo | abhishekk: Your code looks like doing, in normalize_hostname, socket.getaddrinfo(), which is doing DNS resolution, so I am right, though I wonder why RES_OPTIONS=attemps:0 is ignored. Anyways, no need to investigate more, I can blacklist both tests in Debian. | 13:59 |
| zigo | I would strongly recommend mocking the DNS result though. | 13:59 |
| abhishekk | ack | 13:59 |
| zigo | What if the owner of foo.com decides to remove the domain from DNS? | 13:59 |
| zigo | I'll propose a patch for this. | 14:09 |
| abhishekk | ack | 14:10 |
| fungi | rosmaita: you approved https://review.opendev.org/c/openstack/glance/+/981296 with no code-review +2 on it, so it hasn't entered the gate yet, just a heads up | 14:20 |
| opendevreview | Thomas Goirand proposed openstack/glance master: No DNS resolution in test https://review.opendev.org/c/openstack/glance/+/981520 | 14:20 |
| rosmaita | fungi: ty, did not notice that | 14:21 |
| fungi | no worries, i was just going to bring the need for an rc2 up in the release meeting and realized the change hadn't landed | 14:22 |
| opendevreview | Thomas Goirand proposed openstack/glance master: No DNS resolution in test https://review.opendev.org/c/openstack/glance/+/981520 | 14:24 |
| zigo | Shit, got my mocking wrong ... :/ | 14:27 |
| opendevreview | Thomas Goirand proposed openstack/glance master: No DNS resolution in test https://review.opendev.org/c/openstack/glance/+/981520 | 14:29 |
| abhishekk | why any grenade/tempest jobs are not running for stable/2026.1 patch? | 14:55 |
| abhishekk | https://zuul.opendev.org/t/openstack/status?project=openstack%2Fglance&project=openstack%2Fglance_store&project=openstack%2Ftempest | 14:55 |
| abhishekk | openstack/glance 981296 | 14:55 |
| rosmaita | i wonder if the template wasn't adjusted for stable/2026.1 yet | 14:56 |
| dansmith | gmaan: ^ | 14:56 |
| rosmaita | which would be bad | 14:56 |
| abhishekk | right | 14:57 |
| dansmith | yeah not even running tempest is pretty scary | 14:57 |
| dansmith | because that doesn't require a change like grenade does, AFAIK | 14:57 |
| rosmaita | well, looking here, we have more than the template jobs: https://opendev.org/openstack/glance/src/branch/stable/2026.1/.zuul.yaml | 15:00 |
| dansmith | yeah, seems like they should be running.. almost like the irrelevant-files is causing them to be skipped or something | 15:02 |
| dansmith | maybe frickler can peer behind some curtain? | 15:02 |
| frickler | devstack+grenade haven't branched yet | 15:02 |
| dansmith | ...but surely glance 2026.1 patches should be running tempest and grenade, even if same as master right? | 15:03 |
| rosmaita | so that means no 2026.1 devstack-based jobs will run? | 15:03 |
| clarkb | zuul doesn't know what config to load for them because there is no 2026.1 config to be found | 15:03 |
| rosmaita | ok, so no tempest, then | 15:03 |
| clarkb | I think you can set a config pragma to say that master == 2026.1 until the branches exist | 15:03 |
| dansmith | doesn't that leave those branches extremely vulnerable right now? | 15:04 |
| clarkb | but if that isn't done then the jobs basically don't exist for that branch so there isn't anything to run | 15:04 |
| rosmaita | yeah, what dan said | 15:04 |
| rosmaita | clarkb: where would a config pragma be defined? | 15:04 |
| clarkb | sure, the fix for that would be to branch devstack and grenade first before anything else or to temporarily align things | 15:04 |
| abhishekk | so we hold or merge? | 15:04 |
| rosmaita | abhishekk: MERGE!!! | 15:04 |
| abhishekk | ack!!! | 15:05 |
| rosmaita | it passed in master, and master and 2026.1 are practically the same right now | 15:05 |
| dansmith | clarkb: we're trying to get CVE fixes landed, which while probably low-risk, still seems a bit scary | 15:05 |
| dansmith | has it always been like this? I've surely never known that to be a problem before, unless it's just a glance thing that got missed in config or something | 15:05 |
| clarkb | rosmaita: https://opendev.org/openstack/devstack/commit/4aa27976ebb2e4a4dc95a20f96e5d8f25b1ac10d this was where it was set up for openstacksdk once upon a time | 15:05 |
| abhishekk | still 1 hr 20 mins to merge | 15:05 |
| clarkb | dansmith: yes it has always been like this | 15:06 |
| clarkb | dansmith: that change above is from 5 yaers ago and the config it supported was older than that | 15:06 |
| clarkb | I think better than the pragma would be to branch devstack and grenade first | 15:06 |
| clarkb | it needs to be done anyway | 15:06 |
| clarkb | so you may as well do it first and get it done with | 15:07 |
| dansmith | clarkb: I'm a bit confused, that change is removing lines.. is removing them what makes it use master or was the old change what we would need to add? | 15:08 |
| clarkb | dansmith: the old change is what you need to add. | 15:08 |
| clarkb | I'm showing a config that supported this that was removed | 15:08 |
| dansmith | okay I don't see this in nova | 15:09 |
| clarkb | openstacksdk had a feature/r1 branch which nothing else had. So changes pushed to feature/r1 wouldn't find devstack/tempest/etc jobs that were branch specific. The pragma says treat these two branches (master and feature/r1) as matching the current branch (which I assume was master at the time) | 15:10 |
| dansmith | but are you saying we need to do that for 2026.1 while waiting for the other two to branch and then remove? | 15:10 |
| clarkb | dansmith: yes in this case the branch isn't feature/r1 but stable/2026.1 | 15:11 |
| dansmith | I just wonder how many things we've merged without tempest coverage in the past if this has always been like this | 15:11 |
| clarkb | if devstack and grenade barnch first is a complete non issue | 15:11 |
| clarkb | I don't know how consistent branch creation order has been over the years | 15:11 |
| dansmith | I'm just like shocked :) | 15:12 |
| gmaan | dansmith: abhishekk we have not cut the stable/2026.1 branch for devstack and grenade which is done once all other projects has the stable branch | 15:16 |
| clarkb | gmaan: do you know if there is a reason to not do them first? | 15:16 |
| gmaan | once that is cut then I need to start the QA tooling including devstack and grenade setup for new stable as well as new master | 15:16 |
| clarkb | I guess because it is going to try and deploy projects on stable/2026.1 and if that branch doesn't exist then things break? | 15:17 |
| dansmith | gmaan: ack, that just leaves a big risk for the projects that have stable branches now, may propose backports and not realize there's no tempest coverage on them :/ | 15:17 |
| gmaan | yes, that is risk | 15:17 |
| gmaan | If we cut their branch first then it will raise error as devstaack would not find any new stable one to clone | 15:18 |
| clarkb | in that case the pragma may be appropriate. Or maybe we just need to branch everything at the same time rather than bit by bit | 15:18 |
| gmaan | same time is also challenge as branching projects are at different time when their changes merge | 15:19 |
| gmaan | I am checking with release team if we are ready for that and i can start the work today | 15:23 |
| gmaan | clarkb: we can try pragma but that would solve the greande job testing it correctly but at least tempest jobs will run. need to check though if it raise any other other about cloning repo which does not exist | 15:38 |
| gmaan | *would not solve grenade | 15:39 |
| clarkb | gmaan: that is a good point. I think the pragma will allow the jobs to be dfined and run but then when grenade tries to check out the old or new side as stable/2026.1 that content won't be there unless the branch actually exists | 15:45 |
| rosmaita | croelandt or dansmith: need someone to hit https://review.opendev.org/c/openstack/glance/+/981510 to unblock the stable/2025.1 gate | 16:10 |
| dansmith | I'm not stable-maint for glance | 16:10 |
| rosmaita | i thought you were ... we should fix that, you are a responsible fellow | 16:11 |
| dansmith | I'm not very trustworthy | 16:14 |
| abhishekk | +1 for adding to stable core | 16:54 |
| dansmith | no guys really.. I can't be trusted.. I _so_ love telling people I'm not on glance stable core when they ask :D | 17:14 |
| dansmith | core on master and not stable = all the power and no responsibility! :D | 17:15 |
| dansmith | (in case it's not clear, I'm just joking around) | 17:40 |
| abhishekk | :D | 17:54 |
| opendevreview | Merged openstack/glance stable/2024.2: Fix SSRF vulnerabilities in image import API https://review.opendev.org/c/openstack/glance/+/981299 | 20:42 |
| rosmaita | finally, 1 down | 20:44 |
| opendevreview | Merged openstack/glance stable/2025.1: [stable-only] fix stable/2025.1 gate jobs https://review.opendev.org/c/openstack/glance/+/981510 | 20:57 |
| opendevreview | Merged openstack/glance stable/2025.1: Fix SSRF vulnerabilities in image import API https://review.opendev.org/c/openstack/glance/+/981298 | 20:57 |
| rosmaita | oh yeah, they're just rolling in now | 21:02 |
| opendevreview | Merged openstack/glance master: Fix SSRF vulnerabilities in image import API https://review.opendev.org/c/openstack/glance/+/981295 | 21:25 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!