| *** zseguin_ is now known as zseguin | 06:13 | |
| *** vhari_ is now known as vhari | 10:21 | |
| frickler | pdeore_: croelandt: ^^ release team needs your approval for those releases | 12:20 |
|---|---|---|
| rajiv | Hi, were there any changes in glance-swift ACL in flamingo release ? the ACL are not automatically set as in dalmatian release for image sharing | 16:52 |
| dansmith | rajiv: ...need a little more context | 17:14 |
| rajiv | Hi Dan, i think upstream commit moved the `update_store_in_locations()` call to the `get()` method in `ImageRepoProxy`, but did not add it to the `_set_acls()` methods, which is why images with missing store metadata fail to have ACLs set. ### Changes Made Modified `glance/location.py` to fix the issue where Swift ACLs are not set when the `store` metadata is missing from image locations. | 17:15 |
| rajiv | i am referring to this review : https://review.opendev.org/c/openstack/glance/+/797722 | 17:15 |
| rajiv | logs : https://paste.openstack.org/show/bio3nRxx7Ai4E6Gs8iv7/ | 17:16 |
| dansmith | okay that was five years ago.. I hope it's not completely broken since then and nobody noticed | 17:16 |
| rajiv | hence i was wondering if this commit could fix this acl issue : https://github.com/sapcc/glance/pull/34/files | 17:16 |
| dansmith | I'll have to go dig into when _set_acls() is called, I'm not familiar with this stuff | 17:19 |
| dansmith | if you have a proposed code change why not submit it for review? | 17:20 |
| rajiv | okay sure, will create it now | 17:23 |
| dansmith | maybe rosmaita has some context here.. I don't really know what the ACL stuff here is doing | 17:23 |
| dansmith | rajiv: also, filing a bug with a clear description of what you're seeing and when you're expecting would be really helpful because otherwise it's hard to know what you think changed for the worse | 17:24 |
| opendevreview | Rajiv Mucheli proposed openstack/glance master: Fix set_acls when store metadata is missing https://review.opendev.org/c/openstack/glance/+/981813 | 17:41 |
| rajiv | dansmith: hope the above description helps ? | 17:44 |
| dansmith | rajiv: did you file a bug with the logs? | 17:54 |
| rosmaita | dansmith: rajiv: i dont' have any context, looks like this is an upgrade case that got missed in refactoring, maybe? | 17:55 |
| dansmith | I dunno, not sure how it's actually upgrade related, | 17:55 |
| dansmith | and seems to me like it should be equivalent to the old code | 17:56 |
| croelandt | rajiv: ok just like others have said I think we should 1) have a bug with a detailed reproducer (this would help understand the issue and backport it to the relevant branches) 2) Please mention the SHA1 of the "faulty" commit in your commit message | 18:23 |
| rosmaita | croelandt: need you to sanity check https://review.opendev.org/c/openstack/releases/+/981642 and https://review.opendev.org/c/openstack/releases/+/981647 | 18:26 |
| croelandt | rosmaita: done | 18:35 |
| rosmaita | thanks! | 18:35 |
| opendevreview | Rajiv Mucheli proposed openstack/glance master: Fix set_acls when store metadata is missing https://review.opendev.org/c/openstack/glance/+/981823 | 18:40 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!