| *** mhen_ is now known as mhen | 02:11 | |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Enforce stage quota on downloads https://review.opendev.org/c/openstack/glance/+/1014455 | 07:08 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance master: Enforce stage quota on downloads https://review.opendev.org/c/openstack/glance/+/1014455 | 07:18 |
| opendevreview | Juan Larriba proposed openstack/glance master: Add OpenTelemetry tracing middleware for Glance https://review.opendev.org/c/openstack/glance/+/1007756 | 09:40 |
| opendevreview | Arnaud Morin proposed openstack/glance master: Run authtoken before versionnegotiation https://review.opendev.org/c/openstack/glance/+/1014475 | 11:18 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Default HTTP error responses to JSON https://review.opendev.org/c/openstack/glance/+/1014521 | 13:23 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Install error-response middleware programmatically https://review.opendev.org/c/openstack/glance/+/1014522 | 13:23 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Default HTTP error responses to JSON https://review.opendev.org/c/openstack/glance/+/1014521 | 13:56 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Install error-response middleware programmatically https://review.opendev.org/c/openstack/glance/+/1014522 | 13:56 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Serialize JSON errors directly with Fault https://review.opendev.org/c/openstack/glance/+/1014525 | 13:56 |
| stephenfin | abhishekk: Before I rework ☝️ to address your comments, the reason I adopted that approach is that we want to agree on a `Accept` header up front so that it propagates to downstream middleware (e.g. keystonemiddleware). If I don't do that, all middleware needs to carry similar "default to JSON if no header given" behavior | 14:17 |
| abhishekk | I missed that comment, I am looking at it | 14:18 |
| stephenfin | Oh, no, I didn't leave the comment in there (yet) but I should have | 14:18 |
| stephenfin | (...and will if we decide we're happy with that approach) | 14:19 |
| stephenfin | but first, how likely is it that deployers use custom middleare beyond the ones we are aware of/configure in our glance-api-paste.ini? | 14:19 |
| abhishekk | I was talking about this one, https://review.opendev.org/c/openstack/glance/+/1014522/comments/35449ac0_8a0e8c0f?tab=comments | 14:19 |
| stephenfin | oh, I'm talking about https://review.opendev.org/c/openstack/glance/+/1014521/comment/87d6a162_9a08aa66/ | 14:20 |
| stephenfin | sorry, should have introduced my question better /o\ | 14:20 |
| abhishekk | No problem, it's lazy day for me today so definitely need coffee break :D | 14:21 |
| abhishekk | I think early accept normalization sounds reasonable | 14:23 |
| stephenfin | okay, great. I'll put a bit more context in there to explain why we're doing that | 14:24 |
| abhishekk | ack, thank you!! | 14:35 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Serialize JSON errors directly with Fault https://review.opendev.org/c/openstack/glance/+/1014525 | 14:56 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Default HTTP error responses to JSON https://review.opendev.org/c/openstack/glance/+/1014521 | 14:56 |
| opendevreview | Mathieu Gagné proposed openstack/glance_store master: Only load configured drivers when registering store opts https://review.opendev.org/c/openstack/glance_store/+/1014593 | 18:48 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!