*** vahidh has joined #openstack-heat-translator | 01:17 | |
*** vahidh has quit IRC | 01:21 | |
*** spzala has joined #openstack-heat-translator | 01:33 | |
*** spzala has quit IRC | 01:38 | |
*** spzala has joined #openstack-heat-translator | 02:46 | |
*** spzala has quit IRC | 03:19 | |
*** spzala has joined #openstack-heat-translator | 03:20 | |
*** spzala has quit IRC | 03:25 | |
*** vahidh has joined #openstack-heat-translator | 03:59 | |
*** topol has joined #openstack-heat-translator | 04:03 | |
*** vahidh has quit IRC | 04:03 | |
*** topol has quit IRC | 04:07 | |
*** tbh has joined #openstack-heat-translator | 04:12 | |
*** spzala has joined #openstack-heat-translator | 04:20 | |
*** spzala has quit IRC | 04:25 | |
*** sridhar_ram has joined #openstack-heat-translator | 05:10 | |
*** spzala has joined #openstack-heat-translator | 05:22 | |
*** spzala has quit IRC | 05:26 | |
*** spzala has joined #openstack-heat-translator | 06:23 | |
*** spzala has quit IRC | 06:29 | |
*** sridhar_ram has quit IRC | 06:52 | |
*** spzala has joined #openstack-heat-translator | 07:25 | |
*** spzala has quit IRC | 08:00 | |
*** spzala has joined #openstack-heat-translator | 08:27 | |
*** spzala has quit IRC | 08:55 | |
*** spzala has joined #openstack-heat-translator | 09:09 | |
*** spzala has quit IRC | 09:14 | |
*** openstackgerrit has quit IRC | 09:17 | |
*** openstackgerrit has joined #openstack-heat-translator | 09:18 | |
*** vishwana_ has joined #openstack-heat-translator | 09:54 | |
*** vishwanathj has quit IRC | 09:56 | |
*** spzala has joined #openstack-heat-translator | 11:10 | |
*** spzala has quit IRC | 11:15 | |
*** openstackgerrit has quit IRC | 11:17 | |
*** openstackgerrit has joined #openstack-heat-translator | 11:18 | |
*** spzala has joined #openstack-heat-translator | 12:11 | |
*** spzala has quit IRC | 12:16 | |
*** spzala has joined #openstack-heat-translator | 13:12 | |
*** spzala has quit IRC | 13:17 | |
*** tbh has quit IRC | 13:25 | |
*** topol has joined #openstack-heat-translator | 13:50 | |
*** topol has quit IRC | 13:51 | |
*** topol has joined #openstack-heat-translator | 14:16 | |
*** spzala has joined #openstack-heat-translator | 14:17 | |
*** spzala has quit IRC | 14:21 | |
*** spzala has joined #openstack-heat-translator | 14:45 | |
*** topol has quit IRC | 14:55 | |
*** topol has joined #openstack-heat-translator | 14:55 | |
*** topol has quit IRC | 15:00 | |
*** bobh has joined #openstack-heat-translator | 15:27 | |
spzala | bobh: Hi | 15:44 |
---|---|---|
*** topol has joined #openstack-heat-translator | 15:48 | |
bobh | spzala: hello | 15:48 |
spzala | bobh: Happy New Year! | 15:49 |
bobh | spzala: Thanks! Same to you | 15:49 |
spzala | Hope you had good holidays :-) | 15:49 |
spzala | Thanks! | 15:49 |
bobh | spzala: I Was finally able to spend some time on the NFV changes | 15:49 |
spzala | lol | 15:49 |
spzala | I wanted to touch base on the same too | 15:49 |
spzala | I have some comments on it yesterday | 15:50 |
bobh | I saw the comments- I can go either way - you guys are the experts | 15:50 |
spzala | once you take a look please let me know we can chat here more and try to finalize the approach and have initial support for NFV | 15:50 |
spzala | OK, I am voting for the none custom-type approach thinking it will be easy for you and NFV team to have a better control of NFC specific code | 15:51 |
bobh | my only concern is in the testing - I know the import works, but we don't have any valid examples of NFV templates to determine whether it actually works or not | 15:51 |
spzala | and resue NFV templates | 15:51 |
spzala | without enforcing "imports: <nfv definition>" in every single nfv template | 15:52 |
bobh | the other issue is the existing definitions are very early and don't meet all of our needs | 15:52 |
bobh | so we may need to define our own node types that extend the existing NFV nodes | 15:53 |
spzala | Yup, I understand. (We also face the problem of lacking some real life example covering certain aspects of spec) | 15:53 |
spzala | OK, yup I agree | 15:53 |
spzala | and that's something you will import to NFV template | 15:53 |
bobh | yes | 15:53 |
spzala | which makes more sense | 15:53 |
spzala | vs always importing NFV definition to every NFV template | 15:54 |
bobh | we will still need to specify the NFV template version to ensure that the appropriate extension is loaded | 15:54 |
spzala | also like I said, since such imports not required in NFV stand alone template (outside tosca-parser), we shouldn't force it it in tosca-parser for nfv templates | 15:55 |
bobh | that makes sense | 15:55 |
spzala | yup, loading extensions per a specific version is something needed as we go forward ..more like a namespace work | 15:56 |
bobh | I was getting a strange error when testing with a simple NFV template - seemed like it wasn't tracking the requirements properly or something | 15:57 |
spzala | OK, cool. | 15:57 |
spzala | Ahh | 15:57 |
bobh | I commented out the requirements line in the test template and it works, but I'd like to make sure that is functional | 15:57 |
spzala | yup sure, we use requirements to define relationships | 15:58 |
spzala | so I think it might be somewhere in nodetemplate.py/nodetype.py but if you need me to look please let me know | 15:58 |
bobh | I'll try to reproduce the error and send it to you - I spent some time trying to track it down but didn't get very far | 15:59 |
spzala | And that's my fear with using NFV as 'custom types' .. as we define relationship etc. there may be chances that simple profile and nfv has some differences and needs to be code accordinly | 15:59 |
spzala | OK, sure | 15:59 |
bobh | So you will discuss with Srinivas? | 16:01 |
spzala | Yup I will. If you can add any comments to the patch that would be good for his benefit but let me try contacting him. I don't see he has any problem, it's more like his preference to me but let's see if there is any issue | 16:03 |
*** sridhar_ram has joined #openstack-heat-translator | 16:03 | |
bobh | OK - I can fix the one error in the defs file that he mentioned and I'll see if I can get the tests developed a bit more | 16:04 |
spzala | OK that would be great. Hopefully we should able to merge code by/before end of this week. | 16:06 |
spzala | I am not sure if I missed it, but please make sure that we load NFV only if we see NFV profile and I guess 'version' in template is something that we can rely | 16:07 |
spzala | sorry if you have allready took care of it | 16:08 |
bobh | That's the way it works - if the version is not the default, it will load the appropriate extension | 16:08 |
bobh | I need a negative test case on a non-existent version - just thought of that | 16:08 |
spzala | OK, cool. About non-existent, we have a test which checks for missing template (e.g. test_first_level_sections in test_toscatplvalidation) and for invalid versions etc. | 16:14 |
spzala | but more different tests are always good :-) | 16:15 |
bobh | right - so maybe it would never get there anyway since the valid versions are derived automatically | 16:16 |
spzala | true, it may become obsolete | 16:20 |
spzala | but if the only required version key is not provided | 16:22 |
spzala | it will actually fail before even attempt to load versions | 16:22 |
spzala | anyway, if you see a need for new test, pl go for it :-) | 16:23 |
*** vahidh has joined #openstack-heat-translator | 16:23 | |
bobh | I think I'll focus on the NFV tests for now | 16:28 |
spzala | bobh: Sure, that sounds perfect | 16:47 |
*** spzala has quit IRC | 16:59 | |
*** spzala has joined #openstack-heat-translator | 17:00 | |
*** spzala has quit IRC | 17:04 | |
*** tbh has joined #openstack-heat-translator | 17:23 | |
*** vahidh has quit IRC | 17:31 | |
*** vahidh has joined #openstack-heat-translator | 17:32 | |
*** vahidh has quit IRC | 17:36 | |
*** sridhar_ram has quit IRC | 18:05 | |
*** vahidh has joined #openstack-heat-translator | 18:38 | |
*** spzala has joined #openstack-heat-translator | 19:05 | |
*** tbh has quit IRC | 19:08 | |
*** topol has quit IRC | 20:48 | |
*** spzala has quit IRC | 21:53 | |
*** spzala has joined #openstack-heat-translator | 21:54 | |
*** spzala has quit IRC | 21:58 | |
*** spzala has joined #openstack-heat-translator | 22:01 | |
*** bobh has quit IRC | 22:25 | |
*** spzala has quit IRC | 23:35 | |
*** spzala has joined #openstack-heat-translator | 23:36 | |
*** spzala has quit IRC | 23:40 | |
*** spzala has joined #openstack-heat-translator | 23:43 | |
*** spzala has quit IRC | 23:43 | |
*** spzala has joined #openstack-heat-translator | 23:44 | |
*** spzala has quit IRC | 23:48 | |
*** spzala has joined #openstack-heat-translator | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!