| *** bobh has quit IRC | 00:02 | |
| *** bobh has joined #openstack-heat-translator | 00:28 | |
| *** bobh has quit IRC | 02:29 | |
| *** bobh has joined #openstack-heat-translator | 02:39 | |
| *** bobh has quit IRC | 02:43 | |
| *** bobh has joined #openstack-heat-translator | 04:42 | |
| *** bobh has quit IRC | 04:47 | |
| *** sridhar_ram has joined #openstack-heat-translator | 05:12 | |
| *** bobh has joined #openstack-heat-translator | 05:43 | |
| *** bobh has quit IRC | 05:47 | |
| *** sridhar_ram has quit IRC | 06:17 | |
| *** bobh has joined #openstack-heat-translator | 06:44 | |
| *** bobh has quit IRC | 06:48 | |
| *** bobh has joined #openstack-heat-translator | 08:02 | |
| *** bobh has quit IRC | 08:07 | |
| *** bobh has joined #openstack-heat-translator | 10:03 | |
| *** bobh has quit IRC | 10:08 | |
| *** bobh has joined #openstack-heat-translator | 11:15 | |
| *** bobh has quit IRC | 11:19 | |
| *** bobh has joined #openstack-heat-translator | 13:57 | |
| *** bobh has quit IRC | 14:12 | |
| *** spzala has joined #openstack-heat-translator | 14:22 | |
| *** sridhar_ram has joined #openstack-heat-translator | 15:02 | |
| *** mvelten has joined #openstack-heat-translator | 15:58 | |
| spzala | o/ | 16:00 |
|---|---|---|
| mvelten | \o | 16:00 |
| spzala | mvelten: folks are at the MWC and IBM Interconnect this week | 16:01 |
| spzala | so may be it's just two of us except anyone from India joins | 16:01 |
| spzala | mvelten: sorry but I am still confused on https://review.openstack.org/#/c/270318/ | 16:02 |
| spzala | the changes look good and I tested some templates with get_param which is good but confused about commented tests | 16:02 |
| spzala | you mentioned once the patch merge we can then uncomment them separately without any other changes but that's what confuse me | 16:03 |
| spzala | Jenkins run everything together and if those tests fail today then they will later too | 16:03 |
| spzala | your changes doesn't seems to have any specific changes to the url related tests | 16:04 |
| mvelten | so the commented tests reference artifacts through a github link | 16:04 |
| spzala | they references just the template right? | 16:04 |
| mvelten | yes there are :) for example in test_translate.py the commented tests reference a template that I modified, but through an http github link | 16:05 |
| mvelten | and then compared to the local reference => fail | 16:05 |
| spzala | right | 16:05 |
| spzala | but how that will change if merge your patch and then in a follow up patch we uncomment the tests - | 16:06 |
| mvelten | and exactly the same for test_tosca_hot_translation.py | 16:06 |
| spzala | sure | 16:06 |
| mvelten | the referenced template (https://raw.githubusercontent.com/openstack/heat-translator/master/translator/tests/data/tosca_single_instance_wordpress.yaml) will be updated | 16:06 |
| mvelten | and will match again the new ref | 16:06 |
| spzala | ahhh | 16:07 |
| spzala | darn it .. that makes sense | 16:07 |
| mvelten | :D | 16:07 |
| spzala | OK sorry about it | 16:07 |
| spzala | I know | 16:07 |
| spzala | :D | 16:07 |
| spzala | alright let it merge then | 16:08 |
| spzala | in the commit message though | 16:08 |
| spzala | well I am not picky about message | 16:08 |
| spzala | so let it merge | 16:08 |
| mvelten | and tomorrow once it is in i'll send the commit for reenabling the tests | 16:08 |
| spzala | and then you can update a new patch | 16:08 |
| spzala | cool | 16:08 |
| spzala | OK, about the other patch seems like that will take some time? or we can have it in pypi next week? | 16:09 |
| mvelten | for get_param i'll work on it tommorow, except big problem you should have a new patchset | 16:11 |
| spzala | that's fine | 16:12 |
| spzala | let's see if we can get it in the next week's pypi if not we will delay it to new pypi but hopefully we should have it there | 16:14 |
| spzala | key_name patch is merged so we are using get_param approach so will be good to have everything that way | 16:14 |
| spzala | mvelten: thanks, that discussion was worth a meeting ;) .. any other topic to discuss? | 16:16 |
| mvelten | ok for me ! | 16:17 |
| spzala | mvelten: cool, well let's call this a meeting then and we will continue chat/emails as needed. Thanks again! | 16:18 |
| mvelten | np, talk to you soon | 16:20 |
| spzala | mvelten: yup, sounds good! | 16:21 |
| mvelten | hum the gate didnt pass | 16:21 |
| mvelten | let me rebase | 16:21 |
| mvelten | seems like some tests from the key_name patch | 16:22 |
| openstackgerrit | Mathieu Velten proposed openstack/heat-translator: Map get_property to an actual property Disable some tests which import URL from GitHub, this commit needs to reach the repo for those tests to be valid again. A following patch will re-enable them. https://review.openstack.org/270318 | 16:26 |
| mvelten | ok pushed, it should be the last one ^^ | 16:27 |
| *** sridhar_ram has quit IRC | 16:43 | |
| *** bobh has joined #openstack-heat-translator | 16:53 | |
| *** zhipeng has joined #openstack-heat-translator | 17:04 | |
| *** mvelten has left #openstack-heat-translator | 17:38 | |
| *** sridhar_ram has joined #openstack-heat-translator | 17:55 | |
| *** sridhar_ram has quit IRC | 18:02 | |
| *** sridhar_ram has joined #openstack-heat-translator | 18:02 | |
| *** spzala has quit IRC | 18:05 | |
| *** spzala has joined #openstack-heat-translator | 18:06 | |
| *** spzala has quit IRC | 18:11 | |
| *** bobh has quit IRC | 18:25 | |
| *** spzala has joined #openstack-heat-translator | 18:25 | |
| openstackgerrit | Sahdev Zala proposed openstack/heat-translator: Provide informative message for validation success https://review.openstack.org/284871 | 18:50 |
| *** sridhar_ram has quit IRC | 18:57 | |
| *** sridhar_ram has joined #openstack-heat-translator | 19:01 | |
| openstackgerrit | Sahdev Zala proposed openstack/heat-translator: Provide informative message for validation success https://review.openstack.org/284871 | 19:08 |
| openstackgerrit | Sahdev Zala proposed openstack/heat-translator: Provide informative message for validation success https://review.openstack.org/284871 | 19:10 |
| *** bobh has joined #openstack-heat-translator | 19:34 | |
| *** bobh has quit IRC | 20:17 | |
| openstackgerrit | Merged openstack/heat-translator: Map get_property to an actual property Disable some tests which import URL from GitHub, this commit needs to reach the repo for those tests to be valid again. A following patch will re-enable them. https://review.openstack.org/270318 | 20:17 |
| *** vishwanathj has quit IRC | 21:04 | |
| *** spzala has quit IRC | 21:59 | |
| *** sridhar_ram has quit IRC | 23:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!