| *** bobh has joined #openstack-heat-translator | 00:39 | |
| *** sridhar_ram has quit IRC | 01:16 | |
| *** Shangxdy has joined #openstack-heat-translator | 01:17 | |
| *** bobh has quit IRC | 02:25 | |
| *** bobh has joined #openstack-heat-translator | 02:30 | |
| *** bobh has quit IRC | 02:47 | |
| *** bobh has joined #openstack-heat-translator | 03:28 | |
| *** bobh has quit IRC | 03:51 | |
| *** openstack has joined #openstack-heat-translator | 14:09 | |
| *** openstackgerrit_ has quit IRC | 14:36 | |
| *** openstackgerrit_ has joined #openstack-heat-translator | 14:37 | |
| *** spzala has joined #openstack-heat-translator | 14:50 | |
| *** bobh has joined #openstack-heat-translator | 15:04 | |
| *** bobh has quit IRC | 15:10 | |
| *** bobh has joined #openstack-heat-translator | 15:31 | |
| bobh | spzala: ping | 15:50 |
|---|---|---|
| spzala | bobh: on call, give me 30 mins pl.. pinging you back | 16:00 |
| bobh | spzala: np - thanks! | 16:00 |
| *** tbh has joined #openstack-heat-translator | 16:00 | |
| tbh | spzala, bobh Hi | 16:02 |
| *** vishwanathj_zzz is now known as vishwanathj | 16:02 | |
| bobh | tbh: hello spzala is on a call and unavailable for 30 minutes or so | 16:02 |
| tbh | bobh, oh I see, thanks for letting me know | 16:03 |
| tbh | bobh, actually I first wrote the patch using heat client https://review.openstack.org/#/c/280476/1/translator/shell.py, | 16:04 |
| tbh | but as spzala felt, it will be an another dependency we are creating for the user | 16:04 |
| tbh | bobh, so we decided to use ReST in this patch also | 16:05 |
| bobh | tbh: OK - thanks for the background - I probably should have looked more closely at the comment history | 16:05 |
| bobh | tbh: I'll take another look at it | 16:05 |
| tbh | sure thanks bobh | 16:05 |
| spzala | tbh: Hi, sorry on call right now | 16:09 |
| tbh | spzala, sure np | 16:10 |
| spzala | bobh: tbh: sorry but back now | 16:30 |
| tbh | spzala, we were discussing about the usage of openstack clients | 16:34 |
| bobh | spzala: I was looking at the response from dhellman about needed an exception for the requirements change | 16:34 |
| spzala | tbh: yup and I see bobh is going to look at it again as he updated his review comment as well | 16:35 |
| spzala | bobh: oh I didn't check the patch but let me | 16:35 |
| bobh | he mentioned openstack-release which doesn't seem to exist | 16:35 |
| *** tbh has quit IRC | 16:36 | |
| spzala | bobh: hmmm | 16:36 |
| *** tbh has joined #openstack-heat-translator | 16:36 | |
| spzala | let me find out it can | 16:36 |
| spzala | may be good to ping him on #openstack-relmgr-office | 16:37 |
| bobh | I joined that channel but it's not coming up on my client - maybe I'll restart the client and see if that fixes it - brb | 16:38 |
| spzala | bobh: yup | 16:38 |
| *** bobh has quit IRC | 16:38 | |
| *** bobh has joined #openstack-heat-translator | 16:38 | |
| spzala | tbh: so let Bob think more about it and see what's his view | 16:38 |
| spzala | bobh: I guess asking for exception makes sense.. please let me know if anything needed from heat-translator side with the process | 16:39 |
| bobh | spzala: thanks - restarting my client started up openstack-release so I'll ping him there | 16:40 |
| spzala | bobh: any luck joining that channel? He usually is very good replying | 16:40 |
| spzala | bobh: OK, sorry though you already did :-) | 16:40 |
| *** spzala has quit IRC | 16:44 | |
| *** spzala has joined #openstack-heat-translator | 16:44 | |
| bobh | spzala: dhellman approved - we should be good to go | 16:45 |
| spzala | bobh: awesome, was about to ping .. I joined that channel and saw it | 16:46 |
| spzala | so openstack-release did work for me? | 16:46 |
| spzala | with # ofcourse | 16:46 |
| bobh | spzala: it worked for me too after I restarted - very strange - must be a bug in Limechat | 16:46 |
| spzala | I see | 16:47 |
| spzala | bobh: well, yes Limechat behavior .. I face the same. I used to Chatzilla on my old windows and that was great | 16:47 |
| bobh | spzala: tbh Is there any concern that both the get_token and get_url methods will result in a keystone auth request? Would it be better to cache the results from get_token and use the service catalog in get_url? | 16:48 |
| tbh | bobh, I divided them because, may be some(new) methods will invoke any one of the methods | 16:50 |
| tbh | bobh, now I am thinking of such methods :) | 16:51 |
| bobh | tbh: I agree, I'm just not sure we need to generate a REST request every time if the result of the initial token request can be stored for reference by future calls | 16:52 |
| bobh | tbh: memory vs network I guess | 16:52 |
| tbh | bobh, rather I will modify get_token to return access_dict and token as tuple and have get_url (which accepts the access_dict and service name).... | 16:54 |
| bobh | tbh: that sounds good | 16:55 |
| tbh | so that get_url won't invoke get_access_dict | 16:56 |
| tbh | if anyone wants to invoke get_url, he has to get access_dict first and pass it to get_url ?? | 16:56 |
| bobh | tbh: I think it's reasonable to require the user get_token before get_url - at least for the orchestration URL | 16:58 |
| tbh | bobh, true | 16:59 |
| spzala | tbh: as you make changes, one more different thing, | 17:01 |
| spzala | tbh: in shell.py you are printing message based on code but why don't we just print content as it is | 17:01 |
| spzala | (as you get on heat client ) | 17:02 |
| tbh | spzala, but that content is a python dict containing some other params too | 17:03 |
| spzala | tbh: but that should be OK, that's what heat gives back and has more information on parameters, what user wanted to print with 'output' section etc | 17:04 |
| tbh | spzala, I was thinking, do the user really need all those information | 17:05 |
| spzala | tbh: I am sure, for example, that's why they have 'output' section in the template | 17:06 |
| tbh | spzala, but as we are printing the heat stack ID, we get more information about the heat stack deployment status,ouptut params etc from heat itself | 17:08 |
| tbh | spzala, let me output the dict | 17:08 |
| spzala | tbh: sure, cool | 17:08 |
| tbh | spzala, and later on we decide whether we need it or not?? | 17:08 |
| spzala | tbh: sure, for now let's go without any cropping (I think that will also give us less headache on what to display ourself and what not) | 17:10 |
| spzala | I have added as comment, for reference/history purpose | 17:11 |
| tbh | spzala, sure | 17:13 |
| spzala | tbh: thanks!! stepping away for lunch, good night and weekend to you if we don't talk again today! | 17:16 |
| tbh | spzala, see you :) | 17:16 |
| spzala | thb: :) | 17:16 |
| *** sridhar_ram has joined #openstack-heat-translator | 17:17 | |
| *** bobh has quit IRC | 17:47 | |
| *** spzala has quit IRC | 18:48 | |
| *** spzala has joined #openstack-heat-translator | 18:48 | |
| *** tbh has quit IRC | 18:54 | |
| openstackgerrit | Merged openstack/heat-translator: Updated from global requirements https://review.openstack.org/288018 | 18:59 |
| *** spzala has quit IRC | 22:01 | |
| *** spzala has joined #openstack-heat-translator | 22:01 | |
| *** spzala has quit IRC | 22:06 | |
| *** spzala has joined #openstack-heat-translator | 22:15 | |
| *** spzala has quit IRC | 23:24 | |
| *** spzala has joined #openstack-heat-translator | 23:24 | |
| *** bobh has joined #openstack-heat-translator | 23:28 | |
| *** spzala has quit IRC | 23:29 | |
| *** sridhar_ram has quit IRC | 23:43 | |
| *** spzala has joined #openstack-heat-translator | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!