| *** bobh has quit IRC | 00:07 | |
| *** sridhar_ram1 has quit IRC | 00:28 | |
| *** sridhar_ram has joined #openstack-heat-translator | 00:32 | |
| *** bobh has joined #openstack-heat-translator | 00:33 | |
| *** spzala has joined #openstack-heat-translator | 01:08 | |
| *** spzala has quit IRC | 01:08 | |
| *** spzala has joined #openstack-heat-translator | 01:08 | |
| bobh | spzala: ping | 01:14 |
|---|---|---|
| spzala | bobh: hi | 01:14 |
| bobh | spzala: so the folded/literal string handling turns out to be a rabbit hole | 01:15 |
| spzala | lol | 01:15 |
| bobh | spzala: There is a whole section in the YAML spec about keeping/chomping trailing newlines, etc | 01:15 |
| bobh | spzala: The ">-" notation in your second example is actually valid YAML - the YAML translator did not find a newline at the end of the string so it adds the "-" as a chomp indicator | 01:16 |
| bobh | spzala: It seems to be indeterminate whether the yaml.load will keep or discard the trailing newline when it processes the TOSCA input string - in your examples it kept the newline in one case and discarded it in the other | 01:17 |
| spzala | bobh: interesting | 01:17 |
| bobh | spzala: I was hoping to implement it globally so we would not have to look at individual fields to determine whether they should be literal or folded | 01:17 |
| spzala | bobh: if it's valid, that's totally good with me then | 01:17 |
| bobh | spzala: user_data should pretty much always be literal | 01:18 |
| spzala | bobh: sure, other thing I mentioned I think was in one case instead of ">" it translated to "|" | 01:18 |
| bobh | spzala: Right - in that case it kept the trailing newline on the string and then decided it should be literal because of the trailing newline | 01:19 |
| bobh | spzala: but in your second example it stripped the trailing newline | 01:19 |
| spzala | bobh: I see | 01:19 |
| bobh | spzala: I'll be back in a minute - have to put a kid to bed | 01:19 |
| spzala | bobh: hehe, it's same here | 01:20 |
| spzala | bobh: in my case, I will be doing in 15 mins but then need to tell bed time story so it usually takes longer for me. | 01:20 |
| spzala | bobh: tty once you are back.. if I don't respond that means with kiddos.. but in that case will get back to you soon | 01:21 |
| *** sridhar_ram has quit IRC | 01:41 | |
| bobh | spzala: ideally there would be a way to preserve the format indicator from the original TOSCA template and apply it to the translated HOT template, but the yaml parser just loads the string with no record of whether it was literal or folded | 01:45 |
| bobh | spzala: so I'm thinking that if it has internal newlines (ignore trailing newlines) we should make it literal, and if it has no internal newlines and is more than X characters long (80?) it should be folded | 01:46 |
| openstackgerrit | Bob Haddleton proposed openstack/heat-translator: Implements literal and folded string support https://review.openstack.org/317150 | 01:52 |
| openstackgerrit | Bob Haddleton proposed openstack/heat-translator: Implements literal and folded string support https://review.openstack.org/317150 | 01:54 |
| *** bobh has quit IRC | 01:57 | |
| *** vishwanathj has quit IRC | 02:09 | |
| *** bobh has joined #openstack-heat-translator | 02:35 | |
| *** spzala has quit IRC | 02:43 | |
| *** spzala has joined #openstack-heat-translator | 02:43 | |
| *** spzala has quit IRC | 02:44 | |
| *** spzala has joined #openstack-heat-translator | 02:44 | |
| spzala | bobh: sure | 02:48 |
| bobh | spzala: the alternative was to handle individual property fields in each hot_* resource file, but that seems really kludgy | 02:49 |
| spzala | bobh: true, since it's all valid yaml I guess we should be fine. Can you please deploy translated template with heat to see it | 02:50 |
| spzala | 's not complaining and if it's not then I guess we don't have to worry about | 02:50 |
| bobh | sure - I'll do it tomorrow when I get to work | 02:51 |
| spzala | bobh: I see you patch update, didn't test it but I will be right now to see if I still see ">-" and "|" | 02:51 |
| spzala | bobh: great, thanks!! | 02:51 |
| bobh | spzala: it will be interesting to see if Heat handles the '>-' notation | 02:51 |
| spzala | bobh: yup, I believe it should because it's valid yaml | 02:52 |
| bobh | spzala: me too | 02:52 |
| spzala | bobh: heat eventually will handle it as dict value | 02:52 |
| spzala | bobh: so it's strange, why I only see ">-" it. The test template you have out there doesn't have it | 02:53 |
| spzala | and you already have it covered in unit test | 02:53 |
| bobh | spzala: yes - very strange - the YAML spec has a set of conditions about how it handles the scalar string objects so it must be hitting one of the special cases | 02:54 |
| spzala | bobh: true | 02:54 |
| bobh | spzala: I ca reproduce the >- but no idea why the testcase doesn't have the same behavior | 02:54 |
| bobh | s/ca/can/ | 02:54 |
| spzala | bobh: ahh, interesting and strange. well, if Heat can handle it then we don't have to worry | 02:55 |
| spzala | - just: > | 02:55 |
| spzala | write some. | 02:55 |
| spzala | some more. | 02:55 |
| bobh | spzala: I put the >- notation into the tosca input template just to try it and it works as input too | 02:56 |
| spzala | translates by yaml as, | 02:56 |
| spzala | { | 02:56 |
| spzala | "just": "write some. some more.\n" | 02:56 |
| spzala | } | 02:56 |
| bobh | spzala: lol | 02:56 |
| spzala | :-) where as, | 02:57 |
| spzala | - just: >- | 02:57 |
| spzala | write some. | 02:57 |
| spzala | some more. | 02:57 |
| spzala | shows this | 02:57 |
| spzala | { | 02:57 |
| spzala | "just": "write some. some more." | 02:57 |
| spzala | } | 02:57 |
| spzala | so it's all about how it handles newline as you said earlier | 02:58 |
| spzala | bobh: cool, that's a good test | 02:58 |
| *** bobh has quit IRC | 02:58 | |
| *** bobh has joined #openstack-heat-translator | 02:58 | |
| bobh | spzala: yep - lots more to learn about yaml | 02:59 |
| spzala | bobh: hehe, true | 02:59 |
| spzala | bobh: calling it a night unless we want to discuss anything otherwise good night :-) | 03:02 |
| bobh | spzala: good night - thanks! | 03:02 |
| spzala | bobh: we can chat in our IRC meeting tomorrow morning | 03:02 |
| bobh | spzala: ttyl | 03:02 |
| spzala | bobh: np, thank you! | 03:02 |
| spzala | bobh: good night! later. | 03:02 |
| *** spzala has quit IRC | 03:03 | |
| *** bobh has quit IRC | 03:04 | |
| *** tbh has joined #openstack-heat-translator | 04:22 | |
| *** apoorv has joined #openstack-heat-translator | 05:57 | |
| *** sridhar_ram_ has quit IRC | 08:45 | |
| *** tbh has quit IRC | 09:17 | |
| *** sridhar_ram_ has joined #openstack-heat-translator | 09:56 | |
| *** apoorv has quit IRC | 10:47 | |
| *** apoorv has joined #openstack-heat-translator | 10:53 | |
| *** apoorv has quit IRC | 12:25 | |
| *** sridhar_ram_ has quit IRC | 12:55 | |
| *** bobh has joined #openstack-heat-translator | 13:19 | |
| *** tbh has joined #openstack-heat-translator | 14:57 | |
| *** spzala has joined #openstack-heat-translator | 15:08 | |
| *** tbh has quit IRC | 15:52 | |
| *** tbh has joined #openstack-heat-translator | 15:53 | |
| spzala | Hello all | 16:00 |
| bobh | o/ | 16:00 |
| spzala | o/ | 16:00 |
| spzala | topol: tbh: o/ | 16:00 |
| tbh | o/ | 16:00 |
| spzala | well, let's start :) | 16:01 |
| spzala | bobh: we are almost on top of discussion on https://review.openstack.org/#/c/317150/ | 16:01 |
| spzala | but any update? | 16:01 |
| *** shangxdy has joined #openstack-heat-translator | 16:02 | |
| spzala | tbh: I have added to review the above patch too if you get time | 16:02 |
| bobh | spzala: oops.... forgot to try that this morning - too many distractions | 16:02 |
| spzala | bobh: lol | 16:02 |
| bobh | spzala: I will put it on the list for this afternoon | 16:02 |
| spzala | bobh: no rush at all | 16:02 |
| tbh | spzala, sure, will do that | 16:02 |
| spzala | bobh: cool, thanks | 16:02 |
| spzala | shangxdy: o/ | 16:02 |
| spzala | tbh: thanks! | 16:03 |
| shangxdy | HI,spzala,bob and tbh:) | 16:03 |
| tbh | hi shangxdy | 16:03 |
| bobh | shangxdy: o/ | 16:03 |
| spzala | Last week we had some discussion on our priority item of finding a good way to support backward compatibility in tosca-parser and heat-transaltor | 16:04 |
| spzala | bobh: ^ | 16:04 |
| shangxdy | It seems long time to here. | 16:04 |
| spzala | I had some discussion on oslo channel and with couple other folks | 16:04 |
| spzala | so couple of things something that we should discuss | 16:05 |
| shangxdy | Tosca-parser will be a part of oslo? | 16:06 |
| spzala | it seems like most openstack projects doesn't have a good way to support backward compatibility, usually they release and if it breaks anything they fix it and rerelease | 16:06 |
| shangxdy | o | 16:06 |
| bobh | ouch | 16:06 |
| spzala | I am not fan of that approach at all | 16:06 |
| spzala | bobh: yes | 16:07 |
| spzala | It was unexpected but I guess there seems no really good way out there. | 16:07 |
| bobh | spzala: can we use gate jobs to run different version combinations? | 16:07 |
| spzala | oslo seems first project to going to start some automation for this problem | 16:08 |
| spzala | bobh: I guess so but I was suggested to start with one gate for master first | 16:08 |
| spzala | assuming if master works fine then latest pypi should go good as well | 16:08 |
| bobh | spzala: makes sense | 16:09 |
| spzala | bobh: so one more thing which is different than what we discussed | 16:09 |
| spzala | shangxdy: no tosca-parser won't be part of oslo, | 16:09 |
| spzala | I had discussion to know about in general approach in openstack | 16:09 |
| spzala | so back to original discussion, we initially thought of creating gate job in tosca-parser for heat-translator | 16:10 |
| shangxdy | I think it's ok if the restful api are backward compatibility for most of openstack's other projects , but tosca-parser is different. | 16:11 |
| spzala | which can be more productive but it seems like not a practical approach as we may end up with several gate if down the road more projects start using parser and it requires to create gate against all of them | 16:11 |
| spzala | shangxdy: sure | 16:12 |
| spzala | bobh: so I think our best bet is to run heat-translator master with master of tosc-parser | 16:12 |
| spzala | for which we will create gate in heat-translator for parser | 16:12 |
| spzala | and if we find anything is breaking we fix it tosca-parser | 16:13 |
| bobh | spzala: today heat-translator master runs against the current tosca-parser official release? | 16:13 |
| spzala | I found this little anti-productive but I guess it makes sense too that the project that uses a particular projects should do gate job | 16:13 |
| spzala | bobh: yes that's correct | 16:14 |
| spzala | bobh: so we will try to run against tosca-parser master as well and see if that breaks anything in heat-translator | 16:14 |
| bobh | spzala: that sounds like a good solution - it will pick up any errors introduced by tosca-parser changes as soon as they show up | 16:14 |
| spzala | does that make sense? | 16:14 |
| spzala | bobh: yes, exactly | 16:15 |
| shangxdy | What does "gate job" mean? are there more detailes? | 16:15 |
| topol | o/ | 16:15 |
| spzala | topol: o/ | 16:15 |
| bobh | spzala: if there are known incompatibilities that are going to be introduced by tosca-parser the associated heat-translator patch can be coordinated to land at the same time | 16:15 |
| spzala | shangxdy: http://docs.openstack.org/infra/zuul/ | 16:16 |
| spzala | bobh: yes, as I was saying it might need us to redo some work in tosca-parser but it's always good that we do it during ongoing development vs. we may need to do the work after release if we find such incompatibilities and rerelease etc..which is not quite ideal | 16:17 |
| bobh | spzala: agreed - anything we can do to limit production breakage is a good thing | 16:18 |
| spzala | shanxdy: pl take a look at the above link, let me know if you have any question. | 16:18 |
| spzala | bobh: yes, absolutely | 16:18 |
| spzala | so this seems like a good plan to keep parser backward compatible with translator but other question I have is how about keeping translator backward compatible itself? | 16:19 |
| spzala | bobh: I am not sure but once we have work done in translator, you may need to do something similar in tacker for parser or translator if such a need arise | 16:20 |
| *** vishwanathj has joined #openstack-heat-translator | 16:20 | |
| spzala | if we introduce or modify api in translator master, that can impact tacker or other projects too I guess? | 16:21 |
| bobh | spzala: could be - I've seen some chatter on the ML this week about using upper-constraints.txt in testing requirements, so this might be a candidate for that | 16:21 |
| bobh | we could run a gate against tosca-parser master + heat-translator master - maybe skip functional tests to limit the duration and impact of the extra gate job | 16:22 |
| spzala | bobh: I see, sure | 16:22 |
| spzala | bobh: yes that's good idea I think | 16:22 |
| shangxdy | spzala, zuul is the component of openstack CI system, is right? | 16:22 |
| spzala | bobh: I guess it's not needed right away | 16:23 |
| spzala | let's first see how heat-translator does it with parser and then tacker can use those patches? | 16:23 |
| spzala | shangxdy: yes, zuul automates tests for CI | 16:24 |
| spzala | bobh: there is no dependency so tacker can do work anytime | 16:24 |
| shangxdy | My colleague has just set up a ci system based on openstack. | 16:26 |
| shangxdy | Ok | 16:26 |
| spzala | shangxdy: ah, nice | 16:26 |
| shangxdy | But i still don‘t know what is the relationship between the tosca-parser backward compatibility and the zuul. We are using zuul every commit. | 16:28 |
| bobh | spzala: sounds good | 16:28 |
| spzala | shangxdy: all the projects, not just tosca-parser, uses zuul to enforce testing before merging code change | 16:29 |
| spzala | shangxdy: for tosca-parser BC we were talking about creating a zuul gate to test heat-translator with master of tosca-parser | 16:29 |
| spzala | so that if it breaks any tests, we can fix it right hen | 16:30 |
| spzala | shangxdy: makes sense? | 16:30 |
| shangxdy | yes,all the openstack project use zuul. | 16:30 |
| spzala | bobh: cool | 16:30 |
| tbh | spzala, that was a nice explanation :) | 16:30 |
| spzala | tbh: hehe, thanks :) | 16:31 |
| spzala | shanxdy: I hope you are good with the zuul question. | 16:32 |
| spzala | I guess it's time for open discussion :) | 16:32 |
| spzala | anyone has any other topic for discussion? | 16:32 |
| spzala | shangxdy: tbh: bobh: ^ anything? if there is no topic, I guess we can wrap up meeting. :-) | 16:34 |
| bobh | spzala: sounds good to me :-) | 16:35 |
| tbh | spzala, nothing from my end | 16:35 |
| spzala | bobh: tbh: :-) Thanks!! | 16:35 |
| shangxdy | only use zuul only? what about jenkins or JJB？ | 16:36 |
| spzala | I will wait for shangxdy: :) | 16:36 |
| spzala | shangxdy: jenkins is already there | 16:37 |
| spzala | shangxdy: no extra set up is required for it | 16:37 |
| spzala | Jenkins is the CI server | 16:38 |
| shangxdy | Sorry, is there other more details about the solution? | 16:39 |
| spzala | shangxdy: no problem. Well for now solution detail all I have is to create a new gate in translator | 16:39 |
| spzala | :( | 16:39 |
| spzala | I think we will be using openstack standard practices to create gate and that's pretty much it | 16:40 |
| shangxdy | Ok | 16:42 |
| spzala | shangxdy: we will discuss it more as you need it | 16:43 |
| shangxdy | It seems that i'v got the point, i just misunderstood. | 16:43 |
| spzala | shangxdy: OK, prefect :) and np! | 16:44 |
| shangxdy | thanks. | 16:44 |
| spzala | no problem | 16:44 |
| spzala | Alright everyone, thank you much for joining today! | 16:44 |
| spzala | good night, good day! talk to you later. | 16:44 |
| shangxdy | Good day to all:) | 16:45 |
| spzala | :) thanks | 16:46 |
| spzala | bye all! | 16:46 |
| shangxdy | Bye! | 16:49 |
| openstackgerrit | Merged openstack/heat-translator: test heat-translator with master branch of tosca-parser https://review.openstack.org/318302 | 16:50 |
| *** shangxdy has quit IRC | 16:53 | |
| *** sridhar_ram_ has joined #openstack-heat-translator | 17:30 | |
| *** tbh_ has joined #openstack-heat-translator | 18:21 | |
| *** tbh has quit IRC | 18:23 | |
| *** zaneb has quit IRC | 18:26 | |
| *** zaneb has joined #openstack-heat-translator | 18:29 | |
| *** tbh_ has quit IRC | 18:31 | |
| *** tbh_ has joined #openstack-heat-translator | 18:34 | |
| *** tbh_ has quit IRC | 18:57 | |
| *** sridhar_ram_ has quit IRC | 19:35 | |
| *** rebase has joined #openstack-heat-translator | 21:08 | |
| openstackgerrit | Sahdev Zala proposed openstack/heat-translator: Remove incorrect envlist entry https://review.openstack.org/318955 | 21:39 |
| *** sridhar_ram has joined #openstack-heat-translator | 21:39 | |
| *** sridhar_ram has quit IRC | 22:17 | |
| *** sridhar_ram has joined #openstack-heat-translator | 22:20 | |
| *** bobh has quit IRC | 22:37 | |
| *** sridhar_ram has quit IRC | 22:56 | |
| *** rebase has quit IRC | 23:27 | |
| openstackgerrit | Sahdev Zala proposed openstack/heat-translator: Update tox entry to reflect full name https://review.openstack.org/318977 | 23:36 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!