*** uck_ has quit IRC | 00:10 | |
*** uck has joined #openstack-heat-translator | 00:11 | |
*** uck has quit IRC | 00:16 | |
*** bobh has joined #openstack-heat-translator | 00:43 | |
*** spzala has joined #openstack-heat-translator | 00:53 | |
*** spzala has quit IRC | 00:53 | |
*** spzala has joined #openstack-heat-translator | 00:54 | |
*** spzala has quit IRC | 00:58 | |
*** spzala has joined #openstack-heat-translator | 02:08 | |
*** bobh has quit IRC | 02:10 | |
*** spzala has quit IRC | 02:18 | |
*** uck has joined #openstack-heat-translator | 03:19 | |
*** KanagarajM has joined #openstack-heat-translator | 04:06 | |
*** KanagarajM_ has joined #openstack-heat-translator | 04:09 | |
*** KanagarajM has quit IRC | 04:09 | |
*** uck has quit IRC | 04:09 | |
*** KanagarajM_ has quit IRC | 04:18 | |
openstackgerrit | shangxdy proposed openstack/heat-translator: The translation of server's IP as output is error https://review.openstack.org/370720 | 04:49 |
---|---|---|
openstackgerrit | shangxdy proposed openstack/heat-translator: The translation of server's IP as output is error https://review.openstack.org/370720 | 05:05 |
*** KanagarajM_ has joined #openstack-heat-translator | 05:16 | |
*** vishwanathj has quit IRC | 06:25 | |
*** ig0r_ has joined #openstack-heat-translator | 09:22 | |
*** tbh has joined #openstack-heat-translator | 10:38 | |
openstackgerrit | shizhihui proposed openstack/heat-translator: Delete the files in MANIFEST.IN https://review.openstack.org/374697 | 11:01 |
*** bobh has joined #openstack-heat-translator | 11:57 | |
*** bobh has quit IRC | 12:22 | |
*** KanagarajM_ has quit IRC | 13:10 | |
*** spzala has joined #openstack-heat-translator | 13:27 | |
*** bobh has joined #openstack-heat-translator | 13:52 | |
*** bobh has quit IRC | 13:59 | |
*** vishwanathj has joined #openstack-heat-translator | 14:19 | |
spzala | tbh: hi | 14:36 |
tbh | spzala, hi | 14:38 |
spzala | tbh: hey, if you have few mins can you please review this patch https://review.openstack.org/#/c/374407/ | 14:42 |
spzala | quick one :) | 14:42 |
tbh | spzala, sure | 14:46 |
spzala | thanks tbh | 14:47 |
tbh | spzala, np :) | 14:48 |
spzala | :) | 14:48 |
*** bobh has joined #openstack-heat-translator | 14:55 | |
*** bobh has quit IRC | 14:59 | |
spzala | tbh: you will be around for next couple hrs? and join our meeting today too? | 15:11 |
tbh | spzala, yes | 15:12 |
spzala | tbh: cool, thanks! | 15:12 |
openstackgerrit | Merged openstack/heat-translator: Doc update on automatically deploying template https://review.openstack.org/374407 | 15:24 |
*** uck has joined #openstack-heat-translator | 15:53 | |
*** bobh has joined #openstack-heat-translator | 15:55 | |
spzala | Hi all bobh: tbh: topol: shagnxdy: | 16:00 |
tbh | Hi spzala | 16:00 |
*** bobh has quit IRC | 16:00 | |
topol | o/ | 16:00 |
spzala | o/ | 16:00 |
spzala | short meeting | 16:00 |
spzala | there are couple of things but for one we need shang | 16:01 |
spzala | the other main item is to have heat-translator pypi release today and it's on track | 16:01 |
spzala | tbh: can you please test Tacker with current/master repo of heat-translator and make sure it passes all the tests? | 16:02 |
spzala | bobh: used to help with it but seems like he isn't available | 16:02 |
tbh | spzala, sure | 16:02 |
tbh | spzala, yeah no problem | 16:03 |
spzala | tbh: thanks, please raise bug or shoot me mail if you run into anything. | 16:03 |
spzala | tbh: :) | 16:03 |
tbh | spzala, ok | 16:04 |
spzala | the other item to discuss is https://review.openstack.org/#/c/370720/ | 16:04 |
*** shangxdy has joined #openstack-heat-translator | 16:04 | |
shangxdy | Hi, spzala | 16:05 |
spzala | tbh: I will be out for an hour or so after meeting today .. just fyi | 16:05 |
shangxdy | I'am updating the patch. | 16:05 |
spzala | shangxdy: hi, how are you? | 16:05 |
spzala | shangxdy: which one? | 16:05 |
tbh | spzala, I will mail you the results | 16:05 |
shangxdy | Fine,thank you | 16:05 |
spzala | tbh: perfect and we can discuss it on this channel too if needed discussion | 16:06 |
shangxdy | The ip output, and the networks should be deleted | 16:06 |
spzala | shangxdy: :) great .. np | 16:06 |
spzala | shangxdy: so the way it's there in your patch doesn't work right? I did comment on it. | 16:06 |
spzala | shangxdy: let's see with your patch update but if you are planning to use first_address, I don't think that's a good idea.. that attribute is deprecated in heat and that means it can be removed | 16:07 |
openstackgerrit | shangxdy proposed openstack/heat-translator: The translation of server's IP as output is error https://review.openstack.org/370720 | 16:08 |
spzala | shangxdy: well you updated what I feared about :-) and as I said above :-) | 16:08 |
shangxdy | yes, it does't work before the latest update. i'll fix it just now. | 16:09 |
spzala | shangxdy: first_address is deprecated sometime back and that's why we moved to using what's out there today | 16:10 |
spzala | originally we had exactly what you changed in latest patch | 16:10 |
spzala | so thought first_address works because it's deprecated (unless anything changed as of today, please make sure) it can not be supported in future | 16:11 |
shangxdy | Sure, first_address is not good when multiple ips in compute. but it is ok current when there is only one ip. | 16:11 |
shangxdy | It will be deprecated? i don't see it in the spec. | 16:13 |
shangxdy | first_address: {description: 'Convenience attribute to fetch the first assigned network | 16:13 |
shangxdy | address, or an empty string if nothing has been assigned at this time. Result | 16:13 |
shangxdy | may not be predictable if the server has addresses from more than one network.'} | 16:13 |
spzala | http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Nova::Server | 16:14 |
spzala | there is no mention of it there | 16:14 |
spzala | https://review.openstack.org/#/c/86526/ | 16:14 |
spzala | https://bugs.launchpad.net/heat/+bug/1302466 | 16:15 |
openstack | Launchpad bug 1302466 in heat "first_address attribute should be deprecated" [Undecided,Fix released] - Assigned to Sergey Kraynev (skraynev) | 16:15 |
spzala | shangxdy: if you can please take a look to those links and also see if anything else you can find out, that would be great | 16:16 |
shangxdy | my god, it's sure in the latest spec. | 16:16 |
spzala | shangxdy: :) let's do this, let's research little bit more ? | 16:18 |
*** KanagarajM_ has joined #openstack-heat-translator | 16:18 | |
spzala | KanagarajM: Hi | 16:18 |
spzala | shangxdy: I am having a conflict, something I said in the start of meeting to have a short meeting today | 16:20 |
shangxdy | The patch 1302466 was created in 2014, but first_address is still there in Mitaka. | 16:21 |
spzala | shangxdy: if heat doc still says it, as sometime it lingers in doc, then we should open a bug against heat | 16:21 |
shangxdy | Ok | 16:21 |
spzala | shangxdy: agree | 16:21 |
spzala | I was hopping to have it confirmed with KanagarajM: | 16:21 |
shangxdy | Great | 16:22 |
spzala | if anything is changed in heat and we can use first_address then I think we can put more thoughts with your proposal (btw, thanks for your email on it) and see how best we can use it | 16:23 |
spzala | shangxdy: thanks | 16:23 |
spzala | KanagarajM_: hi | 16:23 |
spzala | shangxdy: tbh: I need to leave if there is no other discussion right now? | 16:23 |
tbh | spzala, yup sure, already started testing | 16:24 |
spzala | shangxdy: tbh: I should be back in hour or so and we can continue discussion or take it via mails | 16:24 |
spzala | tbh: awesome! | 16:24 |
shangxdy | It's all from my side. please review https://review.openstack.org/#/c/367499/. | 16:24 |
spzala | KanagarajM_: when you have a minute, no rush, but if you can tell about use of 'first_address' attribute of Nova resource that would be helpful. Seems like it's deprecated ? and in that case we won't use it. | 16:25 |
spzala | shangxdy: thanks.. yup, that's in my list of TODO and will review it hopefully now .. due to work on heat-translator release and my travel I wasn't able to review | 16:26 |
spzala | shagnxdy: but doing it soon, hopefully later today or tomorrow | 16:26 |
spzala | tbh: shangxdy: thanks much! ending meeting :-) .. need to run | 16:27 |
shangxdy | :), thanks. | 16:27 |
tbh | spzala, sure :) | 16:27 |
spzala | shangxdy: :) np | 16:27 |
spzala | tbh: shangxdy: :) bye | 16:27 |
shangxdy | bye spzala and tbh. | 16:27 |
shangxdy | good day. | 16:27 |
spzala | shangxdy: you too, good night :) | 16:28 |
shangxdy | :) | 16:28 |
*** shangxdy has quit IRC | 16:28 | |
openstackgerrit | shangxdy proposed openstack/heat-translator: The translation of server's IP as output is error https://review.openstack.org/370720 | 16:30 |
*** shangxdy has joined #openstack-heat-translator | 16:32 | |
shangxdy | spzala, i reviewed the heat code just now, first_address still exists in the latest version of heat. | 16:35 |
shangxdy | ATTRIBUTES = ( | 16:36 |
shangxdy | NAME_ATTR, ADDRESSES, NETWORKS_ATTR, FIRST_ADDRESS, | 16:36 |
shangxdy | INSTANCE_NAME, ACCESSIPV4, ACCESSIPV6, CONSOLE_URLS, | 16:36 |
shangxdy | ) = ( | 16:36 |
shangxdy | 'name', 'addresses', 'networks', 'first_address', | 16:36 |
shangxdy | 'instance_name', 'accessIPv4', 'accessIPv6', 'console_urls', | 16:36 |
shangxdy | ) | 16:36 |
shangxdy | if name == self.FIRST_ADDRESS: | 16:36 |
shangxdy | return self.client_plugin().server_to_ipaddress( | 16:36 |
shangxdy | self.resource_id) or '' | 16:36 |
shangxdy | So currently, we can use it:) | 16:37 |
*** shangxdy has quit IRC | 16:38 | |
*** KanagarajM_ has quit IRC | 16:41 | |
*** bobh has joined #openstack-heat-translator | 16:56 | |
*** bobh has quit IRC | 17:01 | |
*** uck has quit IRC | 17:21 | |
*** uck has joined #openstack-heat-translator | 17:25 | |
spzala | tbh: hi back | 17:27 |
tbh | spzala,:) | 17:29 |
spzala | tbh: :) | 17:29 |
tbh | spzala, I just send the test report to your mail | 17:33 |
spzala | tbh: thanks! Is everything ok? | 17:34 |
spzala | tbh: hope no breaking related to translator? | 17:34 |
tbh | spzala, few tests failed,but it is not related to heat-translator I guess, I am testing those tests individually again | 17:34 |
spzala | tbh: thanks, I see some failed tests but hard to tell if it's from translator | 17:36 |
spzala | tbh: does tox pass? | 17:36 |
tbh | spzala, yes epy27 tests passed, few errors in pep8, so no issues with tox | 17:36 |
spzala | tbh: not sure how you are running functional tests? one way to make sure, you might thought that too, is run those without master of heat-translator and see the failed tests are there? | 17:37 |
spzala | tbh: NICE | 17:37 |
tbh | spzala, I have commented "heat-translator" in requirements.txt and ran tox -efunctional | 17:38 |
tbh | spzala, with the created virtualenv python binary I have manually install heat-translator of master branch | 17:38 |
spzala | tbh: hmm .. why commenting translator? and then run test? | 17:39 |
spzala | tbh: ok that's nice but then you should leave heat-translator uncommented to test the one you installed manually? | 17:39 |
tbh | spzala, so it won't install pypi release version | 17:39 |
spzala | tbh: I see | 17:40 |
spzala | tbh: it's requirement.txt you said | 17:40 |
spzala | tbh: OK makes sense so you do have installed master version of translator.. sounds good | 17:41 |
tbh | spzala, yes | 17:41 |
spzala | tbh: I misunderstood | 17:41 |
tbh | spzala, this is the version of heat-translator version currently installed "heat-translator==0.5.1.dev61" | 17:41 |
tbh | spzala, can you cross verify this? | 17:41 |
spzala | tbh: perfect that's master | 17:41 |
spzala | tbh: that's good | 17:42 |
tbh | spzala, only three tests are failing, am checking those | 17:42 |
spzala | tbh: OK sure | 17:43 |
tbh | spzala, all the three tests are not related to heat-translator | 17:46 |
spzala | tbh: :) :) yay | 17:46 |
spzala | tbh: nice and thank you so much .. we can go ahead with release .. if anything in worst case break I think I can revert release | 17:47 |
tbh | spzala, sure | 17:48 |
spzala | tbh: :) thanks again! Will let you know once it's out ... but please feel free to log out if it's sleep time :-) | 17:49 |
tbh | spzala,np | 17:50 |
tbh | spzala, btw I haven't changes the version of tosca-parser | 17:51 |
tbh | *changed | 17:51 |
spzala | tbh: that's fine | 17:55 |
spzala | tbh: can you check the version it must be 0.6.0 | 17:56 |
tbh | spzala, yes 0.0.0 | 17:56 |
tbh | sry 0.6.0 | 17:56 |
spzala | tbh: :) np, ok that's perfect than | 17:57 |
*** bobh has joined #openstack-heat-translator | 17:57 | |
*** bobh has quit IRC | 18:02 | |
*** ig0r_ has quit IRC | 18:09 | |
tbh | spzala, logging off | 18:11 |
*** tbh has quit IRC | 18:13 | |
spzala | tbh: :) OK | 18:14 |
spzala | shangxdy: if it's there but it's deprecated than no point using it temporarily | 18:21 |
*** uck has quit IRC | 18:38 | |
*** bobh has joined #openstack-heat-translator | 18:58 | |
*** bobh has quit IRC | 19:03 | |
*** uck has joined #openstack-heat-translator | 19:39 | |
*** spzala has quit IRC | 19:41 | |
*** spzala has joined #openstack-heat-translator | 19:42 | |
*** spzala_ has joined #openstack-heat-translator | 19:45 | |
*** uck has quit IRC | 19:45 | |
*** spzala has quit IRC | 19:46 | |
*** spzala_ has quit IRC | 19:49 | |
*** bobh has joined #openstack-heat-translator | 19:59 | |
*** bobh has quit IRC | 20:03 | |
*** spzala has joined #openstack-heat-translator | 20:24 | |
*** spzala has quit IRC | 20:28 | |
*** spzala has joined #openstack-heat-translator | 20:33 | |
*** bobh has joined #openstack-heat-translator | 21:00 | |
*** bobh has quit IRC | 21:04 | |
*** spzala has quit IRC | 21:10 | |
*** spzala has joined #openstack-heat-translator | 21:35 | |
*** spzala has quit IRC | 21:36 | |
*** aloga has quit IRC | 21:37 | |
*** vishwanathj has quit IRC | 21:37 | |
*** topol has quit IRC | 21:37 | |
*** spzala has joined #openstack-heat-translator | 21:40 | |
*** aloga has joined #openstack-heat-translator | 21:40 | |
*** uck has joined #openstack-heat-translator | 21:42 | |
*** vishwanathj has joined #openstack-heat-translator | 21:42 | |
*** topol has joined #openstack-heat-translator | 21:42 | |
*** spzala has quit IRC | 21:47 | |
*** uck has quit IRC | 21:47 | |
*** bobh has joined #openstack-heat-translator | 22:01 | |
*** bobh has quit IRC | 22:05 | |
*** bobh has joined #openstack-heat-translator | 22:08 | |
*** vishwanathj has quit IRC | 22:18 | |
*** bobh has quit IRC | 22:22 | |
*** uck has joined #openstack-heat-translator | 23:44 | |
*** uck has quit IRC | 23:49 | |
*** KanagarajM_ has joined #openstack-heat-translator | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!