opendevreview | jinyuanliu proposed openstack/openstack-helm-infra master: Clean up residual file https://review.opendev.org/c/openstack/openstack-helm-infra/+/798043 | 05:53 |
---|---|---|
opendevreview | OpenStack Proposal Bot proposed openstack/openstack-helm master: Imported Translations from Zanata https://review.opendev.org/c/openstack/openstack-helm/+/798053 | 07:43 |
opendevreview | Susanta gautam proposed openstack/openstack-helm-infra master: Added helm hook for rabbitmq job cluster wait. https://review.opendev.org/c/openstack/openstack-helm-infra/+/798061 | 09:19 |
sgautam | Hello, Can you please check these two patches. They have been added the helm hook for jobs. Reason behind it being, the jobs are failed to upgrade due to field immutability as some manifest are not applied before the job manifests which are required by jobs. Due to this, when upgrading the helm chart, we have to manually delete the jobs before running the helm upgrade. | 09:25 |
sgautam | For mariadb, hook has been added for the job which create user for prometheus exporter: https://review.opendev.org/c/openstack/openstack-helm-infra/+/797899 | 09:25 |
sgautam | For rabbitmq, hook has been added for the job cluster wait: https://review.opendev.org/c/openstack/openstack-helm-infra/+/798061 | 09:25 |
sgautam | I have tested both the patches in my local environment. | 09:25 |
opendevreview | Oleksandr Kozachenko proposed openstack/openstack-helm-images master: Add monasca-notification https://review.opendev.org/c/openstack/openstack-helm-images/+/798002 | 10:39 |
jinyuanliu | sgautam: | 11:11 |
jinyuanliu | we have to manually delete the jobs? Is it OK to add a deletion policy? like "helm.sh/hook-delete-policy": hook-succeeded | 11:15 |
jinyuanliu | Resources created by HOOK are not managed by HELM. What about resource deletion? The manual? | 11:27 |
jinyuanliu | What are the benefits of this? Since the job cannot be upgraded, shall we manually delete it and then upgrade it? Isn't it the same as using hook | 11:29 |
jinyuanliu | Sorry, I am not familiar with hook, could you tell me more about it | 11:30 |
sgautam | The helm upgrade was failing due to some immutable field in job. When we apply the hook, it force job with hook to be applied at the last i.e all the resources are created then only the job with helm hook are applied and waited for completion. Along with this, in helm 3, hook-delete-policy is applied by default which is before-hook-creation which will force the jobs with hook to be deleted before new one is created. This | 12:11 |
sgautam | will solve the problem which we are facing that needs us to delete the job manually before applying again. | 12:11 |
opendevreview | Susanta gautam proposed openstack/openstack-helm-infra master: Added helm hook for rabbitmq job cluster wait. https://review.opendev.org/c/openstack/openstack-helm-infra/+/798061 | 12:13 |
opendevreview | Susanta gautam proposed openstack/openstack-helm-infra master: Added the helm hook for create user job for exporter. https://review.opendev.org/c/openstack/openstack-helm-infra/+/797899 | 12:14 |
sgautam | I have added the hook-delete-policy too so that hook-delete-policy will be present when the chart is applied with helm2 | 12:15 |
opendevreview | David Smith proposed openstack/openstack-helm-infra master: kafka broker hosts should be defined with a comma separated list https://review.opendev.org/c/openstack/openstack-helm-infra/+/798090 | 13:47 |
opendevreview | David Smith proposed openstack/openstack-helm-infra master: kafka broker hosts should be defined with a comma separated list https://review.opendev.org/c/openstack/openstack-helm-infra/+/798090 | 13:51 |
opendevreview | David Smith proposed openstack/openstack-helm-infra master: kafka broker hosts should be defined with a comma separated list https://review.opendev.org/c/openstack/openstack-helm-infra/+/798090 | 14:08 |
opendevreview | Oleksandr Kozachenko proposed openstack/openstack-helm master: add monasca-api(WIP) https://review.opendev.org/c/openstack/openstack-helm/+/771465 | 14:24 |
opendevreview | Merged openstack/openstack-helm-infra master: Clean up residual file https://review.opendev.org/c/openstack/openstack-helm-infra/+/798043 | 15:35 |
opendevreview | Sangeet Gupta proposed openstack/openstack-helm-images master: [WIP] Nagios: Add TLS support to communicate with Prometheus https://review.opendev.org/c/openstack/openstack-helm-images/+/798023 | 16:17 |
opendevreview | Sangeet Gupta proposed openstack/openstack-helm-images master: [WIP] Nagios: Add TLS support to communicate with Prometheus https://review.opendev.org/c/openstack/openstack-helm-images/+/798023 | 16:17 |
opendevreview | Mohammed Naser proposed openstack/openstack-helm master: Fix multidomain support selector https://review.opendev.org/c/openstack/openstack-helm/+/798138 | 17:16 |
mnaser | jinyuanliu, lamt, gagehugo: ^ appreciate revies on that, it is a trivial fix :) | 17:18 |
opendevreview | Oleksandr Kozachenko proposed openstack/openstack-helm-images master: Add monasca-persister https://review.opendev.org/c/openstack/openstack-helm-images/+/798150 | 18:56 |
opendevreview | Merged openstack/openstack-helm-infra master: Ceph OSD Init Improvements https://review.opendev.org/c/openstack/openstack-helm-infra/+/797783 | 21:56 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!