*** ArcTanSusan has quit IRC | 00:07 | |
*** ArcTanSusan has joined #openstack-horizon | 00:13 | |
*** alexpilotti has quit IRC | 00:13 | |
*** sbfox has quit IRC | 00:14 | |
*** ArcTanSusan has quit IRC | 00:25 | |
*** crobertsrh has left #openstack-horizon | 00:26 | |
*** ArcTanSusan has joined #openstack-horizon | 00:26 | |
*** rwsu has quit IRC | 00:42 | |
*** rwsu has joined #openstack-horizon | 00:55 | |
*** rwsu has quit IRC | 00:57 | |
*** rwsu has joined #openstack-horizon | 00:59 | |
*** ayoung_is_a_Dad is now known as ayoung | 01:04 | |
*** Dafna has quit IRC | 01:07 | |
*** amcrn has quit IRC | 01:10 | |
*** ArcTanSusan has quit IRC | 01:10 | |
*** Krast has quit IRC | 01:17 | |
*** Krast has joined #openstack-horizon | 01:17 | |
*** Sukhdev has quit IRC | 01:26 | |
*** Dafna has joined #openstack-horizon | 01:28 | |
*** Dafna has quit IRC | 01:28 | |
*** Dafna has joined #openstack-horizon | 01:29 | |
*** tqtran has quit IRC | 01:44 | |
*** nlahouti has quit IRC | 01:45 | |
*** nlahouti has joined #openstack-horizon | 01:50 | |
*** ArcTanSusan has joined #openstack-horizon | 01:50 | |
*** nlahouti has quit IRC | 01:50 | |
*** cody-somerville has joined #openstack-horizon | 01:55 | |
*** cody-somerville has quit IRC | 01:55 | |
*** cody-somerville has joined #openstack-horizon | 01:55 | |
*** jpomero has quit IRC | 02:09 | |
*** jpomero has joined #openstack-horizon | 02:10 | |
*** clu_ has quit IRC | 02:19 | |
*** ramishra has joined #openstack-horizon | 02:20 | |
*** ArcTanSusan has quit IRC | 02:27 | |
*** jdonalds has joined #openstack-horizon | 02:35 | |
*** cody-somerville has quit IRC | 02:41 | |
*** sbfox has joined #openstack-horizon | 02:57 | |
*** ramishra has quit IRC | 03:00 | |
*** ramishra has joined #openstack-horizon | 03:01 | |
*** samrose has joined #openstack-horizon | 03:05 | |
*** dsneddon has quit IRC | 03:12 | |
*** ayoung has quit IRC | 03:13 | |
*** vkmc has quit IRC | 03:25 | |
*** samrose has quit IRC | 03:26 | |
*** asahlin has quit IRC | 03:42 | |
*** jpomero_ has joined #openstack-horizon | 03:47 | |
*** masco has joined #openstack-horizon | 03:49 | |
*** gugl2 has joined #openstack-horizon | 03:50 | |
*** jdonalds has quit IRC | 03:51 | |
*** jomara_ has joined #openstack-horizon | 03:51 | |
*** radez_g0n3 has quit IRC | 03:52 | |
*** jomara has quit IRC | 03:52 | |
*** mgagne has quit IRC | 03:52 | |
*** mordred has quit IRC | 03:52 | |
*** Dafna has quit IRC | 03:52 | |
*** jay-atl has quit IRC | 03:52 | |
*** gugl has quit IRC | 03:52 | |
*** dguerri`afk has quit IRC | 03:52 | |
*** jpomero has quit IRC | 03:52 | |
*** dguerri has joined #openstack-horizon | 03:52 | |
*** mgagne has joined #openstack-horizon | 03:53 | |
*** Dafna has joined #openstack-horizon | 03:53 | |
*** mgagne is now known as Guest54676 | 03:53 | |
*** jdonalds has joined #openstack-horizon | 03:53 | |
*** radez_g0n3 has joined #openstack-horizon | 03:53 | |
*** mordred has joined #openstack-horizon | 03:53 | |
*** jay-atl has joined #openstack-horizon | 03:54 | |
*** jdonalds has quit IRC | 03:59 | |
*** nlahouti has joined #openstack-horizon | 04:01 | |
*** neelashah has joined #openstack-horizon | 04:02 | |
*** neelashah1 has joined #openstack-horizon | 04:04 | |
*** nlahouti has quit IRC | 04:04 | |
*** dguerri_ has joined #openstack-horizon | 04:06 | |
*** dguerri has quit IRC | 04:07 | |
*** neelashah has quit IRC | 04:07 | |
*** nlahouti has joined #openstack-horizon | 04:17 | |
*** ArcTanSusan has joined #openstack-horizon | 04:26 | |
*** nlahouti has quit IRC | 04:26 | |
*** nlahouti has joined #openstack-horizon | 04:26 | |
*** amcrn has joined #openstack-horizon | 04:46 | |
*** chandankumar has joined #openstack-horizon | 04:51 | |
*** sseago_ has joined #openstack-horizon | 04:58 | |
*** jdonalds has joined #openstack-horizon | 05:05 | |
*** jdonalds has quit IRC | 05:07 | |
*** jdonalds has joined #openstack-horizon | 05:10 | |
*** sunilm has joined #openstack-horizon | 05:13 | |
*** neelashah1 has quit IRC | 05:14 | |
*** sayan has joined #openstack-horizon | 05:18 | |
*** ArcTanSusan has quit IRC | 05:20 | |
*** amcrn has quit IRC | 05:21 | |
*** ArcTanSusan has joined #openstack-horizon | 05:23 | |
*** arborism has joined #openstack-horizon | 05:24 | |
*** rdopieralski has joined #openstack-horizon | 05:25 | |
*** tnovacik has joined #openstack-horizon | 05:32 | |
*** arborism has quit IRC | 05:35 | |
*** ArcTanSusan has quit IRC | 05:37 | |
*** arborism has joined #openstack-horizon | 05:37 | |
*** amotoki has joined #openstack-horizon | 05:38 | |
*** chandankumar has quit IRC | 05:40 | |
*** Sukhdev has joined #openstack-horizon | 05:43 | |
*** pawels has joined #openstack-horizon | 05:58 | |
*** chandankumar has joined #openstack-horizon | 06:02 | |
*** arborism has quit IRC | 06:03 | |
*** pawels has quit IRC | 06:12 | |
*** Sukhdev has quit IRC | 06:13 | |
*** ramishra has quit IRC | 06:14 | |
*** ramishra has joined #openstack-horizon | 06:14 | |
*** tnovacik has quit IRC | 06:15 | |
*** k4n0 has joined #openstack-horizon | 06:30 | |
*** masco has quit IRC | 06:33 | |
*** masco has joined #openstack-horizon | 06:34 | |
*** ramishra has quit IRC | 06:40 | |
*** jprovazn has joined #openstack-horizon | 06:42 | |
*** bvandenh has joined #openstack-horizon | 06:49 | |
*** ArcTanSusan has joined #openstack-horizon | 06:49 | |
*** alexpilotti has joined #openstack-horizon | 06:56 | |
*** arborism has joined #openstack-horizon | 06:57 | |
*** jtomasek_ has joined #openstack-horizon | 07:01 | |
*** tnovacik has joined #openstack-horizon | 07:04 | |
*** jdonalds has quit IRC | 07:05 | |
*** jdonalds has joined #openstack-horizon | 07:08 | |
*** jdonalds has quit IRC | 07:08 | |
*** jdonalds has joined #openstack-horizon | 07:08 | |
*** jdonalds has quit IRC | 07:10 | |
*** Longgeek has joined #openstack-horizon | 07:13 | |
*** cedrics has joined #openstack-horizon | 07:14 | |
*** nlahouti has quit IRC | 07:15 | |
*** MaxV has joined #openstack-horizon | 07:19 | |
*** sunilm_ has joined #openstack-horizon | 07:24 | |
*** ArcTanSusan has quit IRC | 07:26 | |
*** jcoufal has joined #openstack-horizon | 07:28 | |
*** arborism has quit IRC | 07:30 | |
*** sayan has quit IRC | 07:31 | |
*** romainh has joined #openstack-horizon | 07:31 | |
*** ArcTanSusan has joined #openstack-horizon | 07:32 | |
*** sbfox has quit IRC | 07:46 | |
*** Longgeek has quit IRC | 07:46 | |
*** Longgeek has joined #openstack-horizon | 07:46 | |
*** sunilm_ has quit IRC | 07:58 | |
*** regebro has quit IRC | 07:58 | |
*** regebro has joined #openstack-horizon | 07:58 | |
*** Longgeek has quit IRC | 08:00 | |
*** Longgeek has joined #openstack-horizon | 08:00 | |
*** nlahouti has joined #openstack-horizon | 08:03 | |
*** Longgeek has quit IRC | 08:04 | |
*** Longgeek has joined #openstack-horizon | 08:05 | |
*** alexpilotti has quit IRC | 08:06 | |
*** nlahouti has quit IRC | 08:07 | |
*** qba73 has joined #openstack-horizon | 08:10 | |
rdopieralski | regebro: got a moment? | 08:10 |
---|---|---|
rdopieralski | regebro: so the correct way to remove those titles from tables is to make your own datatable template, that inherits from the original one, but modifies the caption block | 08:11 |
rdopieralski | regebro: what do you think? | 08:12 |
*** MaxV has quit IRC | 08:17 | |
*** MaxV has joined #openstack-horizon | 08:17 | |
*** tnovacik has quit IRC | 08:19 | |
rdopieralski | dear Horizon reviewers, since we are unbundling some of the javascript libraries from horizon, we have more repositories to review the patches in them, see this link: https://review.openstack.org/#/q/project:%255Estackforge/xstatic.*+status:open,n,z | 08:19 |
*** MaxV has quit IRC | 08:22 | |
*** tnovacik has joined #openstack-horizon | 08:24 | |
*** jpich has joined #openstack-horizon | 08:25 | |
*** e0ne has joined #openstack-horizon | 08:25 | |
*** wuhg has joined #openstack-horizon | 08:27 | |
*** MaxV has joined #openstack-horizon | 08:28 | |
rdopieralski | jpich: successfully failed! https://review.openstack.org/#/c/103123/ | 08:31 |
jpich | rdopieralski: Super sweet! It's failing thanks to the http302 flavor thing haha :D This is great, thanks for looking again into it | 08:34 |
jpich | I guess I should look at removing that trace today so we can merge your patch of awesomeness * updates TODO * | 08:35 |
*** masco has quit IRC | 08:37 | |
regebro | rdopieralski: No, then you have a custom template that you need to keep in sync. | 08:40 |
regebro | Any differences between the custom template and the original one are unclear. Is that intentional? Or it is out of sync? | 08:41 |
rdopieralski | regebro: the custom template has only your change, so it's obvious that it's intentional | 08:42 |
regebro | rdopieralski: No, the custom template will have, at some time in the future, multiple differences. It's not obvious which differences are intentional. | 08:44 |
*** sambetts has joined #openstack-horizon | 08:44 | |
rdopieralski | regebro: how will it grow the additional diffrences? | 08:44 |
regebro | we're discussing this in three different place now, let's consolidate. :) | 08:51 |
rdopieralski | here is the best spot, I think | 08:52 |
rdopieralski | so my proposal is https://review.openstack.org/114170 | 08:53 |
rdopieralski | I think it solves the problem elegantly | 08:53 |
*** masco has joined #openstack-horizon | 08:53 | |
rdopieralski | and in reusable way | 08:53 |
*** sayan has joined #openstack-horizon | 08:58 | |
*** DaveJ__ has joined #openstack-horizon | 09:02 | |
*** nlahouti has joined #openstack-horizon | 09:03 | |
*** nlahouti has quit IRC | 09:08 | |
regebro | I disagree. | 09:08 |
*** ArcTanSusan has quit IRC | 09:09 | |
*** vkmc has joined #openstack-horizon | 09:10 | |
*** alexpilotti has joined #openstack-horizon | 09:12 | |
*** tnovacik_ has joined #openstack-horizon | 09:14 | |
*** tnovacik has quit IRC | 09:14 | |
*** tnovacik_ is now known as tnovacik | 09:16 | |
*** akrivoka has joined #openstack-horizon | 09:22 | |
*** dhubbard has quit IRC | 09:29 | |
*** tosky has joined #openstack-horizon | 09:44 | |
*** ramishra has joined #openstack-horizon | 09:45 | |
*** alexpilotti_ has joined #openstack-horizon | 09:53 | |
*** alexpilotti has quit IRC | 09:55 | |
*** alexpilotti_ is now known as alexpilotti | 09:55 | |
*** alexpilotti has quit IRC | 09:57 | |
*** jab has joined #openstack-horizon | 09:59 | |
*** jab has joined #openstack-horizon | 09:59 | |
*** jab is now known as bradjones | 10:03 | |
*** nlahouti has joined #openstack-horizon | 10:04 | |
*** nlahouti has quit IRC | 10:08 | |
*** Longgeek has quit IRC | 10:10 | |
*** Longgeek has joined #openstack-horizon | 10:11 | |
*** sayan has quit IRC | 10:11 | |
*** Longgeek has quit IRC | 10:14 | |
regebro | rdopieralski: I got problems with that patch if you did not have a css_class attribute. I suggested a fix. | 10:18 |
*** chandankumar has quit IRC | 10:19 | |
*** ramishra has quit IRC | 10:19 | |
*** ramishra has joined #openstack-horizon | 10:21 | |
rdopieralski | regebro: argh, copy-paste bug | 10:22 |
rdopieralski | regebro: thanks | 10:23 |
regebro | rdopieralski: So I'll soon have a patch available that depends on this horizon patch (that's how I tested it). | 10:24 |
regebro | Can I mark the patch as dependent in some clever way? | 10:24 |
regebro | Or do I just add it to the commit message as text? | 10:24 |
rdopieralski | regebro: no, that is not possible | 10:26 |
rdopieralski | regebro: that's why I suggested wrapping it in a div with a class for now | 10:26 |
rdopieralski | regebro: and meaybe leaving a TODO in the code, with a link to this patch | 10:26 |
regebro | rdopieralski: OK, I'll add the divs. | 10:27 |
rdopieralski | regebro: by the way, if you need a comment in the templates, use the comment tag, rather than the html comments -- this way it's not rendered and sent to the browser | 10:27 |
regebro | Right, I forget about that one. | 10:27 |
*** e0ne has quit IRC | 10:27 | |
*** ramishra has quit IRC | 10:30 | |
*** ramishra has joined #openstack-horizon | 10:31 | |
*** chandankumar has joined #openstack-horizon | 10:31 | |
*** nlahouti has joined #openstack-horizon | 10:35 | |
*** Longgeek has joined #openstack-horizon | 10:37 | |
regebro | My sister's name is Meta. This makes developing in Django slightly more silly. | 10:39 |
*** nlahouti has quit IRC | 10:39 | |
*** ramishra has quit IRC | 10:51 | |
*** sayan has joined #openstack-horizon | 10:52 | |
*** masco has quit IRC | 10:59 | |
*** bvandenh has quit IRC | 11:00 | |
*** bvandenh has joined #openstack-horizon | 11:06 | |
*** MaxV has quit IRC | 11:17 | |
*** MaxV has joined #openstack-horizon | 11:17 | |
*** ramishra_ has joined #openstack-horizon | 11:18 | |
*** e0ne has joined #openstack-horizon | 11:20 | |
*** MaxV has quit IRC | 11:22 | |
*** ramishra_ has quit IRC | 11:31 | |
*** Krast has quit IRC | 11:31 | |
*** julim has joined #openstack-horizon | 11:33 | |
*** julim has quit IRC | 11:34 | |
*** ramishra_ has joined #openstack-horizon | 11:35 | |
*** lblanchard has joined #openstack-horizon | 11:36 | |
rdopieralski | jpich: I wonder if the fact that those cinder logs are DEBUG is why they are not getting caught on the gate | 11:40 |
*** alexpilotti has joined #openstack-horizon | 11:43 | |
*** tosky has quit IRC | 11:45 | |
*** ramishra_ has quit IRC | 11:47 | |
*** amotoki has quit IRC | 11:48 | |
*** MaxV has joined #openstack-horizon | 11:49 | |
*** MaxV has quit IRC | 11:50 | |
*** MaxV has joined #openstack-horizon | 11:51 | |
*** leeuwenrjj has quit IRC | 11:53 | |
*** MaxV has quit IRC | 11:55 | |
*** MaxV has joined #openstack-horizon | 11:55 | |
jpich | rdopieralski: Possibly so, it's definitely not the most ideal level to try and catch! | 11:57 |
*** pawels has joined #openstack-horizon | 12:00 | |
*** e0ne has quit IRC | 12:10 | |
*** e0ne has joined #openstack-horizon | 12:10 | |
*** julim has joined #openstack-horizon | 12:15 | |
*** tosky has joined #openstack-horizon | 12:22 | |
*** stpierre has joined #openstack-horizon | 12:26 | |
*** bvandenh has quit IRC | 12:31 | |
*** tnovacik has quit IRC | 12:32 | |
*** nlahouti has joined #openstack-horizon | 12:38 | |
*** bvandenh has joined #openstack-horizon | 12:41 | |
*** nlahouti has quit IRC | 12:43 | |
*** tmazur has joined #openstack-horizon | 12:50 | |
*** teju has joined #openstack-horizon | 12:53 | |
*** pawels1 has joined #openstack-horizon | 13:01 | |
*** pawels has quit IRC | 13:04 | |
rdopieralski | jpich: how are you testing for the cinderclient? | 13:06 |
rdopieralski | jpich: I think the exception is actually being silenced on the horizon side | 13:07 |
jpich | rdopieralski: I'm manually reverting that patch I linked to (one of the recent cinder traces issue) | 13:07 |
jpich | Yeah, I was looking at the Cinder client code, they use debug level statement because they do retries on connection errors | 13:07 |
jpich | and then when all the retries fail they finally throw a proper exception | 13:08 |
rdopieralski | exactly | 13:08 |
jpich | that we catch gracefully on the horizon side | 13:08 |
*** jpomero_ has quit IRC | 13:08 | |
rdopieralski | and gracefully pretend that it didn't happen | 13:08 |
jpich | and that's probably happening for the other clients too, that don't have any debug statements on retries - we just don't know we forgot to mock them and that we're testing a slightly different path | 13:09 |
jpich | beh | 13:09 |
rdopieralski | I say we are lucky they even logged anything | 13:09 |
rdopieralski | yeah | 13:09 |
*** nlahouti has joined #openstack-horizon | 13:09 | |
jpich | rdopieralski: It looks like before we used to mock httplib2 directly to catch these at the root: https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/helpers.py#L124 | 13:13 |
*** nlahouti has quit IRC | 13:13 | |
jpich | I think projects switched from httplib2 to requests later on | 13:15 |
rdopieralski | so we should just mock requests the same way | 13:15 |
jpich | That seems promising. I'll have a look around the clients to see if any still has a dependency on httplib2 | 13:16 |
rdopieralski | we can have oth patched, no? | 13:17 |
rdopieralski | both | 13:17 |
jpich | True! | 13:18 |
rdopieralski | I know! Let's just patch socket.socket! | 13:18 |
jpich | patch all the things \o/ | 13:18 |
*** jcoufal has quit IRC | 13:19 | |
*** jcoufal has joined #openstack-horizon | 13:19 | |
rdopieralski | patch all my socks | 13:20 |
*** jprovazn has quit IRC | 13:21 | |
*** akrivoka has quit IRC | 13:22 | |
*** akrivoka has joined #openstack-horizon | 13:23 | |
*** jprovazn has joined #openstack-horizon | 13:25 | |
*** peristeri has joined #openstack-horizon | 13:26 | |
*** jpomero has joined #openstack-horizon | 13:30 | |
*** neelashah has joined #openstack-horizon | 13:36 | |
*** bradjones has quit IRC | 13:38 | |
*** nlahouti has joined #openstack-horizon | 13:40 | |
*** doug-fish has joined #openstack-horizon | 13:40 | |
*** nlahouti has quit IRC | 13:44 | |
*** jthopkin has quit IRC | 13:46 | |
*** vijendar has joined #openstack-horizon | 13:46 | |
*** romainh has left #openstack-horizon | 13:49 | |
*** pawels1 has quit IRC | 13:51 | |
*** tosky has quit IRC | 13:55 | |
*** bvandenh has quit IRC | 14:00 | |
*** jab has joined #openstack-horizon | 14:03 | |
*** jab has joined #openstack-horizon | 14:03 | |
*** sayan has quit IRC | 14:09 | |
*** amotoki has joined #openstack-horizon | 14:12 | |
*** jasondotstar has joined #openstack-horizon | 14:13 | |
*** pawels has joined #openstack-horizon | 14:19 | |
*** sayan has joined #openstack-horizon | 14:23 | |
*** rdopieralski has quit IRC | 14:25 | |
*** pawels has quit IRC | 14:28 | |
*** tosky has joined #openstack-horizon | 14:29 | |
*** nlahouti has joined #openstack-horizon | 14:33 | |
*** nlahouti has quit IRC | 14:38 | |
*** k4n0 has quit IRC | 14:45 | |
*** david-lyle has joined #openstack-horizon | 14:50 | |
*** ddieterly has joined #openstack-horizon | 15:00 | |
*** jprovazn has quit IRC | 15:05 | |
*** jcoufal has quit IRC | 15:06 | |
*** jcoufal has joined #openstack-horizon | 15:06 | |
*** tmazur has quit IRC | 15:07 | |
*** sayan has quit IRC | 15:07 | |
*** akrivoka has quit IRC | 15:09 | |
*** akrivoka has joined #openstack-horizon | 15:10 | |
*** jcoufal has quit IRC | 15:10 | |
*** nlahouti has joined #openstack-horizon | 15:11 | |
*** nlahouti_ has joined #openstack-horizon | 15:12 | |
*** david-lyle has quit IRC | 15:12 | |
*** david-lyle has joined #openstack-horizon | 15:13 | |
*** nlahouti has quit IRC | 15:16 | |
*** colinmcnamara has joined #openstack-horizon | 15:16 | |
*** david-lyle has quit IRC | 15:17 | |
*** david-lyle has joined #openstack-horizon | 15:23 | |
*** ddieterly has quit IRC | 15:25 | |
*** teju has left #openstack-horizon | 15:27 | |
*** tnovacik has joined #openstack-horizon | 15:28 | |
*** MaxV has quit IRC | 15:29 | |
*** lblanchard has quit IRC | 15:33 | |
*** lblanchard has joined #openstack-horizon | 15:34 | |
*** tnovacik has quit IRC | 15:36 | |
*** tnovacik has joined #openstack-horizon | 15:38 | |
*** colinmcnamara has quit IRC | 15:39 | |
*** colinmcnamara has joined #openstack-horizon | 15:41 | |
*** cody-somerville has joined #openstack-horizon | 15:43 | |
*** colinmcnamara has quit IRC | 15:47 | |
*** tnovacik has quit IRC | 15:50 | |
*** Longgeek has quit IRC | 15:52 | |
*** ayoung has joined #openstack-horizon | 15:55 | |
*** e0ne has quit IRC | 15:59 | |
*** david-lyle has quit IRC | 16:01 | |
*** akerr has joined #openstack-horizon | 16:02 | |
*** akerr has left #openstack-horizon | 16:03 | |
*** AlkaD has joined #openstack-horizon | 16:03 | |
*** david-lyle has joined #openstack-horizon | 16:03 | |
*** jthopkin has joined #openstack-horizon | 16:05 | |
*** sbfox has joined #openstack-horizon | 16:06 | |
*** jay-atl has quit IRC | 16:13 | |
*** ArcTanSusan has joined #openstack-horizon | 16:15 | |
*** ayoung is now known as ayoung_lunch | 16:15 | |
*** AlkaD has quit IRC | 16:17 | |
*** dhubbard has joined #openstack-horizon | 16:18 | |
*** AlkaD has joined #openstack-horizon | 16:18 | |
*** absubram has joined #openstack-horizon | 16:19 | |
*** AlkaD has quit IRC | 16:22 | |
*** jab has quit IRC | 16:23 | |
*** jpich has quit IRC | 16:26 | |
*** sayan has joined #openstack-horizon | 16:29 | |
*** jcoufal has joined #openstack-horizon | 16:30 | |
*** Guest54676 is now known as mgagne | 16:30 | |
*** mgagne has joined #openstack-horizon | 16:30 | |
absubram | hi.. I know everyone is busy with j-3.. but if possible.. any core reviewers for https://review.openstack.org/#/c/78708/ would be appreciated.. cheers :) | 16:30 |
*** colinmcnamara has joined #openstack-horizon | 16:31 | |
*** colinmcnamara has quit IRC | 16:31 | |
*** jab has joined #openstack-horizon | 16:33 | |
*** jab has joined #openstack-horizon | 16:33 | |
*** colinmcnamara has joined #openstack-horizon | 16:33 | |
gugl2 | hi...same here...please review https://review.openstack.org/#/c/106512/ thanks! | 16:34 |
absubram | I'll review yours if you review mine gugl2 :) | 16:35 |
*** akrivoka has quit IRC | 16:35 | |
gugl2 | absubram, ok, deal! | 16:35 |
*** ramishra has joined #openstack-horizon | 16:37 | |
*** colinmcnamara has quit IRC | 16:41 | |
*** ramishra has quit IRC | 16:41 | |
gugl2 | absubram, checked your review...it is the area I am not familiar with...but I will give it a try. Do you mind if I send you an email for questions? | 16:41 |
*** tqtran has joined #openstack-horizon | 16:43 | |
absubram | gugl2: thanks.. no problem.. you can ask questions in the review also, no worries.. it's why it's there for :).. I'm also looking at your review being not too familiar with cinder specifically, but I see most code is in openstack_dashboards which I am familiar with.. so hope to address the review by today.. it is a slightly big patch :) | 16:43 |
gugl2 | absubram, okie dokie, I will do it by today as well. thansks. | 16:45 |
*** jtriley has quit IRC | 16:45 | |
*** chandankumar has quit IRC | 16:46 | |
*** david-lyle has quit IRC | 16:50 | |
*** david-lyle has joined #openstack-horizon | 16:50 | |
*** jgriffith has joined #openstack-horizon | 16:50 | |
*** jtriley has joined #openstack-horizon | 16:51 | |
*** david-lyle has quit IRC | 16:53 | |
*** david-lyle has joined #openstack-horizon | 16:53 | |
*** david-lyle has quit IRC | 16:54 | |
*** david-lyle has joined #openstack-horizon | 16:54 | |
*** harlowja has joined #openstack-horizon | 16:56 | |
*** cedrics has quit IRC | 17:00 | |
*** AlkaD has joined #openstack-horizon | 17:02 | |
*** chandankumar has joined #openstack-horizon | 17:03 | |
*** qba73 has quit IRC | 17:06 | |
*** radez_g0n3 is now known as radez | 17:10 | |
*** amotoki has quit IRC | 17:13 | |
*** ArcTanSusan has quit IRC | 17:16 | |
*** wuhg has quit IRC | 17:22 | |
*** Sukhdev has joined #openstack-horizon | 17:24 | |
*** tosky has quit IRC | 17:30 | |
*** jay-atl has joined #openstack-horizon | 17:31 | |
*** jay-atl has quit IRC | 17:32 | |
*** sayan has quit IRC | 17:34 | |
*** clu_ has joined #openstack-horizon | 17:34 | |
absubram | david-lyle: quick question about the J-3 freeze we have for today.. I have code review out for the BP I'm working on (the IPv6 one).. and Jenkins has +1'd it.. anything else that needs to be done before the deadline? | 17:34 |
*** sayali has joined #openstack-horizon | 17:36 | |
*** ramishra has joined #openstack-horizon | 17:37 | |
david-lyle | absubram: link for the bp? | 17:41 |
*** ramishra has quit IRC | 17:42 | |
absubram | david-lyle: https://blueprints.launchpad.net/openstack/?searchtext=neutron-subnet-mode-support | 17:43 |
absubram | you've approved it for J-3 :).. this is the one that got pushed out from Icehouse | 17:43 |
*** AlkaD has quit IRC | 17:44 | |
absubram | there's enough neutron support now for this to be ok from Horizon.. and Akihiro had also pinged me last week to push this out | 17:44 |
absubram | but I still do need the couple guys from Neutron who've signed up for the review - Henry and Sean to test it out and give their ok.. Hopefully Akihiro's too | 17:45 |
absubram | My IPv6 testing with this seems to be ok though | 17:45 |
absubram | would def like your feedback too if you get any time to give this a shot | 17:46 |
*** e0ne has joined #openstack-horizon | 17:46 | |
david-lyle | absubram: you're set as far a the deadline goes | 17:47 |
david-lyle | s/a/as/ | 17:47 |
*** ArcTanSusan has joined #openstack-horizon | 17:47 | |
*** dsneddon has joined #openstack-horizon | 17:47 | |
absubram | great.. thanks! | 17:49 |
*** regebro has quit IRC | 17:50 | |
*** ArcTanSusan has quit IRC | 17:52 | |
*** tosky has joined #openstack-horizon | 17:53 | |
*** ArcTanSusan has joined #openstack-horizon | 17:55 | |
*** david-lyle has quit IRC | 17:55 | |
*** e0ne has quit IRC | 17:55 | |
*** david-lyle has joined #openstack-horizon | 17:56 | |
*** jpomero has quit IRC | 17:57 | |
*** Sukhdev has quit IRC | 18:00 | |
*** Sukhdev_ has joined #openstack-horizon | 18:00 | |
*** david-lyle has quit IRC | 18:00 | |
*** jpomero has joined #openstack-horizon | 18:01 | |
*** david-lyle has joined #openstack-horizon | 18:02 | |
*** radez is now known as radez_g0n3 | 18:06 | |
*** MaxV has joined #openstack-horizon | 18:15 | |
*** sbfox has quit IRC | 18:15 | |
*** MaxV has quit IRC | 18:18 | |
*** MaxV has joined #openstack-horizon | 18:19 | |
*** chandankumar has quit IRC | 18:22 | |
*** ayoung_lunch has quit IRC | 18:22 | |
*** jtomasek_ has quit IRC | 18:23 | |
*** sbfox has joined #openstack-horizon | 18:33 | |
*** MaxV has quit IRC | 18:33 | |
*** e0ne has joined #openstack-horizon | 18:36 | |
*** ramishra has joined #openstack-horizon | 18:38 | |
*** ramishra has quit IRC | 18:42 | |
*** jpomero has quit IRC | 18:46 | |
*** e0ne has quit IRC | 18:48 | |
*** jay-atl has joined #openstack-horizon | 18:50 | |
*** sambetts has quit IRC | 18:53 | |
*** david-lyle has quit IRC | 18:59 | |
*** jpomero has joined #openstack-horizon | 19:00 | |
*** david-lyle has joined #openstack-horizon | 19:02 | |
*** ArcTanSusan has quit IRC | 19:05 | |
*** sbfox has quit IRC | 19:07 | |
*** morganbird has joined #openstack-horizon | 19:17 | |
*** colinmcnamara has joined #openstack-horizon | 19:22 | |
*** colinmcnamara has quit IRC | 19:22 | |
*** sbfox has joined #openstack-horizon | 19:27 | |
*** sbfox1 has joined #openstack-horizon | 19:30 | |
*** colinmcnamara has joined #openstack-horizon | 19:31 | |
*** sbfox has quit IRC | 19:32 | |
*** denis_makogon_ has joined #openstack-horizon | 19:35 | |
*** tnovacik has joined #openstack-horizon | 19:36 | |
*** ArcTanSusan has joined #openstack-horizon | 19:38 | |
*** ramishra has joined #openstack-horizon | 19:39 | |
morganbird | Hi all, I'm looking for info on current recommendation for third party authentication for horizon. I've got a SAML IdP working with shibboleth and federated keystone but can't find much on external or federated auth for horizon. | 19:42 |
morganbird | Is there a working prototype somewhere? | 19:42 |
*** ramishra has quit IRC | 19:44 | |
*** colinmcnamara has quit IRC | 19:48 | |
*** Sukhdev_ has quit IRC | 20:00 | |
*** alexpilotti has quit IRC | 20:09 | |
*** rebelagentm has quit IRC | 20:11 | |
*** rebelagentm has joined #openstack-horizon | 20:12 | |
*** jthopkin has quit IRC | 20:17 | |
*** jasondotstar has quit IRC | 20:19 | |
*** stpierre has quit IRC | 20:25 | |
*** tnovacik has quit IRC | 20:38 | |
*** jthopkin has joined #openstack-horizon | 20:39 | |
*** ramishra has joined #openstack-horizon | 20:40 | |
*** ramishra has quit IRC | 20:44 | |
*** morganbird has quit IRC | 20:48 | |
*** sseago_ has quit IRC | 20:55 | |
*** sseago__ has joined #openstack-horizon | 20:55 | |
*** sseago_ has joined #openstack-horizon | 20:56 | |
*** jpomero has quit IRC | 20:56 | |
*** jcoufal has quit IRC | 20:58 | |
*** sseago__ has quit IRC | 21:00 | |
*** jthopkin has quit IRC | 21:03 | |
*** jthopkin has joined #openstack-horizon | 21:08 | |
*** wchrisj has joined #openstack-horizon | 21:11 | |
wchrisj | Could someone advise as to the correct approach for something? | 21:16 |
wchrisj | I'm doing a "tables.BatchAction" to delete an entry in a table... | 21:16 |
wchrisj | I'd like to (somehow) give the process 20-30 secs for the delete to occur | 21:17 |
wchrisj | What is the "horizon" way to do something like that? | 21:18 |
wchrisj | ATM, the delete comes back and the entry in still in the table | 21:19 |
wchrisj | Should I perhaps just kick off JS to remove the table entry? | 21:20 |
*** ArcTanSusan has quit IRC | 21:24 | |
*** peristeri has quit IRC | 21:30 | |
*** ArcTanSusan has joined #openstack-horizon | 21:32 | |
*** neelashah has quit IRC | 21:41 | |
gugl2 | absubram, checking your review...some questions: I enabled router panel..I aslo enable a bunch of items in OPENSTACK_NEUTRON_NETWORK = { | 21:43 |
gugl2 | in local_settings.py...I only see router panel shows up. I am using devstack which uses nova-network by default, I guess I need to turn on neuron network...I googled...all kinds suggestion...trying. Do you have a good doc to share? | 21:43 |
absubram | gugl2: hi.. you only need to turn on _40_router.py.. in openstack_dashboard/enabled | 21:46 |
absubram | you shouldn't have to change anything else anywhere | 21:46 |
absubram | and yes.. in devstack you would have to use neutron :( | 21:46 |
david-lyle | wchrisj, that's a current limitation | 21:47 |
gugl2 | hmm...the router panel shows up....don't see sub panel | 21:47 |
absubram | I can send you a localrc via dropbox if you'd like | 21:47 |
david-lyle | wchrisj, if you are doing status updates, that row would disappear when it's no longer in the list | 21:47 |
gugl2 | our devstak is using n-net.... | 21:47 |
absubram | if the router dashboard shows up.. you should see a nexus1000v panel | 21:47 |
absubram | if you have enabled _40_router.py that is | 21:48 |
wchrisj | Thanks david-lyle:, so best bet would be to enable status updates...? Is that basically handles via the "ajax=True"? | 21:49 |
gugl2 | I guess it should based on the code...but I don't see the nexus1000v subpanel...ok, let me try again | 21:49 |
david-lyle | wchrisj, no, there's more to it than that | 21:50 |
david-lyle | projects/instances provides a reasonable example | 21:50 |
wchrisj | ok - I can research david-lyle: | 21:50 |
wchrisj | thanks for the direction | 21:50 |
david-lyle | np | 21:50 |
david-lyle | wchrisj: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L610 | 21:51 |
david-lyle | have to add the method to the table metadata too https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L844 | 21:52 |
david-lyle | and 845 | 21:52 |
wchrisj | yeah - found that too | 21:53 |
wchrisj | We are doing similar for our ALS clusters - just wasnt sure that was the best way to handle that | 21:54 |
wchrisj | good to know | 21:54 |
wchrisj | thanks again david-lyle: | 21:54 |
*** ramishra has joined #openstack-horizon | 21:54 | |
absubram | gugl2: how recent is your branch? :).. there was a diff that got merged about 2-3 weeks back that got rid of everything "router" in local_settings.py and now the only mechanism is via _40_router.py | 21:55 |
absubram | please let me know if you're still hitting issues | 21:56 |
gugl2 | absubram, just confirmed, we are using nova network not neutron | 21:58 |
absubram | ok.. that's fine.. so long as you aren't creating a network.. the page should still display the same :) | 21:58 |
gugl2 | I usually pull it fresh everyday | 21:58 |
absubram | oh but this is a bug with update.. | 21:59 |
gugl2 | oh... | 21:59 |
absubram | ok.. so then you will only have to edit _40_router.py to turn that on | 21:59 |
*** ramishra has quit IRC | 21:59 | |
gugl2 | ok | 21:59 |
tqtran | im sort of block on next couple of patches until we have a way to invoke init code individually. could a couple of cores tak a look at https://review.openstack.org/#/c/108144/ | 22:01 |
*** vijendar has quit IRC | 22:14 | |
*** david-lyle has quit IRC | 22:15 | |
*** jthopkin has quit IRC | 22:16 | |
*** david-lyle has joined #openstack-horizon | 22:23 | |
*** david-lyle has quit IRC | 22:29 | |
*** david-lyle has joined #openstack-horizon | 22:29 | |
*** jthopkin has joined #openstack-horizon | 22:31 | |
*** sayali has quit IRC | 22:43 | |
*** sayali has joined #openstack-horizon | 22:49 | |
*** amcrn has joined #openstack-horizon | 22:54 | |
*** ramishra has joined #openstack-horizon | 22:55 | |
*** sbfox1 has quit IRC | 22:56 | |
*** sbfox has joined #openstack-horizon | 22:58 | |
*** ramishra has quit IRC | 22:59 | |
*** denis_makogon_ has quit IRC | 23:06 | |
*** jthopkin has quit IRC | 23:07 | |
*** tosky has quit IRC | 23:10 | |
*** absubram has quit IRC | 23:13 | |
*** jpomero has joined #openstack-horizon | 23:16 | |
*** sbfox has quit IRC | 23:17 | |
*** DaveJ__ has quit IRC | 23:18 | |
*** vkmc has quit IRC | 23:19 | |
*** sbfox has joined #openstack-horizon | 23:22 | |
*** sbfox has quit IRC | 23:24 | |
*** ArcTanSusan has quit IRC | 23:33 | |
*** wchrisj has quit IRC | 23:33 | |
*** ArcTanSusan has joined #openstack-horizon | 23:37 | |
*** vkmc has joined #openstack-horizon | 23:38 | |
*** david-lyle has quit IRC | 23:51 | |
*** david-lyle has joined #openstack-horizon | 23:51 | |
*** ArcTanSusan has quit IRC | 23:53 | |
*** david-lyle has quit IRC | 23:56 | |
*** ramishra has joined #openstack-horizon | 23:56 | |
*** ArcTanSusan has joined #openstack-horizon | 23:57 | |
*** Sukhdev has joined #openstack-horizon | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!