*** ArcTanSusan has quit IRC | 00:01 | |
*** jpomero has joined #openstack-horizon | 00:01 | |
*** ArcTanSusan has joined #openstack-horizon | 00:11 | |
*** peristeri has quit IRC | 00:12 | |
*** gokrokve has joined #openstack-horizon | 00:12 | |
*** gokrokve_ has joined #openstack-horizon | 00:33 | |
*** gokrokve has quit IRC | 00:34 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 00:39 | |
*** nlahouti has left #openstack-horizon | 00:47 | |
*** nlahouti has joined #openstack-horizon | 00:47 | |
*** gokrokve_ has quit IRC | 00:51 | |
*** nlahouti has quit IRC | 00:56 | |
*** amerine has quit IRC | 01:00 | |
*** colinmcnamara has quit IRC | 01:03 | |
*** lnxnut has joined #openstack-horizon | 01:06 | |
*** lcheng has quit IRC | 01:07 | |
*** lnxnut has quit IRC | 01:16 | |
*** gokrokve has joined #openstack-horizon | 01:17 | |
*** neelashah has joined #openstack-horizon | 01:27 | |
*** neelashah1 has joined #openstack-horizon | 01:28 | |
*** neelashah has quit IRC | 01:31 | |
*** vkmc has quit IRC | 01:32 | |
*** prasoon has joined #openstack-horizon | 01:40 | |
*** prasoon has quit IRC | 01:44 | |
*** Sukhdev has joined #openstack-horizon | 01:50 | |
*** Sukhdev has quit IRC | 01:51 | |
*** tqtran has quit IRC | 02:02 | |
*** gokrokve_ has joined #openstack-horizon | 02:14 | |
*** gokrokve_ has quit IRC | 02:16 | |
*** gokrokve has quit IRC | 02:18 | |
*** gokrokve has joined #openstack-horizon | 02:21 | |
*** gokrokve has quit IRC | 02:25 | |
*** amerine has joined #openstack-horizon | 02:27 | |
*** amerine has quit IRC | 02:32 | |
*** nlahouti has joined #openstack-horizon | 02:36 | |
*** amcrn has quit IRC | 02:38 | |
*** sbfox has quit IRC | 02:39 | |
*** david-lyle has joined #openstack-horizon | 02:39 | |
*** prasoon has joined #openstack-horizon | 02:40 | |
*** nlahouti has quit IRC | 02:43 | |
*** nlahouti has joined #openstack-horizon | 02:43 | |
*** prasoon has quit IRC | 02:45 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 02:46 | |
*** harlowja is now known as harlowja_away | 02:52 | |
*** dsneddon has quit IRC | 03:20 | |
*** nlahouti has quit IRC | 03:24 | |
*** dsneddon has joined #openstack-horizon | 03:27 | |
*** amerine has joined #openstack-horizon | 03:28 | |
*** amerine has quit IRC | 03:33 | |
*** prasoon has joined #openstack-horizon | 03:35 | |
*** nlahouti has joined #openstack-horizon | 03:40 | |
*** sbfox has joined #openstack-horizon | 03:42 | |
*** radez is now known as radez_g0n3 | 03:46 | |
*** lcheng has joined #openstack-horizon | 03:46 | |
*** Sukhdev has joined #openstack-horizon | 03:52 | |
*** tzumainn has quit IRC | 04:18 | |
*** sbfox has quit IRC | 04:31 | |
*** sbfox has joined #openstack-horizon | 04:38 | |
*** ramishra has joined #openstack-horizon | 04:47 | |
*** amotoki has joined #openstack-horizon | 04:56 | |
*** ramishra has quit IRC | 04:58 | |
*** ramishra has joined #openstack-horizon | 05:01 | |
*** ramishra has quit IRC | 05:07 | |
*** ramishra has joined #openstack-horizon | 05:08 | |
*** chandankumar has joined #openstack-horizon | 05:13 | |
*** neelashah1 has quit IRC | 05:13 | |
*** ArcTanSusan_ has joined #openstack-horizon | 05:21 | |
*** ramishra has quit IRC | 05:28 | |
*** sbfox has quit IRC | 05:37 | |
*** ramishra has joined #openstack-horizon | 05:42 | |
*** ramishra has quit IRC | 05:44 | |
*** ramishra has joined #openstack-horizon | 05:45 | |
*** dkorn has joined #openstack-horizon | 05:49 | |
*** echevemaster has quit IRC | 05:49 | |
*** Sukhdev has quit IRC | 05:52 | |
*** nlahouti has quit IRC | 06:11 | |
*** k4n0 has joined #openstack-horizon | 06:18 | |
*** david-lyle has quit IRC | 06:19 | |
*** nlahouti has joined #openstack-horizon | 06:26 | |
*** rdopieralski has joined #openstack-horizon | 06:35 | |
*** nlahouti has quit IRC | 06:38 | |
*** jcoufal has joined #openstack-horizon | 06:43 | |
*** jprovazn has joined #openstack-horizon | 06:43 | |
*** pkoniszewski has joined #openstack-horizon | 06:47 | |
*** vokhrimenko_ has joined #openstack-horizon | 06:52 | |
*** MaxV has joined #openstack-horizon | 07:00 | |
*** chandankumar has quit IRC | 07:07 | |
*** MaxV has quit IRC | 07:09 | |
*** chandan_kumar has joined #openstack-horizon | 07:13 | |
*** ArcTanSusan_ has quit IRC | 07:15 | |
*** lsmola has quit IRC | 07:16 | |
*** lcheng has quit IRC | 07:19 | |
*** e0ne has joined #openstack-horizon | 07:19 | |
*** qba73 has joined #openstack-horizon | 07:20 | |
*** ramishra has quit IRC | 07:31 | |
*** jtomasek has joined #openstack-horizon | 07:32 | |
*** chandan_kumar has quit IRC | 07:33 | |
*** romainh has joined #openstack-horizon | 07:36 | |
*** e0ne has quit IRC | 07:38 | |
*** e0ne has joined #openstack-horizon | 07:38 | |
*** dsneddon has quit IRC | 07:39 | |
*** ygbo has joined #openstack-horizon | 07:40 | |
*** arezmerita has joined #openstack-horizon | 07:42 | |
*** lcheng has joined #openstack-horizon | 07:45 | |
*** chandan_kumar has joined #openstack-horizon | 07:47 | |
*** akrivoka has joined #openstack-horizon | 07:48 | |
*** ramishra has joined #openstack-horizon | 07:54 | |
*** MaxV has joined #openstack-horizon | 07:55 | |
*** bvandenh has joined #openstack-horizon | 08:00 | |
*** tmazur has joined #openstack-horizon | 08:03 | |
*** lcheng has quit IRC | 08:06 | |
*** lsmola has joined #openstack-horizon | 08:07 | |
*** ramishra has quit IRC | 08:10 | |
*** athomas has joined #openstack-horizon | 08:17 | |
*** mrunge has joined #openstack-horizon | 08:27 | |
*** chandan_kumar has quit IRC | 08:29 | |
*** Longgeek has joined #openstack-horizon | 08:39 | |
*** ramishra has joined #openstack-horizon | 08:41 | |
*** tnovacik has joined #openstack-horizon | 08:45 | |
*** ramishra has quit IRC | 08:45 | |
*** tzumainn has joined #openstack-horizon | 08:48 | |
*** amotoki has quit IRC | 08:52 | |
*** Longgeek has quit IRC | 08:53 | |
*** Longgeek has joined #openstack-horizon | 08:53 | |
*** tnovacik_ has joined #openstack-horizon | 08:55 | |
*** sanu has joined #openstack-horizon | 09:02 | |
*** sanu has joined #openstack-horizon | 09:03 | |
*** sanu has quit IRC | 09:03 | |
*** DaveJ__ has joined #openstack-horizon | 09:05 | |
*** aix has joined #openstack-horizon | 09:13 | |
*** AJaeger has joined #openstack-horizon | 09:18 | |
*** AJaeger has left #openstack-horizon | 09:19 | |
*** sambetts has joined #openstack-horizon | 09:19 | |
*** amerine has joined #openstack-horizon | 09:20 | |
*** amerine has quit IRC | 09:24 | |
*** Longgeek has quit IRC | 09:24 | |
*** Longgeek has joined #openstack-horizon | 09:27 | |
sambetts | rdopieralski: Thank you :-) | 09:35 |
---|---|---|
rdopieralski | sambetts: ? | 09:35 |
*** e0ne has quit IRC | 09:35 | |
sambetts | rdopieralski: for reviewing my patch | 09:36 |
*** tnovacik has quit IRC | 09:41 | |
*** e0ne has joined #openstack-horizon | 09:41 | |
*** ramishra has joined #openstack-horizon | 09:41 | |
*** ramishra has quit IRC | 09:46 | |
*** ramishra has joined #openstack-horizon | 09:47 | |
*** tosky has joined #openstack-horizon | 09:52 | |
*** AJaeger has joined #openstack-horizon | 09:55 | |
AJaeger | Horizon cores, could you approve the tuskar-ui requirements change https://review.openstack.org/118576 quickly, please? This is needed to unbreak the global requirements job... | 09:55 |
rdopieralski | AJaeger: done | 09:58 |
AJaeger | thanks, rdopieralski ! | 09:58 |
*** AJaeger has left #openstack-horizon | 09:58 | |
*** ramishra has quit IRC | 10:06 | |
prasoon | Hello everyone, I was working on this bug https://bugs.launchpad.net/horizon/+bug/1360012. I have a fix | 10:07 |
*** ramishra has joined #openstack-horizon | 10:07 | |
prasoon | but the run_tests.sh is failing with an error ProtocolError: ('Connection aborted.', gaierror(-2, 'Name or service not known')). | 10:07 |
prasoon | and the trace goes via the lines I have added | 10:08 |
mrunge | prasoon, it looks like you added an api call and didn't mock it. | 10:09 |
prasoon | mrunge: yes I have added an api for flavor_list, the test_launch_instance in tests.py has mocked flavor_list once | 10:10 |
mrunge | prasoon, you need to mock it again | 10:10 |
prasoon | I added a method get_help_text that uses flavor_list | 10:10 |
prasoon | okay, twice? | 10:10 |
prasoon | I am new, so it is not clear to my why | 10:11 |
mrunge | prasoon, or MultipleTimes() | 10:11 |
prasoon | okay, I see MultipleTimes() | 10:11 |
prasoon | I'll try | 10:11 |
prasoon | mrunge, I as well see RuntimeError: Failed to shutdown the live test server in 2 seconds, under test suite for <class 'horizon.test.tests.selenium_tests.LazyLoadedTabsTests'> | 10:14 |
mrunge | prasoon, ./run_tests --failfast helps me a lot | 10:14 |
mrunge | just concentrate on the first issue first | 10:15 |
prasoon | okay, thanks | 10:15 |
mrunge | debugging tests is just a pain | 10:15 |
prasoon | mrunge, I tried with MultipleTimes() didn't help. | 10:18 |
prasoon | same error pops up again | 10:19 |
akrivoka | regebro: ping | 10:20 |
regebro | akrivoka: pong! | 10:20 |
*** amerine has joined #openstack-horizon | 10:20 | |
akrivoka | regebro: hey Lennart | 10:21 |
akrivoka | regebro: I have a css question :) | 10:21 |
akrivoka | regarding this patch https://review.openstack.org/#/c/116855/ | 10:21 |
regebro | OK, let's try :-) | 10:21 |
akrivoka | I tried overflow: auto as you suggested | 10:21 |
akrivoka | that fixed the images table, but it messed up the actions dropdown box on details pages | 10:22 |
regebro | oh | 10:22 |
akrivoka | so I tried all other values for overflow, none of them produced the desired effect | 10:22 |
akrivoka | so... I'm out of ideas :) | 10:22 |
regebro | Right. | 10:22 |
regebro | The problem is that the div around the H1 for some reason is too small to actually fit the H1. | 10:23 |
regebro | akrivoka: I don't actually know why that happens. | 10:23 |
regebro | The overflow:auto is a quick way of fixing that, but that was apparently not the right way this time. | 10:23 |
*** e0ne has quit IRC | 10:24 | |
prasoon | I was talking about this method to make it clear: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/databases/tests.py#L126-127 | 10:24 |
regebro | I can try to look into it, but not right now, or we could find some real CSS guru that understands in detail what is going on. | 10:24 |
prasoon | mrunge, the link I shared above is the one I am looking | 10:25 |
*** amerine has quit IRC | 10:25 | |
rdopieralski | messing with overflow confines all floats in the box | 10:26 |
rdopieralski | akrivoka: what's the problem exactly? | 10:31 |
*** Longgeek has quit IRC | 10:31 | |
*** Longgeek has joined #openstack-horizon | 10:32 | |
akrivoka | rdopieralski: my patch messes up css in such way that tables are shifted to the right (on index pages), and only in firefox | 10:32 |
akrivoka | rdopieralski: Lennart suggested adding overflow:auto to .page-header class to fix that | 10:32 |
akrivoka | rdopieralski: that indeed fixed the tables, but it broke the action dropdown menu that I added to the header | 10:33 |
rdopieralski | akrivoka: hmm, I don't think you should use "partial" grid | 10:33 |
rdopieralski | like there | 10:33 |
akrivoka | I wonder of the col-md-6 class is the problem | 10:33 |
rdopieralski | yes | 10:33 |
rdopieralski | why is it there at all? | 10:33 |
akrivoka | good question :) removing it seems to fix the problem | 10:34 |
rdopieralski | yeah, or adding the rest of the grid's row | 10:35 |
rdopieralski | so that the sum is 12 | 10:35 |
akrivoka | rdopieralski: thanks for the pointers! | 10:35 |
rdopieralski | also, adding "row" class to the page-header | 10:35 |
*** Longgeek_ has joined #openstack-horizon | 10:36 | |
mrunge | prasoon, and you added a MultipleTimes() before .AndReturn(...)? | 10:37 |
*** Longgeek has quit IRC | 10:39 | |
*** e0ne has joined #openstack-horizon | 10:39 | |
*** ramishra has quit IRC | 10:41 | |
*** bvandenh has quit IRC | 10:44 | |
*** bvandenh has joined #openstack-horizon | 10:45 | |
*** mrunge has quit IRC | 10:52 | |
*** mrunge has joined #openstack-horizon | 10:53 | |
*** ramishra has joined #openstack-horizon | 10:57 | |
*** Ephur has quit IRC | 11:03 | |
*** MaxV has quit IRC | 11:04 | |
*** MaxV has joined #openstack-horizon | 11:05 | |
*** sigmavirus24_awa has quit IRC | 11:06 | |
*** dkorn has quit IRC | 11:07 | |
prasoon | mrunge, yes that's where I added | 11:07 |
*** Ephur has joined #openstack-horizon | 11:08 | |
*** MaxV has quit IRC | 11:10 | |
*** sigmavirus24_awa has joined #openstack-horizon | 11:12 | |
*** prasoon has quit IRC | 11:20 | |
*** stpierre has joined #openstack-horizon | 11:21 | |
*** amerine has joined #openstack-horizon | 11:22 | |
*** amerine has quit IRC | 11:26 | |
*** MaxV has joined #openstack-horizon | 11:33 | |
*** sseago_ has quit IRC | 11:39 | |
*** vkmc has joined #openstack-horizon | 11:50 | |
*** vkmc has quit IRC | 11:50 | |
*** vkmc has joined #openstack-horizon | 11:50 | |
*** akrivoka is now known as akrivoka|afk | 11:52 | |
*** Longgeek_ has quit IRC | 11:53 | |
*** Longgeek has joined #openstack-horizon | 11:54 | |
*** Swaroop has joined #openstack-horizon | 11:54 | |
*** Longgeek_ has joined #openstack-horizon | 11:54 | |
*** Longgeek has quit IRC | 11:58 | |
*** lsmola has quit IRC | 12:01 | |
*** prasoon has joined #openstack-horizon | 12:02 | |
*** HenryG is now known as HenryG_afk | 12:04 | |
*** ramishra has quit IRC | 12:04 | |
*** lsmola has joined #openstack-horizon | 12:10 | |
*** akrivoka|afk is now known as akrivoka | 12:16 | |
Swaroop | Hi All | 12:16 |
Swaroop | I am new to openstack horizon group | 12:16 |
Swaroop | I would like to understand code flow of horizon and play with it | 12:16 |
Swaroop | any tutorials are available please point me | 12:16 |
*** Longgeek_ has quit IRC | 12:19 | |
*** pawels has joined #openstack-horizon | 12:21 | |
*** amerine has joined #openstack-horizon | 12:22 | |
*** amerine has quit IRC | 12:27 | |
*** Longgeek has joined #openstack-horizon | 12:30 | |
*** e0ne has quit IRC | 12:31 | |
*** e0ne has joined #openstack-horizon | 12:34 | |
*** ramishra has joined #openstack-horizon | 12:35 | |
*** ramishra has quit IRC | 12:39 | |
*** freyes has quit IRC | 12:45 | |
*** freyes has joined #openstack-horizon | 12:46 | |
tsufiev | Swaroop, here you are http://docs.openstack.org/developer/horizon/quickstart.html | 12:46 |
*** igor has joined #openstack-horizon | 12:52 | |
*** igor has quit IRC | 12:52 | |
*** igor has joined #openstack-horizon | 12:53 | |
*** doug-fish has joined #openstack-horizon | 12:53 | |
*** igor has quit IRC | 12:56 | |
*** aix has quit IRC | 12:58 | |
*** tnovacik_ has quit IRC | 12:58 | |
*** tmazur has quit IRC | 13:01 | |
*** aix has joined #openstack-horizon | 13:01 | |
*** pawels1 has joined #openstack-horizon | 13:05 | |
*** neelashah has joined #openstack-horizon | 13:06 | |
*** Swaroop has quit IRC | 13:07 | |
*** pawels has quit IRC | 13:08 | |
*** lblanchard has joined #openstack-horizon | 13:14 | |
*** jpomero has quit IRC | 13:19 | |
*** peristeri has joined #openstack-horizon | 13:22 | |
*** radez_g0n3 is now known as radez | 13:22 | |
*** julim has joined #openstack-horizon | 13:24 | |
*** rodrigods has joined #openstack-horizon | 13:25 | |
*** echevemaster has joined #openstack-horizon | 13:26 | |
prasoon | are there any documents where I can understand how unit tests are written? | 13:28 |
prasoon | for horizon | 13:29 |
rdopieralski | prasoon: http://www.jpichon.net/blog/2013/07/testing-in-horizon/ | 13:29 |
rdopieralski | this was recently linked on the mailin list | 13:29 |
prasoon | rdopieralski: thanks! I'll go through it | 13:30 |
*** vijendar has joined #openstack-horizon | 13:32 | |
*** ramishra has joined #openstack-horizon | 13:35 | |
*** doug-fish1 has joined #openstack-horizon | 13:36 | |
*** doug-fish has quit IRC | 13:39 | |
*** jasondotstar has joined #openstack-horizon | 13:39 | |
*** ramishra has quit IRC | 13:39 | |
*** e0ne has quit IRC | 13:43 | |
*** jay-atl has quit IRC | 13:43 | |
*** Drago has joined #openstack-horizon | 13:49 | |
*** e0ne has joined #openstack-horizon | 13:50 | |
*** pawels has joined #openstack-horizon | 13:51 | |
*** jpomero has joined #openstack-horizon | 13:52 | |
*** pawels1 has quit IRC | 13:52 | |
*** nlahouti has joined #openstack-horizon | 13:54 | |
*** e0ne has quit IRC | 13:56 | |
*** e0ne has joined #openstack-horizon | 13:58 | |
*** nlahouti has quit IRC | 14:01 | |
*** neelashah has quit IRC | 14:06 | |
*** ramishra has joined #openstack-horizon | 14:07 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:13 | |
*** sigmavirus24 has joined #openstack-horizon | 14:13 | |
*** neelashah has joined #openstack-horizon | 14:24 | |
*** amerine has joined #openstack-horizon | 14:24 | |
*** neelashah1 has joined #openstack-horizon | 14:24 | |
*** neelashah has quit IRC | 14:28 | |
*** amerine has quit IRC | 14:28 | |
prasoon | Could someone tell me what needs to be done for the following failure? | 14:32 |
*** jcoufal_ has joined #openstack-horizon | 14:32 | |
prasoon | "RuntimeError: Failed to shutdown the live test server in 2 seconds. The server might be stuck or generating a slow response" | 14:32 |
prasoon | failed in test suite for <class 'horizon.test.tests.selenium_tests.LazyLoadedTabsTests'> | 14:34 |
*** jcoufal has quit IRC | 14:34 | |
*** HenryG_afk is now known as HenryG | 14:36 | |
*** david-lyle has joined #openstack-horizon | 14:36 | |
*** ericpeterson has joined #openstack-horizon | 14:36 | |
*** cody-somerville has joined #openstack-horizon | 14:39 | |
*** hurgleburgler has joined #openstack-horizon | 14:41 | |
*** tnovacik_ has joined #openstack-horizon | 14:42 | |
*** jprovazn has quit IRC | 14:46 | |
*** rdopieralski has quit IRC | 14:51 | |
*** sseago_ has joined #openstack-horizon | 14:52 | |
*** jcoufal_ has quit IRC | 14:55 | |
*** arezmerita has quit IRC | 14:56 | |
*** sbfox has joined #openstack-horizon | 14:57 | |
*** arezmerita has joined #openstack-horizon | 15:02 | |
*** nlahouti has joined #openstack-horizon | 15:04 | |
*** ygbo has quit IRC | 15:04 | |
*** pawels has quit IRC | 15:06 | |
*** rebelagentm has joined #openstack-horizon | 15:06 | |
*** vokhrimenko_ has quit IRC | 15:07 | |
*** ftcjeff has joined #openstack-horizon | 15:13 | |
*** pkoniszewski has quit IRC | 15:13 | |
*** gokrokve has joined #openstack-horizon | 15:16 | |
*** TravT has joined #openstack-horizon | 15:17 | |
*** akrivoka has quit IRC | 15:17 | |
*** akrivoka has joined #openstack-horizon | 15:19 | |
ericpeterson | does anyone know if Gabriel will be in the room later??? looking to follow up on https://review.openstack.org/#/c/111854/ | 15:20 |
david-lyle | ericpeterson: he's never in the room | 15:21 |
david-lyle | but he does have a point | 15:21 |
david-lyle | the lookup is incredibly useful, but a one of fix for larger issues | 15:22 |
sigmavirus24 | I agree with Gabriel and David | 15:22 |
*** jcoufal has joined #openstack-horizon | 15:22 | |
david-lyle | off* | 15:22 |
ericpeterson | yeah, I'm not sure how to work through the comments. the region selector is kind of limited..... so an admin should have to select each region.... do their work..... and select the next region..... | 15:22 |
david-lyle | I'm not sure that's the comment | 15:23 |
david-lyle | The comment is more along the lines of you have one page that breaks the one region based views | 15:23 |
david-lyle | it's clunky to bury it among the other one-region pages | 15:23 |
ericpeterson | so creating a grouping of super panels is what is being asked??? that isn't correct either | 15:24 |
david-lyle | we need to allow multi-region views, but not in a one off copy of the instances table | 15:24 |
doug-fish1 | sounds like a comic book! | 15:24 |
ericpeterson | this page real is outside of the region selector | 15:24 |
doug-fish1 | The League of Super Panels | 15:25 |
doug-fish1 | are there other pages that aren't scoped to the region? | 15:25 |
david-lyle | doug-fish1: not now | 15:25 |
*** amerine has joined #openstack-horizon | 15:25 | |
ericpeterson | not really | 15:25 |
*** ramishra has quit IRC | 15:25 | |
*** ramishra has joined #openstack-horizon | 15:26 | |
ericpeterson | I think this is needed / important..... the current way admin panels work with regions is kind of a joke in larger or multi region deployments | 15:26 |
ericpeterson | it works fine in devstack, though ;) | 15:26 |
*** Sukhdev has joined #openstack-horizon | 15:26 | |
ericpeterson | it seems to me we can either -1 the change and say that horizon | 15:28 |
david-lyle | ericpeterson: no one's arguing the need, they're arguing the UX implications | 15:28 |
ericpeterson | 's admin stuff is not really meant for larger uses | 15:28 |
doug-fish1 | Have we had this in front of any users yet? | 15:28 |
david-lyle | inside HP, yes | 15:29 |
doug-fish1 | I thought ericpeterson adapted this from real life administration | 15:29 |
ericpeterson | yep, I know...... it's needed.... but if we say the UX is not meant to support complex or large scale uses....that is kind of a statement | 15:29 |
*** aix has quit IRC | 15:29 | |
david-lyle | ericpeterson: that's not the statement | 15:29 |
*** amerine has quit IRC | 15:29 | |
david-lyle | the statement is that hacking it in a panel that varies from all other conventions in Horizon is a sub-optimal approach | 15:30 |
sigmavirus24 | ericpeterson: the statement is that this is a break in consistency of the existing user experience | 15:30 |
ericpeterson | I know.... I am kind of in a mood this am, just pushing your buttons. sorry | 15:30 |
david-lyle | and poses the larger question of how we do this right | 15:30 |
david-lyle | maybe all admin panels should be cross-region and that's the role of the admin panels now | 15:31 |
doug-fish1 | do it right = make sure its not confusing to users? | 15:31 |
*** ramishra has quit IRC | 15:31 | |
david-lyle | doug-fish1: no, just do it right, to hell with users ') | 15:31 |
doug-fish1 | lol | 15:31 |
ericpeterson | I kind of think admin panels should always be the power user panels | 15:31 |
doug-fish1 | that's what I'm afraid we are going actually | 15:31 |
*** qba73 has quit IRC | 15:31 | |
*** dsneddon has joined #openstack-horizon | 15:32 | |
doug-fish1 | s/going/doing | 15:32 |
david-lyle | ericpeterson: I tend to agree | 15:32 |
ericpeterson | I think we have taken the admin panels, just made them the project panels plus a few changes | 15:32 |
david-lyle | well the history is it made an easy separation of roles | 15:33 |
david-lyle | that separation is cloudier now | 15:33 |
david-lyle | if admin dashboard evolves into a multi-region based view, I'm ok with that | 15:34 |
*** amotoki has joined #openstack-horizon | 15:34 | |
*** alexpilotti has joined #openstack-horizon | 15:34 | |
david-lyle | and move the current admin tasks into the project panels gated by RBAC | 15:34 |
ericpeterson | I am not trying to argue against Gabriel too, he has a valid point.... It's just an odd way to get to this point and rework stuff. But this was really me/hp contributing a tool we found to be very useful and in need | 15:35 |
doug-fish1 | but how do we take the first step in that evoluation? IMO the panel does its job, and is a nice first step. We should put it out there - if its confusing I think people won't use it. | 15:35 |
david-lyle | ericpeterson: understood, but we always knew it was a hack | 15:35 |
david-lyle | no offense, we obviously have worse hacks, cough, domain-context, cough | 15:36 |
doug-fish1 | hack in the sense that maybe it doesn't match the intended mental model, but its good in the sense that it solves a real and specific need | 15:36 |
*** gokrokve has quit IRC | 15:37 | |
david-lyle | doug-fish1: true, but how do we frame that for users? | 15:37 |
ericpeterson | maybe blinking text is needed, I can totally do that ;) | 15:38 |
david-lyle | without having them question what the use model is for each page | 15:38 |
doug-fish1 | when you say frame it for users that implies it going to confuse them ... does the overview panel confuse users even though we have a project selector on the page? | 15:38 |
david-lyle | ericpeterson: marquee text please | 15:38 |
*** gokrokve has joined #openstack-horizon | 15:39 | |
david-lyle | doug-fish1: not sure I follow your point | 15:39 |
*** lcheng has joined #openstack-horizon | 15:39 | |
doug-fish1 | sure, let me try again .... | 15:39 |
ericpeterson | doug-fish1: this new page is the confusing point..... b/c you will see instances from all your regions | 15:40 |
sigmavirus24 | ericpeterson: just put the construction worker gifs in there | 15:40 |
ericpeterson | I should probably place a column in the table for the region as well??? | 15:40 |
doug-fish1 | Our UI already implies that pages are scoped to a region and a project - we have selectors for both, right? | 15:40 |
david-lyle | doug-fish1: the overview page should really be cross-region too, but that's hitting the problem again | 15:40 |
ericpeterson | sigmavirus24: big +1 | 15:41 |
doug-fish1 | lol | 15:41 |
david-lyle | maybe put the word advanced on the page to indicate level of difficulty? | 15:41 |
sigmavirus24 | david-lyle: super pro page | 15:42 |
david-lyle | and a skilz test to enter | 15:42 |
ericpeterson | http://stonehousesigns.com/sites/default/files/products/formatted/Expert_Only_Ski_WJ92.jpg | 15:42 |
david-lyle | problem solved | 15:42 |
david-lyle | I am expert | 15:42 |
*** mflobo has quit IRC | 15:43 | |
sigmavirus24 | david-lyle: is become expert, master of regions | 15:43 |
ericpeterson | I think adding the region column to the table might help, so you also know that instance X resides in a certain region (which might differ from what you selected?) | 15:44 |
doug-fish1 | +1 to adding the region column | 15:45 |
ericpeterson | but the table also has about 25 columns to start with, might remove a column too.... will need to see how it sizes out | 15:45 |
ericpeterson | (25 is a sight exageration) | 15:45 |
david-lyle | optical illusion then? | 15:45 |
*** aix has joined #openstack-horizon | 15:48 | |
sigmavirus24 | ericpeterson: use the accordion effect so as your mouse moves, new columns randomly open up | 15:48 |
sigmavirus24 | that's great UX ;) | 15:48 |
ericpeterson | I think I like the under construction gif and blinking text better | 15:49 |
ericpeterson | web 1.0 | 15:49 |
david-lyle | NOTE: any horizon cores please don't approve any bug fixes that aren't critical and no blueprints today. The gate needs to focus on Features targeted for Juno-3, we can merge bugs post J-3. Gate is ~19 hours deep now. akrivoka, mrunge, lcheng | 15:50 |
*** arezmerita has quit IRC | 15:50 | |
*** bvandenh has quit IRC | 15:54 | |
akrivoka | david-lyle: ok | 15:54 |
david-lyle | thanks | 15:54 |
*** akrivoka has quit IRC | 15:55 | |
*** ramishra has joined #openstack-horizon | 15:56 | |
*** arezmerita has joined #openstack-horizon | 15:57 | |
regebro | Hm. I get "horizon.cookies is undefined" in the JS. When/How is that supposed to be set? | 15:59 |
*** AlkaD has joined #openstack-horizon | 16:00 | |
*** ramishra has quit IRC | 16:00 | |
*** Longgeek has quit IRC | 16:02 | |
*** jakedahn_ is now known as jakedahn | 16:02 | |
*** jakedahn has quit IRC | 16:02 | |
*** jakedahn has joined #openstack-horizon | 16:02 | |
*** jakedahn has joined #openstack-horizon | 16:02 | |
*** tqtran has joined #openstack-horizon | 16:02 | |
regebro | aha, got it. | 16:03 |
regebro | (maybe) | 16:04 |
*** tristanC_ has joined #openstack-horizon | 16:06 | |
*** rhagarty_ has joined #openstack-horizon | 16:08 | |
*** swartulv has quit IRC | 16:08 | |
*** jasondotstar has quit IRC | 16:08 | |
*** k4n0 has quit IRC | 16:08 | |
*** tristanC has quit IRC | 16:08 | |
*** freyes has quit IRC | 16:08 | |
*** rhagarty has quit IRC | 16:08 | |
*** arezmerita has quit IRC | 16:08 | |
*** Ugallu has joined #openstack-horizon | 16:08 | |
*** tristanC_ is now known as tristanC | 16:08 | |
*** k4n0_ has joined #openstack-horizon | 16:09 | |
*** arezmerita has joined #openstack-horizon | 16:09 | |
*** amcrn has joined #openstack-horizon | 16:10 | |
*** freyes has joined #openstack-horizon | 16:10 | |
*** swartulv has joined #openstack-horizon | 16:11 | |
*** neillc has joined #openstack-horizon | 16:15 | |
*** MaxV has quit IRC | 16:18 | |
*** MaxV has joined #openstack-horizon | 16:19 | |
*** amerine has joined #openstack-horizon | 16:22 | |
rebelagentm | tnovacik_: I think I got it right this time. ;) | 16:22 |
*** MaxV has quit IRC | 16:23 | |
rebelagentm | tnovacik_: Also, the testing wiki page has the space after the colon ("Partially implements blueprint: selenium-integration-testing"). This is where I got it from originally. Does the wiki need to be fixed? | 16:28 |
*** cody-somerville has quit IRC | 16:29 | |
*** cody-somerville has joined #openstack-horizon | 16:31 | |
tnovacik_ | rebelagentm, :) why do you split it over two lines ? :] https://review.openstack.org/#/c/101177/ and https://review.openstack.org/#/c/112579/ both have it on one line i do not think it is necessary :D | 16:34 |
tnovacik_ | rebelagentm, but i do not want to torture you, btw you can change commit message within the web ui | 16:35 |
tnovacik_ | rebelagentm, you do not have to upload new patch :) | 16:35 |
rebelagentm | tnovacik_: I didn't know about the web UI. Thanks for the tip! | 16:35 |
rebelagentm | tnovacik_: I broke that line into two because Gerrit was giving a PEP8 error saying that the commit message was too long | 16:36 |
tnovacik_ | rebelagentm, well in that case it is alright | 16:36 |
rebelagentm | tnovacik_: Thanks for your help! :) I updated the commit message via the UI and put it back on one line. Hopefully that works alright for Gerrit | 16:37 |
tnovacik_ | rebelagentm, thank you ! and sorry ... :) | 16:38 |
rebelagentm | tnovacik_: No worries. Happy to learn! And you were kind about it. :) | 16:40 |
afaranha | mrunge: Sorry, I didn't read it earlier. | 16:40 |
afaranha | I don't know where and what I have to modify, can you help me with this? | 16:40 |
*** ramishra has joined #openstack-horizon | 16:49 | |
*** ramishra has quit IRC | 16:49 | |
*** ramishra has joined #openstack-horizon | 16:49 | |
*** ramishra has quit IRC | 16:50 | |
*** ramishra has joined #openstack-horizon | 16:51 | |
*** prasoon has quit IRC | 16:51 | |
*** prasoon has joined #openstack-horizon | 16:52 | |
ericpeterson | we have a request for a feature that I would like to talk through, before I file any tickets.. the request is to get the region picker to be sticky. so when a user switches projects, it should recall they are in the same region and not reset it to the first region found. I am thinking about making this a client side cookie, and even recall your last region when you return back into horizon. thoughts?? | 16:55 |
ericpeterson | ?? | 16:55 |
tqtran | make sense to me | 17:01 |
tqtran | would be a nice feature | 17:01 |
*** amcrn_ has joined #openstack-horizon | 17:02 | |
*** jcoufal has quit IRC | 17:03 | |
*** gokrokve_ has joined #openstack-horizon | 17:03 | |
*** tosky has quit IRC | 17:04 | |
*** gokrokve has quit IRC | 17:05 | |
*** amcrn has quit IRC | 17:06 | |
*** amcrn_ is now known as amcrn | 17:06 | |
rebelagentm | tnovacik_: What happens next? When does a commit become part of master? I'm excited! :D | 17:08 |
ericpeterson | thanks tqtran.... anyone else? this will likely go in django-openstack-auth project. we should rename that to be python-django-openstack-auth, not sure if I can find anymore prefixes for that project | 17:09 |
*** absubram has joined #openstack-horizon | 17:10 | |
*** sambetts has quit IRC | 17:10 | |
*** amotoki has quit IRC | 17:10 | |
*** AlkaD has quit IRC | 17:12 | |
*** AlkaD has joined #openstack-horizon | 17:12 | |
tqtran | we should just rename it to horizon-auth | 17:13 |
tqtran | makes more sense to me | 17:13 |
*** romainh has quit IRC | 17:14 | |
*** AlkaD has quit IRC | 17:15 | |
*** AlkaD has joined #openstack-horizon | 17:15 | |
afaranha | Hello, can anyone help me testing Horizon? I'm getting some errors after I added a new parameter in create project. But majority of them are in mox. I'm having trouble identifying the reasons of the error. | 17:16 |
*** ftcjeff has quit IRC | 17:18 | |
*** harlowja_away is now known as harlowja | 17:20 | |
gugl | tqtran, | 17:23 |
gugl | ping | 17:23 |
gugl | tqtran, ping | 17:23 |
*** nlahouti has quit IRC | 17:24 | |
gugl | tqtran, just want to know where I should put the issues pictures regarding the reviews you and where both on? | 17:25 |
*** Sukhdev has quit IRC | 17:26 | |
tnovacik_ | rebelagentm, after you receive 2x +2, which means that 2 core reviewers has approved your change | 17:27 |
tnovacik_ | rebelagentm, then is your commit merged to master :) | 17:27 |
*** nlahouti has joined #openstack-horizon | 17:30 | |
tqtran | gugl: pong, im back! | 17:33 |
tqtran | gugl: not sure which one you're talking about? | 17:33 |
gary-smith | afaranha: http://docs.openstack.org/developer/horizon/topics/testing.html#understanding-the-output-from-mox may be helpful | 17:35 |
gugl | tqtran, I am just wondering Ana wants to know what the tabs issue I saw...want to post the pictures...but not sure where is the normal place to post. paste.openstack.org doesn't seem to take pics | 17:35 |
*** e0ne has quit IRC | 17:35 | |
tqtran | gugl: ah... so i use a dirty little trick... | 17:35 |
tqtran | gugl: i post the image in the bug tracker | 17:36 |
tqtran | gugl: then link to it in the code review | 17:36 |
*** stpierre_ has joined #openstack-horizon | 17:37 | |
*** alexpilotti has quit IRC | 17:39 | |
gugl | tqtran, you mean launchpad | 17:39 |
*** stpierre has quit IRC | 17:39 | |
*** absubram has quit IRC | 17:39 | |
rebelagentm | tnovacik_: Thanks! | 17:40 |
tqtran | gugl: yes launchpad | 17:40 |
afaranha | gary-smith: thanks :) | 17:40 |
gugl | tqtran, ok. thanks | 17:41 |
*** alexpilotti has joined #openstack-horizon | 17:41 | |
gary-smith | afaranha: good luck! Trying to get mox unit tests happy is often harder to do than the actual development | 17:44 |
*** stpierre_ is now known as stpierre | 17:45 | |
*** nlahouti has quit IRC | 17:45 | |
david-lyle | afaranha: what is the paste of the error you are seeing? | 17:47 |
*** ramishra has quit IRC | 17:49 | |
afaranha | david-lyle: It's mainly 3 kinds: 1. "ProtocolError: ('Connection aborted.', gaierror(-2, 'Name or service not known'))" | 17:53 |
afaranha | 2. "ExpectedMethodCallsError: Verify: Expected methods never called:" | 17:53 |
afaranha | 3. "TemplateSyntaxError: unbound method get() must be called with TenantManager instance as first argument (got str instance instead)" | 17:53 |
*** morganfainberg is now known as morganfainberg_Z | 17:53 | |
*** nlahouti has joined #openstack-horizon | 17:58 | |
*** colinmcnamara has joined #openstack-horizon | 17:59 | |
*** aix has quit IRC | 18:00 | |
*** colinmcnamara has quit IRC | 18:02 | |
*** radez is now known as radez_g0n3 | 18:06 | |
*** DaveJ__ has quit IRC | 18:08 | |
david-lyle | afaranha: have you recently rebased? | 18:09 |
*** e0ne has joined #openstack-horizon | 18:10 | |
david-lyle | #1 should be fixed by that, most likely | 18:11 |
david-lyle | 2 is likely a method signature error, you are mocking the method incorrectly (think parameters) | 18:11 |
david-lyle | 3 looks like the same kind of thing | 18:12 |
david-lyle | you are calling a method with a parameter of the wrong type | 18:12 |
*** ArcTanSusan has quit IRC | 18:14 | |
afaranha | david-lyle: I checkout monday, but just updated it | 18:16 |
*** ArcTanSusan has joined #openstack-horizon | 18:19 | |
*** radez_g0n3 is now known as radez | 18:21 | |
*** gokrokve has joined #openstack-horizon | 18:29 | |
*** regebro is now known as regebro|afk | 18:29 | |
*** gokrokve_ has quit IRC | 18:31 | |
*** gokrokve has quit IRC | 18:33 | |
*** dsneddon has quit IRC | 18:34 | |
*** romainh has joined #openstack-horizon | 18:39 | |
*** Ugallu has quit IRC | 18:45 | |
*** dsneddon has joined #openstack-horizon | 18:45 | |
*** dsneddon has quit IRC | 18:46 | |
*** ArcTanSusan has quit IRC | 18:46 | |
*** e0ne has quit IRC | 18:47 | |
*** dsneddon has joined #openstack-horizon | 18:47 | |
*** dsneddon has quit IRC | 18:48 | |
*** amcrn_ has joined #openstack-horizon | 18:51 | |
*** amcrn has quit IRC | 18:54 | |
*** ftcjeff has joined #openstack-horizon | 18:59 | |
*** AlkaD has quit IRC | 19:00 | |
*** dsneddon has joined #openstack-horizon | 19:03 | |
*** dsneddon has quit IRC | 19:04 | |
*** e0ne has joined #openstack-horizon | 19:05 | |
gary-smith | david-lyle: for bug 1365107 (missing font_awesome), there is no issue with a clean venv | 19:12 |
gary-smith | i.e. I wiped out my venv, rebuilt it, and it pulled down font_awesome correctly. Am I missing something? | 19:12 |
gary-smith | won't adding it to our requirements.txt imply that it should also be added to the global requirements.txt (an unlikely endeavor)? | 19:13 |
*** dsneddon has joined #openstack-horizon | 19:14 | |
*** radez is now known as radez_g0n3 | 19:15 | |
*** e0ne has quit IRC | 19:16 | |
david-lyle | clean will work fine | 19:18 |
david-lyle | is using an existing venv that's problematic | 19:19 |
*** e0ne has joined #openstack-horizon | 19:19 | |
david-lyle | ideally, every time we update requirements we should bump the environment version | 19:19 |
david-lyle | to trigger an update in the venv | 19:19 |
*** gokrokve has joined #openstack-horizon | 19:19 | |
*** ericpeterson has quit IRC | 19:20 | |
gary-smith | so are you planning to bump the number or add the dependency in requirements.txt | 19:20 |
gary-smith | ? | 19:20 |
david-lyle | I posted a patch to bump the env version | 19:20 |
gary-smith | (I'm hoping the former) | 19:20 |
gary-smith | ok, good | 19:20 |
david-lyle | the dependency is already there | 19:20 |
david-lyle | run_tests just doesn't reevaluate requirements.txt unless the env is out of date | 19:21 |
gary-smith | I hadn't looked at global requirements -- i see that it is already there too | 19:22 |
tqtran | david-lyle: did we document how to package a js library for xstatic? | 19:25 |
*** tnovacik_ has quit IRC | 19:26 | |
tqtran | david-lyle: and agreed that all 3rd party js lib will go through xstatic right? | 19:26 |
david-lyle | tqtran: yes, in docs in the horizon tree | 19:26 |
david-lyle | and yes | 19:26 |
*** ArcTanSusan has joined #openstack-horizon | 19:26 | |
tqtran | ty good sir | 19:27 |
*** ftcjeff has quit IRC | 19:38 | |
*** prasoon_ has joined #openstack-horizon | 19:40 | |
*** prasoon has quit IRC | 19:44 | |
*** prasoon_ has quit IRC | 19:44 | |
*** ftcjeff has joined #openstack-horizon | 19:45 | |
*** crobertsrh1 has left #openstack-horizon | 19:48 | |
*** radez_g0n3 is now known as radez | 19:51 | |
*** romainh has quit IRC | 20:00 | |
*** radez is now known as radez_g0n3 | 20:06 | |
*** e0ne has quit IRC | 20:06 | |
*** doug-fish1 has left #openstack-horizon | 20:14 | |
*** romainh has joined #openstack-horizon | 20:15 | |
*** fifieldt_ has joined #openstack-horizon | 20:17 | |
*** neelashah has joined #openstack-horizon | 20:18 | |
*** neelashah1 has quit IRC | 20:20 | |
*** ArcTanSusan has quit IRC | 20:20 | |
*** fifieldt has quit IRC | 20:21 | |
*** julim has quit IRC | 20:24 | |
*** ArcTanSusan has joined #openstack-horizon | 20:29 | |
*** dsneddon has quit IRC | 20:30 | |
*** stpierre has quit IRC | 20:33 | |
*** Drago has quit IRC | 20:49 | |
*** mrunge has quit IRC | 20:51 | |
*** doug-fish has joined #openstack-horizon | 20:51 | |
*** dsneddon has joined #openstack-horizon | 20:55 | |
*** ftcjeff has quit IRC | 20:56 | |
*** Sukhdev has joined #openstack-horizon | 21:01 | |
*** neelashah has quit IRC | 21:03 | |
*** jasondotstar has joined #openstack-horizon | 21:05 | |
*** david-lyle has quit IRC | 21:12 | |
*** neelashah has joined #openstack-horizon | 21:13 | |
*** lblanchard has quit IRC | 21:27 | |
*** dsneddon has quit IRC | 21:30 | |
*** peristeri has quit IRC | 21:32 | |
*** dsneddon has joined #openstack-horizon | 21:32 | |
*** david-lyle has joined #openstack-horizon | 21:33 | |
*** doug-fish has quit IRC | 21:33 | |
*** dsneddon has quit IRC | 21:37 | |
*** rebelagentm has quit IRC | 21:42 | |
*** romainh has left #openstack-horizon | 21:50 | |
*** ArcTanSusan has quit IRC | 21:50 | |
*** ftcjeff has joined #openstack-horizon | 22:02 | |
boltR | seems like the ADD_ANGULAR_MODULES setting is global | 22:03 |
boltR | versus extension-specific | 22:03 |
boltR | that doesn't seem right | 22:04 |
boltR | is there a reason why it was done that way? | 22:04 |
*** openstack has joined #openstack-horizon | 22:11 | |
*** sseago_ has quit IRC | 22:15 | |
*** ArcTanSusan has joined #openstack-horizon | 22:16 | |
*** packet has joined #openstack-horizon | 22:22 | |
*** ftcjeff has quit IRC | 22:25 | |
*** amerine has quit IRC | 22:34 | |
*** amerine_ has joined #openstack-horizon | 22:34 | |
*** jpomero has quit IRC | 22:35 | |
*** dsneddon has joined #openstack-horizon | 22:36 | |
*** kalipg has joined #openstack-horizon | 22:38 | |
*** ArcTanSusan has quit IRC | 22:39 | |
*** neelashah has quit IRC | 22:43 | |
*** kalipg has quit IRC | 22:43 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:44 | |
*** dsneddon has quit IRC | 22:47 | |
*** neillc has quit IRC | 22:47 | |
*** ArcTanSusan has joined #openstack-horizon | 22:52 | |
*** Sukhdev has quit IRC | 23:00 | |
*** ArcTanSusan has quit IRC | 23:11 | |
*** david-lyle has quit IRC | 23:14 | |
*** ArcTanSusan has joined #openstack-horizon | 23:20 | |
*** ftcjeff has joined #openstack-horizon | 23:36 | |
*** alexpilotti has quit IRC | 23:37 | |
*** jpomero has joined #openstack-horizon | 23:43 | |
*** dsneddon has joined #openstack-horizon | 23:46 | |
*** gokrokve has quit IRC | 23:50 | |
*** dsneddon has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!