Friday, 2014-09-19

*** alexpilotti_ has quit IRC00:01
*** rodrigods_ has joined #openstack-horizon00:02
*** Sukhdev has quit IRC00:02
*** johnma has quit IRC00:04
*** alexpilotti has joined #openstack-horizon00:06
*** ddieterly has joined #openstack-horizon00:07
*** rwsu has quit IRC00:11
*** rodrigods_ has quit IRC00:16
*** rodrigods_ has joined #openstack-horizon00:22
*** Sukhdev has joined #openstack-horizon00:24
*** neillc has joined #openstack-horizon00:24
*** nlahouti has joined #openstack-horizon00:25
*** alexpilotti_ has joined #openstack-horizon00:26
*** alexpilotti has quit IRC00:26
*** alexpilotti_ is now known as alexpilotti00:26
*** rwsu has joined #openstack-horizon00:27
*** neillc has quit IRC00:32
*** neillc has joined #openstack-horizon00:32
*** arborism has quit IRC00:33
*** Sukhdev has quit IRC00:35
*** Sukhdev_ has joined #openstack-horizon00:36
*** alexpilotti has quit IRC00:36
*** alexpilotti has joined #openstack-horizon00:42
*** rodrigods_ has quit IRC00:52
*** colinmcnamara has joined #openstack-horizon00:53
*** neillc has quit IRC00:55
*** neillc_ has joined #openstack-horizon00:59
*** neillc_ has quit IRC01:02
*** neillc_ has joined #openstack-horizon01:02
*** neillc_ has quit IRC01:10
*** neillc_ has joined #openstack-horizon01:11
*** rodrigods_ has joined #openstack-horizon01:11
*** Longgeek has joined #openstack-horizon01:15
*** rodrigods_ has quit IRC01:17
*** colinmcnamara has quit IRC01:21
*** neillc_ has quit IRC01:21
*** nlahouti has quit IRC01:28
*** sbfox has joined #openstack-horizon01:30
*** clu_ has quit IRC01:32
*** neillc has joined #openstack-horizon01:38
*** sbfox has quit IRC01:38
*** rodrigods_ has joined #openstack-horizon01:39
*** jacalcat has joined #openstack-horizon01:40
*** vkmc has quit IRC01:41
*** vkmc has joined #openstack-horizon01:46
*** sbfox has joined #openstack-horizon01:52
*** jacalcat has quit IRC01:53
*** ericpeterson has joined #openstack-horizon01:54
*** rwsu has quit IRC01:56
*** jpich_ has joined #openstack-horizon02:00
*** jpich has quit IRC02:03
*** Sukhdev has joined #openstack-horizon02:06
*** Sukhdev_ has quit IRC02:06
*** Longgeek has quit IRC02:08
*** rwsu has joined #openstack-horizon02:09
*** rwsu has quit IRC02:11
*** Sukhdev has quit IRC02:11
*** Longgeek has joined #openstack-horizon02:14
*** jpich_ is now known as jpich02:14
*** sbfox has quit IRC02:19
*** sbfox has joined #openstack-horizon02:22
*** ericpeterson has quit IRC02:23
*** rwsu has joined #openstack-horizon02:27
*** rodrigods_ has quit IRC02:29
*** harlowja is now known as harlowja_away02:29
*** sbfox has quit IRC02:30
*** ramishra has joined #openstack-horizon02:36
*** sbfox has joined #openstack-horizon02:51
*** amotoki has quit IRC03:06
*** sbfox has quit IRC03:08
*** jacalcat has joined #openstack-horizon03:17
*** vivekd has joined #openstack-horizon03:35
*** vivekd has left #openstack-horizon03:35
*** r1chardj0n3s is now known as r1chardj0n3s_afk03:37
*** ramishra_ has joined #openstack-horizon03:40
*** ramishra has quit IRC03:41
*** neillc has quit IRC03:47
*** neillc has joined #openstack-horizon03:47
*** Longgeek_ has joined #openstack-horizon03:52
*** lcheng has joined #openstack-horizon03:53
*** jacalcat has quit IRC03:53
*** Longgeek has quit IRC03:55
*** Sukhdev has joined #openstack-horizon04:00
*** Longgeek_ has quit IRC04:11
*** nikunj2512 has joined #openstack-horizon04:11
*** Dragomir has joined #openstack-horizon04:18
*** r1chardj0n3s_afk is now known as r1chardj0n3s04:20
*** Longgeek has joined #openstack-horizon04:22
*** bradjones has quit IRC04:24
*** ramishra_ has quit IRC04:25
*** ramishra has joined #openstack-horizon04:27
*** nlahouti has joined #openstack-horizon04:31
*** vkmc has quit IRC04:31
nikunj2512Hi04:32
nikunj2512I am working on this bug - https://launchpad.net/bugs/118279704:32
nikunj2512and i am facing problems with implementing the test case for my fix, Please help me out04:33
*** Longgeek has quit IRC04:37
*** Longgeek has joined #openstack-horizon04:45
*** Longgeek has quit IRC04:49
*** tzumainn has quit IRC05:02
*** Dragomir has quit IRC05:03
*** sayan_ has joined #openstack-horizon05:04
*** ramishra_ has joined #openstack-horizon05:06
*** ramishra has quit IRC05:09
*** Longgeek has joined #openstack-horizon05:15
*** masco has joined #openstack-horizon05:42
*** nlahouti has quit IRC05:42
*** jprovazn has joined #openstack-horizon05:45
*** nlahouti has joined #openstack-horizon05:45
*** amotoki has joined #openstack-horizon05:57
*** ramishra_ has quit IRC05:58
*** ramishra has joined #openstack-horizon05:59
*** Sukhdev has quit IRC06:00
*** Sukhdev_ has joined #openstack-horizon06:01
*** Longgeek has quit IRC06:01
*** ramishra has quit IRC06:02
*** nlahouti has quit IRC06:07
*** pkoniszewski has joined #openstack-horizon06:08
*** nlahouti has joined #openstack-horizon06:09
*** IbnyAdam has joined #openstack-horizon06:19
IbnyAdamhi06:19
IbnyAdamanybody here to help me ? I have my custom panel in openstack and i want to create a test case for this06:20
*** romainh has joined #openstack-horizon06:20
*** Longgeek has joined #openstack-horizon06:21
*** mrunge has joined #openstack-horizon06:22
*** k4n0 has joined #openstack-horizon06:29
*** IbnyAdam has quit IRC06:33
*** sayali has joined #openstack-horizon06:40
*** Dafna has quit IRC06:43
*** wuhg has joined #openstack-horizon06:45
*** romainh1 has joined #openstack-horizon06:46
*** romainh has quit IRC06:48
*** mrunge has quit IRC06:52
*** ttrifonov_zZzz is now known as ttrifonov06:55
*** romainh1 has left #openstack-horizon06:59
*** ygbo has joined #openstack-horizon07:02
*** romainh has joined #openstack-horizon07:05
*** nlahouti has quit IRC07:06
*** sayan_ has quit IRC07:07
*** mrunge has joined #openstack-horizon07:08
*** Sukhdev_ has quit IRC07:23
*** vokhrimenko has joined #openstack-horizon07:23
*** neillc has quit IRC07:26
*** dulek has joined #openstack-horizon07:27
*** r1chardj0n3s is now known as r1chardj0n3s_afk07:31
*** 7GHAA4IDM has joined #openstack-horizon07:35
*** 7GHAA4IDM is now known as neillc07:36
*** regebro has joined #openstack-horizon07:43
*** MaxV has joined #openstack-horizon07:50
*** jcoufal has joined #openstack-horizon07:52
*** sayan has joined #openstack-horizon08:04
*** sayan is now known as Guest809308:05
*** Dafna has joined #openstack-horizon08:10
*** e0ne has joined #openstack-horizon08:15
*** jtomasek has joined #openstack-horizon08:17
*** jpich has quit IRC08:18
*** e0ne has quit IRC08:28
*** e0ne has joined #openstack-horizon08:30
*** Guest8093 has quit IRC08:55
*** tnovacik|afk has joined #openstack-horizon09:04
*** pawels has joined #openstack-horizon09:09
*** tnovacik|afk has quit IRC09:16
*** e0ne has quit IRC09:25
*** krykowski has joined #openstack-horizon09:26
*** e0ne has joined #openstack-horizon09:32
*** athomas has joined #openstack-horizon09:42
*** pkarikh has joined #openstack-horizon09:47
*** bradjones has joined #openstack-horizon09:54
*** bradjones has quit IRC09:54
*** bradjones has joined #openstack-horizon09:54
*** aix has joined #openstack-horizon09:54
*** krykowski has quit IRC09:56
*** johnma has joined #openstack-horizon10:02
*** sayan has joined #openstack-horizon10:05
*** sayan has joined #openstack-horizon10:05
*** akrivoka has joined #openstack-horizon10:09
*** jtomasek has quit IRC10:12
*** cedrics has joined #openstack-horizon10:16
*** e0ne has quit IRC10:17
*** amotoki_ has joined #openstack-horizon10:19
*** Longgeek has quit IRC10:21
*** e0ne has joined #openstack-horizon10:21
regebroAnd why did I update Horizon now? Sigh.10:22
*** amotoki has quit IRC10:25
*** amotoki_ is now known as amotoki10:26
*** cedrics has quit IRC10:28
mrungeamotoki, since I'm not involved with i18n now: what's the status with patches adding or changing strings?10:37
mrungeamotoki, are they still allowed to merge?10:37
amotokimrunge: Let me check. It was discussed in the I18N meeting yesterday (though I couldn't attend)10:39
mrungeamotoki, that'll be great10:40
mrungeit's about this change: https://review.openstack.org/#/c/78708/10:40
mrungeit already go a freeze exception10:40
*** sambetts has joined #openstack-horizon10:41
*** e0ne has quit IRC10:43
amotokimrunge: In general, small fixes are no problem. verb+noun patches from Yves with 40+ string change was accepted.10:44
amotokimrunge: re 78708, I need to check the detail how many words are affected.10:45
amotokimrunge: could you check another I18N fix from me? https://review.openstack.org/#/c/120010/10:45
*** bradjones has quit IRC10:45
mrungeamotoki, looking10:46
*** Longgeek has joined #openstack-horizon10:51
*** nikunj2512 has quit IRC10:53
amotokimrunge: regarding 78708, it is not a problem from translator perspective. 2 small changes and 1 small addition.10:53
mrungeamotoki, yeah, I got that; thanks for checking!10:54
amotokimrunge: most translators are now working on and it affects only a few minutes :-)10:54
amotokimrunge: In my understanding, the subsequent two patches are out of Juno.10:55
mrungeamotoki, glad to hear!10:55
mrungeamotoki, yes, that's reflected at least in https://blueprints.launchpad.net/horizon/+spec/cisco-network-profile-multi-tenants-support10:57
*** pawels1 has joined #openstack-horizon11:00
*** dulek_ has joined #openstack-horizon11:00
amotokimrunge: in addition, the other one multi-nic patch for Cisco n1kv introduces two new strings but the author has no action over a week.11:01
amotokimrunge: The patch lives for a long time over 6 months, so I think it should be out of juno. I will leave a comment.11:01
mrungeamotoki, thanks, every comment is helpful here11:02
*** pawels has quit IRC11:02
*** dulek has quit IRC11:03
*** pkoniszewski has quit IRC11:03
*** pkoniszewski has joined #openstack-horizon11:03
*** jacalcat has joined #openstack-horizon11:04
*** dulek_ has quit IRC11:07
*** dulek_ has joined #openstack-horizon11:08
*** dulek_ has quit IRC11:08
*** dulek_ has joined #openstack-horizon11:08
*** bradjones has joined #openstack-horizon11:09
*** bradjones has quit IRC11:09
*** bradjones has joined #openstack-horizon11:09
*** e0ne has joined #openstack-horizon11:10
bradjonesamotoki: ping11:12
amotokibradjones: pong11:12
bradjonesfor this patch https://review.openstack.org/#/c/118478/ I moved most of the logic to usage.quotas11:12
bradjonescould you let me know if that was the sort of refactor you had in mind11:13
amotokibradjones: looking11:15
*** vkmc has joined #openstack-horizon11:16
*** vkmc has quit IRC11:16
*** vkmc has joined #openstack-horizon11:16
bradjonesamotoki: thanks11:16
amotokibradjones: the general direciton looks good but the logic inside usage.quotas seems to need more improvement.11:24
amotokibradjones: unfortunately I don't have enough time to comment the detail of my points at the moment.11:24
amotokibradjones: will look tomorrow.11:24
bradjonesamotoki: ok sure thanks11:25
*** dulek_ has quit IRC11:28
*** dulek_ has joined #openstack-horizon11:28
*** mrunge has quit IRC11:39
*** jpomero has quit IRC11:51
*** hhuang has quit IRC11:51
*** cedrics has joined #openstack-horizon11:58
*** jacalcat has quit IRC12:04
*** tnovacik|afk has joined #openstack-horizon12:04
*** ZZelle has joined #openstack-horizon12:09
*** tnovacik|afk has quit IRC12:12
*** dulek_ has quit IRC12:15
*** e0ne has quit IRC12:18
*** e0ne has joined #openstack-horizon12:19
*** pkoniszewski has quit IRC12:24
thiagopgood day everyone12:28
thiagopjcoufal: have you received my e-mail?12:28
jcoufalthiagop: I did, just havn't had chance to look at it in more details yet12:29
jcoufalthiagop: Will try to answer today12:30
thiagopOk. If you'd like to take a look at the code: https://review.openstack.org/#/c/119385/12:30
thiagopjcoufal: but just feedback on the experience if more than fine :)12:35
thiagopis*12:35
*** Drago1 has joined #openstack-horizon12:37
*** neillc has quit IRC12:40
jcoufalthiagop: sure ;)12:42
jcoufaland sorry for the delay12:42
*** dulek has joined #openstack-horizon12:45
*** Drago1 has quit IRC12:47
*** neillc_ has joined #openstack-horizon12:47
*** sayan has quit IRC12:55
*** dulek has quit IRC12:55
*** doug-fish has joined #openstack-horizon12:58
*** _crobertsrh is now known as crobertsrh13:00
*** alexpilotti has quit IRC13:00
*** Longgeek has quit IRC13:04
*** tzumainn has joined #openstack-horizon13:08
*** jacalcat has joined #openstack-horizon13:08
*** julim has joined #openstack-horizon13:10
rbertramamotoki: I'm thinking about how to address your concern about https://review.openstack.org/#/c/120242/. Doug suggested that the DATEPICKER_LOCALES list might have a (commented-out) line for each line in the LANGUAGES list. Would that help remember to change both?13:11
thiagopjcoufal: np13:12
rbertramamotoki: Also, is there any other place where we could put a reminder that one would see when adding languages or updating datepicker version?13:12
*** pawels1 has quit IRC13:13
doug-fishrbertram: amotoki:  What about putting a comment right above the LANGUAGES setting noting that when it is updated DATEPICKER_LOCALES should also be updated?13:14
*** pkoniszewski has joined #openstack-horizon13:15
amotokirbertram: doug-fish: Let me clarify some points first. Can we have all languages available in datepicker in DATEPICKER_LOCALES?13:16
amotokirbertram: In my understanding, only languages in LANGUAGES can be selected but DATEPICKER_LOCALES can have more entries.13:16
amotokirbertram: If not, DATEPICKER_LOCALES needs to be maintained in sync with LANGUAGES.13:17
*** dulek has joined #openstack-horizon13:17
*** pawels has joined #openstack-horizon13:18
amotokirbertram: If can, I think it is better to explore the better place which have a complete list of DATEPICKER_LOCALES (now I am exploring).13:18
*** peristeri has joined #openstack-horizon13:19
doug-fishamotoki:  One of the challenges is that the languages supported by Horizon and the languages supported by DATEPICKER_LOCALES are overlapping sets, but there are a few languages that Horizon supports which don't have a translation available in the datepicker ...13:20
doug-fishone of the outcomes I liked about making the language mapping configurable is that a distro or installation could choose to override the mapping and decide that a different language calendar was a better fallback if a direct translation wasn't available13:21
*** ddieterly has quit IRC13:21
*** Longgeek has joined #openstack-horizon13:21
amotokidoug-fish: yes, I know. I think I understand the need of DATEPICKER_LOCALES. I don't oppose introducing DATEPICKER_LOCALES itself.13:21
doug-fishokay - maybe it's better for me to wait for you to complete your exploration so I can understand better what you are thinking13:22
amotokidoug-fish: rbertram: one more. Is there any reason, datepicker templatetag is defined in not openstack_dashboard/templatetags but horizon/templatetag?13:23
rbertramamotoki: I have a meeting in a minute, so will be away. But it is a reasonable idea to put ALL the LANGUAGES languages in DATEPICKER_LANGUAGES, making them set specifically to "en" instead of defaulting.13:23
rbertramDATEPICKER_LOCALES I mean13:24
doug-fishrbertram:  I like the idea of including en mappings explicitly13:24
doug-fishI thought that wasn't an option13:24
*** pkoniszewski has quit IRC13:24
rbertramamotoki, doug-fish: I think we can do that. It's just redundant with what the default would have been, so it felt wrong.13:25
doug-fishamotoki:  I expected the datepicker templatetag to be defined in horizon because its a general utility for building all sorts of dashboards, not just openstack.13:26
rbertramamotoki, doug-fish: The way it is now will handle forgetting to add to DATEPICKER_LOCALES, but amotiki's point is that he wants it to force him to be hands-on13:26
amotokirbertram: thanks. I need more thought...13:27
*** cbader has joined #openstack-horizon13:28
amotokidoug-fish: thanks. agree. all changes are inside horizon.13:28
*** neillc_ has quit IRC13:31
*** jpomero has joined #openstack-horizon13:32
*** jpomero has quit IRC13:32
*** jpomero has joined #openstack-horizon13:34
*** Sukhdev has joined #openstack-horizon13:34
*** ZZelle_ has joined #openstack-horizon13:34
ZZelle_amotoki, hi13:35
*** Longgeek has quit IRC13:39
*** k4n0 has quit IRC13:40
*** sigmavirus24_awa is now known as sigmavirus2413:45
*** Longgeek has joined #openstack-horizon13:48
amotokiZZelle_: hi13:48
*** ddieterly has joined #openstack-horizon13:49
amotokiZZelle_: Thanks for updating a new version. It is really nice.13:53
*** Sukhdev has quit IRC13:53
*** ihrachyshka has joined #openstack-horizon13:56
*** rodrigods_ has joined #openstack-horizon13:57
*** gursimran has joined #openstack-horizon13:58
*** viklund_ has joined #openstack-horizon14:00
*** lcheng has quit IRC14:01
*** gary-smith_ has joined #openstack-horizon14:04
*** amerine_ has joined #openstack-horizon14:05
*** rodrigods_ has quit IRC14:05
*** pawels has quit IRC14:06
*** neelashah has joined #openstack-horizon14:08
*** ihrachyshka_ has joined #openstack-horizon14:08
*** aix has quit IRC14:10
*** ihrachyshka has quit IRC14:10
*** ygbo has quit IRC14:10
*** harlowja_away has quit IRC14:10
*** gary-smith has quit IRC14:10
*** viklund has quit IRC14:10
*** amerine has quit IRC14:10
*** coolsvap has quit IRC14:10
*** rodrigods_ has joined #openstack-horizon14:11
*** ericpeterson has joined #openstack-horizon14:12
*** lcheng has joined #openstack-horizon14:13
*** aix has joined #openstack-horizon14:15
*** ygbo has joined #openstack-horizon14:17
*** coolsvap has joined #openstack-horizon14:20
*** MaxV has quit IRC14:21
*** david-lyle has joined #openstack-horizon14:22
*** rodrigods_ has quit IRC14:23
*** lcheng has quit IRC14:23
*** jcoufal has quit IRC14:28
*** rwsu has quit IRC14:29
*** gursimran has quit IRC14:39
*** lcheng has joined #openstack-horizon14:43
*** mflobo_ has joined #openstack-horizon14:43
*** mflobo_ has quit IRC14:43
amotokidoug-fish: I am not thinking an idea that DATEPICKER_LOCALES is defined in some separate module and import it in openstack_dashboard.settings.14:44
*** jprovazn has quit IRC14:44
amotokidoug-fish: A candidate of the module location in my mind is horizon/contrib/datepicker.py. It is a config related to third-party module.14:45
amotokidoug-fish: what do you think?14:45
*** sayali_ has joined #openstack-horizon14:45
doug-fishamotoki:  I'm unclear about what the benfit would be.  Why put it into a separate file?14:46
amotokidoug-fish: Per my question above, DATEPICKER_LOCALES can have languages not included in LANGUAGES.14:46
amotokidoug-fish: it means that DATEPICKER_LOCALES can be maintained only when there is some change in datepicker.14:47
doug-fishoh I see14:47
amotokidoug-fish: if datepicker adds a new language, we can edit the file.14:47
doug-fishso the idea is that DATEPICKER_LOCALES should include a mapping for every language that is in the widget, even if Hoirzon doesn't use it14:48
*** sayali has quit IRC14:48
*** mflobo has quit IRC14:48
*** davelowe has quit IRC14:48
*** sseago has quit IRC14:48
* doug-fish thinking14:48
*** masco has quit IRC14:48
*** rodrigods_ has joined #openstack-horizon14:49
doug-fishyeah that seems like a good idea.  If I understand correctly values could still be overriden in local_settings.py if desired.14:49
doug-fishamotoki: do we have any examples of configuration that is done like that today?14:50
*** rodrigods_ has quit IRC14:50
ericpetersonI don't have examples of that doug-fish.... but that is done frequently with local_setting.py14:50
amotokidoug-fish: i don't think so...14:51
ericpetersondoug-fish:  like if you wanted to have a different session persistence layer.... that could go in local_settings.py and override settings.py14:52
doug-fishericpeterson: sure, I just had to think for a minute if putting DATEPICKER_LOCALES into a separate file would matter.  I'm convinced it doesn't.14:53
*** lcheng has quit IRC14:53
doug-fishericpeterson: amotoki:  well this all makes sense to me.  Now it's just a simple matter of rbertram doing the work.   :-D14:53
amotokidoug-fish: I am also thinkng to change templatetags to http://paste.openstack.org/show/113340/ ?14:53
amotokidoug-fish: thought?14:53
amotokidoug-fish: we can omit DATEPICKER_LOCALES in the default settings, but we can still override or control datepicker locale mapping.14:54
peristeridavid-lyle: ping14:54
amotokidoug-fish: if rbertram don't mind it, I can upload my idea to his review based on our discussion here.14:56
*** sseago has joined #openstack-horizon14:56
doug-fishamotoki: your pastebin surprises me ... if the new horizon/contrib/datepicker.py configuration is included in settings.py, is that change needed?14:57
*** jayb-atl has joined #openstack-horizon14:57
*** jayb-atl has quit IRC14:57
doug-fishor are you thinking that's a replacement to keep it out of the settings?14:57
amotokidoug-fish: on the second idea, datepicker config is not imported in openstack_dashboard.settings.14:58
david-lyleperisteri: pong14:58
*** jayb-home-atl has joined #openstack-horizon14:59
david-lyle@all, I'm going to release django_openstack_auth today, as this is the deadline, any qualms with that?14:59
amotokidoug-fish: I am not sure we need to make it configurable, but I also think your point to allow distributions to control as they want is important. It is a balance of simplicity and flexibility.14:59
doug-fishamotoki:  I'm not sure I have a strong opinion either way yet.  I think I have a mild preference for including it through the settings, with the idea it might be easier to find through code inspection that way.14:59
*** absubram has joined #openstack-horizon14:59
peristeridavid-lyle: I was wandering if you can look at some encoding bugs?15:00
peristerihttps://bugs.launchpad.net/horizon/+bug/134773415:00
peristerihttps://bugs.launchpad.net/horizon/+bug/134638615:00
doug-fishI've certainly learned more about the Horizon settings through code inspection that by reading any documentation.  Maybe that's just me.15:00
*** ihrachyshka__ has joined #openstack-horizon15:01
david-lyleperisteri: looking15:01
*** jayb-home-atl is now known as jay-atl-home15:02
peristeridavid-lyle: great thanks.15:02
doug-fishamotoki:  really either way (include the settings or modify the tag) meets the need from my perspective.  I don't have a strong preference.15:03
amotokidoug-fish: horizon configuration is a bit tricky to me too. we don't have a good way to provide the default option :-(   IMHO settings (not local_setting.py) has good defaults and there is no need to cover all settings. The document can cover it.15:03
*** krotscheck_ has joined #openstack-horizon15:05
*** crobertsrh has quit IRC15:05
*** sambetts has quit IRC15:05
*** athomas has quit IRC15:05
*** krotscheck has quit IRC15:05
*** ihrachyshka_ has quit IRC15:05
*** ZZelle has quit IRC15:05
*** krotscheck_ is now known as krotscheck15:05
*** athomas has joined #openstack-horizon15:05
*** crobertsrh has joined #openstack-horizon15:06
*** sambetts has joined #openstack-horizon15:07
*** ddieterly has quit IRC15:07
*** ZZelle has joined #openstack-horizon15:07
*** lcheng has joined #openstack-horizon15:09
*** dulek has quit IRC15:10
*** MaxV has joined #openstack-horizon15:14
*** tnovacik|afk has joined #openstack-horizon15:17
*** Longgeek_ has joined #openstack-horizon15:20
*** Longgeek has quit IRC15:22
ZZelle_amotoki, thanks for your feedback :)15:25
ZZelle_amotoki, do you know the reason behind https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/firewalls/forms.py#L79-L83?15:26
amotokiZZelle_: I don't know the exact reason. I don't think we need to place the current at the top of the list.15:27
*** vijendar has joined #openstack-horizon15:28
*** romainh has quit IRC15:28
ZZelle_amotoki, ah! it's only for layout15:28
*** romainh has joined #openstack-horizon15:28
amotokiZZelle_: but the current code has a problem that the first element is not displayed in a localized language.15:29
amotokiZZelle_: it is a different thing though.15:29
ZZelle_amotoki, i am on it, there is the same trouble with action15:29
*** pbelanyi_ has joined #openstack-horizon15:29
*** athomas has quit IRC15:29
*** nlahouti has joined #openstack-horizon15:29
*** gugl2 has joined #openstack-horizon15:30
*** mordred_ has joined #openstack-horizon15:31
amotokiZZelle_: my preference is just to remove "protocol_choices = [(protocol, protocol)]" because I think the order is not so important and it is a usual case in Horizon.15:31
*** clds_ has joined #openstack-horizon15:31
*** SlickN1k has joined #openstack-horizon15:31
*** abramley has quit IRC15:31
*** mordred has quit IRC15:31
*** clds has quit IRC15:31
*** pbelanyi has quit IRC15:31
*** gugl has quit IRC15:31
*** SlickNik has quit IRC15:31
*** d0ugal has quit IRC15:31
*** tristanC has quit IRC15:31
*** hhuang has joined #openstack-horizon15:31
*** mordred_ is now known as mordred15:31
*** SlickN1k is now known as SlickNik15:31
ZZelle_amotoki, the order important because the form chooses by default the first one in list15:31
ZZelle_amotoki, i just realize it (not ihm used :))15:32
*** akrivoka has quit IRC15:32
*** abramley has joined #openstack-horizon15:32
*** akrivoka has joined #openstack-horizon15:32
amotokiZZelle_: no, If the initial is appropriately set, the specified one is selected regardless of its position in a list.15:32
*** tristanC has joined #openstack-horizon15:33
rbertramamotoki doug-fish: I'm back, catching up on discussion - feel free to put the info (and anything else) into the review15:34
*** d0ugal has joined #openstack-horizon15:35
*** d0ugal is now known as Guest5064815:35
amotokirbertram: Does the discussion above between doug-fish and me provide enough information on the points?15:35
rbertramamotoki: probably, let me study it a few minutes15:36
amotokirbertram: no problem. thanks for your patience.15:36
*** hhuang has quit IRC15:37
amotokiZZelle_: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/routers/views.py#L170-L172 and15:38
amotokiZZelle_: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/routers/forms.py#L87-L9315:38
amotokiZZelle_: I believe they solves your question on the initial choice of the list.15:38
ZZelle_amotoki, great, was looking for examples :)15:38
amotokiZZelle_: the second link is a bit wrong. more correct one is "else"-clause below https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/routers/forms.py#L87-L9315:40
ZZelle_amotoki, the last url seems wrong15:42
amotokiZZelle_: woops :-(   It should be L.95-9715:43
*** jedix__ has joined #openstack-horizon15:44
*** shuffleb1t has joined #openstack-horizon15:45
*** JoshNang_ has joined #openstack-horizon15:45
*** sayan has joined #openstack-horizon15:45
*** JoshNang has quit IRC15:46
*** akrivoka has quit IRC15:46
*** jedix has quit IRC15:46
*** shufflebot has quit IRC15:46
*** akrivoka has joined #openstack-horizon15:46
*** JoshNang_ is now known as JoshNang15:46
*** ddieterly has joined #openstack-horizon15:47
*** Drago has joined #openstack-horizon15:48
*** doug-fish has quit IRC15:49
*** doug-fish has joined #openstack-horizon15:49
*** regebro has quit IRC15:51
*** Drago has quit IRC15:55
*** Drago has joined #openstack-horizon15:55
*** Drago1 has joined #openstack-horizon15:59
*** Drago has quit IRC15:59
*** tnovacik|afk has quit IRC15:59
*** 1JTAADBLA has joined #openstack-horizon15:59
*** Drago has joined #openstack-horizon16:00
rbertramamotoki dougfish: So (1) move DATEPICKER_LOCALES to horizon.contrib (2) Make DATEPICKER_LOCALES include all datepicker locales and all Horizon LANGUAGES (3) change the tag so that settings can override (1).16:04
rbertramamotoki dougfish: Is that the bottom line?16:05
amotokirbertram: per my idea, (1) yes (2) yes about the first half. Are all LANGUAGES not necessarily required? It defaults to 'en', so I think it is not needed.16:07
*** sambetts has quit IRC16:07
amotokirbertram: (3) I am not sure we need to allow settings. per doug-fish's suggestion, yes.16:08
*** vokhrimenko has quit IRC16:08
*** alexpilotti has joined #openstack-horizon16:09
doug-fishrbertram: amotoki:  Agreed.  On 2, I agree with amotoki that we need only include languages from the datepicker.  Adding in the unmapped horizon languages and showing them as english was an idea at one point to help with maintenance, but I believe with this plan, those mappings are not needed or helpful.16:10
rbertramamotoki: I think you are right; only add all the missing datepicker locales. Then if one of those is added to LANGUAGES, it will be supported in the datepicker automatically.16:11
doug-fishI do think (3) settings is a good idea.16:11
rbertramdoug-fish: so you agree with what I said for (3)?16:12
rbertramdoug-fish: I think it is based on the paste from amotoki16:12
doug-fishI agree with "(3) change the tag so that settings can override (1)."16:12
doug-fishwas that the question?16:12
doug-fishyeah, amotoki had a pastebin with a clear way to do that16:13
*** wuhg has quit IRC16:13
rbertramdoug-fish: yep, think I've got what I need. Will work on it early next week.16:13
doug-fishcool!16:13
amotokirbertram: on (2), as you may know, django language list is available at django/conf/locale/__init__.py16:13
rbertramamotoki: no I didn't. I will look at that.16:14
amotokirbertram: thanks for your work. nice!16:14
rbertramamotoki: yes - I can see that I will need that... yw16:14
*** alexpilotti has quit IRC16:15
*** Sukhdev has joined #openstack-horizon16:16
*** sbfox has joined #openstack-horizon16:19
*** EmilyW has joined #openstack-horizon16:19
*** alexpilotti has joined #openstack-horizon16:22
*** pkarikh has quit IRC16:24
*** Guest50648 is now known as d0ugal16:29
*** alexpilotti has quit IRC16:30
*** d0ugal has quit IRC16:30
*** d0ugal has joined #openstack-horizon16:30
*** rwsu has joined #openstack-horizon16:34
*** cedrics has quit IRC16:35
*** ihrachyshka__ has quit IRC16:38
*** ygbo has quit IRC16:41
crobertsrhAny chance we can get some core reviews on https://review.openstack.org/#/c/118885/ ?  Not having it seriously cripples the Sahara/Data Processing UI.16:43
ericpetersonZZelle  - got a second???16:43
ZZelle_ericpeterson, yep16:44
ericpetersonso if the region is going to be sticky (from login to logout).... then DOA will need some amount of cookie code16:44
ZZelle_from login to logout or from logout to login?16:45
ericpetersonfrom logout to login16:45
ericpetersonacross browser sessions I mean too16:45
ZZelle_yes16:45
ericpetersonand you concern is that if region gets set..... that the writing of the cookie should only occur in the horizon project16:46
ZZelle_ericpeterson, yes and no16:46
* ericpeterson can't write code for both yes and no ;)16:47
ZZelle_ericpeterson, cookie management could be done on DOA or horizon16:47
ZZelle_ericpeterson, on both seems wrong16:47
ericpetersonI think it really depends upon the cookie itself, or the item itself16:48
ericpetersonso like the region (whether that is a session setting or a cookie setting, or both)..... that is DOA to manage16:48
ericpetersonand then horizon / openstack_dashboard just reads that for API calls16:49
ericpetersonlike DOA changing the items / page cookie.... yeah, that is wrong as that is a openstack_dashboard item to manage16:50
ZZelle_ericpeterson, if DOA manages cookies, it implies to provide interface to horizon if we want to expose some configuration to the user (through settings frm)16:50
ZZelle_form16:50
ericpetersonI think that is saying that all cookies should be in the settings form, I don't agree with that rule.... but I could see where you are coming from16:52
ZZelle_ericpeterson, and i am not sure it's expected to embed cookie config in DOA ... it seems more like a front end feature than an auth lib feature16:52
ericpetersonyeah, the DOA / auth lib is already messy.... it's not a clean layer just doing authentication16:53
ericpetersonit already has the project / region selection stuff in there16:53
ericpetersonand then openstack_dashboard has url references back to it..... etc.    it's not a clean boundary16:53
*** colinmcnamara has joined #openstack-horizon16:54
ericpetersonthanks for explaining more what you are looking for.   I am not sure I agree with it, or will make the change.... but this helps :D16:54
ericpetersonthere is another change up for this same bug, reviewers can choose which one they like :)16:55
ZZelle_ericpeterson, i also would like to see a better interface between horizon/DOA to know where to put some project/region management customization16:57
*** alexpilotti has joined #openstack-horizon16:58
ericpetersonwe both can agree on that ZZelle_16:59
*** MaxV has quit IRC16:59
*** amcrn has joined #openstack-horizon17:02
*** alexpilotti has quit IRC17:03
*** ZZelle_ has quit IRC17:03
*** dkorn has joined #openstack-horizon17:05
*** ZZelle_ has joined #openstack-horizon17:06
*** rodrigods_ has joined #openstack-horizon17:10
*** Longgeek_ has quit IRC17:10
*** romainh has quit IRC17:11
*** Ala has quit IRC17:12
*** dsneddon has quit IRC17:13
*** alexpilotti has joined #openstack-horizon17:14
ZZelle_Hi everyone,17:14
ZZelle_one question, what is the right place to define Form initial values? In Form classes? Or in FormView classes?17:16
*** sigmavirus24 is now known as sigmavirus24_awa17:16
ericpetersonI think I have seen formview for the initial values17:16
*** Sukhdev has quit IRC17:18
*** clu_ has joined #openstack-horizon17:18
*** jedix__ is now known as jedix17:26
*** rodrigods_ has quit IRC17:29
*** colinmcnamara has quit IRC17:31
*** ArcTanSusan has joined #openstack-horizon17:37
*** zul has joined #openstack-horizon17:37
*** rodrigods_ has joined #openstack-horizon17:39
*** dkorn has quit IRC17:41
*** harlowja has joined #openstack-horizon17:42
*** rodrigods_ has quit IRC17:43
*** Sukhdev has joined #openstack-horizon17:44
*** MaxV has joined #openstack-horizon17:45
*** lcheng has quit IRC17:45
*** lcheng has joined #openstack-horizon17:46
*** rodrigods_ has joined #openstack-horizon17:51
*** akrivoka has quit IRC17:52
crobertsrhThanks guys....the Sahara team will be excited to see that fix get in.17:52
*** sbfox has quit IRC17:53
*** sigmavirus24_awa is now known as sigmavirus2417:53
*** sbfox has joined #openstack-horizon18:03
*** lcheng has quit IRC18:12
*** jacalcat has quit IRC18:13
*** Sukhdev has quit IRC18:14
*** e0ne has quit IRC18:19
*** ttrifonov is now known as ttrifonov_zZzz18:26
*** sbfox has quit IRC18:31
*** vokhrimenko has joined #openstack-horizon18:32
*** rodrigods_ has quit IRC18:33
*** rodrigods_ has joined #openstack-horizon18:34
*** ArcTanSusan has quit IRC18:34
*** neelashah has quit IRC18:38
*** lcheng has joined #openstack-horizon18:40
*** colinmcnamara has joined #openstack-horizon18:40
*** EmilyW has quit IRC18:44
*** harlowja has quit IRC18:46
*** harlowja_ has joined #openstack-horizon18:46
*** e0ne has joined #openstack-horizon18:52
*** e0ne has quit IRC18:55
*** alexpilotti has quit IRC18:57
*** Sukhdev has joined #openstack-horizon18:58
*** Drago has quit IRC18:59
*** e0ne has joined #openstack-horizon18:59
johnmadoes anyone know what the no_autocomplete field in openstack_dashboard/dashboards/identity/users/forms.py is for and if its still needed? Thanks19:00
*** Drago1 has quit IRC19:03
*** neelashah has joined #openstack-horizon19:05
*** aix has quit IRC19:06
ericpetersonjohnma: it helps when the browser decides to remember your password19:06
ericpetersonsome installs may or may not want that type of behavior19:07
*** EmilyW has joined #openstack-horizon19:07
johnmaericpeterson: oh ok, got it. that makes sense. Thanks alot. appreciate it19:07
*** EMW has joined #openstack-horizon19:08
*** doug-fish has left #openstack-horizon19:08
*** Sukhdev has quit IRC19:09
*** EmilyW has quit IRC19:12
*** colinmcnamara has quit IRC19:14
*** sigmavirus24 is now known as sigmavirus24_awa19:17
*** sigmavirus24_awa is now known as sigmavirus2419:18
*** romainh has joined #openstack-horizon19:23
*** e0ne has quit IRC19:26
*** asahlin has quit IRC19:29
*** e0ne has joined #openstack-horizon19:30
*** Sukhdev has joined #openstack-horizon19:30
*** mrunge has joined #openstack-horizon19:33
*** ericpete_ has joined #openstack-horizon19:34
*** ericpeterson has quit IRC19:37
*** e0ne has quit IRC19:37
*** cbader has quit IRC19:39
*** e0ne has joined #openstack-horizon19:41
*** ddieterly has quit IRC19:50
*** morganfainberg is now known as CaptainMorgan19:52
*** ericpeterson has joined #openstack-horizon19:52
*** rodrigods_ has quit IRC19:53
*** nlahouti has quit IRC19:53
*** ihrachyshka has joined #openstack-horizon19:55
*** ericpete_ has quit IRC19:56
*** crobertsrh is now known as _crobertsrh20:08
*** ddieterly has joined #openstack-horizon20:09
*** e0ne has quit IRC20:12
*** david-lyle has quit IRC20:13
*** e0ne has joined #openstack-horizon20:16
*** ddieterly has quit IRC20:19
*** vijendar has quit IRC20:31
*** ddieterly has joined #openstack-horizon20:33
*** sayali_ has quit IRC20:37
*** nlahouti has joined #openstack-horizon20:51
*** bradjones has quit IRC20:57
*** julim has quit IRC21:03
*** sbfox has joined #openstack-horizon21:07
*** ericpeterson has quit IRC21:10
*** romainh has quit IRC21:15
*** lcheng has quit IRC21:15
*** sbfox has quit IRC21:16
*** peristeri has quit IRC21:17
*** e0ne has quit IRC21:18
*** sbfox has joined #openstack-horizon21:23
*** sbfox has quit IRC21:23
*** rbertram has quit IRC21:23
*** alexpilotti has joined #openstack-horizon21:23
*** ddieterly has quit IRC21:24
*** CaptainMorgan is now known as morganfainberg21:28
*** david-lyle has joined #openstack-horizon21:30
*** Sukhdev has quit IRC21:30
*** david-lyle has quit IRC21:30
*** alexpilotti has quit IRC21:31
*** romainh has joined #openstack-horizon21:34
*** romainh has left #openstack-horizon21:34
*** mrunge has quit IRC21:35
*** e0ne has joined #openstack-horizon21:36
*** alexpilotti has joined #openstack-horizon21:38
*** ihrachyshka has quit IRC21:40
*** alexpilotti_ has joined #openstack-horizon21:41
*** alexpilotti has quit IRC21:43
*** alexpilotti_ is now known as alexpilotti21:43
*** e0ne has quit IRC21:43
*** e0ne has joined #openstack-horizon21:49
*** ddieterly has joined #openstack-horizon21:54
*** e0ne has quit IRC21:58
*** harlowja_ has quit IRC22:00
*** harlowja has joined #openstack-horizon22:00
*** sigmavirus24 is now known as sigmavirus24_awa22:00
*** rodrigods_ has joined #openstack-horizon22:00
*** rebelagentm has quit IRC22:03
*** Sukhdev has joined #openstack-horizon22:04
*** absubram has quit IRC22:11
*** Drago1 has joined #openstack-horizon22:11
*** neelashah has quit IRC22:13
*** Drago has joined #openstack-horizon22:23
*** Drago has quit IRC22:28
*** alexpilotti_ has joined #openstack-horizon22:42
*** alexpilotti has quit IRC22:42
*** rodrigods_ has quit IRC22:44
*** alexpilotti has joined #openstack-horizon22:45
*** alexpilotti_ has quit IRC22:46
*** alexpilotti_ has joined #openstack-horizon22:49
*** alexpilotti has quit IRC22:50
*** alexpilotti_ is now known as alexpilotti22:50
*** alexpilotti has quit IRC22:56
*** colinmcnamara has joined #openstack-horizon23:10
*** echevemaster has joined #openstack-horizon23:12
*** Drago has joined #openstack-horizon23:13
*** Drago has quit IRC23:14
*** Drago has joined #openstack-horizon23:14
*** kmartin has quit IRC23:15
*** Drago has quit IRC23:24
*** Sukhdev has quit IRC23:30
*** colinmcnamara has quit IRC23:39
*** amcrn has quit IRC23:39
*** Drago has joined #openstack-horizon23:40
*** Drago has quit IRC23:44
*** halede has quit IRC23:52
*** Drago has joined #openstack-horizon23:53
*** colinmcnamara has joined #openstack-horizon23:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!