*** Drago has joined #openstack-horizon | 00:01 | |
*** harlowja has quit IRC | 00:02 | |
*** harlowja has joined #openstack-horizon | 00:02 | |
*** HenryG has quit IRC | 00:04 | |
*** Sukhdev has quit IRC | 00:09 | |
*** MaxV has joined #openstack-horizon | 00:09 | |
*** MaxV has quit IRC | 00:14 | |
*** packet has joined #openstack-horizon | 00:16 | |
*** tosky has quit IRC | 00:17 | |
*** yjiang5 has quit IRC | 00:18 | |
*** packet has quit IRC | 00:20 | |
*** Drago has quit IRC | 00:25 | |
*** david-lyle has joined #openstack-horizon | 00:25 | |
*** rbertram has quit IRC | 00:28 | |
*** lhcheng has joined #openstack-horizon | 00:42 | |
*** packet has joined #openstack-horizon | 00:43 | |
*** ramishra has joined #openstack-horizon | 00:44 | |
*** rwsu has quit IRC | 00:47 | |
*** packet has quit IRC | 00:48 | |
*** ramishra has quit IRC | 00:49 | |
*** david-lyle has quit IRC | 00:57 | |
*** amcrn has quit IRC | 01:02 | |
*** hightall has joined #openstack-horizon | 01:04 | |
*** MaxV has joined #openstack-horizon | 01:10 | |
*** MaxV has quit IRC | 01:15 | |
*** Drago1 has joined #openstack-horizon | 01:22 | |
*** Drago1 has quit IRC | 01:26 | |
*** ramishra has joined #openstack-horizon | 01:32 | |
*** bpokorny_ has quit IRC | 01:34 | |
*** sunrenjie has joined #openstack-horizon | 01:38 | |
*** packet has joined #openstack-horizon | 01:44 | |
*** halede_ has quit IRC | 01:45 | |
*** nlahouti has quit IRC | 01:45 | |
*** ramishra has quit IRC | 01:47 | |
*** packet has quit IRC | 01:49 | |
*** ramishra has joined #openstack-horizon | 02:05 | |
*** MaxV has joined #openstack-horizon | 02:11 | |
*** dsneddon_ has quit IRC | 02:13 | |
*** dsneddon_ has joined #openstack-horizon | 02:13 | |
*** MaxV has quit IRC | 02:16 | |
*** clu_ has quit IRC | 02:17 | |
*** HenryG has joined #openstack-horizon | 02:26 | |
*** jacalcat has joined #openstack-horizon | 02:28 | |
*** Dragomir has joined #openstack-horizon | 02:33 | |
*** dsneddon_ has quit IRC | 02:33 | |
*** Longgeek has joined #openstack-horizon | 02:33 | |
*** dsneddon_ has joined #openstack-horizon | 02:34 | |
*** harlowja is now known as harlowja_away | 02:37 | |
*** ramishra has quit IRC | 02:37 | |
*** sunrenjie has quit IRC | 02:45 | |
*** ramishra has joined #openstack-horizon | 03:01 | |
*** doe has joined #openstack-horizon | 03:05 | |
*** ramishra has quit IRC | 03:11 | |
*** MaxV has joined #openstack-horizon | 03:12 | |
*** harlowja_away has quit IRC | 03:12 | |
*** MaxV has quit IRC | 03:17 | |
*** hightall has quit IRC | 03:17 | |
*** Drago1 has joined #openstack-horizon | 03:23 | |
*** Drago1 has quit IRC | 03:25 | |
*** colinmcnamara has joined #openstack-horizon | 03:29 | |
*** jacalcat has quit IRC | 03:30 | |
*** ramishra has joined #openstack-horizon | 03:42 | |
*** nlahouti has joined #openstack-horizon | 03:44 | |
*** nlahouti has quit IRC | 03:44 | |
*** nlahouti has joined #openstack-horizon | 03:44 | |
*** ramishra has quit IRC | 03:47 | |
*** vivekd has joined #openstack-horizon | 03:50 | |
*** colinmcnamara has quit IRC | 03:52 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 04:12 | |
*** MaxV has joined #openstack-horizon | 04:12 | |
*** echevemaster has quit IRC | 04:14 | |
*** MaxV has quit IRC | 04:17 | |
*** doe has quit IRC | 04:30 | |
*** tzumainn has quit IRC | 04:31 | |
*** sayan_ has joined #openstack-horizon | 04:34 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 05:02 | |
*** lhcheng has quit IRC | 05:09 | |
*** lhcheng has joined #openstack-horizon | 05:09 | |
*** nikunj2512 has joined #openstack-horizon | 05:10 | |
*** MaxV has joined #openstack-horizon | 05:13 | |
*** lhcheng has quit IRC | 05:14 | |
*** sayan has quit IRC | 05:17 | |
*** MaxV has quit IRC | 05:18 | |
*** Drago has joined #openstack-horizon | 05:24 | |
*** lhcheng has joined #openstack-horizon | 05:28 | |
*** Drago has quit IRC | 05:28 | |
*** yjiang5 has joined #openstack-horizon | 05:29 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 05:29 | |
*** ramishra has joined #openstack-horizon | 05:33 | |
*** ramishra has quit IRC | 05:38 | |
*** yjiang51 has joined #openstack-horizon | 05:39 | |
*** yjiang5 has quit IRC | 05:40 | |
*** MaxV has joined #openstack-horizon | 05:45 | |
*** masco has joined #openstack-horizon | 05:46 | |
*** packet has joined #openstack-horizon | 05:49 | |
*** romainh has joined #openstack-horizon | 05:52 | |
*** packet has quit IRC | 05:54 | |
*** dsneddon_ has quit IRC | 05:54 | |
*** dsneddon_ has joined #openstack-horizon | 05:55 | |
*** mrunge has joined #openstack-horizon | 06:11 | |
*** lhcheng has quit IRC | 06:15 | |
*** d0m0reg00dthing has joined #openstack-horizon | 06:23 | |
*** k4n0 has joined #openstack-horizon | 06:34 | |
*** ramishra has joined #openstack-horizon | 06:34 | |
*** regebro has quit IRC | 06:37 | |
*** regebro has joined #openstack-horizon | 06:38 | |
*** MaxV has quit IRC | 06:38 | |
*** jcoufal has joined #openstack-horizon | 06:39 | |
*** ramishra has quit IRC | 06:39 | |
*** jprovazn has joined #openstack-horizon | 06:41 | |
*** mattt has joined #openstack-horizon | 06:41 | |
*** d0m0reg00dthing has quit IRC | 06:47 | |
*** d0m0reg00dthing has joined #openstack-horizon | 06:47 | |
*** ygbo has joined #openstack-horizon | 06:47 | |
*** d0m0reg00dthing has quit IRC | 06:47 | |
*** d0m0reg00dthing has joined #openstack-horizon | 06:48 | |
*** Dragomir has quit IRC | 06:49 | |
*** Ala has joined #openstack-horizon | 06:49 | |
*** packet has joined #openstack-horizon | 06:50 | |
*** d0m0reg00dthing has quit IRC | 06:50 | |
*** d0m0reg00dthing has joined #openstack-horizon | 06:50 | |
*** d0m0reg00dthing has quit IRC | 06:53 | |
*** d0m0reg00dthing has joined #openstack-horizon | 06:53 | |
*** packet has quit IRC | 06:54 | |
*** nlahouti has quit IRC | 06:54 | |
*** ttrifonov is now known as ttrifonov_zZzz | 06:56 | |
*** packet has joined #openstack-horizon | 06:58 | |
*** rdopieralski has joined #openstack-horizon | 06:59 | |
*** coolsvap|afk is now known as coolsvap | 07:02 | |
*** packet has quit IRC | 07:03 | |
*** udaycode has joined #openstack-horizon | 07:04 | |
*** yjiang51 has quit IRC | 07:05 | |
*** vokhrimenko has joined #openstack-horizon | 07:05 | |
udaycode | anyone has sample code to add panel group in dashboard through local/enabled setting? | 07:05 |
---|---|---|
rdopieralski | I have one for replacing a panel with another panel | 07:09 |
rdopieralski | not sure you can add another group | 07:09 |
udaycode | rdopieralski: I am following this link http://docs.openstack.org/developer/horizon/topics/settings.html#pluggable-settings-label | 07:10 |
rdopieralski | sure | 07:11 |
udaycode | it is confusing, if we need to add panel group, we also need to add panels in different files? these docs are never clear | 07:11 |
rdopieralski | why do you need to add a panel group? | 07:11 |
rdopieralski | you want to have a panel group without panels? | 07:12 |
udaycode | no, i want to add a panel group with two panels | 07:12 |
udaycode | if I just create file like "_90_admin_add_panel_group.py", will it automatically take the panels? | 07:13 |
rdopieralski | then you need two files, one per panel | 07:13 |
rdopieralski | the idea is that later configuration can override individual files | 07:14 |
udaycode | rdopieralski: I think I need three files, one for panel group and two for each panel, right? | 07:14 |
rdopieralski | no | 07:14 |
rdopieralski | panel group doesn't have a separate file | 07:14 |
rdopieralski | hmm | 07:15 |
rdopieralski | no, wait | 07:15 |
rdopieralski | maybe it does | 07:15 |
rdopieralski | sorry, ignore me | 07:15 |
rdopieralski | yeah, you need three, it seems | 07:15 |
udaycode | yes, it is confusing, anyway, I added files, but they are not showing up and no error | 07:15 |
rdopieralski | I made the initial mechanism for dashboards only, later someone extended it to panels and groups | 07:15 |
rdopieralski | udaycode: did you restart horizon? | 07:16 |
udaycode | yes | 07:16 |
rdopieralski | the files have .py extension? | 07:16 |
rdopieralski | also, are you using Juno? | 07:17 |
rdopieralski | or Icehouse? | 07:17 |
*** pkoniszewski has joined #openstack-horizon | 07:21 | |
*** sayan has joined #openstack-horizon | 07:23 | |
*** k4n0 has quit IRC | 07:24 | |
rdopieralski | udaycode: can you pastebin your files? | 07:27 |
*** k4n0 has joined #openstack-horizon | 07:28 | |
*** ramishra has joined #openstack-horizon | 07:35 | |
*** MaxV has joined #openstack-horizon | 07:35 | |
*** sayan_ has quit IRC | 07:37 | |
*** ramishra has quit IRC | 07:39 | |
udaycode | i am using juno | 07:42 |
*** ttrifonov_zZzz is now known as ttrifonov | 07:42 | |
udaycode | rdopieralski: there is nothing to pastebin, i just started not sure where to begin | 07:43 |
rdopieralski | udaycode: didn't you just write that you added the files? | 07:44 |
udaycode | rdipieralski: I added the file as the sample given in that link | 07:45 |
udaycode | let me type it | 07:45 |
*** jpich has joined #openstack-horizon | 07:47 | |
udaycode | in my add_panel.py PANEL = 'endpoint_groups_panel' | 07:47 |
udaycode | PANEL_DASHBOARD = 'project' | 07:47 |
udaycode | PANEL_GROUP = 'group-based-policy-ui.panel_group.GroupPolicyPanels' | 07:47 |
udaycode | ADD_PANEL = 'group-based-policy-ui.panels.contracts.panel.Contract' | 07:47 |
rdopieralski | group-based-policy-ui is not a valid python module name | 07:48 |
udaycode | ok | 07:49 |
rdopieralski | also, you need ADD_INSTALLED_APPS | 07:49 |
rdopieralski | in one of them | 07:49 |
rdopieralski | to make horizon actually import your application | 07:49 |
mattt | anyone know why devstack doesn't properly install horizon? | 07:49 |
mattt | (ie. doesn't pip install it) | 07:49 |
rdopieralski | mattt: because it's broken? | 07:49 |
mattt | rdopieralski: broken how? | 07:49 |
jpich | It shouldn't pip install it, but clone it into /opt/stack/horizon ? | 07:50 |
udaycode | rdopieralski:ok, let me change the name and try | 07:50 |
rdopieralski | jpich: what about all the plugins that require it? | 07:50 |
rdopieralski | jpich: how are they supposed to import it when it's not installed? | 07:50 |
jpich | rdopieralski: My understanding is that devstack sets up the paths so all the master branches are used like that, like for the clients | 07:50 |
jpich | but my understanding may well be incomplete :) | 07:51 |
mattt | i did a pip install on my test environment, but then the xstatic stuff doesn't load | 07:51 |
mattt | however it all works fine on devstack and that has apache just pointing to the dir where it was cloned | 07:51 |
rdopieralski | mattt: pip install -r requirements.txt | 07:51 |
mattt | rdopieralski: the xstatic stuff is installed, but it doesn't get loaded | 07:51 |
mattt | i get 404s for all the stuff installed via xstatic packages | 07:51 |
rdopieralski | mattt: did you run collectstatic? | 07:52 |
mattt | rdopieralski: so that's my next question :) | 07:52 |
mattt | rdopieralski: if i run collecstatic and point /static to where-ever that gets collected to, it all works fine | 07:52 |
mattt | but i'm just wondering why devstack does it differently and i want to ensure i'm doing it the right way | 07:52 |
rdopieralski | that's how it should work on production | 07:52 |
rdopieralski | devstack doesn't run horizon on apache, does it? | 07:53 |
mattt | yeah it does | 07:53 |
rdopieralski | but in debug mode? | 07:53 |
mattt | i believe so | 07:53 |
rdopieralski | django handles static files differently in debug mode | 07:53 |
mattt | ok, but it's fine to assume that collectstatic needs to be run in production, and i should point /static in apache to the dir collecstatic dumps things to? | 07:54 |
mattt | if so i'm happy w/ that | 07:54 |
rdopieralski | so that you don't have to write collectstatic every time you change something | 07:54 |
rdopieralski | mattt: yup | 07:54 |
mattt | that works for me, thank you rdopieralski | 07:54 |
udaycode | rdopieralski: It worked! but the panel group names coming as "other", anyway, I can figure it out, Thanks | 07:57 |
rdopieralski | udaycode: awesome! | 07:57 |
*** sayan_ has joined #openstack-horizon | 07:58 | |
*** packet has joined #openstack-horizon | 07:59 | |
*** athomas has joined #openstack-horizon | 08:00 | |
*** aix has joined #openstack-horizon | 08:01 | |
*** packet has quit IRC | 08:03 | |
*** Longgeek has quit IRC | 08:07 | |
nikunj2512 | Hi, i need some help in a test case of this patch - https://review.openstack.org/#/c/126247/8. This is error i am getting - http://paste.openstack.org/show/120093/. the other test cases for the same functionality after modification are working fine but this one is not | 08:07 |
*** akrivoka has joined #openstack-horizon | 08:33 | |
*** ramishra has joined #openstack-horizon | 08:33 | |
*** e0ne has joined #openstack-horizon | 08:34 | |
rdopieralski | ugh, mox | 08:50 |
* rdopieralski hides | 08:50 | |
nikunj2512 | rdopieralski: yes mox | 08:51 |
rdopieralski | burn it with fire | 08:52 |
nikunj2512 | rdopieralski: I wish but can't :p | 08:54 |
*** ramishra has quit IRC | 08:55 | |
mrunge | nikunj2512, use --failfast | 08:56 |
mrunge | when calling run_tests.sh | 08:56 |
mrunge | to see the first error | 08:57 |
nikunj2512 | mrunge: Ok | 08:57 |
nikunj2512 | let me run it | 08:57 |
mrunge | nikunj2512, and a side note: a git checkout etc, runs very well without root rights | 08:59 |
mrunge | but running that stuff as a root user *might* hide other issues | 08:59 |
nikunj2512 | mrunge: Ok, So, will i checkout the code again as non-root user and try the ruuning tests?? | 09:00 |
mrunge | nikunj2512, your issue really shouldn't be connected with that | 09:01 |
mrunge | that was just a side remark | 09:01 |
nikunj2512 | mrunge: Ok, thank You | 09:01 |
*** cedrics has joined #openstack-horizon | 09:02 | |
*** pkoniszewski has quit IRC | 09:03 | |
*** masco has quit IRC | 09:04 | |
*** exploreshaifali has joined #openstack-horizon | 09:04 | |
*** exploreshaifali has left #openstack-horizon | 09:05 | |
*** Longgeek has joined #openstack-horizon | 09:05 | |
*** exploreshaifali has joined #openstack-horizon | 09:07 | |
*** Longgeek has quit IRC | 09:07 | |
*** Longgeek has joined #openstack-horizon | 09:08 | |
nikunj2512 | mrunge: here is the output of the ./runtest.sh - http://paste.openstack.org/show/120101/ | 09:09 |
* mrunge clicks | 09:09 | |
mrunge | nikunj2512, AttributeError: 'VolumeSnapshot' object has no attribute '_volume' | 09:10 |
mrunge | does that ring a bell at you? | 09:10 |
*** exploreshaifali has quit IRC | 09:11 | |
jpich | This is due to https://bugs.launchpad.net/horizon/+bug/1378907 | 09:11 |
nikunj2512 | mrunge: yes but i am not changing volume code | 09:11 |
nikunj2512 | i am changing network code | 09:11 |
jpich | You could try applying akrivoka's patch and see what problems remain if any. This is a problem on master too | 09:12 |
*** exploreshaifali has joined #openstack-horizon | 09:12 | |
nikunj2512 | mrunge: rest of the result | 09:12 |
nikunj2512 | mrunge: rest of the result of the test - http://paste.openstack.org/show/120102/ | 09:12 |
mrunge | that's a good suggestion | 09:12 |
nikunj2512 | jpich: Can you provide me the link for akrivoka's patch?? | 09:13 |
jpich | nikunj2512: It's linked in the bug report I just pasted :) | 09:14 |
mrunge | nikunj2512, to clear up output, you should rebase your patch in top of akrivokas patch | 09:14 |
nikunj2512 | jpich: Thank You :) | 09:14 |
nikunj2512 | mrunge: OK | 09:14 |
jpich | You're welcome, good luck! | 09:14 |
nikunj2512 | mrunge: And thank You :) | 09:14 |
mrunge | nikunj2512, I didn't do anything ;-) | 09:15 |
mrunge | jpich, had the pointer nikunj2512 | 09:15 |
*** akrivoka has quit IRC | 09:15 | |
nikunj2512 | jpich: i seriously need luck, i am trying to fix this test case problem from days but not reaching anywhere :( | 09:15 |
* jpich sends another wave of luck | 09:16 | |
nikunj2512 | jpich: :):) | 09:18 |
*** ramishra has joined #openstack-horizon | 09:19 | |
*** dsneddon_ has quit IRC | 09:22 | |
nikunj2512 | jpich, mrunge : running the tests again after rebase | 09:22 |
*** dsneddon_ has joined #openstack-horizon | 09:23 | |
*** cedrics has quit IRC | 09:27 | |
*** exploreshaifali has quit IRC | 09:27 | |
*** ramishra has quit IRC | 09:29 | |
*** sayan_ has quit IRC | 09:29 | |
nikunj2512 | mrunge: i tested the code again after rebase and all the other errors cleared out. Please see the log here - http://paste.openstack.org/show/120109/ | 09:32 |
*** sambetts has joined #openstack-horizon | 09:34 | |
mrunge | nikunj2512, did you mock network_delete somewhere? | 09:35 |
nikunj2512 | mrunge: Yes | 09:36 |
mrunge | nikunj2512, apparently that's not called | 09:37 |
nikunj2512 | mrunge: So, how can i figure out why it is not called?? | 09:37 |
nikunj2512 | mrunge: it is also not giving any pythonic error | 09:37 |
mrunge | nikunj2512, good question. last time I debugged such an issue by hand | 09:38 |
*** cedrics has joined #openstack-horizon | 09:38 | |
nikunj2512 | mrunge: ok :( | 09:39 |
nikunj2512 | mrunge: any suggestion, from where i can start?? | 09:40 |
mrunge | nikunj2512, where is your code change? | 09:40 |
mrunge | link? | 09:40 |
nikunj2512 | mrunge: one minute | 09:41 |
nikunj2512 | mrunge: https://review.openstack.org/#/c/126247/ | 09:42 |
*** sayan_ has joined #openstack-horizon | 09:44 | |
mrunge | nikunj2512, it's the no_subnet test | 09:45 |
mrunge | nikunj2512, what happens, if there is no subnet? | 09:45 |
nikunj2512 | mrunge: See L716 | 09:46 |
nikunj2512 | mrunge: this is the testw which is failing | 09:46 |
mrunge | yes | 09:47 |
nikunj2512 | mrunge: And mock for subnet_list is not required because it is not called in the code | 09:48 |
*** qba73 has joined #openstack-horizon | 09:49 | |
*** d0m0reg00dthing has quit IRC | 09:58 | |
*** ramishra has joined #openstack-horizon | 10:00 | |
*** athomas has quit IRC | 10:00 | |
*** packet has joined #openstack-horizon | 10:01 | |
*** tosky has joined #openstack-horizon | 10:01 | |
*** cedrics has quit IRC | 10:02 | |
sambetts | Hi nikunj2512 o/ | 10:02 |
*** ramishra has quit IRC | 10:04 | |
*** packet has quit IRC | 10:05 | |
NikitaKonovalov | Hi, there's an improtant patch for Sahara https://review.openstack.org/#/c/125927/ can anyone help reviewing that? | 10:07 |
sambetts | nikunj2512: The reason you won't see any pythonic errors when running the tests is because the code is catching all Exceptions and I guess is easting the error message | 10:07 |
sambetts | s/easting/eating | 10:07 |
*** athomas has joined #openstack-horizon | 10:07 | |
sambetts | thats why I would suggest either adding prints at stratigic points throughout the talbes code or if you use an IDE and it supports it add break points | 10:08 |
sambetts | also I don't know if the code you have on review.openstack.org is the most but to me the your mocking of network_get still looks wrong, isn't self.network.first()'s subnet list expanded, not just the list of ids? | 10:14 |
sambetts | s/most/most recent | 10:14 |
*** akrivoka has joined #openstack-horizon | 10:15 | |
nikunj2512 | Hi Sambetts | 10:16 |
sambetts | o/ | 10:16 |
nikunj2512 | Sambetts: code on the review is the lastest one | 10:17 |
nikunj2512 | Sambetts: i am putting the print statements in the code. lets see | 10:18 |
pkarikh | nikunj2512, I totally agree with Sam - use prints or breakpoints to get where does your code stop runing - the error should be somwhere in that place. I also pointed out in your review. | 10:20 |
nikunj2512 | pkarikh: i am doing what You and Sam suggested but getting no where | 10:22 |
pkarikh | nikunj2512, you can also use pdb for debug something like this: "import pdb; pdb.set_trace()" - put this string in yout code and when execution reaches this point, you will be able to run commands as console. | 10:22 |
nikunj2512 | pkarikh: OK, let me try. thank You | 10:23 |
sambetts | pkarikh: thats really interesting to know!! ! | 10:23 |
pkarikh | nikunj2512, you’re welcome) If you need, you can get more about pdb commands here: https://docs.python.org/2/library/pdb.html | 10:27 |
pkarikh | sambetts, :) | 10:27 |
nikunj2512 | pkarikh: Ok | 10:27 |
*** alexpilotti has joined #openstack-horizon | 10:28 | |
*** krykowski has joined #openstack-horizon | 10:34 | |
*** jprovazn has quit IRC | 10:36 | |
pkarikh | nikunj2512, is there any progress? | 10:47 |
akrivoka | doug-fish: ping | 10:48 |
*** Longgeek has quit IRC | 10:52 | |
*** tosky has quit IRC | 10:54 | |
*** qba73 has quit IRC | 10:54 | |
mrunge | rdopieralski, may I have your attention? | 10:55 |
mrunge | do we use glyphicons in bootstrap-scss? | 10:55 |
mrunge | http://getbootstrap.com/components/ | 10:55 |
mrunge | they are not free | 10:55 |
mrunge | zigo, do you provide xstatic-bootstrap-scss in debian? | 10:57 |
rdopieralski | mrunge: yeah, I know, that's why I'm working on replacing them all with font awesome | 10:57 |
zigo | mrunge: Yup. | 10:57 |
mrunge | rdopieralski, we don't use fonts from bootstrap-scss? | 10:57 |
mrunge | zigo http://getbootstrap.com/components/ | 10:57 |
zigo | mrunge: https://packages.debian.org/sid/python-xstatic-bootstrap-scss | 10:57 |
zigo | mrunge: That's one of the few packages for which I didn't write a specific libjs-* package. | 10:58 |
mrunge | I just had feedback from review in fedora. | 10:58 |
zigo | The reason is that there's already a libjs-bootstrap in Debian, but it's version 2, and also the bootstrap-saas thing has some ruby components, which I don't want to maintain, and wouldn't know how to manage / test / use. | 10:58 |
rdopieralski | mrunge: we do, indirectly, I working on fixing it | 10:58 |
mrunge | and we might need to talk with a lawyer about including bootstrap-scss | 10:59 |
mrunge | IMHO it's not distributable by a linux distro | 10:59 |
zigo | mrunge: Which part is problematic? | 10:59 |
*** ramishra has joined #openstack-horizon | 11:00 | |
rdopieralski | mrunge: shouldn't it be fine if we remove the glyphicons? | 11:01 |
mrunge | rdopieralski, yeah, probably | 11:01 |
mrunge | zigo: how do you provide a link back to glyphicons? | 11:01 |
*** packet has joined #openstack-horizon | 11:01 | |
mrunge | zigo: in exact words there: Glyphicons Halflings are normally not available for free, | 11:02 |
mrunge | rdopieralski, removing glyphicons will be safe for us? | 11:02 |
mrunge | I mean: code wise? | 11:02 |
sambetts | font-awesome provides a good alternative | 11:02 |
zigo | mrunge: As I wrote, I didn't removed anything from xstatic-bootstrap-scss, I just ship whatever it does, and didn't replace it by symlinks to something else. | 11:03 |
mrunge | zigo, ok I got you. thank you. | 11:04 |
zigo | So the font is there... | 11:04 |
mrunge | glyphicons as well? | 11:04 |
zigo | It's bad if it's non-free. | 11:04 |
zigo | Yeah. | 11:04 |
zigo | Is Horizon using it already? | 11:04 |
zigo | I think this deserves a mail to the dev list. | 11:04 |
*** ramishra has quit IRC | 11:05 | |
zigo | mrunge: How can we see it's non-free? | 11:05 |
mrunge | zigo: second sentence on http://getbootstrap.com/components/ | 11:05 |
mrunge | is not available for free | 11:05 |
*** packet has quit IRC | 11:05 | |
*** jprovazn has joined #openstack-horizon | 11:06 | |
sambetts | not normally but is made avaliable used with bootstrap ? | 11:08 |
rdopieralski | sambetts: yeah, means that it's not open source | 11:09 |
sambetts | rdopieralski: Ah, got ya | 11:09 |
rdopieralski | sambetts: you can't take it from bootstrap and build something else with it | 11:09 |
sambetts | rdopieralski: Yeah | 11:09 |
*** john-davidge has joined #openstack-horizon | 11:11 | |
*** ZZelle has quit IRC | 11:11 | |
*** ZZelle has joined #openstack-horizon | 11:11 | |
*** krykowski_ has joined #openstack-horizon | 11:12 | |
rdopieralski | mrunge: that's why we have font-awesome in deps and there is a patch replacing (mostly) all instances of glyphicons in horizon with font-awesome icons, but it didn't make it to Juno | 11:12 |
*** robcresswell has joined #openstack-horizon | 11:12 | |
rdopieralski | mrunge: not enough interest, I guess | 11:12 |
mrunge | damn | 11:12 |
sambetts | could this be a topic for RC2 ? | 11:12 |
mrunge | yes! | 11:12 |
rdopieralski | https://blueprints.launchpad.net/horizon/+spec/font-icons | 11:13 |
zigo | mrunge: I don't agree with you, the fonts are free. | 11:14 |
rdopieralski | there are some icons being used in the sass files, but those are the old bitmap glyphicons which are free | 11:14 |
zigo | mrunge: See: http://glyphicons.com/license/ | 11:14 |
zigo | "GLYPHICONS Halflings are also a part of Bootstrap from Twitter, and they are released under the same license as Bootstrap." | 11:14 |
zigo | That's clear enough ... | 11:14 |
rdopieralski | zigo: only the bitmaps | 11:14 |
mrunge | zigo ok, I agree | 11:15 |
*** krykowski has quit IRC | 11:15 | |
zigo | Otherwise, it's CC BY, which is here: http://creativecommons.org/licenses/by/3.0/ | 11:16 |
mrunge | zigo, but: but you must always add a link to GLYPHICONS.com in a prominent place (e.g. the footer of a website), include the CC-BY license and the reference to GLYPHICONS.com on every page using icons. | 11:16 |
zigo | and which I believe is a free (as in freedom) license. | 11:16 |
zigo | mrunge: Not in the case of bootstrap-included GLYPHICONS. | 11:16 |
rdopieralski | mrunge: actually interpretations vary, some say it's enough to list it in the readme | 11:16 |
zigo | mrunge: They are released in the same license as Boostrap itself. | 11:16 |
zigo | The author understand the issue and wrote: "While you are not required to include attribution on your Bootstrap-based projects, I would certainly appreciate a visible link back to GLYPHICONS.com in any place you find appropriate (footer, docs, etc)." | 11:17 |
zigo | "I would certainly appreciate" <--- That's not "must" | 11:17 |
*** nikunj2512 has quit IRC | 11:17 | |
mrunge | yes. hmmm :-/ | 11:18 |
zigo | rdopieralski: There's no interpretation possible here. IE: We don't even *have* to mention GLYPHICONS ... | 11:18 |
zigo | Same license as boostrap. | 11:18 |
zigo | Dinner time for me. | 11:18 |
zigo | I'll be back later on. | 11:18 |
rdopieralski | zigo: yeah, I mean the interpretation for CC-BY | 11:18 |
*** masco has joined #openstack-horizon | 11:21 | |
*** krykowski_ has quit IRC | 11:21 | |
*** krykowski has joined #openstack-horizon | 11:23 | |
mrunge | rdopieralski, do we already have a patch to replace bootstrap fonts and glyphicons? | 11:25 |
rdopieralski | mrunge: https://blueprints.launchpad.net/horizon/+spec/font-icons-replace | 11:26 |
rdopieralski | mrunge: https://review.openstack.org/#/c/119369/ | 11:26 |
mrunge | thank you radomir | 11:27 |
rdopieralski | mrunge: it may be incomplete | 11:29 |
*** cedrics has joined #openstack-horizon | 11:29 | |
mrunge | rdopieralski, every move off from bootstrap glyphicons is a big step ahead | 11:29 |
rdopieralski | mrunge: I think this leaves only the bitmap icons from the old bootstrap (which were free) and maybe the icons that bootstrap 3 istelf uses internally | 11:30 |
*** packet has joined #openstack-horizon | 11:30 | |
rdopieralski | mrunge: I'm not sure aboout the last one, or how to handle it | 11:31 |
mrunge | sigh. | 11:32 |
rdopieralski | yeah, licenses are a pain | 11:32 |
mrunge | use icons as a part of any application where your customers are not a final customer | 11:32 |
rdopieralski | mostly because nobody cares | 11:32 |
mrunge | ah I meant http://glyphicons.com/license/ ... You must not: use icons as a part of any application where your customers are not a final customer | 11:33 |
*** dsneddon_ has quit IRC | 11:33 | |
*** bradjones has joined #openstack-horizon | 11:33 | |
rdopieralski | mrunge: except for the ones in bootstrap | 11:34 |
*** Longgeek has joined #openstack-horizon | 11:34 | |
*** dsneddon_ has joined #openstack-horizon | 11:34 | |
rdopieralski | mrunge: which are released on a separate license | 11:34 |
rdopieralski | mrunge: the halflings | 11:34 |
mrunge | ah yes. that's for ALL and PRO version | 11:34 |
mrunge | what a mess | 11:34 |
rdopieralski | we only use the halflings | 11:35 |
rdopieralski | which are apache 2 | 11:35 |
mrunge | remind me, who brought us this mess? | 11:35 |
* rdopieralski raises a hand | 11:35 | |
mrunge | who wants to use bootstrap3? | 11:35 |
* rdopieralski doesn't care | 11:35 | |
rdopieralski | mrunge: the thing is, zigo is right, if you look at the glyphicons font files in bootstrap | 11:36 |
rdopieralski | mrunge: they are all "halflings" version | 11:36 |
rdopieralski | mrunge: and they are released under Apache 2 license together with bootstrap 3 | 11:36 |
rdopieralski | mrunge: so it was a false alarm | 11:36 |
rdopieralski | actually, it's not apache 2 | 11:37 |
rdopieralski | sorry | 11:37 |
rdopieralski | it's MIT | 11:37 |
rdopieralski | even better | 11:37 |
rdopieralski | mrunge: but do run it through the lawyers | 11:38 |
mrunge | rdopieralski, yes, I think I will, at least to be sure | 11:38 |
*** k4n0 has quit IRC | 11:42 | |
*** jamespage has joined #openstack-horizon | 11:50 | |
*** nikunj2512 has joined #openstack-horizon | 11:57 | |
*** sambetts has quit IRC | 11:57 | |
nikunj2512 | mrunge: How i can create a network without subnet?? | 11:59 |
*** ramishra has joined #openstack-horizon | 12:01 | |
*** ramishra has quit IRC | 12:06 | |
*** vivekd has left #openstack-horizon | 12:06 | |
*** ramishra has joined #openstack-horizon | 12:09 | |
*** mattt has left #openstack-horizon | 12:10 | |
*** krykowski_ has joined #openstack-horizon | 12:10 | |
*** krykowski has quit IRC | 12:13 | |
*** krykowski_ has quit IRC | 12:15 | |
*** krykowski has joined #openstack-horizon | 12:25 | |
*** coolsvap is now known as coolsvap|afk | 12:26 | |
*** ramishra has quit IRC | 12:28 | |
*** krykowski_ has joined #openstack-horizon | 12:30 | |
*** krykowski has quit IRC | 12:31 | |
doug-fish | Hi akrivoka | 12:40 |
akrivoka | doug-fish: Hi Doug, I updated the test cleanup patch as you suggested | 12:41 |
doug-fish | akrivoka: Thanks for doing that! | 12:42 |
doug-fish | let me take a look at it now | 12:42 |
akrivoka | great, thanks | 12:42 |
akrivoka | (the only change is 'closes-bug' -> 'partial-bug' in the commit message) | 12:43 |
doug-fish | oh I see | 12:43 |
doug-fish | Yeah, it's very hard to fix something you can't reproduce! | 12:44 |
*** christophs has joined #openstack-horizon | 12:45 | |
jpich | It's a heisenfailure too, I can only reproduce it when running the full suite, not when running a subset. Grr. | 12:45 |
doug-fish | jpich, "heisenfailure"? | 12:46 |
rdopieralski | heisenbug | 12:47 |
jpich | doug-fish: Based on http://en.wikipedia.org/wiki/Heisenbug ? I probably should try to remember names correctly :-) | 12:47 |
rdopieralski | except we don't call them 'bugs' anymore, we call them 'defects' | 12:47 |
doug-fish | I've never heard that term before. | 12:47 |
rdopieralski | and debugging has been renamed to 'fecting' | 12:47 |
*** Drago has joined #openstack-horizon | 12:48 | |
doug-fish | I have to step away for a bit, but I'll try to set aside some time to try to help narrow down what is going on. | 12:49 |
*** thiagop has joined #openstack-horizon | 12:50 | |
*** Drago has quit IRC | 12:52 | |
*** katyafervent_awa is now known as katyafervent | 12:53 | |
*** tzumainn has joined #openstack-horizon | 12:55 | |
*** katyafervent is now known as katyafervent_awa | 12:56 | |
*** HenryG has quit IRC | 12:57 | |
*** ramishra has joined #openstack-horizon | 12:59 | |
*** ramishra has quit IRC | 13:00 | |
*** ramishra has joined #openstack-horizon | 13:01 | |
*** krykowski_ has quit IRC | 13:02 | |
*** masco has quit IRC | 13:02 | |
*** e0ne has quit IRC | 13:03 | |
*** e0ne has joined #openstack-horizon | 13:04 | |
*** ramishra has quit IRC | 13:05 | |
*** katyafervent_awa is now known as katyafervent | 13:06 | |
*** jcoufal has quit IRC | 13:07 | |
*** _crobertsrh is now known as crobertsrh | 13:11 | |
*** julim has joined #openstack-horizon | 13:12 | |
afaranha | pkarikh: Hi, are you there? | 13:14 |
*** neelashah has joined #openstack-horizon | 13:14 | |
*** jay-atl has quit IRC | 13:21 | |
*** MaxV has quit IRC | 13:21 | |
*** romainh has left #openstack-horizon | 13:21 | |
*** romainh has joined #openstack-horizon | 13:22 | |
*** jcoufal has joined #openstack-horizon | 13:25 | |
pkarikh | afaranha, yep | 13:29 |
*** MaxV has joined #openstack-horizon | 13:30 | |
*** peristeri has joined #openstack-horizon | 13:30 | |
afaranha | pkarikh: I agree that adding the variable OPENSTACK_KEYSTONE_ADMIN_ROLE is a great improvement, but I think the best solution for this is to Horizon base on the policies | 13:31 |
*** regebro has quit IRC | 13:32 | |
afaranha | pkarikh: Also, because of the Keystone v2 that has operations for admin only, this could fiz this issue | 13:32 |
*** jacalcat has joined #openstack-horizon | 13:33 | |
afaranha | pkarikh: In this case I'm gonna use this patch in the identity-rbac when the Horizon is using V2 | 13:34 |
afaranha | what do you think? | 13:34 |
pkarikh | afaranha, I see wour comments under reviews about it, just now reading them | 13:35 |
pkarikh | afaranha, looks like I understood your problem with keystone-v2. Do I understand correctly that you want to fix the problem with the V-2 in this patch? https://review.openstack.org/#/c/126640/ | 13:38 |
*** Doe has joined #openstack-horizon | 13:38 | |
afaranha | pkarikh: I'll just check if using Keystone v3 the panel Identity is going to be shown to a non-admin user, if no, I'll fix it | 13:43 |
afaranha | pkarikh: I was thinking in showing the Identity dashboard for the user even in Keystone v2, but because of the operations only for admin api I think I can't do anything with v2 :/ | 13:46 |
*** jprovazn has quit IRC | 13:47 | |
christophs | Hi there, I'm trying to modify an existing dashboard. For example I want to add a new tab to dashboards.projects.instances. Is it better to add a new dashboard which replaces the corresponding part or to "reregister" the dashboard I have to change? | 13:47 |
pkarikh | afaranha, if I understand correctly, your solution can break keystone v2. how do you plan to deal with it? I see comments from Lin Hua Chengand Timur Sufiev here about it https://review.openstack.org/#/c/126640/ | 13:48 |
afaranha | pkarikh: I was thinking in put an "if" when calling keystone API | 13:49 |
pkarikh | afaranha, if I'm wrong, in my opinion, it would be better if you post your patch on Gerrit and the community will be able to discuss it. What do you think about it? | 13:49 |
afaranha | that will check if the keystone is v3 or v2 | 13:49 |
afaranha | but now I think it's the same as leaving it as it is | 13:50 |
afaranha | because Keystone V3 just ignore the parameter "admin", for the admin API and internal API keystone v3 has the same operations | 13:51 |
*** morganfainberg has left #openstack-horizon | 13:51 | |
afaranha | pkarikh: Sure, I'll understand the problem better and post it there, thanks | 13:53 |
pkarikh | afaranha, ok | 13:54 |
*** akrivoka has quit IRC | 14:00 | |
*** woodm1979 has joined #openstack-horizon | 14:01 | |
*** Doe has quit IRC | 14:02 | |
thiagop | tsufiev: are you sure checking directly by the policy file modification time is the best approach? | 14:03 |
thiagop | tsufiev: I'm working in an approach to generate policy from a string rather then from reading it from a file. It appears that it could conflict when the policy is not coming from a file. | 14:04 |
*** tosky has joined #openstack-horizon | 14:04 | |
thiagop | tsufiev: but I think that my approach will require some changes on oslo also to make it more flexible... | 14:05 |
*** vijendar has joined #openstack-horizon | 14:05 | |
tsufiev | thiagop, well I thought of editing policy files as the main way to update policy rules | 14:08 |
*** e0ne has quit IRC | 14:09 | |
thiagop | tsufiev: and it is. For now... in fact, I'm looking for ways to make it more flexible so it can, eg, get a policy from another service directly in a determined URL | 14:09 |
tsufiev | thiagop, the advantage of that approach is that editing *policy.json files files could be regarded as editing configs, while editing policies in any other place is like changing Horizon code - which is more dangerous | 14:09 |
afaranha | pkarikh: Identity dashboard is working perfectly for keystone V3, the blueprint I created is invalid though | 14:10 |
thiagop | tsufiev: I know that currently it's not the main path, but maybe you can consider this :) | 14:10 |
thiagop | tsufiev: (in fact, what you're doing is the approached in every other service until now) | 14:11 |
thiagop | s/approached/approach used/ | 14:12 |
*** rebelagentm has joined #openstack-horizon | 14:13 | |
*** e0ne has joined #openstack-horizon | 14:15 | |
*** e0ne has quit IRC | 14:17 | |
pkarikh | afaranha, so, do I understand correctly that you can use my patch? Or am I still missing something? | 14:17 |
*** e0ne has joined #openstack-horizon | 14:18 | |
tsufiev | thiagop, I'm also thinking about more flexible policies definitions, though I headed in a slightly different direction - enhancing standard dashboard so every or most of interface elements could be hidden via editing policies | 14:21 |
afaranha | pkarikh: Nop, I can't use it because the Identity dashboard is already working fine. | 14:21 |
afaranha | I just thought that it wasn't working correctly because when I tested it was with keystone v2, and keystone v2 has the admin operations issue | 14:21 |
afaranha | I jsut realize recently this issue. So it's not Horizon fault | 14:21 |
pkarikh | afaranha, oh, ok. :) | 14:21 |
tsufiev | thiagop, these changes seem to be worth of a separate blueprint or even several ones... had to elaborate it a bit more and gather all my ideas... | 14:22 |
thiagop | tsufiev: my colleague afaranha is working in something like this also. I'm on step 2 of our evil plan: are you familiar with the Endpoint Policy blueprint? | 14:22 |
tsufiev | thiagop, not sure, could you provide a link? | 14:23 |
thiagop | tsufiev: sure: https://blueprints.launchpad.net/keystone/+spec/endpoint-policy | 14:24 |
*** rebelagentm has quit IRC | 14:27 | |
*** HenryG has joined #openstack-horizon | 14:31 | |
*** ramishra has joined #openstack-horizon | 14:31 | |
tsufiev | thiagop, do I understand correctly that it will eliminate the need in openstack_dashboard/conf/*policy.json files for KeystoneV3? | 14:32 |
doug-fish | jpich, not sure if you are still looking at this, but I have some observations recorded in https://bugs.launchpad.net/horizon/+bug/1378907 | 14:32 |
doug-fish | it seems like some unit tests fail when they are run individually | 14:33 |
thiagop | tsufiev: not only for Keystone V3, you can register a policy for each service and retrieve it through REST (for now) | 14:33 |
jpich | doug-fish: Our UT are so crap in places :( I've seen this before, it's usually due to side effects like the test data being modified directly | 14:33 |
doug-fish | yeah that's what I was afraid of | 14:34 |
tsufiev | thiagop, well, I | 14:34 |
*** david-lyle has joined #openstack-horizon | 14:34 | |
doug-fish | so the tests that are failing rely on some other test to modify the state? | 14:34 |
jpich | doug-fish: Note that for this specific tests, you can see which one is causing the issue by using ./run_tests.sh -v2, but when run individually it passes, in my environment. I haven't had a chance to look more into it today | 14:34 |
tsufiev | thiagop, I'm speaking about 'This extension requires v3.X of the Identity API.' from the blueprint full spec | 14:34 |
*** ericpeterson has joined #openstack-horizon | 14:34 | |
thiagop | tsufiev: ow, yeah. Sure. | 14:35 |
doug-fish | well that would have been cleaner than my command line shenanigans. | 14:35 |
thiagop | tsufiev: I have a PoC already | 14:36 |
jpich | doug-fish: Your way uncovered more issues though :) Maybe we should open separate bugs for these? | 14:36 |
thiagop | speaking of Identity V3... | 14:36 |
doug-fish | jpich: I wasn't sure if they were separate bugs or part of the same problem | 14:36 |
jpich | doug-fish: It could be a number of things, I think "intermittently failing tests" should be separate from "noise in the test output", IMO. Or we might never get to close that bug :-) | 14:37 |
jpich | doug-fish: Last time I dug into this I found things like https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/test_data/keystone_data.py#L139 , but I wouldn't be surprised if there are new and exciting side-effects that are causing some tests to fail sometimes | 14:38 |
thiagop | david-lyle jpich tzumainn: is there a plan to migrate Horizon definitely to Identity V3? | 14:38 |
jpich | Hopefully I can help dig into it next week too | 14:39 |
jpich | thiagop: Like, as a default, or completely dropping v2? | 14:39 |
doug-fish | jpich: sounds good. Maybe we need to go through and figure of if we can validate that tests aren't changing the state of the test data. | 14:40 |
*** nikunj2512 has quit IRC | 14:40 | |
thiagop | jpich: as default resolves my problem :) | 14:40 |
doug-fish | like run each test several times | 14:40 |
jpich | doug-fish: That sounds very forward looking, I would support such efforts :-) | 14:40 |
jpich | doug-fish: The best way would be if there was a flag to run the tests in a random order, usually that surfaces side-effects pretty quickly | 14:40 |
afaranha | pkarikh: Instead of checking for roles here OPENSTACK_KEYSTONE_ADMIN_ROLE, can we check for rules? If yes, we can check the rule: admin_required and any role in this rule will be treated as admin by Horizon | 14:40 |
jpich | Used that when I was working with twisted, not sure if there's a way to do it with nose/django...? | 14:41 |
doug-fish | jpich: sounds good. The thing I like about running the same test multiple times is that the offending test will probably be the one that fails | 14:41 |
* david-lyle reading scrollback | 14:41 | |
afaranha | it solves the list of roles issue | 14:41 |
jpich | thiagop: Is there any issue with changing the api version in the local settings manually, if you know you need v3? | 14:42 |
jpich | thiagop: From what I recall, the issues with making v3 the default is that the level of support in the other components was not always ready and it made the dashboard unusable under certain circumstances | 14:42 |
jpich | like when using another domain than default | 14:42 |
david-lyle | jpich exactly | 14:43 |
thiagop | jpich: no, it's more a question of developing things assuming that some useful resources are available | 14:44 |
*** rebelagentm has joined #openstack-horizon | 14:44 | |
jpich | thiagop: as downstream plugin, or upstream in horizon itself? | 14:44 |
jpich | As long as Keystone supports v2 I don't see us dropping it | 14:44 |
tsufiev | thiagop, I'll refactor my patch a bit then, to move checking how fresh are the current policies to a separate function | 14:44 |
david-lyle | I would very much like to move the default back to v3, but... | 14:45 |
david-lyle | the default domain primarily works by coincidence in keystone with the other services | 14:45 |
jpich | david-lyle: * pondering suggesting moving devstack to v3 by default so every project has all of Kilo to iron out issues * | 14:45 |
david-lyle | my fear is that if they closed the logical gap, we'd be completely broken | 14:45 |
thiagop | jpich: upstream. I believe Keystone has deprecated v2 already, maybe we should be looking forward... | 14:45 |
jpich | If v2 is required by the other projects still there's not much we can do, as far as I can see. We need them too :) | 14:46 |
pkarikh | afaranha, may be it would realy solve this problem. I will think about how to implement it better. And I'll update my patch if everythink will be ok. | 14:46 |
david-lyle | there are people working to get add v3 support to the various services, but it will take time | 14:47 |
jpich | That's good news :) | 14:48 |
*** Drago has joined #openstack-horizon | 14:48 | |
thiagop | jpich: I think that v3 is already supporting validation of v2 acquired tokens | 14:50 |
*** Drago has quit IRC | 14:50 | |
tsufiev | jpich, david-lyle: IMO, it would be great to move out logic for working with KeystoneV2 into some separate code (and not spoil all Horizon Keystone api with it) | 14:50 |
*** rdopieralski has quit IRC | 14:50 | |
tsufiev | the need to work specifically with adminUrl endpoint for /users in case of KeystoneV2 bothers me a lot :-\ | 14:51 |
thiagop | in fact, there is a new code in keystoneclient that has a discovery service for keystone and delivers the right client | 14:51 |
thiagop | v3 if it's avalable, v2 if not. | 14:52 |
thiagop | but I have not tested it yet on Horizon | 14:52 |
thiagop | https://review.openstack.org/#/c/38414/ | 14:54 |
*** akrivoka has joined #openstack-horizon | 14:55 | |
thiagop | david-lyle: is there any place where I can find all problems that caused the reversion to v2? | 14:57 |
david-lyle | it's mainly in the token handling code of keystone | 14:59 |
*** jacalcat has quit IRC | 14:59 | |
jpich | thiagop: Maybe https://github.com/openstack/django_openstack_auth/commit/7ff623638dc36fc29e7fc643483509ce226b92f6 for a start? | 14:59 |
david-lyle | when other services attempt to use a v3 token in a v2 context things don't go well | 14:59 |
*** rebelagentm has quit IRC | 15:00 | |
thiagop | I have a setup here using v3 on a devstack. Let me try to create some stuff... | 15:01 |
david-lyle | in the default domain it will work | 15:02 |
david-lyle | if you enable multidomain then it won't | 15:02 |
*** dsneddon_ has quit IRC | 15:02 | |
*** johnma has joined #openstack-horizon | 15:03 | |
david-lyle | the biggest worry on my part was keystone breaking the existing hole that allows v3 tokens to be used as v2 tokens in the default domain | 15:03 |
david-lyle | I no longer have the lines of code handy | 15:04 |
*** dsneddon_ has joined #openstack-horizon | 15:05 | |
*** rwsu has joined #openstack-horizon | 15:05 | |
*** udaycode has quit IRC | 15:08 | |
thiagop | david-lyle: is it not a feature to ease the migration? | 15:10 |
*** hurgleburgler has joined #openstack-horizon | 15:10 | |
*** jay-atl has joined #openstack-horizon | 15:10 | |
*** sayan has quit IRC | 15:11 | |
david-lyle | thiagop. the cause for my concern is that when v3 support domain went in, it worked with multi-dommain, then that was "fixed", my fear is they would "fix" it for the default domain as well | 15:11 |
*** halede has joined #openstack-horizon | 15:11 | |
*** sayan has joined #openstack-horizon | 15:12 | |
*** sayan has quit IRC | 15:14 | |
*** sayan has joined #openstack-horizon | 15:14 | |
*** wborkowski has joined #openstack-horizon | 15:17 | |
*** david-lyle has quit IRC | 15:17 | |
*** david-lyle has joined #openstack-horizon | 15:18 | |
*** kmartin has quit IRC | 15:19 | |
*** Drago has joined #openstack-horizon | 15:22 | |
*** colinmcnamara has joined #openstack-horizon | 15:23 | |
*** halede has quit IRC | 15:23 | |
*** vokhrimenko has quit IRC | 15:24 | |
thiagop | david-lyle: I made some tests certain that they'll fail, but they didn't | 15:25 |
thiagop | with multidomain enabled: created domain 'schweppes', set domain context, created project 'citrus' and user 'joe' (using admin credentials) | 15:26 |
thiagop | logout | 15:26 |
david-lyle | keystone works fine | 15:26 |
david-lyle | it's launch instance | 15:26 |
david-lyle | create volume | 15:26 |
thiagop | on Horizon | 15:26 |
david-lyle | create network | 15:26 |
david-lyle | that fail | 15:27 |
david-lyle | Horizon works with keystone v3 | 15:27 |
david-lyle | the problem is we pass the v3 token on to services that only know about v2.0 | 15:27 |
*** ramishra has quit IRC | 15:27 | |
thiagop | Nova is already talking v3? | 15:28 |
david-lyle | no, that | 15:28 |
david-lyle | that | 15:28 |
david-lyle | argh | 15:28 |
david-lyle | that | 15:28 |
* david-lyle quits | 15:28 | |
*** krotscheck has quit IRC | 15:28 | |
david-lyle | that is the problem | 15:28 |
david-lyle | nova treats the token as a v2.0 token | 15:29 |
*** krotscheck has joined #openstack-horizon | 15:29 | |
*** Ala has quit IRC | 15:30 | |
thiagop | david-lyle: (create network doesn't failed for me [but I'm using Neutron]) | 15:34 |
thiagop | I'm still not understanding what is the end result of nova treating it as a v2 token (besides the possibility that it starts not do that in the future) | 15:35 |
*** mrunge has quit IRC | 15:36 | |
*** colinmcnamara has quit IRC | 15:37 | |
*** wborkowski has quit IRC | 15:38 | |
*** robcresswell has quit IRC | 15:40 | |
*** Drago has quit IRC | 15:40 | |
*** Drago has joined #openstack-horizon | 15:41 | |
*** ZZelle has quit IRC | 15:48 | |
david-lyle | thiagop, try it and see, you get an authorization error | 15:48 |
david-lyle | perhaps it's fixed now | 15:49 |
david-lyle | if so, we can look into v3 again | 15:49 |
thiagop | I tried, but I'm still in doubt if it was fixed purposely or if it's another collateral effect | 15:50 |
david-lyle | I know keystone has been working to support v3 throughout openstack, so it's certainly possible that the problem was fixed. | 15:51 |
*** john-davidge has quit IRC | 15:52 | |
david-lyle | but I remain skeptical until I see evidence otherwise. I spent a lot of time with v3 enablement in Horizon | 15:52 |
thiagop | I believe it will be a joint section on summit between Horizon and Keystone, am I right? | 15:53 |
thiagop | s/be/have/ | 15:53 |
*** bpokorny has joined #openstack-horizon | 15:54 | |
thiagop | I heard someone on the team commenting something like that this morning.. | 15:54 |
*** katyafervent is now known as katyafervent_awa | 15:55 | |
*** kmartin has joined #openstack-horizon | 15:56 | |
*** lhcheng has joined #openstack-horizon | 15:57 | |
*** e0ne has quit IRC | 15:58 | |
david-lyle | thiagop, yes | 15:58 |
david-lyle | we're working on a plan for the planning meeting :D | 15:58 |
thiagop | hauhauuahuahu | 15:58 |
*** pkarikh has quit IRC | 15:59 | |
thiagop | maybe it's a good place to sync this thing up. It's a shame I can't go to the summit.. | 16:00 |
*** ZZelle has joined #openstack-horizon | 16:00 | |
tsufiev | +1 for join session between Horizon and Keystone | 16:02 |
raildo | +1 too | 16:02 |
*** yjiang5 has joined #openstack-horizon | 16:03 | |
thiagop | raildo goes in my place | 16:04 |
david-lyle | alright raildo and I will work it all out :) | 16:04 |
david-lyle | well hopefully there will be some other voices | 16:05 |
jpich | one or two maybe | 16:05 |
raildo | david-lyle, great :) | 16:05 |
lhcheng | david-lyle: ping | 16:06 |
david-lyle | maybe I won't have to talk at all :) | 16:06 |
david-lyle | lhcheng, pong | 16:06 |
*** rebelagentm has joined #openstack-horizon | 16:06 | |
lhcheng | this ticket got merged in j-3: https://bugs.launchpad.net/horizon/+bug/1347348 for some reason the status didn't got updated. | 16:07 |
lhcheng | is it still possible to set the milestone to j-3? | 16:07 |
david-lyle | I don't think I can change the milestone, just remove it | 16:08 |
david-lyle | milestones are mostly intended for targeting, so targeting in the past doesn't really make sense | 16:08 |
jpich | I *think* ttx may have The Power | 16:10 |
*** MaxV has quit IRC | 16:11 | |
lhcheng | david-lyle: I'll remove the milestone for now then. | 16:13 |
david-lyle | works for me | 16:14 |
*** cody-somerville has quit IRC | 16:16 | |
*** lhcheng has quit IRC | 16:17 | |
*** nlahouti has joined #openstack-horizon | 16:17 | |
*** ygbo has quit IRC | 16:17 | |
*** lhcheng has joined #openstack-horizon | 16:18 | |
*** lhcheng has quit IRC | 16:22 | |
*** ttrifonov is now known as ttrifonov_zZzz | 16:22 | |
*** amalagon has joined #openstack-horizon | 16:25 | |
*** jpich has quit IRC | 16:26 | |
*** akrivoka has quit IRC | 16:32 | |
*** akrivoka has joined #openstack-horizon | 16:33 | |
thiagop | tsufiev: thank you so much! | 16:34 |
thiagop | tsufiev: I'll test it on monday. | 16:35 |
tsufiev | thiagop, well, it was pretty trivial refactoring - until we'll start getting Horizon policies via requests to Keystone | 16:36 |
*** jcoufal has quit IRC | 16:41 | |
*** danieru has quit IRC | 16:44 | |
*** danieru has joined #openstack-horizon | 16:45 | |
*** e0ne has joined #openstack-horizon | 16:46 | |
*** akrivoka has quit IRC | 16:46 | |
*** bpokorny_ has joined #openstack-horizon | 16:54 | |
*** MaxV has joined #openstack-horizon | 16:57 | |
*** bpokorny has quit IRC | 16:57 | |
*** sayan_ has quit IRC | 17:00 | |
*** aix has quit IRC | 17:01 | |
*** bpokorny_ has quit IRC | 17:03 | |
*** bpokorny has joined #openstack-horizon | 17:04 | |
*** woodm1979 has quit IRC | 17:07 | |
*** woodm1979 has joined #openstack-horizon | 17:08 | |
*** woodm1979 has left #openstack-horizon | 17:08 | |
*** woodm1979 has joined #openstack-horizon | 17:08 | |
*** woodm1979 has quit IRC | 17:08 | |
*** Drago has quit IRC | 17:09 | |
*** colinmcnamara has joined #openstack-horizon | 17:10 | |
*** ArcTanSusan has joined #openstack-horizon | 17:11 | |
*** Longgeek has quit IRC | 17:12 | |
*** athomas has quit IRC | 17:16 | |
*** colinmcnamara has quit IRC | 17:22 | |
*** jacalcat has joined #openstack-horizon | 17:24 | |
*** jwy has joined #openstack-horizon | 17:30 | |
*** cedrics has quit IRC | 17:32 | |
*** Drago has joined #openstack-horizon | 17:32 | |
*** Drago has quit IRC | 17:33 | |
*** Drago has joined #openstack-horizon | 17:33 | |
*** lhcheng has joined #openstack-horizon | 17:35 | |
*** vijendar has quit IRC | 17:36 | |
*** bpokorny_ has joined #openstack-horizon | 17:40 | |
*** neelashah has quit IRC | 17:41 | |
*** bpokorny has quit IRC | 17:43 | |
*** ArcTanSusan has quit IRC | 17:44 | |
*** ArcTanSusan has joined #openstack-horizon | 17:44 | |
*** jacalcat has quit IRC | 17:44 | |
*** sayan_ has joined #openstack-horizon | 17:45 | |
*** david-lyle has quit IRC | 17:50 | |
*** david-lyle has joined #openstack-horizon | 17:50 | |
*** lhcheng has quit IRC | 17:51 | |
*** lhcheng has joined #openstack-horizon | 17:52 | |
*** exploreshaifali has joined #openstack-horizon | 17:53 | |
*** harlowja has joined #openstack-horizon | 17:54 | |
*** ericpeterson has quit IRC | 17:54 | |
*** ArcTanSusan has quit IRC | 17:55 | |
*** ArcTanSusan has joined #openstack-horizon | 17:56 | |
*** lhcheng has quit IRC | 17:56 | |
*** sigmavirus24 has joined #openstack-horizon | 17:58 | |
*** ericpeterson has joined #openstack-horizon | 18:03 | |
*** coolsvap|afk has quit IRC | 18:03 | |
*** bpokorny has joined #openstack-horizon | 18:04 | |
*** neelashah has joined #openstack-horizon | 18:06 | |
*** bpokorny_ has quit IRC | 18:06 | |
*** ZZelle_ has joined #openstack-horizon | 18:11 | |
*** Drago has quit IRC | 18:13 | |
*** nlahouti has quit IRC | 18:17 | |
*** colinmcnamara has joined #openstack-horizon | 18:19 | |
*** packet has quit IRC | 18:20 | |
*** e0ne has quit IRC | 18:21 | |
*** lhcheng has joined #openstack-horizon | 18:21 | |
*** rebelagentm has quit IRC | 18:22 | |
*** rbertram has joined #openstack-horizon | 18:22 | |
*** ArcTanSusan has quit IRC | 18:23 | |
*** rebelagentm has joined #openstack-horizon | 18:24 | |
*** tosky has quit IRC | 18:25 | |
*** ArcTanSusan has joined #openstack-horizon | 18:32 | |
*** lhcheng has quit IRC | 18:38 | |
*** lhcheng has joined #openstack-horizon | 18:38 | |
*** aix has joined #openstack-horizon | 18:39 | |
*** nlahouti has joined #openstack-horizon | 18:40 | |
*** lhcheng has quit IRC | 18:43 | |
*** colinmcnamara has quit IRC | 18:46 | |
*** cedrics has joined #openstack-horizon | 18:47 | |
*** Sukhdev has joined #openstack-horizon | 18:50 | |
*** kmartin has quit IRC | 18:52 | |
*** bpokorny has quit IRC | 18:52 | |
*** lhcheng has joined #openstack-horizon | 18:52 | |
*** romainh has left #openstack-horizon | 18:54 | |
*** ArcTanSusan has quit IRC | 18:55 | |
*** jacalcat has joined #openstack-horizon | 18:59 | |
*** lhcheng has quit IRC | 19:00 | |
*** lhcheng has joined #openstack-horizon | 19:01 | |
*** lhcheng_ has joined #openstack-horizon | 19:02 | |
*** lhcheng has quit IRC | 19:05 | |
*** lhcheng_ has quit IRC | 19:10 | |
*** lhcheng has joined #openstack-horizon | 19:10 | |
*** sbfox has joined #openstack-horizon | 19:11 | |
*** cedrics has quit IRC | 19:15 | |
*** lhcheng has quit IRC | 19:15 | |
*** packet has joined #openstack-horizon | 19:24 | |
*** sbfox has quit IRC | 19:25 | |
*** sbfox has joined #openstack-horizon | 19:28 | |
*** vijendar has joined #openstack-horizon | 19:28 | |
*** vijendar has quit IRC | 19:30 | |
*** vijendar has joined #openstack-horizon | 19:30 | |
exploreshaifali | thiagop, hi | 19:30 |
exploreshaifali | thiagop, I have installed neutron properly, yet grid.html is not reflecting changes on dashboard | 19:31 |
exploreshaifali | thiagop, I am simply putting "<div style='background-color: green;'> Here I AM!!!!</div>" just below the {main block} | 19:33 |
*** kmartin has joined #openstack-horizon | 19:34 | |
*** tqtran has joined #openstack-horizon | 19:36 | |
exploreshaifali | tqtran, hi | 19:38 |
tqtran | exploreshaifail, hello | 19:39 |
exploreshaifali | tqtran, still my changes from grid.html are not reflecting on dashboard | 19:39 |
exploreshaifali | tqtran, while changes of file index.html are picking up | 19:40 |
*** cedrics has joined #openstack-horizon | 19:41 | |
tqtran | exploreshaifail, do you want me to submit the changes for you? would probably be easiest at this point | 19:41 |
tqtran | exploreshaifail, just upload what you have, i'll test it out and make changes as neccessary | 19:41 |
exploreshaifali | tqtran, ur changes from grid.html reflect on dashboard? | 19:41 |
*** e0ne has joined #openstack-horizon | 19:41 | |
tqtran | i dont know yet, but if you upload your latest work, i will test it out | 19:42 |
exploreshaifali | how ll I know I have done correct changes or not | 19:43 |
exploreshaifali | untill I won't test it | 19:43 |
tqtran | just do your best, i will fill in the gap | 19:44 |
raildo | exploreshaifali,I work with thiagop and he is not online at the moment, I'll show mensage to him when he gets back, ok? | 19:46 |
*** nlahouti has quit IRC | 19:47 | |
exploreshaifali | raildo, ok :) | 19:47 |
*** cedrics has quit IRC | 19:47 | |
*** ArcTanSusan has joined #openstack-horizon | 20:01 | |
*** ArcTanSusan has quit IRC | 20:06 | |
*** alexpilotti has quit IRC | 20:06 | |
*** bpokorny_ has joined #openstack-horizon | 20:06 | |
exploreshaifali | raildo, I am working on https://review.openstack.org/#/c/126141/2/openstack_dashboard/dashboards/project/routers/templates/routers/extensions/routerrules/grid.html | 20:07 |
exploreshaifali | raildo, so now I want to create a separate css class get this job done | 20:08 |
*** e0ne has quit IRC | 20:10 | |
*** sbfox has quit IRC | 20:11 | |
*** jacalcat has quit IRC | 20:13 | |
raildo | exploreshaifali, sorry, i believe that i can't help you, i don't have much experience in this. :( | 20:13 |
*** Longgeek has joined #openstack-horizon | 20:13 | |
exploreshaifali | raildo, no worries! :) | 20:13 |
*** ArcTanSusan has joined #openstack-horizon | 20:15 | |
*** crobertsrh is now known as _crobertsrh | 20:16 | |
*** Longgeek has quit IRC | 20:17 | |
*** sbfox has joined #openstack-horizon | 20:21 | |
*** denis_makogon has joined #openstack-horizon | 20:26 | |
*** david-lyle has quit IRC | 20:26 | |
*** sbfox has quit IRC | 20:32 | |
*** jtomasek has quit IRC | 20:34 | |
*** e0ne has joined #openstack-horizon | 20:38 | |
*** sbfox has joined #openstack-horizon | 20:40 | |
*** harlowja is now known as harlowja_away | 20:43 | |
*** nlahouti has joined #openstack-horizon | 20:45 | |
*** harlowja_away is now known as harlowja | 20:47 | |
*** mitz_ has quit IRC | 20:47 | |
*** neelashah has quit IRC | 20:48 | |
*** e0ne has quit IRC | 20:48 | |
*** Sukhdev has quit IRC | 20:50 | |
*** e0ne has joined #openstack-horizon | 20:52 | |
*** e0ne has quit IRC | 20:53 | |
*** ArcTanSusan has quit IRC | 21:00 | |
*** bpokorny has joined #openstack-horizon | 21:00 | |
*** julim has quit IRC | 21:00 | |
*** ArcTanSusan has joined #openstack-horizon | 21:03 | |
*** bpokorny_ has quit IRC | 21:03 | |
*** sayan has quit IRC | 21:10 | |
*** MaxV has quit IRC | 21:10 | |
*** ybathia has joined #openstack-horizon | 21:10 | |
*** sbfox has quit IRC | 21:28 | |
*** Drago has joined #openstack-horizon | 21:29 | |
*** Drago has joined #openstack-horizon | 21:29 | |
*** ArcTanSusan has quit IRC | 21:29 | |
*** Sukhdev has joined #openstack-horizon | 21:31 | |
*** sbfox has joined #openstack-horizon | 21:31 | |
*** johnma has quit IRC | 21:34 | |
*** bpokorny_ has joined #openstack-horizon | 21:35 | |
*** johnma has joined #openstack-horizon | 21:36 | |
*** bpokorny has quit IRC | 21:38 | |
*** peristeri has quit IRC | 21:42 | |
*** packet has quit IRC | 21:44 | |
*** Drago has quit IRC | 21:54 | |
*** doug-fish has left #openstack-horizon | 21:57 | |
*** Drago has joined #openstack-horizon | 21:58 | |
*** Drago has quit IRC | 21:59 | |
*** Drago has joined #openstack-horizon | 21:59 | |
*** ArcTanSusan has joined #openstack-horizon | 21:59 | |
*** colinmcnamara has joined #openstack-horizon | 22:01 | |
*** denis_makogon has quit IRC | 22:05 | |
*** rebelagentm has quit IRC | 22:05 | |
exploreshaifali | thiagop, around? | 22:09 |
*** amalagon has quit IRC | 22:11 | |
*** Drago has quit IRC | 22:11 | |
exploreshaifali | raildo, can u tell me approx time when will thiagop come back? | 22:11 |
exploreshaifali | tqtran, around | 22:15 |
tqtran | exploreshaifali, yes sir | 22:18 |
exploreshaifali | sir? | 22:19 |
exploreshaifali | tqtran, I am unable to see effects of changes I am making in code | 22:19 |
exploreshaifali | tqtran, please can u check it once in your system | 22:20 |
exploreshaifali | if they are working well or not? | 22:20 |
exploreshaifali | tqtran, just to remind u, I am working on https://review.openstack.org/#/c/126141/2/openstack_dashboard/dashboards/project/routers/templates/routers/extensions/routerrules/grid.html | 22:20 |
*** Drago has joined #openstack-horizon | 22:22 | |
*** lhcheng has joined #openstack-horizon | 22:22 | |
tqtran | ok let me take a look | 22:23 |
exploreshaifali | tqtran, I need to past code for u to check them | 22:24 |
tqtran | thats ok, i'll just change background to red or something, if it shows up, then should be good | 22:25 |
exploreshaifali | tqtran, u want me to past whole files or only the section which is modified | 22:25 |
tqtran | would be better if you upload that pach | 22:25 |
exploreshaifali | cool :) | 22:25 |
tqtran | then i can just git fetch it for testing | 22:25 |
exploreshaifali | tqtran, okay | 22:25 |
exploreshaifali | just uploading patch :) | 22:26 |
*** Drago has quit IRC | 22:26 | |
tqtran | give me a sec, have to restack | 22:30 |
*** vijendar has quit IRC | 22:30 | |
*** alexpilotti has joined #openstack-horizon | 22:30 | |
*** alexpilotti has quit IRC | 22:31 | |
exploreshaifali | tqtran, I have devstack in new fresh env, than the previous one on which I have submited the previous patches | 22:34 |
exploreshaifali | tqtran, so now if I ll submit patch from new env it will be treated as a fresh patch | 22:34 |
tqtran | include the same change-Id | 22:35 |
tqtran | and it will replace your current patch with the new one | 22:35 |
exploreshaifali | tqtran, and I don't need to fetch it? | 22:35 |
tqtran | nope | 22:35 |
exploreshaifali | cool :) | 22:35 |
tqtran | as long as you use the same change-id, it will overwrite it | 22:36 |
exploreshaifali | tqtran, and it will overight the comments too? | 22:36 |
tqtran | yes | 22:36 |
exploreshaifali | *overwrite | 22:36 |
exploreshaifali | ok | 22:36 |
exploreshaifali | thanks!!! | 22:36 |
tqtran | np | 22:38 |
*** bpokorny has joined #openstack-horizon | 22:41 | |
*** colinmcnamara has quit IRC | 22:43 | |
*** bpokorny_ has quit IRC | 22:44 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:47 | |
*** echevemaster has joined #openstack-horizon | 22:52 | |
*** ericpeterson has quit IRC | 22:53 | |
*** rwsu has quit IRC | 22:59 | |
*** nlahouti has quit IRC | 23:00 | |
tqtran | exploreshaifali, are you able to drill down to router details? | 23:02 |
tqtran | exploreshaifali, and do you see the "router rules grid" tab? | 23:02 |
exploreshaifali | tqtran, in tab project-->Network--<Routers | 23:03 |
*** nlahouti has joined #openstack-horizon | 23:04 | |
tqtran | yes, create a router, then drill down to it | 23:04 |
exploreshaifali | ok | 23:05 |
tqtran | do you see a "router rules grid" tab once you created and clicked on the router? | 23:05 |
*** ArcTanSusan has quit IRC | 23:08 | |
*** ArcTanSusan has joined #openstack-horizon | 23:09 | |
*** bpokorny has quit IRC | 23:09 | |
exploreshaifali | tqtran, when I clicked on router that i created | 23:13 |
exploreshaifali | there is one grid | 23:13 |
*** ArcTanSusan has quit IRC | 23:13 | |
exploreshaifali | empty | 23:13 |
exploreshaifali | showing name, fixed IPs, status etc | 23:14 |
tqtran | ok so we're both missing something | 23:14 |
exploreshaifali | ok | 23:15 |
tqtran | theres some config we have to do to enable the router rules | 23:15 |
tqtran | then the tab will show up | 23:15 |
tqtran | and if you then modify the grid.html, it will show up there | 23:15 |
tqtran | alrighty, time for me to log off, good luck! | 23:15 |
*** tqtran has quit IRC | 23:15 | |
*** bpokorny has joined #openstack-horizon | 23:23 | |
*** Sukhdev has quit IRC | 23:31 | |
*** sbfox has quit IRC | 23:31 | |
*** sbfox has joined #openstack-horizon | 23:36 | |
*** nlahouti has quit IRC | 23:44 | |
*** nlahouti has joined #openstack-horizon | 23:44 | |
*** nlahouti has quit IRC | 23:44 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!