*** sbfox has quit IRC | 00:12 | |
*** mitz_ has joined #openstack-horizon | 00:44 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 01:19 | |
*** jacalcat has joined #openstack-horizon | 01:26 | |
*** dsneddon_ has quit IRC | 01:26 | |
*** dsneddon_ has joined #openstack-horizon | 01:27 | |
*** lhcheng has joined #openstack-horizon | 01:37 | |
*** lhcheng has quit IRC | 01:39 | |
*** lhcheng has joined #openstack-horizon | 01:40 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 01:48 | |
*** Doe has joined #openstack-horizon | 02:04 | |
*** jacalcat has quit IRC | 02:10 | |
*** bradjones has quit IRC | 02:12 | |
*** ramishra has joined #openstack-horizon | 02:19 | |
*** Longgeek has joined #openstack-horizon | 02:30 | |
*** Longgeek has quit IRC | 02:50 | |
*** david-lyle has joined #openstack-horizon | 02:51 | |
*** Doe has quit IRC | 02:57 | |
*** jacalcat has joined #openstack-horizon | 02:58 | |
*** Drago has quit IRC | 03:08 | |
*** tzumainn has joined #openstack-horizon | 03:21 | |
*** Longgeek has joined #openstack-horizon | 03:27 | |
*** lhcheng has quit IRC | 03:27 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 03:36 | |
*** lhcheng has joined #openstack-horizon | 03:36 | |
*** echevemaster has quit IRC | 03:36 | |
*** Drago has joined #openstack-horizon | 03:45 | |
*** nlahouti has joined #openstack-horizon | 03:46 | |
*** tzumainn has quit IRC | 03:46 | |
*** Drago has quit IRC | 03:46 | |
*** nlahouti has quit IRC | 03:47 | |
*** nlahouti has joined #openstack-horizon | 03:47 | |
*** jacalcat has quit IRC | 03:58 | |
*** lhcheng has quit IRC | 04:04 | |
*** lhcheng has joined #openstack-horizon | 04:10 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 04:12 | |
*** nikunj2512 has joined #openstack-horizon | 05:07 | |
*** sayan has joined #openstack-horizon | 05:11 | |
*** Longgeek has quit IRC | 05:16 | |
*** david-lyle has quit IRC | 05:21 | |
*** masco has joined #openstack-horizon | 05:45 | |
*** Longgeek has joined #openstack-horizon | 05:46 | |
*** exploreshaifali has joined #openstack-horizon | 05:52 | |
*** vivekd has joined #openstack-horizon | 05:53 | |
*** exploreshaifali has quit IRC | 05:53 | |
*** rrr has joined #openstack-horizon | 05:59 | |
*** rrr has quit IRC | 06:07 | |
*** hightall has joined #openstack-horizon | 06:09 | |
*** k4n0 has joined #openstack-horizon | 06:16 | |
*** ramishra has quit IRC | 06:18 | |
*** ramishra has joined #openstack-horizon | 06:18 | |
*** katyafervent_awa is now known as katyafervent | 06:18 | |
*** sayan has quit IRC | 06:18 | |
*** Longgeek has quit IRC | 06:20 | |
*** jcoufal has joined #openstack-horizon | 06:21 | |
*** nikunj2512 has quit IRC | 06:24 | |
*** mrunge has joined #openstack-horizon | 06:24 | |
*** Longgeek has joined #openstack-horizon | 06:24 | |
*** lhcheng has quit IRC | 06:27 | |
*** nikunj2512 has joined #openstack-horizon | 06:33 | |
*** jtomasek has joined #openstack-horizon | 06:36 | |
*** jprovazn has joined #openstack-horizon | 06:41 | |
*** nlahouti has quit IRC | 07:05 | |
*** e0ne has joined #openstack-horizon | 07:13 | |
*** wborkowski has joined #openstack-horizon | 07:18 | |
*** vokhrimenko has joined #openstack-horizon | 07:19 | |
*** vivekd has left #openstack-horizon | 07:22 | |
*** ttrifonov_zZzz is now known as ttrifonov | 07:24 | |
*** thiagop has quit IRC | 07:28 | |
*** raildo has quit IRC | 07:28 | |
*** afaranha has quit IRC | 07:28 | |
*** rdopieralski has joined #openstack-horizon | 07:32 | |
rdopieralski | hello gentledevs | 07:32 |
---|---|---|
*** pkarikh has joined #openstack-horizon | 07:34 | |
*** Ala has joined #openstack-horizon | 07:46 | |
*** regebro has joined #openstack-horizon | 07:47 | |
NikitaKonovalov | hi everyone, can someone review https://review.openstack.org/#/c/125927/ please, this is important for Sahara UI | 07:47 |
*** regebro has quit IRC | 07:48 | |
*** regebro has joined #openstack-horizon | 07:49 | |
*** regebro has quit IRC | 07:59 | |
*** regebro has joined #openstack-horizon | 08:00 | |
*** ygbo has joined #openstack-horizon | 08:02 | |
*** wborkowski has quit IRC | 08:03 | |
*** sayan has joined #openstack-horizon | 08:04 | |
*** jpich has joined #openstack-horizon | 08:05 | |
*** cedrics has joined #openstack-horizon | 08:12 | |
*** romainh has joined #openstack-horizon | 08:31 | |
*** alexpilotti has joined #openstack-horizon | 08:32 | |
*** akrivoka has joined #openstack-horizon | 08:39 | |
*** exploreshaifali has joined #openstack-horizon | 08:44 | |
*** pkoniszewski has joined #openstack-horizon | 08:47 | |
*** Longgeek has quit IRC | 08:47 | |
*** Longgeek has joined #openstack-horizon | 08:47 | |
*** k4n0 has quit IRC | 08:50 | |
*** k4n0 has joined #openstack-horizon | 08:55 | |
*** mitz_ has quit IRC | 08:57 | |
*** mitz_ has joined #openstack-horizon | 08:59 | |
*** Ala has quit IRC | 09:04 | |
*** romainh has quit IRC | 09:05 | |
*** athomas has joined #openstack-horizon | 09:11 | |
*** aix_ has joined #openstack-horizon | 09:11 | |
*** exploreshaifali has quit IRC | 09:11 | |
*** tosky has joined #openstack-horizon | 09:12 | |
*** sambetts has joined #openstack-horizon | 09:15 | |
*** exploreshaifali has joined #openstack-horizon | 09:18 | |
*** Longgeek has quit IRC | 09:25 | |
*** cedrics has quit IRC | 09:27 | |
*** zz_ttrifonov has joined #openstack-horizon | 09:28 | |
*** zz_ttrifonov has quit IRC | 09:29 | |
*** ttrifonov is now known as ttrifonov_zZzz | 09:29 | |
*** zz_ttrifonov has joined #openstack-horizon | 09:32 | |
*** zz_ttrifonov is now known as ttrifonov | 09:33 | |
*** ttrifonov has quit IRC | 09:33 | |
*** zz_ttrifonov has joined #openstack-horizon | 09:33 | |
*** hightall has quit IRC | 09:33 | |
*** zz_ttrifonov is now known as ttrifonov | 09:33 | |
*** ttrifonov_zZzz has quit IRC | 09:35 | |
*** k4n0 has quit IRC | 09:35 | |
*** cedrics has joined #openstack-horizon | 09:36 | |
*** Dafna has joined #openstack-horizon | 09:37 | |
*** Longgeek has joined #openstack-horizon | 09:37 | |
*** wborkowski has joined #openstack-horizon | 09:38 | |
*** cedrics has quit IRC | 09:46 | |
*** k4n0 has joined #openstack-horizon | 09:54 | |
*** k4n0 has quit IRC | 09:55 | |
*** k4n0 has joined #openstack-horizon | 09:56 | |
*** cedrics has joined #openstack-horizon | 09:57 | |
*** bradjones has joined #openstack-horizon | 10:05 | |
*** cedrics has quit IRC | 10:09 | |
*** pkoniszewski has quit IRC | 10:10 | |
*** qba73 has joined #openstack-horizon | 10:12 | |
*** cedrics has joined #openstack-horizon | 10:19 | |
*** cedrics has quit IRC | 10:28 | |
*** aix_ has quit IRC | 10:35 | |
*** cedrics has joined #openstack-horizon | 10:39 | |
*** athomas has quit IRC | 10:42 | |
*** Ala has joined #openstack-horizon | 10:43 | |
*** nikunj2512 has quit IRC | 10:46 | |
*** ramishra has quit IRC | 10:47 | |
*** jcoufal has quit IRC | 10:49 | |
*** jcoufal has joined #openstack-horizon | 10:50 | |
*** exploreshaifali has quit IRC | 10:50 | |
*** tosky has quit IRC | 10:52 | |
*** Longgeek has quit IRC | 10:53 | |
*** athomas has joined #openstack-horizon | 10:53 | |
*** cedrics has quit IRC | 10:57 | |
*** Longgeek has joined #openstack-horizon | 10:59 | |
*** ramishra has joined #openstack-horizon | 10:59 | |
*** sayan has quit IRC | 11:01 | |
*** sayan_ has joined #openstack-horizon | 11:01 | |
*** Doe has joined #openstack-horizon | 11:05 | |
*** nikunj2512 has joined #openstack-horizon | 11:12 | |
*** nikunj2512 has quit IRC | 11:17 | |
*** exploreshaifali has joined #openstack-horizon | 11:18 | |
*** mrunge has quit IRC | 11:19 | |
*** Doe has quit IRC | 11:26 | |
*** aix_ has joined #openstack-horizon | 11:30 | |
*** katyafervent is now known as katyafervent_awa | 11:41 | |
*** katyafervent_awa is now known as katyafervent | 11:43 | |
*** mrunge has joined #openstack-horizon | 11:44 | |
*** nikunj2512 has joined #openstack-horizon | 11:46 | |
nikunj2512 | rdopieralski: Hi | 11:47 |
nikunj2512 | rdopieralski: As You know i already submitted a patch for this bug - https://launchpad.net/bugs/1156433 (It is for notfiying the user for older browser versions) | 11:48 |
*** cedrics has joined #openstack-horizon | 11:48 | |
nikunj2512 | rdopieralski: But it is stuck until the patch to add the package in the global-requirements file gets approved. | 11:49 |
nikunj2512 | rdopieralski: So, i was thinking until that happens, can i use jquey-migrate plugin to detect the brower type and version and notify the users?? | 11:50 |
rdopieralski | nikunj2512: I have no idea | 11:50 |
*** wborkowski has quit IRC | 11:50 | |
nikunj2512 | rdopieralski: https://review.openstack.org/#/c/110067/ | 11:50 |
nikunj2512 | rdopieralski: this is the review, if possible please take a look and it might jog your memory :) | 11:51 |
*** Longgeek has quit IRC | 11:58 | |
*** katyafervent is now known as katyafervent_awa | 11:59 | |
*** katyafervent_awa is now known as katyafervent | 11:59 | |
*** katyafervent is now known as katyafervent_awa | 12:00 | |
*** Longgeek has joined #openstack-horizon | 12:05 | |
rdopieralski | nikunj2512: I don't think I want to get involved in that | 12:09 |
nikunj2512 | rdopieralski: ok | 12:09 |
nikunj2512 | rdopieralski: Thank You, So, can you point me to the right person whom i can ask for advice?? | 12:10 |
*** katyafervent_awa is now known as katyafervent | 12:11 | |
rdopieralski | nikunj2512: maybe the mailing list? | 12:12 |
rdopieralski | nikunj2512: but I doubt you will find much interest in that feature | 12:12 |
rdopieralski | it seems wrong to tell the users to change their browsers | 12:13 |
nikunj2512 | rdopieralski: OK but this feature is related to a bug. | 12:13 |
rdopieralski | nikunj2512: a bug in an unsupported browser | 12:13 |
nikunj2512 | rdopieralski: Yes, that is what we have to tell the user that the browser is unsupported | 12:13 |
rdopieralski | we do, in the documentation | 12:14 |
nikunj2512 | rdopieralski: OK | 12:14 |
*** packet has joined #openstack-horizon | 12:14 | |
*** john-davidge has joined #openstack-horizon | 12:15 | |
rdopieralski | nikunj2512: another thing that is wrong is checking for browser make and version, instead of checking if the feature that we require works | 12:15 |
rdopieralski | nikunj2512: that's not future-proof | 12:16 |
nikunj2512 | rdopieralski: But tell how many of us read documentation before using any product :) | 12:16 |
rdopieralski | in case of openstack it's not possible to use it without reading the docs | 12:16 |
sambetts | rdopieralski++ | 12:16 |
nikunj2512 | rdopieralski: Ok | 12:17 |
rdopieralski | nikunj2512: don't get me wrong, it's great that you are contributing and I can see it's hard | 12:18 |
*** robcresswell has joined #openstack-horizon | 12:18 | |
*** doug-fish has joined #openstack-horizon | 12:19 | |
nikunj2512 | rdopieralski: No, i can understand Your point of view but i had seen many bugs related to same issue where user either don't read or read the documentation incomplete and file for a bug | 12:19 |
rdopieralski | nikunj2512: also, I'm not going to get in the way of that feature if someone thinks it's important | 12:19 |
rdopieralski | maybe there is a better solution than sniffing the version | 12:19 |
rdopieralski | for instance, graceful degradation | 12:20 |
nikunj2512 | rdopieralski: And we have a feature that notifies the end-user once they login, it will help everyone in long run and also thinking why things are not working | 12:20 |
nikunj2512 | rdopieralski: what does graceful degradation means? | 12:20 |
*** sayali has joined #openstack-horizon | 12:20 | |
*** k4n0 has quit IRC | 12:21 | |
*** katyafervent is now known as katyafervent_awa | 12:21 | |
*** Doe has joined #openstack-horizon | 12:21 | |
nikunj2512 | rdopieralski: i got it.. Google :) | 12:21 |
sambetts | Something like a little message saying, you might not have a great experience with this browser could be interesting | 12:22 |
*** cedrics has quit IRC | 12:22 | |
*** katyafervent_awa is now known as katyafervent | 12:22 | |
rdopieralski | nikunj2512: for instance, just don't display those graphs | 12:22 |
doug-fish | rdopieralski: sometimes I feel like if Google were suddenly no longer available I could no longer do my job. :-) | 12:22 |
nikunj2512 | rdopieralski: But won't it be an cucumbersome solution. Because then we have to implement this thing for evey other thing which is not supported in order browsers ?? | 12:23 |
nikunj2512 | doug-fish: yes, same here :) | 12:23 |
rdopieralski | nikunj2512: yes, but then it will work for browsers in which only some of the things are supported | 12:23 |
nikunj2512 | sambetts: But that same thing we can have it with browser detection, a small message saying you might not have a great experience with this browser | 12:24 |
*** cedrics has joined #openstack-horizon | 12:24 | |
sambetts | in a previous project I worked on, we added browser detection on the backend side, looking at the user agent then injected a banner into the login template, with something simply like this "this browser is unsupported, for supported browsers see <documentation link>" | 12:27 |
nikunj2512 | rdopieralski: Ok but what about the css with is not supported in old browsers?? And i am really sorry for draging this conversation but i am trying to understand what can be the best for this problem with Yours and others help. | 12:27 |
robcresswell | nikunj2512: Ideally you'd use a combination of both... gracefully reduce the feature set, with a small non-intrusive message (on login, perhaps). The issue, as always, is code bloat. | 12:27 |
*** radez_g0n3 is now known as radez | 12:27 | |
bradjones | sambetts: I remember that project ;) I think that would be a nice addition | 12:28 |
nikunj2512 | sambetts: Yes, this can also be a good way to tell user | 12:28 |
nikunj2512 | robcresswell: Yes, we can use both but the gracefully reduce we can use for big features like canvas svg or other and browser detection we can use for small features | 12:29 |
robcresswell | A small notification of reduced support would be good. Graceful degradation is a separate decision - How far to support this etc... | 12:29 |
*** katyafervent is now known as katyafervent_awa | 12:30 | |
nikunj2512 | robcresswell: Yes, that is what i am trying to convey :). A small notification using browser dectection. And later we can add Graceful degradation support forbig features | 12:31 |
robcresswell | nikunj2512: +1 | 12:31 |
*** exploreshaifali has quit IRC | 12:33 | |
nikunj2512 | robcresswell: Thank You :). Please sambetts, bradjones & rdopieralski, what are views?? | 12:34 |
sambetts | A simple message with a link to the docs is all I think we need to see right now, maybe the other should be brought up at the summit | 12:36 |
nikunj2512 | sambetts: Ok. i think that will enough for now | 12:37 |
*** cedrics has quit IRC | 12:37 | |
bradjones | nikunj2512: A simple message seems like a good addition, any browser detection should be done by looking at the user agent string in the request rather than in js IMO | 12:38 |
nikunj2512 | bradjones: Ok, this means using backend to identify the browser type and version like sambetts told earlier and then injecting the message into the base template?? | 12:39 |
rdopieralski | bradjones: people have a tendency to change their user agent strings, expecially when they use non-standard browsers | 12:41 |
sambetts | thats why I think we should look at them, because if someone has changd their user agent string, surly thats what they want | 12:42 |
bradjones | sambetts: ++ | 12:42 |
robcresswell | rdopieralski: I dont think we should be held accountable for people choosing to alter their user agent though... It won't change site functionality, just whether a message appears. | 12:43 |
sambetts | like if I change my phone browser to pretend its the desktop one | 12:43 |
*** tzumainn has joined #openstack-horizon | 12:43 | |
rdopieralski | nikunj2512: have you looked as stuff like http://modernizr.com/ ? | 12:43 |
nikunj2512 | rdopieralski: yes, i have looked into the modernizr JS library and i know it detects specific feature not the browser version but my concern is also comes when we have break in css with old broswers | 12:44 |
rdopieralski | nikunj2512: it also detects css features | 12:45 |
sambetts | it says on the left hand side that it includeds yesno.js for conditional loading of css and js too | 12:45 |
nikunj2512 | rdopieralski: Yes but isn't defect most all the css features which will going to break in older browers like IE 6 will be headache?? | 12:45 |
rdopieralski | no idea, I never tried | 12:46 |
rdopieralski | but my hunch is that most problems are not critical | 12:46 |
rdopieralski | I mean, I can live without shadows or rounded corners | 12:47 |
rdopieralski | but I can't live without display: inline-block | 12:47 |
nikunj2512 | rdopieralski: Sorry, i am not as much expericed as you guys but won;t it be good to detect big features using Modernizr and using browser detection just finalize a minium workable browser version?? | 12:47 |
rdopieralski | also, I'm still againts displaying any messages to the user on every page load | 12:48 |
rdopieralski | this is just an annoyance | 12:48 |
rdopieralski | especially for the users who can't change their browsers | 12:48 |
nikunj2512 | rdopieralski: Ok. we can implement what ever community thinks will be good for the user, that is why i started this conversion:) | 12:48 |
rdopieralski | because of a company policy | 12:48 |
robcresswell | rdopieralski: I dont think the intention is on every load. Perhaps on login, or just a small banner on the login screen. I agree, every page would incredibly annoying. | 12:48 |
nikunj2512 | rdopieralski: Ok then can we only display message on the login page once | 12:49 |
nikunj2512 | ?? | 12:49 |
rdopieralski | robcresswell: hmm, a small notification on the login screem might actually work | 12:49 |
rdopieralski | nikunj2512: but then you don't need js, do you? | 12:49 |
rdopieralski | nikunj2512: just two lines of python to check the agent string? | 12:49 |
nikunj2512 | rdopieralski: yes, i need js but i can use jquery-migrate and css | 12:49 |
bradjones | robcresswell, rdopieralski: I agree small message on the login screen, anything more would become an annoyance | 12:50 |
nikunj2512 | rdopieralski: ohh.. You want to use python, that can be done also :) | 12:50 |
rdopieralski | I'm not sure if we don't want to drop jquery-migrate at some point | 12:50 |
nikunj2512 | I also agree with small message | 12:50 |
rdopieralski | ie when we actually migrate all our code and deps | 12:50 |
robcresswell | +1 to python implementation. The less reliance on js, the better. | 12:51 |
nikunj2512 | rdopieralski: Ok. Than from your point of view, it will best to implement this in python side?? | 12:51 |
nikunj2512 | robcresswell: Ok | 12:51 |
rdopieralski | nikunj2512: I don't have an opinion, but robcresswell and sambetts seem to both suggest that | 12:51 |
rdopieralski | it would be still prudent to use a library for that, though | 12:52 |
rdopieralski | user agent string parsing is... tricky | 12:52 |
nikunj2512 | rdopieralski: Yes. Ok but jquery-migrate is already included in the global-requirements. | 12:52 |
*** jacalcat has joined #openstack-horizon | 12:53 | |
rdopieralski | we might want to drop it | 12:53 |
nikunj2512 | rdopieralski: ohhh... Ok | 12:53 |
john-davidge | Python implementation ++. A simple message on login like "It appears that you are using an older web browser. For the best experience, please upgrade to the latest version." | 12:53 |
john-davidge | unintrusive but informative | 12:53 |
sambetts | https://github.com/selwin/django-user_agents for the django side | 12:53 |
sambetts | or this http://stackoverflow.com/questions/22374985/parse-http-user-agent-string-in-django | 12:54 |
nikunj2512 | sambetts: i liked the second approach. with this no need to include additional django app | 12:55 |
rdopieralski | nikunj2512: I would reach out to the UX guys about how the message should look like and be worded | 12:55 |
rdopieralski | nikunj2512: best, join #openstack-ux and ask | 12:56 |
nikunj2512 | rdopieralski: Ok. thank You. That will great and helpful. So, in the meantime what should, i do?? just implement it or do someone have to submit a bug or blueprint for this?? | 12:56 |
nikunj2512 | rdopieralski: Ok. Thank You | 12:56 |
rdopieralski | nikunj2512: a blueprint would be nice | 12:56 |
rdopieralski | nikunj2512: as for speed, we have 6 months to the next release... | 12:57 |
sambetts | yeah this isn't something thats going to make RC2 | 12:57 |
nikunj2512 | rdopieralski: Ok. Thank You. may i start the this talk in ux channel or will You?? Ok | 12:58 |
rdopieralski | nikunj2512: I'm not even there, and I don't want to get involved | 12:59 |
nikunj2512 | rdopieralski: Ok. But You said you will "reach out to the UX guys about how the message should look like and be worded". | 13:00 |
rdopieralski | no, I said you should do it | 13:00 |
nikunj2512 | Thank You everyone for the discussion | 13:00 |
rdopieralski | I would do it if I were you | 13:00 |
nikunj2512 | rdopieralski: Ok, Thank You | 13:00 |
*** rbertram has joined #openstack-horizon | 13:02 | |
*** exploreshaifali has joined #openstack-horizon | 13:02 | |
*** wborkowski has joined #openstack-horizon | 13:04 | |
tsufiev | rdopieralski, jpich: Hi! I've made a follow-up to discussion of QUnit/Jasmine/Sinon.js testing frameworks on the last meeting http://lists.openstack.org/pipermail/openstack-dev/2014-October/048301.html | 13:04 |
*** Doe has quit IRC | 13:04 | |
*** Doe has joined #openstack-horizon | 13:04 | |
tsufiev | tl;dr both Jasmine and Sinon.js IMO seem good things to have in Horizon :) | 13:05 |
rdopieralski | tsufiev: awesome, reading now | 13:06 |
*** amalagon has joined #openstack-horizon | 13:07 | |
*** ramishra has quit IRC | 13:08 | |
*** raildo has joined #openstack-horizon | 13:10 | |
rdopieralski | tsufiev: you are right about the xstatic package for jasmine not containing ajax.js | 13:10 |
*** _crobertsrh is now known as crobertsrh | 13:10 | |
rdopieralski | tsufiev: I also agree with your conclusion that if we have to add a package to have that, we can as well choose the better one | 13:11 |
*** afaranha has joined #openstack-horizon | 13:11 | |
rdopieralski | tsufiev: but I don't think your conclusion about reqriting qunit into jasmine is properly motivated or explained ;) | 13:11 |
rdopieralski | rewrtitting* | 13:12 |
rdopieralski | argh | 13:12 |
rdopieralski | can't type | 13:12 |
tsufiev | rdopieralski, personally, I don't like QUnit very much | 13:12 |
rdopieralski | it's not perfect, but it's better than the natural-language-pretending jasmine | 13:12 |
tsufiev | rdopieralski, well, if we care about lessening the number of supported dependencies, why not try drop something :)? | 13:12 |
rdopieralski | which tries to look like it's stateless, when it obviously isn't | 13:13 |
rdopieralski | tsufiev: it would be awesome to have one well documented way of writing js tests, with a rich set of examples for different situations -- no matter what library that uses | 13:14 |
rdopieralski | tsufiev: by examples I mean existing tests | 13:14 |
rdopieralski | alas, we only have a handful of tests for the stuff that was easiest to test | 13:14 |
tsufiev | rdopieralski, that means such document should stick to the syntax of some existing framework | 13:14 |
rdopieralski | and no real guidelines or examples | 13:15 |
tsufiev | rdopieralski, or do you suggest writing it in some testing pseudo-code? | 13:15 |
*** jcoufal has quit IRC | 13:15 | |
*** katyafervent_awa is now known as katyafervent | 13:15 | |
rdopieralski | no, no, what I mean is that I could live with Jasmine if it meant cleaner tests :) | 13:15 |
*** jcoufal has joined #openstack-horizon | 13:15 | |
rdopieralski | I have no idea how hard it would be to rewrite the existing tests, and/or write new tests for non-angular stuff | 13:16 |
tsufiev | rdopieralski, okay. The possible reason I don't like QUnit tests much is the fixtures it uses - they're really ugly. Maybe there is some way to get rid of them?... | 13:16 |
*** amalagon_ has joined #openstack-horizon | 13:17 | |
rdopieralski | tsufiev: I'm sure there are specialized libs for fixtures similar to sinon.js | 13:17 |
tsufiev | rdopieralski, well, that means adding another dependency :). Are you fine with that? | 13:17 |
rdopieralski | I'm a great fan of small libraries that do one thing well | 13:17 |
tsufiev | +1 | 13:18 |
rdopieralski | to be honest, I don't know what are the future plans for Horizon | 13:18 |
*** amalagon has quit IRC | 13:18 | |
*** amalagon_ is now known as amalagon | 13:18 | |
rdopieralski | should we ultimately rewrite evertyhing to angular? | 13:18 |
rdopieralski | if so, then just using jasmine would make sense | 13:19 |
rdopieralski | that is definitely a topic that we should discuss on the summit | 13:20 |
tsufiev | rdopieralski, agree | 13:21 |
tsufiev | rdopieralski, I have been thinking for a while about unifying/simplifying JS testing in Horizon, perhaps writing a doc/tutorial summarizing existing use cases would be a good way to deal with this issue | 13:24 |
rdopieralski | tsufiev: I think that we should start with cleaning up the existing tests and writing some more, for the difficult cases | 13:25 |
rdopieralski | tsufiev: so that we can point people to examples | 13:25 |
rdopieralski | and good practices | 13:25 |
rdopieralski | then, when we actually know what the good practices are, write the docs | 13:25 |
tsufiev | rdopieralski, and what if in order to write test for some difficult case additional library will be needed, just as in the case with Sinon.JS? | 13:27 |
rdopieralski | tsufiev: obviously, we add it | 13:27 |
rdopieralski | tsufiev: if it's needed, it's needed | 13:28 |
tsufiev | rdopieralski, okay :) | 13:28 |
rdopieralski | tsufiev: I'm not against adding dependencies or anything like that, I just want them to be properly reviewed and versioned | 13:28 |
rdopieralski | tsufiev: and to have someone maintaining them | 13:28 |
tsufiev | rdopieralski, got it. I hope for some feedback in the ML to my message, collective mind could give a few good advices :) | 13:30 |
nikunj2512 | rdopieralski: do you know What is the URL of the browser support matrix for horizon? | 13:31 |
*** hightall has joined #openstack-horizon | 13:37 | |
*** wborkowski has quit IRC | 13:40 | |
*** Doe has quit IRC | 13:41 | |
*** cedrics has joined #openstack-horizon | 13:41 | |
*** julim has joined #openstack-horizon | 13:48 | |
*** ramishra has joined #openstack-horizon | 13:49 | |
*** cedricss has joined #openstack-horizon | 13:51 | |
*** katyafervent is now known as katyafervent_awa | 13:52 | |
*** vijendar has quit IRC | 13:52 | |
*** cedrics has quit IRC | 13:52 | |
*** Drago has joined #openstack-horizon | 13:53 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:54 | |
*** Drago has quit IRC | 13:57 | |
*** neelashah has joined #openstack-horizon | 14:00 | |
rdopieralski | nikunj2512: it's on the wiki somewhere | 14:01 |
rdopieralski | nikunj2512: no idea where it will be once it's moved into the docs | 14:01 |
nikunj2512 | rdopieralski: Ok. i got the url, robcresswell helped me | 14:03 |
*** rwsu has joined #openstack-horizon | 14:22 | |
*** colinmcnamara has joined #openstack-horizon | 14:22 | |
*** david-lyle has joined #openstack-horizon | 14:26 | |
*** masco has quit IRC | 14:26 | |
*** tosky has joined #openstack-horizon | 14:29 | |
*** vijendar has joined #openstack-horizon | 14:30 | |
*** mrunge has quit IRC | 14:34 | |
*** packet has quit IRC | 14:36 | |
*** doug-fish1 has joined #openstack-horizon | 14:36 | |
*** doug-fish has quit IRC | 14:36 | |
*** jprovazn has quit IRC | 14:45 | |
*** rwsu has quit IRC | 14:47 | |
*** colinmcnamara has quit IRC | 14:48 | |
*** vijendar has quit IRC | 14:48 | |
*** packet has joined #openstack-horizon | 14:52 | |
*** hightall has quit IRC | 14:56 | |
*** absubram has joined #openstack-horizon | 15:03 | |
*** cedricss has quit IRC | 15:05 | |
*** rebelagentm has joined #openstack-horizon | 15:09 | |
*** julim has quit IRC | 15:13 | |
*** woodm1979 has joined #openstack-horizon | 15:13 | |
*** julim has joined #openstack-horizon | 15:17 | |
*** amalagon has quit IRC | 15:18 | |
*** vijendar has joined #openstack-horizon | 15:18 | |
*** amalagon has joined #openstack-horizon | 15:18 | |
*** hightall has joined #openstack-horizon | 15:19 | |
*** cedrics has joined #openstack-horizon | 15:20 | |
*** vijendar has quit IRC | 15:20 | |
*** vijendar has joined #openstack-horizon | 15:21 | |
*** cbader has joined #openstack-horizon | 15:22 | |
*** Drago has joined #openstack-horizon | 15:25 | |
*** robcresswell has quit IRC | 15:33 | |
*** nlahouti has joined #openstack-horizon | 15:37 | |
*** aberezin has joined #openstack-horizon | 15:43 | |
*** sayan_ has quit IRC | 15:46 | |
*** bpokorny has joined #openstack-horizon | 15:49 | |
*** hightall has quit IRC | 15:50 | |
*** Longgeek has quit IRC | 15:51 | |
*** Drago has quit IRC | 15:51 | |
*** ericpeterson has joined #openstack-horizon | 15:52 | |
*** sayali has quit IRC | 15:52 | |
*** rdopieralski has quit IRC | 15:55 | |
*** amalagon has quit IRC | 15:57 | |
*** amalagon has joined #openstack-horizon | 15:57 | |
*** doug-fish has joined #openstack-horizon | 15:59 | |
*** doug-fish1 has quit IRC | 15:59 | |
*** sayali has joined #openstack-horizon | 16:00 | |
*** ZZelle has quit IRC | 16:00 | |
*** exploreshaifali has quit IRC | 16:00 | |
*** ZZelle has joined #openstack-horizon | 16:01 | |
*** ramishra has quit IRC | 16:03 | |
*** absubram has quit IRC | 16:04 | |
*** julim has quit IRC | 16:05 | |
*** ramishra_ has joined #openstack-horizon | 16:07 | |
*** julim has joined #openstack-horizon | 16:08 | |
*** amalagon has quit IRC | 16:09 | |
*** jpich has quit IRC | 16:10 | |
*** Drago has joined #openstack-horizon | 16:18 | |
*** Drago has quit IRC | 16:18 | |
*** Drago has joined #openstack-horizon | 16:18 | |
*** lhcheng has joined #openstack-horizon | 16:19 | |
*** absubram has joined #openstack-horizon | 16:23 | |
*** jcoufal has quit IRC | 16:25 | |
*** ttrifonov is now known as zz_ttrifonov | 16:26 | |
*** bpokorny has quit IRC | 16:27 | |
*** athomas has quit IRC | 16:29 | |
*** sayan has joined #openstack-horizon | 16:29 | |
*** cedrics has quit IRC | 16:32 | |
*** athomas has joined #openstack-horizon | 16:35 | |
*** cody-somerville has joined #openstack-horizon | 16:35 | |
*** cody-somerville has quit IRC | 16:35 | |
*** cody-somerville has joined #openstack-horizon | 16:35 | |
*** e0ne has quit IRC | 16:35 | |
*** johnma has joined #openstack-horizon | 16:36 | |
*** ygbo has quit IRC | 16:37 | |
*** nikunj2512 has quit IRC | 16:38 | |
*** exploreshaifali has joined #openstack-horizon | 16:38 | |
*** bpokorny has joined #openstack-horizon | 16:39 | |
*** rwsu has joined #openstack-horizon | 16:42 | |
*** aberezin has quit IRC | 16:49 | |
*** colinmcnamara has joined #openstack-horizon | 16:57 | |
*** vokhrimenko has quit IRC | 16:57 | |
*** harlowja_away is now known as harlowja | 17:03 | |
*** denis_makogon_ has joined #openstack-horizon | 17:09 | |
*** halede has joined #openstack-horizon | 17:13 | |
*** regebro has quit IRC | 17:20 | |
*** amalagon has joined #openstack-horizon | 17:23 | |
*** Drago has quit IRC | 17:25 | |
*** amalagon_ has joined #openstack-horizon | 17:25 | |
*** Drago has joined #openstack-horizon | 17:25 | |
*** qba73 has quit IRC | 17:26 | |
*** e0ne has joined #openstack-horizon | 17:26 | |
*** amalagon has quit IRC | 17:28 | |
*** amalagon_ is now known as amalagon | 17:28 | |
*** colinmcnamara has quit IRC | 17:30 | |
*** bpokorny_ has joined #openstack-horizon | 17:32 | |
*** bpokorn__ has joined #openstack-horizon | 17:34 | |
*** bpokorny has quit IRC | 17:34 | |
*** bpokorny_ has quit IRC | 17:37 | |
*** ramishra_ has quit IRC | 17:38 | |
*** ramishra has joined #openstack-horizon | 17:39 | |
*** vijendar has quit IRC | 17:43 | |
*** vijendar has joined #openstack-horizon | 17:47 | |
*** akrivoka has quit IRC | 17:49 | |
*** ArcTanSusan has joined #openstack-horizon | 17:54 | |
*** absubram has quit IRC | 17:55 | |
*** bpokorny has joined #openstack-horizon | 17:58 | |
*** david-lyle has quit IRC | 17:58 | |
*** david-lyle has joined #openstack-horizon | 17:58 | |
*** bpokorn__ has quit IRC | 18:00 | |
*** denis_makogon_ is now known as denis_makogon | 18:05 | |
*** dsneddon_ has quit IRC | 18:06 | |
*** dsneddon_ has joined #openstack-horizon | 18:07 | |
*** clu_ has joined #openstack-horizon | 18:08 | |
*** aix_ has quit IRC | 18:10 | |
*** jacalcat has quit IRC | 18:13 | |
*** wborkowski has joined #openstack-horizon | 18:17 | |
*** e0ne has quit IRC | 18:21 | |
*** tosky has quit IRC | 18:27 | |
*** ArcTanSusan has quit IRC | 18:29 | |
*** colinmcnamara has joined #openstack-horizon | 18:30 | |
*** ArcTanSusan has joined #openstack-horizon | 18:38 | |
*** woodm1979 has quit IRC | 18:38 | |
*** sambetts has quit IRC | 18:40 | |
*** amcrn has joined #openstack-horizon | 18:40 | |
*** esp has joined #openstack-horizon | 18:45 | |
*** e0ne has joined #openstack-horizon | 18:51 | |
*** colinmcnamara has quit IRC | 18:54 | |
*** bpokorny_ has joined #openstack-horizon | 18:54 | |
*** bpokorny has quit IRC | 18:56 | |
*** Sukhdev has joined #openstack-horizon | 18:57 | |
*** bpokorny has joined #openstack-horizon | 19:01 | |
*** bpokorny_ has quit IRC | 19:04 | |
*** julim has quit IRC | 19:09 | |
*** ZZelle_ has joined #openstack-horizon | 19:20 | |
*** wborkowski has quit IRC | 19:30 | |
*** julim has joined #openstack-horizon | 19:36 | |
*** nlahouti has quit IRC | 19:47 | |
*** sayali has quit IRC | 19:51 | |
*** jtomasek has quit IRC | 19:51 | |
*** wborkowski has joined #openstack-horizon | 19:56 | |
*** david-lyle has quit IRC | 20:09 | |
*** hurgleburgler has joined #openstack-horizon | 20:12 | |
*** ramishra has quit IRC | 20:13 | |
*** hurgleburgler has quit IRC | 20:13 | |
*** ramishra has joined #openstack-horizon | 20:19 | |
*** hurgleburgler has joined #openstack-horizon | 20:25 | |
*** john-davidge has quit IRC | 20:28 | |
*** ArcTanSusan has quit IRC | 20:32 | |
*** neelashah has quit IRC | 20:43 | |
*** julim has quit IRC | 20:46 | |
*** nlahouti has joined #openstack-horizon | 20:49 | |
*** radez is now known as radez_g0n3 | 20:49 | |
*** ybathia has joined #openstack-horizon | 20:50 | |
*** david-lyle has joined #openstack-horizon | 20:53 | |
*** Drago has quit IRC | 20:54 | |
*** crobertsrh is now known as _crobertsrh | 20:56 | |
*** Sukhdev has quit IRC | 20:56 | |
*** david-lyle has quit IRC | 20:59 | |
*** Sukhdev has joined #openstack-horizon | 21:00 | |
*** ArcTanSusan has joined #openstack-horizon | 21:00 | |
*** colinmcnamara has joined #openstack-horizon | 21:00 | |
*** TravT has joined #openstack-horizon | 21:01 | |
*** colinmcnamara has quit IRC | 21:03 | |
*** colinmcnamara has joined #openstack-horizon | 21:04 | |
*** amotoki has joined #openstack-horizon | 21:06 | |
*** wborkowski has left #openstack-horizon | 21:09 | |
*** colinmcnamara has quit IRC | 21:10 | |
*** denis_makogon has quit IRC | 21:10 | |
*** e0ne has quit IRC | 21:18 | |
*** colinmcnamara has joined #openstack-horizon | 21:22 | |
*** colinmcnamara has quit IRC | 21:24 | |
*** rebelagentm has quit IRC | 21:25 | |
rodrigods | amotoki, addressed your comments in https://review.openstack.org/#/c/121410/ =) | 21:30 |
amotoki | rodrigods: thanks. I just commented the final cleanups. | 21:36 |
*** pkarikh has quit IRC | 21:37 | |
*** neelashah has joined #openstack-horizon | 21:42 | |
*** ishwari has joined #openstack-horizon | 21:45 | |
*** jacalcat has joined #openstack-horizon | 21:48 | |
*** jgravel__ has quit IRC | 21:49 | |
*** rbertram has quit IRC | 21:54 | |
*** david-lyle has joined #openstack-horizon | 21:55 | |
*** asahlin has quit IRC | 21:55 | |
*** ArcTanSusan has quit IRC | 21:55 | |
*** ArcTanSusan has joined #openstack-horizon | 21:57 | |
*** sayan has quit IRC | 22:07 | |
*** david-lyle_ has joined #openstack-horizon | 22:12 | |
*** david-lyle has quit IRC | 22:15 | |
rodrigods | amotoki, thanks again for the review... fixed the final clean ups =) | 22:19 |
*** jgravel has joined #openstack-horizon | 22:26 | |
*** packet has quit IRC | 22:28 | |
*** cody-somerville has quit IRC | 22:30 | |
*** clu_ has quit IRC | 22:32 | |
*** clu_ has joined #openstack-horizon | 22:34 | |
*** amalagon_ has joined #openstack-horizon | 22:36 | |
*** amalagon has quit IRC | 22:38 | |
*** amalagon_ is now known as amalagon | 22:38 | |
*** david-lyle_ is now known as david-lyle | 22:40 | |
*** amalagon_ has joined #openstack-horizon | 22:45 | |
*** amalagon has quit IRC | 22:48 | |
*** amalagon_ is now known as amalagon | 22:48 | |
*** ericpeterson has quit IRC | 22:48 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:53 | |
*** amalagon_ has joined #openstack-horizon | 22:58 | |
*** david-lyle has quit IRC | 22:58 | |
*** Sukhdev has quit IRC | 23:00 | |
*** amalagon has quit IRC | 23:00 | |
*** amalagon_ is now known as amalagon | 23:00 | |
*** neelashah has quit IRC | 23:01 | |
*** amalagon_ has joined #openstack-horizon | 23:03 | |
*** openstackgerrit has joined #openstack-horizon | 23:05 | |
*** amalagon has quit IRC | 23:05 | |
*** amalagon_ is now known as amalagon | 23:05 | |
*** Sukhdev has joined #openstack-horizon | 23:07 | |
*** david-lyle has joined #openstack-horizon | 23:08 | |
*** david-lyle has quit IRC | 23:14 | |
*** amotoki has quit IRC | 23:15 | |
*** ishwari has quit IRC | 23:26 | |
*** hurgleburgler has quit IRC | 23:31 | |
*** cbader has quit IRC | 23:32 | |
*** openstackgerrit has quit IRC | 23:33 | |
*** openstackgerrit has joined #openstack-horizon | 23:34 | |
*** gary-smith has quit IRC | 23:38 | |
openstackgerrit | Janet Yu proposed a change to openstack/horizon: Fix addition of plugin panel to panel group https://review.openstack.org/128133 | 23:39 |
openstackgerrit | Shaifali Agrawal proposed a change to openstack/horizon: CSS padding style is used instead of &nsbp; https://review.openstack.org/126141 | 23:52 |
openstackgerrit | Shaifali Agrawal proposed a change to openstack/horizon: CSS padding style is used instead of &nsbp; https://review.openstack.org/126141 | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!