*** russellb has joined #openstack-horizon | 00:04 | |
*** kumartin has quit IRC | 00:09 | |
*** kumartin has joined #openstack-horizon | 00:09 | |
*** MaxV has joined #openstack-horizon | 00:11 | |
*** Piet has joined #openstack-horizon | 00:15 | |
*** MaxV has quit IRC | 00:30 | |
openstackgerrit | Kahou Lei proposed openstack/horizon: Implements: blueprint 133767 https://review.openstack.org/138214 | 00:31 |
---|---|---|
*** yingjun has joined #openstack-horizon | 00:33 | |
*** raildo_ has joined #openstack-horizon | 00:33 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Change topic and description format for this patch. https://review.openstack.org/137417 | 00:34 |
*** raildo_ has quit IRC | 00:37 | |
*** colinmcnamara has quit IRC | 00:37 | |
openstackgerrit | Merged openstack/horizon: Replace the glyphicons with font awesome icons https://review.openstack.org/119369 | 00:39 |
Piet | Does anyone have a sense of how many members could be part of a project in the real world? For example, is it feasible that a project have over fifty members? | 00:42 |
*** TravT has joined #openstack-horizon | 00:44 | |
openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Log service catalog entries for keystone v3 API https://review.openstack.org/138190 | 00:45 |
*** ongk has quit IRC | 00:45 | |
david-lyle | Piet, I think operator mailing list would be a better place to ask | 00:45 |
lhcheng | Piet: We have setup some big shared projects where there are more than 50 members. | 00:45 |
lhcheng | Piet: But the UI is not usable to manage 50 members though :P | 00:46 |
Piet | lhcheng: ok - cool | 00:46 |
*** hurgleburgler has quit IRC | 00:47 | |
Piet | lhcheng: That's why I asked - we were looking at redesigning the UI | 00:48 |
*** cedrics has joined #openstack-horizon | 00:48 | |
*** EmilyW has quit IRC | 00:48 | |
*** raildo_ has joined #openstack-horizon | 00:48 | |
lhcheng | Piet, great. Maybe should be a separate page rather than part of the modal. | 00:50 |
Piet | lhcheng: we were looking into adding edit capabilities from the Project details panel under the Members tab | 00:51 |
Piet | link to proposed Edit Project Details UX; http://invis.io/QJ1SGW034 | 00:53 |
*** yingjun has quit IRC | 00:54 | |
openstackgerrit | Li Yingjun proposed openstack/django_openstack_auth: Domain enabled login screen needs focus on Domain field https://review.openstack.org/137499 | 00:55 |
*** cedrics has quit IRC | 00:57 | |
*** amcrn_ has quit IRC | 00:57 | |
lhcheng | Piet, thanks for the link | 00:57 |
*** david-lyle is now known as david-lyle_afk | 01:03 | |
*** jacalcat has quit IRC | 01:07 | |
lhcheng | Piet, I'll add some comments on the prototype. | 01:08 |
*** yingjun has joined #openstack-horizon | 01:10 | |
openstackgerrit | Thai Tran proposed openstack/horizon: POST instantiation for Django-Angular https://review.openstack.org/136556 | 01:15 |
openstackgerrit | Thai Tran proposed openstack/horizon: WIP angularize identity users. Most things are broken. Working on create modal. https://review.openstack.org/133767 | 01:15 |
*** yingjun has quit IRC | 01:16 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: Add 'Start/Stop Instance' to Instances table actions https://review.openstack.org/119290 | 01:17 |
*** yingjun has joined #openstack-horizon | 01:20 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 01:27 | |
*** yingjun has quit IRC | 01:37 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: Change "Modify Users" to "Manage Members" https://review.openstack.org/138221 | 01:40 |
openstackgerrit | Thai Tran proposed openstack/horizon: WIP angularize identity users. Most things are broken. Working on create modal. https://review.openstack.org/133767 | 01:43 |
*** yingjun has joined #openstack-horizon | 01:44 | |
*** KurtMartin has quit IRC | 01:48 | |
*** yingjun_ has joined #openstack-horizon | 01:53 | |
*** colinmcnamara has joined #openstack-horizon | 01:53 | |
*** yingjun has quit IRC | 01:55 | |
*** yingjun has joined #openstack-horizon | 01:55 | |
*** bpokorny has joined #openstack-horizon | 01:56 | |
*** yingjun_ has quit IRC | 01:58 | |
*** jacalcat has joined #openstack-horizon | 01:59 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 02:02 | |
*** dboik has joined #openstack-horizon | 02:13 | |
*** wuhg has joined #openstack-horizon | 02:13 | |
*** ongk has joined #openstack-horizon | 02:16 | |
*** Dafna has quit IRC | 02:16 | |
*** ongk has quit IRC | 02:17 | |
*** dboik has quit IRC | 02:18 | |
rbertram_afk | tsufiev: In tables, a "server" type filter goes to a service's API. Does the "query" type filter operate on the client-side only? | 02:18 |
*** rbertram_afk is now known as rbertram | 02:18 | |
*** kumartin has quit IRC | 02:25 | |
*** bpokorny has quit IRC | 02:29 | |
Piet | I'm hoping to spend some time working on the UX of the Details panel tomorrow. If you have time, feel free to review the current mocks and leave comments by clicking on http://invis.io/NB1L22K4Q | 02:33 |
*** bpokorny has joined #openstack-horizon | 02:49 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 02:50 | |
*** bpokorny has quit IRC | 02:50 | |
*** dsneddon has quit IRC | 02:52 | |
*** nlahouti has quit IRC | 02:54 | |
openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Log service catalog entries for keystone v3 API https://review.openstack.org/138190 | 03:02 |
*** liuyulong has joined #openstack-horizon | 03:07 | |
openstackgerrit | Li Yingjun proposed openstack/django_openstack_auth: Domain enabled login screen needs focus on Domain field https://review.openstack.org/137499 | 03:09 |
openstackgerrit | Li Yingjun proposed openstack/horizon: Change "Modify Users" to "Manage Members" https://review.openstack.org/138221 | 03:15 |
*** vkmc has quit IRC | 03:16 | |
*** liuyulong has quit IRC | 03:29 | |
*** raildo_ has quit IRC | 03:31 | |
*** jacalcat has quit IRC | 03:35 | |
*** colinmcnamara has quit IRC | 03:37 | |
*** colinmcnamara has joined #openstack-horizon | 03:52 | |
*** yingjun has quit IRC | 03:59 | |
*** neillc is now known as neillc_away\ | 03:59 | |
*** neillc_away\ is now known as neillc_away | 04:00 | |
*** rbertram is now known as rbertram_afk | 04:06 | |
*** tzumainn has quit IRC | 04:06 | |
*** clu_ has quit IRC | 04:26 | |
*** colinmcnamara has quit IRC | 04:31 | |
*** ayoung has quit IRC | 04:35 | |
*** EmilyW has joined #openstack-horizon | 04:35 | |
*** tqtran has quit IRC | 04:41 | |
*** yingjun has joined #openstack-horizon | 04:43 | |
*** masco has joined #openstack-horizon | 04:52 | |
*** Poornima_ has joined #openstack-horizon | 04:54 | |
*** EmilyW has quit IRC | 05:04 | |
*** EmilyW has joined #openstack-horizon | 05:04 | |
*** lhcheng has quit IRC | 05:13 | |
openstackgerrit | Travis Tripp proposed openstack/horizon: Searchable index service PoC https://review.openstack.org/132683 | 05:13 |
*** lhcheng has joined #openstack-horizon | 05:13 | |
*** lhcheng has quit IRC | 05:18 | |
*** yingjun has quit IRC | 05:19 | |
openstackgerrit | Richard Jones proposed openstack/horizon: WIP new REST API for angular front end https://review.openstack.org/136676 | 05:21 |
*** echevemaster has quit IRC | 05:28 | |
*** nlahouti has joined #openstack-horizon | 05:42 | |
*** nlahouti has quit IRC | 05:48 | |
*** nlahouti has joined #openstack-horizon | 05:48 | |
*** EmilyW has quit IRC | 05:52 | |
*** exploreshaifali has joined #openstack-horizon | 05:55 | |
*** exploreshaifali has quit IRC | 06:02 | |
*** sayan_ has joined #openstack-horizon | 06:23 | |
*** exploreshaifali has joined #openstack-horizon | 06:24 | |
*** lhcheng has joined #openstack-horizon | 06:26 | |
*** yingjun has joined #openstack-horizon | 06:32 | |
*** Arvinder has joined #openstack-horizon | 06:41 | |
Arvinder | Hi everyone | 06:41 |
Arvinder | I am new to the community and implemented the code changes for the blueprint <Use new block device mapping for booting from volume> | 06:43 |
Arvinder | Link for the same is : https://blueprints.launchpad.net/horizon/+spec/horizon-block-device-mapping-v2 | 06:43 |
Arvinder | I have already done the code changes from my side and floated for review, link : https://review.openstack.org/#/c/135253/ | 06:44 |
Arvinder | can anyone please tell me, how to proceed further :) | 06:45 |
*** yingjun_ has joined #openstack-horizon | 06:47 | |
*** yingjun has quit IRC | 06:50 | |
*** exploreshaifali has quit IRC | 06:51 | |
*** lhcheng has quit IRC | 06:51 | |
*** lhcheng has joined #openstack-horizon | 06:52 | |
mrunge | Arvinder, thank you for your patch! | 06:53 |
mrunge | Arvinder, now, next step is to get your patch reviewed. | 06:53 |
mrunge | Arvinder, we have a huge review queue; you can help in reviewing others patches | 06:54 |
*** neillc_away is now known as neillc | 06:55 | |
lhcheng | Arvinder: patch reviewed | 07:00 |
*** lhcheng has quit IRC | 07:16 | |
*** sayan_ has quit IRC | 07:16 | |
*** lhcheng has joined #openstack-horizon | 07:16 | |
Arvinder | mrunge, Thank you, I will surely try to review other patches | 07:20 |
*** lhcheng has quit IRC | 07:21 | |
*** k4n0 has joined #openstack-horizon | 07:21 | |
Arvinder | mrunge, Do i need to do anything else from my side to get review done ? | 07:22 |
mrunge | Arvinder, respond to comments? | 07:24 |
Arvinder | lhcheng, thank you very much.. i will surely take your comments and try to fix them | 07:24 |
mrunge | Arvinder, he left a few mins ago | 07:24 |
Arvinder | mrunge, Yes i just saw the comment, i think its a valid one..i will change the code and provide the patch today itself | 07:25 |
Arvinder | mrunge, lhcheng > can u please guide me that if i change single file in my patch so i need to stage the other file also | 07:27 |
mrunge | Arvinder, change your file | 07:28 |
mrunge | git add <file> | 07:28 |
mrunge | git commit --amend | 07:28 |
mrunge | git review | 07:28 |
Arvinder | mrunge yes i know this but i was asking about like i have to files and i changed only one so while commiting i need to stage both files or only one file which i have changed | 07:30 |
Arvinder | Will my new patch set will have 2 files or only one. ? | 07:31 |
mrunge | Arvinder you're using git commit --amend, thus changing your previous changeset | 07:32 |
Arvinder | mrunge ok thanks .. got it :) | 07:32 |
*** jprovazn has joined #openstack-horizon | 07:34 | |
*** e0ne has joined #openstack-horizon | 07:35 | |
*** nlahouti has quit IRC | 07:41 | |
*** e0ne has quit IRC | 07:47 | |
*** mflobo has joined #openstack-horizon | 07:47 | |
*** e0ne has joined #openstack-horizon | 07:48 | |
openstackgerrit | Federico Gimenez Nieto proposed openstack/horizon: Added pagination support for swift containers. https://review.openstack.org/88246 | 07:49 |
*** yingjun has joined #openstack-horizon | 07:49 | |
*** yingjun_ has quit IRC | 07:52 | |
openstackgerrit | Federico Gimenez Nieto proposed openstack/horizon: Added pagination support for swift containers. https://review.openstack.org/88246 | 07:52 |
*** jtomasek has joined #openstack-horizon | 08:04 | |
*** jprovazn has quit IRC | 08:10 | |
*** markus_z has joined #openstack-horizon | 08:14 | |
*** jprovazn has joined #openstack-horizon | 08:16 | |
*** Arvinder has quit IRC | 08:19 | |
*** MaxV has joined #openstack-horizon | 08:25 | |
*** Arvinder has joined #openstack-horizon | 08:25 | |
*** aberezin has joined #openstack-horizon | 08:30 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon: Remove tab bar from detail pages with a single tab https://review.openstack.org/129449 | 08:31 |
*** dkorn has joined #openstack-horizon | 08:31 | |
*** aberezin has quit IRC | 08:40 | |
*** jcoufal has joined #openstack-horizon | 08:42 | |
*** aix has quit IRC | 08:45 | |
*** cedrics has joined #openstack-horizon | 08:49 | |
*** christophs has quit IRC | 08:49 | |
*** cedrics has quit IRC | 08:51 | |
*** cedrics has joined #openstack-horizon | 08:54 | |
*** christophs has joined #openstack-horizon | 08:55 | |
*** christophs has joined #openstack-horizon | 08:55 | |
*** jprovazn has quit IRC | 08:55 | |
*** aix has joined #openstack-horizon | 08:58 | |
*** jpich has joined #openstack-horizon | 08:59 | |
openstackgerrit | Merged openstack/horizon: Change "Modify Users" to "Manage Members" https://review.openstack.org/138221 | 09:04 |
*** romainh has joined #openstack-horizon | 09:09 | |
jpich | tsufiev: Hello! Thanks for getting https://bugs.launchpad.net/horizon/+bug/1396544 resolved :) Are you looking at/interested in backporting it as well or would you rather leave that to someone else? | 09:10 |
*** tosky has joined #openstack-horizon | 09:16 | |
*** ygbo has joined #openstack-horizon | 09:18 | |
*** ZZelle__ has quit IRC | 09:25 | |
*** ZZelle__ has joined #openstack-horizon | 09:25 | |
*** rdopieralski has joined #openstack-horizon | 09:27 | |
*** aix has quit IRC | 09:27 | |
openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: removing mandatory mark for post_creation tab https://review.openstack.org/138290 | 09:29 |
*** e0ne has quit IRC | 09:34 | |
*** athomas has joined #openstack-horizon | 09:35 | |
*** e0ne has joined #openstack-horizon | 09:35 | |
*** ZZelle__ is now known as ZZelle | 09:36 | |
*** e0ne has quit IRC | 09:37 | |
openstackgerrit | Merged openstack/horizon: Add menu regions to integration tests https://review.openstack.org/109299 | 09:38 |
*** sayan_ has joined #openstack-horizon | 09:39 | |
*** aix has joined #openstack-horizon | 09:40 | |
*** lsmola has quit IRC | 09:43 | |
*** jcoufal_ has joined #openstack-horizon | 09:44 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon: Split large methods into submethods to reduce max-complexity https://review.openstack.org/129689 | 09:45 |
openstackgerrit | Merged openstack/tuskar-ui: Fixes for nodes status page https://review.openstack.org/137797 | 09:47 |
*** jcoufal has quit IRC | 09:47 | |
openstackgerrit | Merged openstack/tuskar-ui: Use tarballs in requirements.txt https://review.openstack.org/136753 | 09:48 |
openstackgerrit | Merged openstack/tuskar-ui: Number picker improvements https://review.openstack.org/135928 | 09:49 |
*** yingjun has quit IRC | 09:51 | |
openstackgerrit | Merged openstack/tuskar-ui: Don't scroll on clicking ? in configuration https://review.openstack.org/135934 | 09:51 |
*** Dafna has joined #openstack-horizon | 09:57 | |
*** lsmola has joined #openstack-horizon | 09:58 | |
*** sambetts has joined #openstack-horizon | 10:01 | |
*** e0ne has joined #openstack-horizon | 10:01 | |
*** cedrics has quit IRC | 10:05 | |
mflobo | Anyone know if this is the oficial project for SPICE console http://cgit.freedesktop.org/spice/spice-html5/ ? | 10:05 |
*** e0ne has quit IRC | 10:05 | |
*** neillc is now known as neillc_away | 10:06 | |
*** robcresswell has joined #openstack-horizon | 10:06 | |
openstackgerrit | Jiri Tomasek proposed openstack/horizon: Modal fixes - 2 columns, padding, header, membership https://review.openstack.org/113519 | 10:25 |
openstackgerrit | Jiri Tomasek proposed openstack/horizon: Modal template updates https://review.openstack.org/135649 | 10:25 |
*** Arvinder has quit IRC | 10:28 | |
*** lsmola has quit IRC | 10:34 | |
*** regebro has joined #openstack-horizon | 10:35 | |
*** cedrics has joined #openstack-horizon | 10:35 | |
openstackgerrit | Merged openstack/horizon: Add 'Start/Stop Instance' to Instances table actions https://review.openstack.org/119290 | 10:35 |
*** e0ne has joined #openstack-horizon | 10:37 | |
*** jamielennox is now known as jamielennox|away | 10:40 | |
*** yingjun has joined #openstack-horizon | 10:41 | |
*** guilhem_ has quit IRC | 10:41 | |
*** yingjun has quit IRC | 10:42 | |
*** guilhem_ has joined #openstack-horizon | 10:46 | |
*** cedrics has quit IRC | 10:49 | |
*** lsmola has joined #openstack-horizon | 10:50 | |
*** guilhem_ has quit IRC | 10:55 | |
*** bradjones has quit IRC | 11:14 | |
*** akrivoka has joined #openstack-horizon | 11:19 | |
*** bradjones has joined #openstack-horizon | 11:19 | |
*** bradjones has quit IRC | 11:19 | |
*** bradjones has joined #openstack-horizon | 11:19 | |
*** alexpilotti_ has joined #openstack-horizon | 11:19 | |
*** alexpilotti has quit IRC | 11:20 | |
*** vkmc has joined #openstack-horizon | 11:22 | |
*** alexpilotti_ has quit IRC | 11:23 | |
*** akrivoka has quit IRC | 11:33 | |
jtomasek | rdopieralski: thanks for a review, I was trying to tacle with all icon changes, I'll update the patch | 11:35 |
*** akrivoka has joined #openstack-horizon | 11:35 | |
*** raildo_ has joined #openstack-horizon | 11:36 | |
jpich | tsufiev: Thank you!! | 11:38 |
*** exploreshaifali has joined #openstack-horizon | 11:41 | |
*** raildo_ has quit IRC | 11:43 | |
tsufiev | jpich, you're welcome :) | 11:43 |
tsufiev | jpich, I wasn't sure who should determine severity of the bug in stable branches, so haven't set it myself | 11:44 |
jpich | tsufiev: It's up to us as well (and it helps the stable maintainers determine whether something should be backported as well). I'm tempted to set it High for both Juno and Icehouse too, there already was quite a few policy files / access checks in Icehouse | 11:45 |
tsufiev | jpich, okay, then I'll leave to you to yield to this temptation :) | 11:48 |
* jpich yielding as we speak | 11:48 | |
openstackgerrit | Jiri Tomasek proposed openstack/horizon: Modal fixes - 2 columns, padding, header, membership https://review.openstack.org/113519 | 11:53 |
openstackgerrit | Jiri Tomasek proposed openstack/horizon: Modal template updates https://review.openstack.org/135649 | 11:53 |
*** dkorn has quit IRC | 11:55 | |
*** jacalcat has joined #openstack-horizon | 11:57 | |
*** markus_z has quit IRC | 12:00 | |
*** colinmcnamara has joined #openstack-horizon | 12:05 | |
rdopieralski | jtomasek: any idea why that devstack-cells job is failing? | 12:07 |
* jtomasek looks | 12:09 | |
jtomasek | rdopieralski: hmm, I can't find any failures in the log except for FAILURE horizon... | 12:11 |
jtomasek | rdopieralski: I am waiting for the failed jenkins in gerrit and will try to recheck | 12:12 |
jtomasek | rdopieralski: If I remember correctly, this happened also with sidebar patch and recheck helped | 12:13 |
rdopieralski | jtomasek: if you look at the previous patches, it was failing there too | 12:13 |
jtomasek | rdopieralski: oh, I see the error now | 12:16 |
jtomasek | rdopieralski: [ERROR] /opt/stack/new/devstack/exercises/horizon.sh:39 Horizon front page not functioning! | 12:17 |
jtomasek | rdopieralski: http://logs.openstack.org/49/135649/3/check/check-devstack-dsvm-cells/f611c2f/console.html | 12:17 |
jtomasek | rdopieralski: it is again because the test checks for <h3>Log In</h3> and h3 has class specified now | 12:17 |
jtomasek | rdopieralski: I'll try to fix that | 12:18 |
robcresswell | https://review.openstack.org/#/c/138313/ <-- Well this was a big learning experience. I had no idea python behaved like this. | 12:21 |
*** cedrics has joined #openstack-horizon | 12:21 | |
jpich | I suspect it's something python developers get burnt with badly once and then (hopefully) never again | 12:23 |
jpich | definitely how I discovered that one the first time :P | 12:23 |
robcresswell | jpich: I was totally baffled by that patch. From a non-python background, it looked like declaring a null value then instantly casting it to an empty dict every time, and I couldnt understand why that worked. Very interesting. | 12:26 |
*** exploreshaifali has quit IRC | 12:27 | |
*** k4n0 has quit IRC | 12:28 | |
rdopieralski | side effects are always a bad idea | 12:28 |
rdopieralski | aah, that thing | 12:29 |
rdopieralski | robcresswell: did you stumble upon the closure trick too? :) | 12:29 |
jtomasek | rdopieralski: https://review.openstack.org/#/c/138337/ | 12:30 |
*** robcresswell_ has joined #openstack-horizon | 12:30 | |
jtomasek | jpich: this ^ is thes similar issue that was happening in tempest | 12:30 |
robcresswell_ | Ack, session died. | 12:31 |
robcresswell_ | rdopieralski: What's the closure one? I'm curious | 12:31 |
rdopieralski | robcresswell_: try predicting what this does: http://paste.openstack.org/show/143489/ | 12:32 |
rdopieralski | robcresswell_: then try explaining why it does actually :) | 12:32 |
rdopieralski | what* | 12:32 |
*** robcresswell has quit IRC | 12:33 | |
rdopieralski | I guess he clicked the link :/ | 12:33 |
robcresswell_ | rdopieralski: O.o well it definitely wasn't what I predicted... | 12:34 |
*** aberezin has joined #openstack-horizon | 12:34 | |
*** colinmcnamara has quit IRC | 12:35 | |
rdopieralski | robcresswell_: its because python functions retain references to variables from outside of them | 12:35 |
rdopieralski | robcresswell_: so it's the same i in all of those lambdas | 12:36 |
sambetts | ah yes, the old lamda scoping issues :-P | 12:38 |
robcresswell_ | rdopieralski: Ahh, I see. I think I saw something similar with javascript a couple years ago, trying to dynamically generate anchors - they all retain the same reference. | 12:40 |
rdopieralski | yup, js has the same behavior | 12:41 |
sambetts | Tasting the curry :-) http://paste.openstack.org/show/143503/ | 12:43 |
rdopieralski | sambetts: https://docs.python.org/2/library/functools.html#functools.partial | 12:49 |
*** radez_afk is now known as radez | 12:52 | |
sambetts | rdopieralski: like this? http://paste.openstack.org/show/143507/ | 12:54 |
rdopieralski | sambetts: I guess so, I just though of partial when you mentioned curry :) | 12:56 |
sambetts | its quite interesting the amount of functional programming ideas come up when uisng python | 12:59 |
rdopieralski | it was all added around 2.4-2.5 | 13:03 |
*** sayan_ has quit IRC | 13:05 | |
openstackgerrit | Doug Fish proposed openstack/horizon: Create titles without concatenation https://review.openstack.org/136056 | 13:09 |
jpich | jtomasek: It probably runs the tempest tests as well | 13:31 |
*** exploreshaifali has joined #openstack-horizon | 13:31 | |
*** tnovacik has joined #openstack-horizon | 13:32 | |
*** tzumainn has joined #openstack-horizon | 13:38 | |
*** palendae has quit IRC | 13:38 | |
*** palendae has joined #openstack-horizon | 13:46 | |
*** jacalcat has quit IRC | 13:51 | |
*** aix has quit IRC | 13:54 | |
*** amotoki has quit IRC | 13:56 | |
*** amotoki has joined #openstack-horizon | 13:57 | |
*** robcresswell_ has quit IRC | 13:58 | |
*** masco has quit IRC | 14:01 | |
*** dboik has joined #openstack-horizon | 14:01 | |
*** _crobertsrh is now known as crobertsrh | 14:04 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Adding filtering to data_processing tables https://review.openstack.org/136459 | 14:08 |
*** rbertram_afk is now known as rbertram | 14:08 | |
*** Longgeek has joined #openstack-horizon | 14:11 | |
*** julim has joined #openstack-horizon | 14:16 | |
*** Longgeek has quit IRC | 14:17 | |
*** neelashah has joined #openstack-horizon | 14:19 | |
*** ayoung has joined #openstack-horizon | 14:30 | |
*** davelowe has quit IRC | 14:31 | |
*** vijendar has joined #openstack-horizon | 14:31 | |
*** davelowe has joined #openstack-horizon | 14:32 | |
*** ayoung has quit IRC | 14:32 | |
*** john-davidge has joined #openstack-horizon | 14:35 | |
*** ayoung has joined #openstack-horizon | 14:38 | |
*** peristeri has joined #openstack-horizon | 14:38 | |
*** ala_ has quit IRC | 14:39 | |
*** ala_ has joined #openstack-horizon | 14:40 | |
*** Longgeek has joined #openstack-horizon | 14:43 | |
jtomasek | ping asahlin_afk | 14:44 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Prevent user from disabling her current project https://review.openstack.org/138383 | 14:46 |
asahlin_afk | jtomasek: Hello | 14:46 |
*** asahlin_afk is now known as asahlin | 14:46 | |
jtomasek | asahlin_afk: hey, I just wanted to ask if you could rebase this one https://review.openstack.org/#/c/115693/ | 14:47 |
jtomasek | asahlin: If it's not a problem of course:) | 14:47 |
asahlin | jtomasek: yes, will do that here shortly. | 14:48 |
jtomasek | asahlin: thanks a lot! | 14:48 |
*** lhcheng has joined #openstack-horizon | 14:48 | |
*** Poornima_ has quit IRC | 14:53 | |
*** Sukhdev has joined #openstack-horizon | 14:57 | |
*** jacalcat has joined #openstack-horizon | 15:02 | |
openstackgerrit | Andrew Bramley proposed openstack/horizon: Add support for Trove Replication https://review.openstack.org/114380 | 15:06 |
*** mattfarina has joined #openstack-horizon | 15:12 | |
*** woodm1979 has joined #openstack-horizon | 15:15 | |
*** ericpeterson has joined #openstack-horizon | 15:16 | |
openstackgerrit | Aaron Sahlin proposed openstack/horizon: Fixed display issues on Details Page caused by bootstrap 3 update https://review.openstack.org/115693 | 15:16 |
jtomasek | asahlin: thanks! | 15:18 |
asahlin | jtomasek: no problem. Hopefully that one goes in soon ;-) | 15:18 |
jtomasek | asahlin: yes | 15:18 |
asahlin | Hi all I have a fairly simple css patch that has made the +1 rounds hoping to get some core approval. https://review.openstack.org/#/c/112394/ | 15:20 |
*** aix has joined #openstack-horizon | 15:22 | |
*** david-lyle has joined #openstack-horizon | 15:23 | |
*** aix has quit IRC | 15:28 | |
*** aix has joined #openstack-horizon | 15:28 | |
*** raorn has quit IRC | 15:29 | |
*** robcresswell has joined #openstack-horizon | 15:33 | |
robcresswell | Does anyone know off the top of their head which version of bootstrap we use? | 15:33 |
*** radez is now known as radez_g0n3 | 15:34 | |
*** aberezin has quit IRC | 15:34 | |
*** aberezin has joined #openstack-horizon | 15:34 | |
*** lhcheng has quit IRC | 15:35 | |
*** lhcheng has joined #openstack-horizon | 15:36 | |
*** raorn has joined #openstack-horizon | 15:36 | |
*** colinmcnamara has joined #openstack-horizon | 15:39 | |
*** lhcheng has quit IRC | 15:40 | |
*** radez_g0n3 is now known as radez | 15:41 | |
*** aberezin has quit IRC | 15:41 | |
*** cody-somerville has quit IRC | 15:41 | |
*** cody-somerville has joined #openstack-horizon | 15:42 | |
*** hinnant has joined #openstack-horizon | 15:42 | |
*** hurgleburgler has joined #openstack-horizon | 15:43 | |
*** wuhg has quit IRC | 15:43 | |
*** mattfarina has quit IRC | 15:45 | |
rbertram | robcresswell: bootstrap 3 - need more specific? | 15:47 |
tsufiev | ah, quite an interesting talk about closures that I missed | 15:49 |
*** david-lyle has quit IRC | 15:50 | |
tsufiev | rdopieralski, that has more to do with the way variables are bound in python/js, not the closures themselves | 15:50 |
*** sayan_ has joined #openstack-horizon | 15:51 | |
*** bpokorny has joined #openstack-horizon | 15:52 | |
*** ZZelle_ has joined #openstack-horizon | 15:52 | |
tsufiev | I started to program in JS after 4 years writing in Common Lisp/Scheme - and had the same problem with unexpected variable modification in a loop (contrary to my experience with Scheme) | 15:52 |
robcresswell | rbertram: Nope, thats fine, thanks | 15:55 |
robcresswell | tsufiev: Yeah it really threw me the first time I encountered it. Not too difficult to isolate, but just very unexpected behaviour | 15:56 |
*** alexpilotti has joined #openstack-horizon | 15:58 | |
*** alexpilotti has quit IRC | 15:59 | |
tsufiev | robcresswell, yeah, it was very confusing for me too :) | 15:59 |
*** alexpilotti has joined #openstack-horizon | 15:59 | |
*** clu_ has joined #openstack-horizon | 16:00 | |
*** ala_ has quit IRC | 16:02 | |
*** regebro has quit IRC | 16:02 | |
*** jacalcat has quit IRC | 16:02 | |
*** dsneddon has joined #openstack-horizon | 16:03 | |
*** ericpeterson has quit IRC | 16:04 | |
*** ericpeterson has joined #openstack-horizon | 16:05 | |
*** Piet has quit IRC | 16:05 | |
*** Sukhdev has quit IRC | 16:05 | |
openstackgerrit | Brianna Poulos proposed openstack/horizon: View encryption metadata for encrypted volumes https://review.openstack.org/134341 | 16:08 |
*** EmilyW has joined #openstack-horizon | 16:11 | |
*** mattfarina has joined #openstack-horizon | 16:15 | |
openstackgerrit | Merged openstack/horizon: Fix popup error when volume service disabled https://review.openstack.org/137547 | 16:18 |
*** tqtran has joined #openstack-horizon | 16:20 | |
*** sayan_ has quit IRC | 16:22 | |
*** raorn has quit IRC | 16:23 | |
*** raorn has joined #openstack-horizon | 16:23 | |
*** mrunge has quit IRC | 16:29 | |
*** kumartin has joined #openstack-horizon | 16:30 | |
*** ericpeterson has quit IRC | 16:30 | |
*** ericpeterson has joined #openstack-horizon | 16:31 | |
*** ygbo has quit IRC | 16:32 | |
*** regebro has joined #openstack-horizon | 16:34 | |
*** neelashah has quit IRC | 16:35 | |
*** htruta has quit IRC | 16:38 | |
*** htruta has joined #openstack-horizon | 16:39 | |
*** ygbo has joined #openstack-horizon | 16:39 | |
*** rbertram is now known as rbertram_afk | 16:45 | |
*** david-lyle has joined #openstack-horizon | 16:49 | |
*** david-lyle has quit IRC | 16:49 | |
*** rbertram_afk is now known as rbertram | 16:49 | |
*** ongk has joined #openstack-horizon | 16:52 | |
*** david-lyle_afk is now known as david-lyle | 16:52 | |
*** ongk has quit IRC | 16:52 | |
*** jcoufal_ has quit IRC | 16:57 | |
*** ongk has joined #openstack-horizon | 16:57 | |
*** packet has joined #openstack-horizon | 16:58 | |
*** packet has quit IRC | 17:00 | |
*** rdopieralski has quit IRC | 17:04 | |
*** packet has joined #openstack-horizon | 17:04 | |
*** nlahouti has joined #openstack-horizon | 17:06 | |
*** packet has quit IRC | 17:07 | |
*** kumartin has quit IRC | 17:08 | |
*** jpich has quit IRC | 17:09 | |
*** nlahouti has quit IRC | 17:12 | |
*** packet has joined #openstack-horizon | 17:13 | |
*** nlahouti has joined #openstack-horizon | 17:14 | |
*** amotoki has quit IRC | 17:15 | |
*** ygbo has quit IRC | 17:16 | |
*** woodm1979 has quit IRC | 17:16 | |
*** cedrics has quit IRC | 17:18 | |
*** lhcheng has joined #openstack-horizon | 17:21 | |
*** ming has joined #openstack-horizon | 17:23 | |
*** dboik has quit IRC | 17:24 | |
ming | hi, i'm trying to get a horizon patch set merged to kilo. It's got 5 +1's and 1 +2, what else do I need to do to get it merged? | 17:25 |
*** MaxV has quit IRC | 17:26 | |
robcresswell | ming: Needs 2 +2s and a workflow | 17:27 |
tnovacik | ming, you need one more +2 | 17:27 |
ming | ahh, okay. Do i just wait for a core to review it then? | 17:27 |
ming | a core reviewer i mean | 17:28 |
robcresswell | ming: Yup! They're very busy, but sometimes if you ask reeeeaally nicely... Generally speaking, just give it a few days and they'll get to it. They're all very active. | 17:28 |
robcresswell | ming: Hope that helps! | 17:28 |
ming | k, thanks! | 17:28 |
*** kmartin has joined #openstack-horizon | 17:29 | |
*** sayan_ has joined #openstack-horizon | 17:29 | |
*** kumartin has joined #openstack-horizon | 17:30 | |
*** colinmcnamara has quit IRC | 17:30 | |
*** ming has quit IRC | 17:31 | |
*** Piet has joined #openstack-horizon | 17:33 | |
*** tosky has quit IRC | 17:42 | |
*** aix has quit IRC | 17:42 | |
*** Longgeek has quit IRC | 17:43 | |
*** robcresswell has quit IRC | 17:47 | |
*** Longgeek has joined #openstack-horizon | 17:48 | |
*** sambetts has quit IRC | 17:48 | |
*** crobertsrh has quit IRC | 17:49 | |
*** athomas has quit IRC | 17:50 | |
*** e0ne has quit IRC | 17:52 | |
*** Longgeek_ has joined #openstack-horizon | 17:53 | |
*** Longgeek has quit IRC | 17:56 | |
*** Longgeek has joined #openstack-horizon | 17:58 | |
*** exploreshaifali has quit IRC | 17:58 | |
*** jamielennox|away is now known as jamielennox | 18:01 | |
*** Longgeek_ has quit IRC | 18:01 | |
tqtran | praying to the review god will also help | 18:02 |
*** neelashah has joined #openstack-horizon | 18:04 | |
tqtran | r1chardj0n3s: have you tested latest patch? its not working for me, fails line22 in keystone.py | 18:04 |
*** dboik has joined #openstack-horizon | 18:06 | |
*** rwsu has joined #openstack-horizon | 18:07 | |
openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Refactor last events https://review.openstack.org/138465 | 18:08 |
tqtran | r1chardj0n3s: request.DATA is blank because request.body is blank. not sure why you would need it to list users? | 18:08 |
*** colinmcnamara has joined #openstack-horizon | 18:11 | |
*** tosky has joined #openstack-horizon | 18:13 | |
*** romainh has quit IRC | 18:13 | |
*** radez is now known as radez_g0n3 | 18:15 | |
rbertram | tqtran: Are you referring to https://review.openstack.org/#/c/136676/12 | 18:16 |
tqtran | rbertram: yes | 18:16 |
rbertram | tqtran: I was just about to pull it down & start catching up on the work. Wondering if it would be the right source of data for the table behavior BP I have. | 18:17 |
tqtran | ok i think i know what richard is doing, but now theres another hurdle. we need the user information client-side | 18:18 |
tqtran | it should work with the table BP you have | 18:19 |
rbertram | tqtran: and the next question is: make an angular table or use jQuery table from clu_ patch | 18:20 |
tqtran | currently using smart table for angular. plan is to eventually move there one panel at a time. so i suppose could use clu's patch in the mean time. | 18:21 |
openstackgerrit | Cindy Lu proposed openstack/horizon: double check admin password when update user password https://review.openstack.org/136874 | 18:21 |
rbertram | tqtran: or I could keep pace with you, following your lead to do Users first | 18:22 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix Terminate Instance on network topology page https://review.openstack.org/138472 | 18:23 |
tqtran | rbertram: yeah, its really up to you. | 18:24 |
tqtran | rbertram: i think in the long run, your time might be better invested in angular. but... if you need something faster, clu's patch might be the better way to go | 18:24 |
rbertram | tqtran: jQuery = do-over when you convert to angular. Angular = more risk for short-term. | 18:25 |
rbertram | tqtran: right. | 18:25 |
tqtran | rbertram: ok here it comes...... "do what your heart tells you" lol jk | 18:25 |
rbertram | tqtran: Wise advice. I need to expose my heart to more of your work, so it tells me something that is better informed. | 18:26 |
tqtran | rbertram: haha yeah, lots of catching up to do. are you going to be on the call later today? | 18:27 |
rbertram | tqtran: The table UX call? Yeah. Just posted comments on the table design in Insight. | 18:28 |
tqtran | yup, im wondering if piet can mock up something for simple modal forms | 18:28 |
tqtran | that way, can incorporate it into what im doing now | 18:29 |
Piet | Just heard my name... | 18:29 |
Piet | What do ya'll need from me? | 18:29 |
tqtran | haha, just wondering if you can also mock up the create user dialog | 18:31 |
rbertram | tqtran: When I look at your patch's link to Richard's, it says "[OUTDATED]". What does that mean? | 18:32 |
Piet | Talk later this afternoon? I think we're meeting with Travis | 18:32 |
tqtran | yes sounds good | 18:33 |
tqtran | it means that richarad updated his patch, while mine still depends on his older patch | 18:33 |
tqtran | i dont recommend rebasing quite yet, because he introduce some new concepts in his latest patch | 18:34 |
tqtran | i have temporary workaround just so i can test out the create user action | 18:34 |
*** rwsu has quit IRC | 18:38 | |
*** sayan_ has quit IRC | 18:42 | |
*** dkorn has joined #openstack-horizon | 18:43 | |
*** kumartin has quit IRC | 18:44 | |
*** amcrn has joined #openstack-horizon | 18:49 | |
*** tosky has quit IRC | 18:51 | |
openstackgerrit | Kahou Lei proposed openstack/horizon: Implements: blueprint 133767 https://review.openstack.org/138214 | 18:52 |
*** crobertsrh has joined #openstack-horizon | 18:52 | |
*** colinmcnamara has quit IRC | 18:56 | |
*** akrivoka has quit IRC | 18:56 | |
*** Longgeek has quit IRC | 18:58 | |
*** radez_g0n3 is now known as radez | 18:58 | |
*** dboik_ has joined #openstack-horizon | 18:59 | |
*** e0ne has joined #openstack-horizon | 18:59 | |
*** dboik has quit IRC | 19:03 | |
rbertram | tqtran: I see what you mean | 19:04 |
*** mikedillion has joined #openstack-horizon | 19:07 | |
*** tnovacik has quit IRC | 19:08 | |
*** ericpeterson has quit IRC | 19:08 | |
*** ericpeterson has joined #openstack-horizon | 19:09 | |
Piet | It would be good to know where we should be focusing our UX activities next...after we're done with Launch Instance, Details panel and Responsive Tables. | 19:10 |
openstackgerrit | Gloria Gu proposed openstack/horizon: Added snapshot list for a volume https://review.openstack.org/138494 | 19:16 |
*** jwy has joined #openstack-horizon | 19:16 | |
*** Piet has quit IRC | 19:22 | |
*** e0ne has quit IRC | 19:25 | |
*** e0ne has joined #openstack-horizon | 19:26 | |
*** tnovacik has joined #openstack-horizon | 19:28 | |
*** neillc_away is now known as neillc | 19:33 | |
*** rdobosz has quit IRC | 19:34 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Adding filtering to data_processing tables https://review.openstack.org/136459 | 19:34 |
*** rdobosz has joined #openstack-horizon | 19:34 | |
*** exploreshaifali has joined #openstack-horizon | 19:38 | |
openstackgerrit | David Lyle proposed openstack/horizon: Improving more projects link in context selection https://review.openstack.org/138501 | 19:38 |
*** e0ne has quit IRC | 19:43 | |
*** amcrn has quit IRC | 19:45 | |
*** MaxV has joined #openstack-horizon | 19:54 | |
*** MaxV has quit IRC | 19:57 | |
*** Longgeek has joined #openstack-horizon | 19:58 | |
*** ZZelle_ has quit IRC | 19:58 | |
openstackgerrit | Gloria Gu proposed openstack/horizon: Added snapshot list for a volume https://review.openstack.org/138510 | 19:59 |
*** sayan_ has joined #openstack-horizon | 20:01 | |
*** packet has quit IRC | 20:01 | |
*** MaxV has joined #openstack-horizon | 20:02 | |
*** MaxV has quit IRC | 20:02 | |
*** Longgeek has quit IRC | 20:03 | |
*** Sukhdev has joined #openstack-horizon | 20:05 | |
*** dboik_ has quit IRC | 20:05 | |
*** e0ne has joined #openstack-horizon | 20:05 | |
*** dboik has joined #openstack-horizon | 20:06 | |
*** dboik has quit IRC | 20:07 | |
*** dboik has joined #openstack-horizon | 20:07 | |
*** radez is now known as radez_g0n3 | 20:07 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon: doc: Split settings page into sub sections https://review.openstack.org/125278 | 20:08 |
*** jtomasek has quit IRC | 20:09 | |
*** e0ne has quit IRC | 20:10 | |
*** MaxV has joined #openstack-horizon | 20:10 | |
*** MaxV has quit IRC | 20:11 | |
*** Piet has joined #openstack-horizon | 20:18 | |
*** john-davidge has quit IRC | 20:27 | |
*** htruta has quit IRC | 20:30 | |
*** raildo has quit IRC | 20:30 | |
*** dsneddon has quit IRC | 20:30 | |
*** ongk has quit IRC | 20:31 | |
openstackgerrit | David Lyle proposed openstack/horizon: Changing icons for floating IP association https://review.openstack.org/138523 | 20:31 |
*** dsneddon has joined #openstack-horizon | 20:31 | |
*** jacalcat has joined #openstack-horizon | 20:32 | |
r1chardj0n3s | tqtran: whoops, sorry. | 20:36 |
tqtran | r1chardj0n3s: i just discovered something else too, posting doesnt work =( | 20:38 |
tqtran | r1chardj0n3s: let me upload the latest patch so you can test it | 20:38 |
*** exploreshaifali has quit IRC | 20:40 | |
rbertram | r1chardj0n3s: We were talking recently about async events to the browser. I assume you are still interested in that topic? | 20:40 |
openstackgerrit | Thai Tran proposed openstack/horizon: WIP new REST API for angular front end https://review.openstack.org/136676 | 20:41 |
openstackgerrit | Thai Tran proposed openstack/horizon: POST instantiation for Django-Angular https://review.openstack.org/136556 | 20:41 |
openstackgerrit | Thai Tran proposed openstack/horizon: WIP angularize identity users. Most things are broken. Working on create modal. https://review.openstack.org/133767 | 20:41 |
r1chardj0n3s | tqtran: ok, yep. just eating my breakfast at the moment, catching up on messages :) | 20:41 |
r1chardj0n3s | rbertram: sure, yep | 20:41 |
rbertram | r1chardj0n3s: I was noticing that in the list of BPs for Kilo here https://blueprints.launchpad.net/horizon ordered by priority, the 2nd, 3rd, and 4th one are on that topic. So David is prioritizing this highly. | 20:41 |
*** htruta has joined #openstack-horizon | 20:42 | |
*** raildo has joined #openstack-horizon | 20:42 | |
rbertram | And this patch seems like the one to look at: https://review.openstack.org/#/c/40198/ | 20:42 |
*** ongk has joined #openstack-horizon | 20:42 | |
rbertram | r1chardj0n3s: It uses SocksJS (from another patch) to update the Instances view. I have not looked at it yet but plan to. | 20:42 |
r1chardj0n3s | oh, thanks for pointing that out. I'll take a look. What do you think? | 20:43 |
r1chardj0n3s | ah ok | 20:43 |
rbertram | r1chardj0n3s: I think many things... | 20:43 |
r1chardj0n3s | hang on, *why* is it using sockjs ... ;) | 20:43 |
r1chardj0n3s | what browser target do we have that doesn't support websokcets natively? | 20:44 |
*** ZZelle_ has joined #openstack-horizon | 20:45 | |
rbertram | r1chardj0n3s: none. I think SockJS is on the server side to feed it. | 20:45 |
rbertram | r1chardj0n3s: SockJS is python, despite the name. I think. | 20:45 |
r1chardj0n3s | rbertram: erm. but sockjs on the server side is a node thing... wha... | 20:45 |
r1chardj0n3s | ok, I will look more closely lol | 20:46 |
rbertram | me too | 20:46 |
rbertram | r1chardj0n3s: no, you are right. It is for browsers to fail over to, when no websocket support. | 20:48 |
rbertram | So I misunderstood; need to look at patch more closely for sure. | 20:48 |
david-lyle | rbertram: r1chardj0n3s, the patch using those are almost 2 years old IIRC | 20:49 |
david-lyle | year and a half now that I looked | 20:49 |
david-lyle | but started before that | 20:50 |
rbertram | david-lyle: right. | 20:50 |
r1chardj0n3s | david-lyle, rbertram: yeah, I just noticed the mention in the discussion that it was abandoned | 20:50 |
r1chardj0n3s | definitely worth looking into the current state of the art | 20:50 |
david-lyle | real-time has been marked high for longer than that | 20:51 |
rbertram | david-lyle: so you are not hopeful of it for Kilo? | 20:52 |
david-lyle | rbertram: no | 20:52 |
r1chardj0n3s | but, y'know, a boy's gotta have dreams | 20:52 |
david-lyle | it would be nice, but I think many other things are in motion already | 20:52 |
rbertram | david-lyle: seems we are still trying to figure out right architecture for it, right? | 20:53 |
david-lyle | would rather get those things nailed down, if real-time is requirement to doing the clientside work, then we raise its actual priority | 20:53 |
david-lyle | rbertram: yes | 20:53 |
*** Piet has quit IRC | 20:54 | |
r1chardj0n3s | tqtran: you uploaded patchset 14 of the REST API but I can't see any changes (I'm probably driving gerrit wrong) | 20:54 |
tqtran | r1chardj0n3s: yeah, its because my patch has a dependency on yours | 20:55 |
tqtran | r1chardj0n3s: so when i upload mine, it auto upload yours as well | 20:55 |
r1chardj0n3s | tqtran: and oh wow that bug is quite the braino, sorry I broke that stuff, I'll fix it ASAP :/ | 20:55 |
r1chardj0n3s | tqtran: oh, ok | 20:56 |
tqtran | r1chardj0n3s: basically, i reverted your patch back one step, then added my own code to allow listing of projects | 20:56 |
rbertram | r1chardj0n3s: I do not see that this is abandoned: https://review.openstack.org/#/c/40198/ Nor the patch it depends on. Maybe they should be. | 20:56 |
tqtran | r1chardj0n3s: just so i can continue to test my modal stuff | 20:56 |
*** TravT has quit IRC | 20:57 | |
r1chardj0n3s | rbertram: it was abandoned, see the comments | 20:57 |
tqtran | rbertram: we have plans in motion that would allow us to take advantage of the websocket stuff | 20:58 |
rbertram | r1chardj0n3s: I see abandoned, and later restored | 20:58 |
r1chardj0n3s | yep | 20:58 |
tqtran | rbertram: but need to lay foundation with REST and angular first | 20:59 |
openstackgerrit | Richard Jones proposed openstack/horizon: WIP new REST API for angular front end https://review.openstack.org/136676 | 21:02 |
r1chardj0n3s | tqtran: fixed those broken get handlers | 21:02 |
r1chardj0n3s | brb | 21:02 |
r1chardj0n3s | er, no I didn't | 21:03 |
*** bpokorny_ has joined #openstack-horizon | 21:03 | |
*** bpokorny has quit IRC | 21:06 | |
r1chardj0n3s | gah, has_more_data | 21:07 |
openstackgerrit | Richard Jones proposed openstack/horizon: WIP new REST API for angular front end https://review.openstack.org/136676 | 21:09 |
r1chardj0n3s | ok, tqtran, this time for sure. more tests needed, clearly ;) | 21:09 |
r1chardj0n3s | tqtran: note that GET /api/keystone/projects/ returns (list, has_more_data) because it's one of the few APIs that supports pagination | 21:10 |
*** MaxV has joined #openstack-horizon | 21:10 | |
tqtran | r1chardj0n3s: yup thats fine, can you also test the POST? | 21:10 |
r1chardj0n3s | tqtran: which one? | 21:11 |
tqtran | launch the create modal and create a new user | 21:11 |
tqtran | using my new code | 21:11 |
r1chardj0n3s | I'm just using the chrome rest client to test this stuff | 21:11 |
tqtran | check the console and you'll see a printout of the object, however, it never reaches the POST handler | 21:11 |
r1chardj0n3s | much easier to debug | 21:11 |
r1chardj0n3s | hm | 21:12 |
*** radez_g0n3 is now known as radez | 21:12 | |
*** sayan has quit IRC | 21:15 | |
r1chardj0n3s | tqtran: ok, I fixed a couple of issues in the user create POST handler so now it works for simple cases at least | 21:18 |
tqtran | i'll go download a REST client and play around as well | 21:19 |
r1chardj0n3s | grab the "advanced rest client" app for chrome | 21:19 |
r1chardj0n3s | I'll try to focus on extending the unit test suite for the API today | 21:20 |
tqtran | ok, i'll poke around see why the angular post isnt hitting the API | 21:21 |
r1chardj0n3s | latest version up on gerrit? | 21:21 |
tqtran | yeah it is | 21:22 |
*** regebro has quit IRC | 21:24 | |
*** sayan_ has quit IRC | 21:25 | |
r1chardj0n3s | is there some magic I can use to have both your change and mine at the same time? | 21:25 |
*** neelashah has quit IRC | 21:26 | |
*** colinmcnamara has joined #openstack-horizon | 21:27 | |
david-lyle | r1chardj0n3s: git review -d <change-id-of-thai's patch> | 21:27 |
david-lyle | that should pull the chain of dependencies | 21:27 |
r1chardj0n3s | oh, ok! | 21:28 |
r1chardj0n3s | thanks :) | 21:28 |
tqtran | or you can just pull down my change and create a new branch for it. then rebase as needed | 21:30 |
r1chardj0n3s | I like the sound of the one line command :) | 21:30 |
*** e0ne has joined #openstack-horizon | 21:30 | |
tqtran | haha sure, that will work too | 21:31 |
r1chardj0n3s | "git review -d <thai's change>" pulls in my old change, not the latest | 21:31 |
r1chardj0n3s | gah. ok, "git merge rest-api" was *not* what I wanted to do, apparently | 21:32 |
*** mikedillion has quit IRC | 21:32 | |
*** julim has quit IRC | 21:33 | |
*** openstackgerrit has quit IRC | 21:34 | |
*** openstackgerrit has joined #openstack-horizon | 21:35 | |
r1chardj0n3s | well, it got me to the right place eventually, mergy mergy | 21:36 |
openstackgerrit | Kahou Lei proposed openstack/horizon: WIP new REST API for angular front end https://review.openstack.org/136676 | 21:37 |
openstackgerrit | Kahou Lei proposed openstack/horizon: POST instantiation for Django-Angular https://review.openstack.org/136556 | 21:37 |
openstackgerrit | Kahou Lei proposed openstack/horizon: WIP angularize identity users. Most things are broken. Working on create modal. https://review.openstack.org/133767 | 21:37 |
openstackgerrit | Kahou Lei proposed openstack/horizon: WIP Angularize identity modal forms https://review.openstack.org/138547 | 21:37 |
r1chardj0n3s | agh, I keep making changes but forget that we don't have LiveReload on! we need LiveReload :) | 21:37 |
*** alexpilotti has quit IRC | 21:38 | |
r1chardj0n3s | ok, tqtran, got a couple of changes to make to your code | 21:38 |
tqtran | sure, go for it | 21:39 |
tqtran | if you're using the django server, it should be live for python at least | 21:39 |
r1chardj0n3s | in hzIdentityFormCtrl the /api/keystone/projects/ handler needs to $scope.projects = data[0]; | 21:39 |
r1chardj0n3s | yeah, but that doesn't help angular ;) | 21:39 |
r1chardj0n3s | which is where all the fun is these days ;) | 21:39 |
r1chardj0n3s | so the projects list returns (list, has_more_data) because the projects API is one of the few that supports pagination | 21:40 |
r1chardj0n3s | secondly the POST action URL is incorrect, is "identity/users" should be "api/keystone/users/" | 21:41 |
r1chardj0n3s | then it works | 21:41 |
*** TravT has joined #openstack-horizon | 21:41 | |
r1chardj0n3s | well, it works *more*... | 21:41 |
*** TravT has quit IRC | 21:42 | |
*** TravT has joined #openstack-horizon | 21:42 | |
*** ayoung is now known as moregainfainburp | 21:42 | |
r1chardj0n3s | no, it works completely, just the list wasn't updated ;) | 21:42 |
*** moregainfainburp is now known as ayoung | 21:42 | |
*** TravT has quit IRC | 21:42 | |
*** Piet has joined #openstack-horizon | 21:42 | |
tqtran | lol | 21:43 |
*** TravT has joined #openstack-horizon | 21:43 | |
tqtran | omg so my url was wrong.... thats why lol | 21:43 |
tqtran | i was attempting to post to a template | 21:43 |
tqtran | lol | 21:43 |
tqtran | no wonder the response was html | 21:43 |
r1chardj0n3s | :) | 21:44 |
* r1chardj0n3s coffees | 21:44 | |
*** Longgeek has joined #openstack-horizon | 21:48 | |
openstackgerrit | David Lyle proposed openstack/horizon: Adding Host Server to instance detail page https://review.openstack.org/138555 | 21:50 |
*** ongk has quit IRC | 21:50 | |
*** Longgeek has quit IRC | 21:52 | |
r1chardj0n3s | brb | 21:53 |
*** mikedillion has joined #openstack-horizon | 21:53 | |
*** ongk has joined #openstack-horizon | 21:58 | |
*** bpokorn__ has joined #openstack-horizon | 22:03 | |
*** nlahouti1 has joined #openstack-horizon | 22:04 | |
*** jacalcat1 has joined #openstack-horizon | 22:04 | |
*** Sukhdev has quit IRC | 22:05 | |
*** bpokorny_ has quit IRC | 22:05 | |
*** nlahouti has quit IRC | 22:05 | |
*** crobertsrh has quit IRC | 22:05 | |
*** bpokorny_ has joined #openstack-horizon | 22:05 | |
*** e0ne has quit IRC | 22:05 | |
*** jacalcat has quit IRC | 22:07 | |
*** bpokorn__ has quit IRC | 22:08 | |
*** alexpilotti has joined #openstack-horizon | 22:08 | |
*** vijendar has quit IRC | 22:10 | |
*** bpokorny has joined #openstack-horizon | 22:12 | |
*** bpokorny_ has quit IRC | 22:15 | |
openstackgerrit | Doug Fish proposed openstack/horizon: Make the instance status in Network Topolgy translatable https://review.openstack.org/130413 | 22:22 |
*** mikedillion has quit IRC | 22:23 | |
*** dboik has quit IRC | 22:26 | |
*** dboik has joined #openstack-horizon | 22:26 | |
r1chardj0n3s | . | 22:26 |
*** dboik has quit IRC | 22:28 | |
*** dkorn has quit IRC | 22:28 | |
*** dboik has joined #openstack-horizon | 22:28 | |
openstackgerrit | Doug Fish proposed openstack/horizon: Make the instance status in Network Topolgy translatable https://review.openstack.org/130413 | 22:36 |
*** ayoung is now known as buhbye | 22:39 | |
*** buhbye has quit IRC | 22:39 | |
openstackgerrit | Doug Fish proposed openstack/horizon: Make the instance status in Network Topolgy translatable https://review.openstack.org/130413 | 22:39 |
*** dboik has quit IRC | 22:44 | |
*** dboik has joined #openstack-horizon | 22:48 | |
*** dboik has quit IRC | 22:48 | |
*** dboik has joined #openstack-horizon | 22:48 | |
*** ericpeterson has quit IRC | 22:50 | |
*** ericpeterson has joined #openstack-horizon | 22:50 | |
*** raildo_ has joined #openstack-horizon | 22:50 | |
*** MaxV has quit IRC | 22:50 | |
*** ongk has quit IRC | 22:53 | |
*** Dafna has quit IRC | 22:58 | |
*** rhagarty has quit IRC | 22:58 | |
*** rhagarty has joined #openstack-horizon | 22:58 | |
*** Dafna has joined #openstack-horizon | 22:59 | |
*** bradjones has quit IRC | 22:59 | |
*** dboik has quit IRC | 22:59 | |
*** htruta has quit IRC | 23:00 | |
*** mattfarina has quit IRC | 23:01 | |
*** dboik has joined #openstack-horizon | 23:01 | |
*** ericpeterson has quit IRC | 23:04 | |
*** ericpeterson has joined #openstack-horizon | 23:05 | |
*** ericpete_ has joined #openstack-horizon | 23:05 | |
*** bpokorny has quit IRC | 23:09 | |
*** alexpilotti has quit IRC | 23:09 | |
*** ericpeterson has quit IRC | 23:10 | |
*** htruta has joined #openstack-horizon | 23:12 | |
openstackgerrit | Richard Hagarty proposed openstack/horizon: Add bootable flag to edit volume panel https://review.openstack.org/135730 | 23:13 |
*** bpokorny has joined #openstack-horizon | 23:14 | |
*** alexpilotti has joined #openstack-horizon | 23:16 | |
*** bpokorny_ has joined #openstack-horizon | 23:19 | |
*** alexpilotti has quit IRC | 23:21 | |
*** bpokorny has quit IRC | 23:22 | |
*** bradjones has joined #openstack-horizon | 23:28 | |
*** dboik_ has joined #openstack-horizon | 23:31 | |
*** bpokorny_ has quit IRC | 23:32 | |
*** dboik has quit IRC | 23:35 | |
*** radez is now known as radez_g0n3 | 23:35 | |
*** dboik_ has quit IRC | 23:36 | |
*** ericpete_ has quit IRC | 23:37 | |
openstackgerrit | Richard Jones proposed openstack/horizon: WIP new REST API for angular front end https://review.openstack.org/136676 | 23:39 |
r1chardj0n3s | tqtran: if you're still around, I've pushed rev 18 of my REST API change which addresses most of your comments (if not all) which is a shame because I think I fixed them before you wrote the comments. At least we're on the same page :/ | 23:40 |
tqtran | r1chardj0n3s: haha ok, i'll take a look later tonight. | 23:41 |
r1chardj0n3s | tqtran: except for the project/project_id thing which I'll address in a new change set | 23:42 |
r1chardj0n3s | tqtran: I like the idea of making things like project*_id* explicit in the API. | 23:42 |
tqtran | r1chardj0n3s: yeah thats fine, its not a big deal. only this is that right now, the fields that angular send out has to match exactly what you have on the server | 23:42 |
r1chardj0n3s | will do the same for group/group_id, domain/domain_id | 23:42 |
*** ftcjeff has joined #openstack-horizon | 23:43 | |
r1chardj0n3s | user/user_id | 23:43 |
tqtran | r1chardj0n3s: yeah that would be good | 23:43 |
openstackgerrit | Richard Jones proposed openstack/horizon: WIP new REST API for angular front end https://review.openstack.org/136676 | 23:45 |
r1chardj0n3s | tqtran: ok, that change is pushed :) | 23:45 |
r1chardj0n3s | tqtran: I've run out of milk so I'm gonna go cafehack for the rest of the morning so I can have coffee, will get onto writing more tests there :) | 23:46 |
*** peristeri has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!