*** woodm19791 has quit IRC | 00:02 | |
*** Sukhdev has quit IRC | 00:02 | |
*** Sukhdev has joined #openstack-horizon | 00:03 | |
*** e0ne has quit IRC | 00:07 | |
*** ericpeterson has quit IRC | 00:08 | |
*** e0ne has joined #openstack-horizon | 00:11 | |
tqtran | r1chardj0n3s: got an angular question for you | 00:14 |
---|---|---|
r1chardj0n3s | tqtran: fire away | 00:14 |
gugl | ping tqtran regarding review https://review.openstack.org/#/c/117053/ not sure how to combine them...can you advise? thanks. | 00:15 |
tqtran | r1chardj0n3s: im trying to put identity users into a different module, but i want to load it only when i need it, basically, i dont want to preload it as a dependency in hz app. | 00:16 |
r1chardj0n3s | why? | 00:16 |
r1chardj0n3s | (given that it'll all be loaded in a single JS file anyway) | 00:17 |
tqtran | r1chardj0n3s: hm... not sure if theres much to be gain here, but the idea is to load only what we need, this of course will include the angular modules as well | 00:18 |
tqtran | gugl: i'll leave a comment in the patch | 00:19 |
r1chardj0n3s | indeed I question what the gain is given the complication it introduces :) | 00:19 |
gugl | tqtran, sounds good, thanks. | 00:19 |
tqtran | r1chardj0n3s: well if you think about it, lets say we have 20 different panels, each panel requiring its own JS module | 00:20 |
r1chardj0n3s | you can use require.js to load js stuff on demand, but it overly-complicates your application and again since we're compiling all the JS down to a single file, I don't see any benefit | 00:20 |
tqtran | r1chardj0n3s: thats 20 different modules we are loading upfront, when we only need 1 | 00:20 |
tqtran | r1chardj0n3s: right, so the compression will take care of it, and might be easier to do. just wanted a different opinion | 00:21 |
r1chardj0n3s | tqtran: the way I see it is that the angular app is a single-page app which has a bunch of JS behind it. trying to do partial loads would be like writing a Python application that only executed code imports when functions inside the modules are executed. lots of complexity for little gain. | 00:23 |
r1chardj0n3s | angular app development is not like old-school JS spaghetti development where the page changes constantly and the JS is re-executed every time | 00:23 |
r1chardj0n3s | (well, it'll be *kinda* like that, but less and less so as we migrate) | 00:24 |
r1chardj0n3s | the more stuff in the angular app, the fewer transitions in and out of the single-page angular app :) | 00:24 |
tqtran | r1chardj0n3s: ok, good talk lol, i think i'll keep it simple | 00:24 |
r1chardj0n3s | I like simple :) | 00:25 |
r1chardj0n3s | (which is why I'm currently reading horizon/exceptions.py and dying a little on the inside) | 00:25 |
r1chardj0n3s | ... which also contains this comment: | 00:26 |
r1chardj0n3s | # TODO(gabriel): This bugfix is cribbed from Django's code. When 1.4.1 | 00:26 |
r1chardj0n3s | # is available we can remove this code. | 00:26 |
*** colinmcnamara has quit IRC | 00:27 | |
*** sbfox has quit IRC | 00:27 | |
tqtran | gugl: try this: <div id="{% if resize_instance %} quota_resize_instance {%else%} quota_instances {% endif %}" ....></div> | 00:29 |
*** ongk has quit IRC | 00:29 | |
tqtran | gulg: not the prettiest thing, but it should do the trick | 00:29 |
openstackgerrit | Kevin Benton proposed openstack/horizon: Provide tenant_id in Neutron create requests https://review.openstack.org/133884 | 00:33 |
*** Sukhdev_ has joined #openstack-horizon | 00:34 | |
jamielennox | is django_openstack_auth ever called back into from horizon? i realize the user and token objects are used but are the interfaces contained with DOA public? | 00:34 |
*** Sukhdev_ has quit IRC | 00:35 | |
*** Sukhdev has quit IRC | 00:36 | |
gugl | tqtran, will try, tks. | 00:36 |
*** Sukhdev has joined #openstack-horizon | 00:40 | |
tqtran | jamielennox: from my understanding, you are redirected to DOA when you hit the /auth/... url. from there, the form you submit is generated by DOA and the user object is injected into the request object. From there horizon is able to use this user object to obtain the token and use it to make various API calls | 00:40 |
jamielennox | tqtran: how does it handle multiple tokens / user? | 00:41 |
jamielennox | ok - so that means i should be able to change the function interfaces within DOA that aren't part of the user object | 00:42 |
tqtran | jamielennox: not sure i understand, the request object is on a per user basis | 00:42 |
jamielennox | tqtran: i was thinking rescoping to other projects | 00:42 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Create a reusable angular based wizard https://review.openstack.org/137417 | 00:43 |
tqtran | jamielennox: https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/views.py#L156 allows switching of one project to another. | 00:45 |
*** aix has quit IRC | 00:49 | |
gugl | tqtran, the combined code doesn't seem to work correctly...it only picks up quota_resize_instance...ignors quota_instances sort of messed up the launch instance...looks like can not combine them | 00:53 |
openstackgerrit | Cindy Lu proposed openstack/horizon: add missing icons for Project > Images filter https://review.openstack.org/120237 | 00:54 |
tqtran | gugl: let me give it a try | 00:54 |
gugl | tqtran, k | 00:54 |
*** e0ne has quit IRC | 01:02 | |
*** Sukhdev_ has joined #openstack-horizon | 01:03 | |
*** Sukhdev has quit IRC | 01:04 | |
tqtran | gulg: <div id="{% if resize_instance %}quota_resize_instance{% else %}quota_instances{% endif %}" class="quota_bar" data-progress-indicator-flavor data-quota-limit="{{ usages.maxTotalInstances }}" data-quota-used="{{usages.totalInstancesUsed}}"></div> | 01:05 |
tqtran | gulg: that is what i have, and it works for me | 01:05 |
*** e0ne has joined #openstack-horizon | 01:06 | |
*** Sukhdev_ has quit IRC | 01:06 | |
gugl | tqtran, have you tried launch instance as well...the instance number stops increase for that dialog | 01:06 |
*** Sukhdev has joined #openstack-horizon | 01:06 | |
gugl | tqtran, it works for resize...but has issue for launch instance | 01:06 |
*** Piet has joined #openstack-horizon | 01:07 | |
*** kumartin has joined #openstack-horizon | 01:08 | |
tqtran | yeah, looking into that | 01:08 |
tqtran | but not sure how thats related to the change | 01:08 |
*** Sukhdev_ has joined #openstack-horizon | 01:08 | |
*** ZZelle_ has quit IRC | 01:09 | |
*** dboik has quit IRC | 01:09 | |
gugl | well, for launch instance, it uses the id=quota_instance, for resize it uses id=quota_resize_instance...based on different id, it calcs diff numbers | 01:10 |
tqtran | gulg: ok so i just tested it, it works for me | 01:10 |
tqtran | gulg: when i increase instance count, the bar moves upward | 01:10 |
*** Sukhdev has quit IRC | 01:11 | |
gugl | tqtran, assume you tested both resize and luanch...ok, will try again. thanks | 01:11 |
tqtran | gugl: yep, i tested both | 01:11 |
tqtran | gugl: if you dont like encompassing it all in the string, can also do <div {% if cond %}id="something1"{% else %}id="something2"..... | 01:13 |
*** ongk has joined #openstack-horizon | 01:13 | |
gugl | tqtran, ok, that is more readable...will try. thanks for the help! | 01:13 |
tqtran | gugl: np, i'll help bug lin to reapprove as well once you upload latest | 01:15 |
gugl | tqtran, thanks so much! | 01:15 |
gugl | tqtran, it works, many thanks again! Will upload new patch, ping you when Jenkins is happy. | 01:28 |
tqtran | gugl: ok =) | 01:29 |
*** cbader has quit IRC | 01:29 | |
*** Sukhdev_ has quit IRC | 01:30 | |
*** raildo has joined #openstack-horizon | 01:35 | |
*** tnovacik has quit IRC | 01:35 | |
openstackgerrit | Gloria Gu proposed openstack/horizon: Fixed issue of progress bars in resize instance https://review.openstack.org/117053 | 01:35 |
*** e0ne has quit IRC | 01:37 | |
*** e0ne has joined #openstack-horizon | 01:41 | |
*** kumartin has quit IRC | 01:41 | |
*** alexpilotti has joined #openstack-horizon | 01:43 | |
*** raildo has quit IRC | 01:46 | |
*** lhcheng has quit IRC | 01:47 | |
*** colinmcnamara has joined #openstack-horizon | 01:55 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: Replace set_id_as_name_if_empty with name_or_id https://review.openstack.org/122372 | 02:01 |
*** alexpilotti has quit IRC | 02:06 | |
openstackgerrit | Gloria Gu proposed openstack/horizon: No delete volume action for volume with snapshots https://review.openstack.org/136431 | 02:10 |
openstackgerrit | Jamie Lennox proposed openstack/django_openstack_auth: Use standard test loading features https://review.openstack.org/140200 | 02:11 |
*** ayoung has joined #openstack-horizon | 02:17 | |
*** e0ne has quit IRC | 02:20 | |
*** julim has quit IRC | 02:27 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: WIP Styling identity tables https://review.openstack.org/138598 | 02:28 |
*** clu_ has quit IRC | 02:31 | |
*** jacalcat has joined #openstack-horizon | 02:31 | |
gugl | tqtran, https://review.openstack.org/117053 is done. whenever you get a chance, please rereview. Thanks. | 02:31 |
*** jacalcat has quit IRC | 02:36 | |
*** tom_lkn1 has quit IRC | 02:41 | |
*** nlahouti has quit IRC | 02:41 | |
tqtran | gugl: done! | 02:42 |
gugl | tqtran, great! Thanks! | 02:43 |
tqtran | gugl: np, you're very welcome | 02:43 |
gugl | tqtran, :) | 02:43 |
tqtran | r1chardj0n3s: https://review.openstack.org/#/c/139532/2/openstack_dashboard/api/rest/keystone.py | 02:44 |
tqtran | r1chardj0n3s: im thinking that return object should also follow the same format we discussed | 02:44 |
tqtran | r1chardj0n3s: that way, its flexible enough to allow us to attach other things in the future, like has_more, etc.... | 02:45 |
r1chardj0n3s | oh, I was going to ask you about that comment; am happy to change it :) | 02:45 |
tqtran | r1chardj0n3s: awesome =) | 02:45 |
*** tom_lkn1 has joined #openstack-horizon | 02:46 | |
r1chardj0n3s | I keep getting distracted from trying to figure out what horizon/exceptions.py is doing and whether I can leverage it; I welcome the distraction to keep not thinking about that ;) | 02:46 |
tqtran | r1chardj0n3s: lol | 02:46 |
tqtran | r1chardj0n3s: yeah i do that a lot too, was trying to figure out the best way to do password confirmation validation. i think the form is in good shape now.... so now its all about testing your API | 02:47 |
*** dboik has joined #openstack-horizon | 02:57 | |
openstackgerrit | Richard Jones proposed openstack/horizon: REST API for angular front end. https://review.openstack.org/136676 | 03:01 |
openstackgerrit | Richard Jones proposed openstack/horizon: Keystone REST API for angular front end. https://review.openstack.org/139532 | 03:01 |
r1chardj0n3s | tqtran: updated API now in gerrit | 03:01 |
tqtran | r1chardj0n3s: so im doing a bit of digging, looks like API can fail when attempting to add roles for user | 03:02 |
r1chardj0n3s | fail how? | 03:03 |
tqtran | r1chardj0n3s: right now, REST API isnt returning some form of http error so client doesn't know what error to show user | 03:03 |
*** vijendar has quit IRC | 03:03 | |
*** dsneddon has quit IRC | 03:03 | |
r1chardj0n3s | what is it returning? a django 500 HTML page? | 03:03 |
tqtran | r1chardj0n3s: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/forms.py#L143 | 03:04 |
*** dsneddon has joined #openstack-horizon | 03:04 | |
tqtran | r1chardj0n3s: yours doesnt return anything, it assumes that a role will be added and returns the newUser object | 03:04 |
r1chardj0n3s | what do you mean "doesnt return anything"? what specifically isn't returning anything, and is it the complete absence of return data, or is it not returning anything sensible (eg the django 500 page)? is anything being logged (ie. is the rest/utils.py Exception handler path being used?) | 03:06 |
r1chardj0n3s | or is it returning a 204? | 03:07 |
tqtran | r1chardj0n3s: so im basically just following the flow of your code. i havent gotten it to error out, but suppose it does, how are exceptions caught right now? | 03:07 |
*** tom_lkn1 has quit IRC | 03:08 | |
r1chardj0n3s | what specific bit of code? :) the various REST endpoints are wrapped in the rest/utils.py wrapper which catches exceptions and returns an AJAX error, even in "except Exception" cases. | 03:08 |
r1chardj0n3s | if it's an error in *the wrapper* though, you should still get a django 500 HTML error page returned | 03:10 |
*** vijendar has joined #openstack-horizon | 03:11 | |
tqtran | r1chardj0n3s: so lets say i invoke the create user REST API, and the REST API then invokes 1. api.keystone.user_create and 2. api.keystone.roles_for_user | 03:11 |
r1chardj0n3s | if api.keystone.add_tenant_user_role fails by throwing an exception, you should see that as an AJAX result to the call on the client | 03:11 |
r1chardj0n3s | yep | 03:11 |
tqtran | r1chardj0n3s: right now, if 1 or 2 fails, i get a 500 regardless | 03:11 |
tqtran | r1chardj0n3s: but the error needs to be more specific so i can display an error message to the user | 03:12 |
tqtran | r1chardj0n3s: ah ok, so if add_tenant_user_role fails, then am i getting a specific error code? or just 500? | 03:13 |
r1chardj0n3s | ah, ok, so you are getting the 500 response (not "nothing") but you want to customise the error | 03:13 |
tqtran | r1chardj0n3s: yes, it would be best if you can just forward the API error code to the client | 03:13 |
tqtran | r1chardj0n3s: that way, we can avoid having our own custom exception handler, let client decide what message is appropriate for what error | 03:14 |
r1chardj0n3s | that *is* the error code from the client, if the client returns a useful one (see the special HTTPClientError branch in rest/utils.py) | 03:14 |
r1chardj0n3s | in this case, the client is apparently not returning a useful error | 03:14 |
r1chardj0n3s | would it be feasible for me to reproduce this error? | 03:15 |
tqtran | https://review.openstack.org/#/c/133767/15/openstack_dashboard/static/dashboard/js/hz.identity.users.js L38, basically i want to catch the status code and display custom error message depending on status code | 03:15 |
tqtran | r1chardj0n3s: not sure how you would reproduce the error, im just doing this all on theory | 03:15 |
r1chardj0n3s | sure, and you can. my point is that apparently the underlying service API is not giving you one | 03:15 |
r1chardj0n3s | *if* the underlying service API throws a sensible HTTP status code back at us, I pass that up to the REST API caller (you). Otherwise, you get a 500. | 03:16 |
*** jacalcat has joined #openstack-horizon | 03:16 | |
r1chardj0n3s | GIGO :) | 03:16 |
tqtran | r1chardj0n3s: i see, so thats how it works today | 03:16 |
r1chardj0n3s | there is no other data for me to pass up, AFAICT | 03:16 |
r1chardj0n3s | no other error information | 03:16 |
r1chardj0n3s | there *is* the context information from inside the REST API code itself (ie. which service API is being invoked) | 03:17 |
*** gary-smith_ has joined #openstack-horizon | 03:17 | |
*** Poornima has joined #openstack-horizon | 03:17 | |
*** gary-smith_ has quit IRC | 03:17 | |
r1chardj0n3s | but adding cruft around that is one of the reasons I *don't* want to see such complexity in the REST API code | 03:17 |
r1chardj0n3s | the multiple calls should be performed *on the client* so it can do sensible things, not needing additional logic coded into the | 03:18 |
r1chardj0n3s | REST API | 03:18 |
r1chardj0n3s | ie. your client should be calling user_create, roles_for_user and add_tenant_for_role itself, and doing sensible things in response to failures itself | 03:19 |
tqtran | r1chardj0n3s: im fine with doing it that way. i think the only action that should be batch are deletes | 03:20 |
r1chardj0n3s | \o/ | 03:20 |
r1chardj0n3s | I'll be happy to clean up that POST to remove that extra logic ;) | 03:21 |
r1chardj0n3s | I will need to add new REST API endpoints for roles_for_user and add_tenant_for_role | 03:21 |
r1chardj0n3s | no biggie | 03:21 |
tqtran | r1chardj0n3s: well, its not like you can batch create users, doesnt make sense | 03:21 |
r1chardj0n3s | indeed | 03:22 |
tqtran | r1chardj0n3s: lets handle it case by case, because i know that for instances, you can batch create, but we can deal with it then | 03:22 |
r1chardj0n3s | ok, so I'll look at re-working the REST API to split out those calls. any thoughts about what they should look like in a REST API? | 03:23 |
tqtran | r1chardj0n3s: and i have a feeling its probably still ok to do it the way we do it now anyway, because of the async nature, the amount of time we lost is fairly negibile up to a point | 03:23 |
tqtran | r1chardj0n3s: thats up to you =) i'll comment when you're done | 03:23 |
r1chardj0n3s | haha, thanks :) | 03:23 |
*** dsneddon has quit IRC | 03:24 | |
tqtran | r1chardj0n3s: it will make handling error messages easier to deal with going forward as well | 03:24 |
tqtran | r1chardj0n3s: because we know exactly which API failed | 03:24 |
r1chardj0n3s | yep! | 03:24 |
tqtran | r1chardj0n3s: and if the API error message is too vague, client can easily step in to produce a more readible message | 03:24 |
*** david-lyle is now known as david-lyle_afk | 03:24 | |
r1chardj0n3s | yep | 03:25 |
*** dsneddon has joined #openstack-horizon | 03:26 | |
*** ongk has quit IRC | 03:38 | |
*** tqtran is now known as tqtran_afk | 03:39 | |
Piet | What is the min and max number of security groups in Horizon? I'm looking for an estimate. | 03:39 |
*** colinmcnamara has quit IRC | 03:43 | |
*** dsneddon has quit IRC | 03:46 | |
rbertram | tqtran_afk: yep, I have not forgotten https://review.openstack.org/#/c/112654/ - I will update/rebase again if a core somewhere is paying attention ;-) | 03:46 |
*** dsneddon has joined #openstack-horizon | 03:48 | |
*** bradjones has quit IRC | 03:51 | |
*** colinmcnamara has joined #openstack-horizon | 03:59 | |
*** dsneddon has quit IRC | 04:07 | |
*** dsneddon has joined #openstack-horizon | 04:08 | |
*** ericpeterson has joined #openstack-horizon | 04:12 | |
*** sayan has quit IRC | 04:15 | |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adding missing cancel button in create & edit subnet https://review.openstack.org/131928 | 04:17 |
*** Sukhdev has joined #openstack-horizon | 04:22 | |
*** dboik has quit IRC | 04:25 | |
*** nikunj2512 has joined #openstack-horizon | 04:27 | |
*** colinmcnamara has quit IRC | 04:28 | |
*** dsneddon has quit IRC | 04:28 | |
*** dsneddon has joined #openstack-horizon | 04:29 | |
*** sbfox has joined #openstack-horizon | 04:42 | |
*** vkmc has quit IRC | 04:43 | |
*** lhcheng has joined #openstack-horizon | 04:47 | |
*** jacalcat has quit IRC | 04:48 | |
*** dsneddon has quit IRC | 04:49 | |
*** sayan has joined #openstack-horizon | 04:49 | |
*** dsneddon has joined #openstack-horizon | 04:50 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Keystone REST API for angular front end. https://review.openstack.org/139532 | 04:54 |
*** Sukhdev has quit IRC | 04:58 | |
*** tzumainn has quit IRC | 05:07 | |
*** ericpeterson has quit IRC | 05:08 | |
*** dsneddon has quit IRC | 05:10 | |
*** dsneddon has joined #openstack-horizon | 05:11 | |
*** sayan has quit IRC | 05:12 | |
*** sbfox has quit IRC | 05:20 | |
*** dsneddon has quit IRC | 05:30 | |
*** dsneddon has joined #openstack-horizon | 05:31 | |
*** sbfox has joined #openstack-horizon | 05:38 | |
*** tqtran_afk is now known as tqtran | 05:51 | |
*** dsneddon has quit IRC | 05:51 | |
tqtran | r1chardj0n3s: might need to move utils.py to this patch https://review.openstack.org/#/c/136676/30 instead | 05:51 |
tqtran | rbertram: i'm paying attention =) | 05:52 |
r1chardj0n3s | tqtran: why? I think it belongs in the base patch so others can build their APIs using it... | 05:52 |
r1chardj0n3s | tqtran: also, why u not asleep? :) | 05:52 |
*** dsneddon has joined #openstack-horizon | 05:52 | |
tqtran | r1chardj0n3s: precisely, utils.py should be in the 1st patch, not the REST identity patch | 05:53 |
tqtran | r1chardj0n3s: lol i'm cooking a very late dinner | 05:53 |
r1chardj0n3s | wait. it's *in* the 1st patch. oh, I see, it also appears to be in the second patch... um | 05:53 |
r1chardj0n3s | clearly I don't git | 05:53 |
r1chardj0n3s | no, wait | 05:54 |
r1chardj0n3s | https://review.openstack.org/#/c/136676/ is the base patch providing the core for REST APIs to build on, it has utils.py | 05:54 |
r1chardj0n3s | https://review.openstack.org/#/c/139532/ is the dependent patch building on that for keystone/identity | 05:55 |
tqtran | r1chardj0n3s: so "git checkout <2nd patch>", then "git rebase -i <1s patch>", then "git review" | 05:55 |
tqtran | r1chardj0n3s: yes, utils should appear in the 1st patch, not the 2nd | 05:56 |
r1chardj0n3s | oh, crap, I've been rebasing on master for the 2nd patch :P | 05:56 |
r1chardj0n3s | as I said, I clearly don't git :) | 05:56 |
r1chardj0n3s | I'll fix that in a bit, got some in-flight stuff on the 1st patch I need to clear up | 05:56 |
tqtran | r1chardj0n3s: ok | 05:56 |
*** Poornima has quit IRC | 05:59 | |
r1chardj0n3s | when I "git rebase -i rest-api" I get two commits - should I squash those into one? | 06:00 |
r1chardj0n3s | if I don't then the rebase fails with just "could not apply <the first commit>" | 06:00 |
r1chardj0n3s | I've merged the first branch into the second | 06:01 |
*** masco has joined #openstack-horizon | 06:01 | |
sambetts | r1chardj0n3s: you should have 2 commits I belive, andthen when you push gerrit understands its a depenant | 06:02 |
r1chardj0n3s | weird, there's a 3rd commit in the git log, but rebase doesn't offer me the ability to remove it in rebase | 06:02 |
r1chardj0n3s | and it has its own change-id which is baaad | 06:02 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/140239 | 06:03 |
r1chardj0n3s | oh, man, this log is messed up now :( | 06:03 |
r1chardj0n3s | tqtran: http://paste.openstack.org/show/147644/ | 06:04 |
r1chardj0n3s | tqtran: so the base change now appears twice in the log \o/ | 06:04 |
r1chardj0n3s | on either side of the actual change for this branch \o/ | 06:04 |
r1chardj0n3s | ARGH :) | 06:05 |
tqtran | r1chardj0n3s: haha, i'll rebase i for you | 06:07 |
tqtran | r1chardj0n3s: but yeah, sam is right. you actually commiting 2, and gerrit will understand and create dependency | 06:08 |
*** freyes has quit IRC | 06:12 | |
*** dsneddon has quit IRC | 06:12 | |
*** Ephur has quit IRC | 06:13 | |
*** Ephur has joined #openstack-horizon | 06:13 | |
*** dsneddon has joined #openstack-horizon | 06:13 | |
*** freyes has joined #openstack-horizon | 06:13 | |
*** nlahouti has joined #openstack-horizon | 06:15 | |
*** nlahouti has quit IRC | 06:17 | |
*** nlahouti has joined #openstack-horizon | 06:18 | |
r1chardj0n3s | sam? | 06:19 |
r1chardj0n3s | oh sambetts :_ | 06:19 |
r1chardj0n3s | :) | 06:19 |
r1chardj0n3s | so that 2 commit thing is what I've had all along, rebasing on master | 06:19 |
r1chardj0n3s | if I try to rebase on the rest-api it tells me to sod off | 06:20 |
openstackgerrit | Thai Tran proposed openstack/horizon: REST API for angular front end. https://review.openstack.org/136676 | 06:20 |
r1chardj0n3s | tqtran: what did your push ^^ just do? | 06:22 |
openstackgerrit | Thai Tran proposed openstack/horizon: Keystone REST API for angular front end. https://review.openstack.org/139532 | 06:23 |
tqtran | r1chardj0n3s: ok all done | 06:23 |
r1chardj0n3s | done what?! :) | 06:23 |
tqtran | r1chardj0n3s: i moved the utils.py from identity to rest | 06:24 |
tqtran | r1chardj0n3s: just take a look at your patch, you will understand | 06:24 |
r1chardj0n3s | oh, there was an edit to utils.py that had snuck into the keystone patch, I see | 06:25 |
r1chardj0n3s | ok, I coulda fixed that if I knew that was the problem | 06:25 |
r1chardj0n3s | I was all confused because I thought I'd screwed up some git thing :/ | 06:25 |
tqtran | r1chardj0n3s: haha thats what i was trying to tell you the entire time | 06:25 |
r1chardj0n3s | but you were all rebase is wrong and stuff and then I screwed up my local git big time and I've been undoing that mess for the last 30 minutes :( | 06:26 |
r1chardj0n3s | I'm gonna see if I can just get my work from this afternoon into the review and be done for the day | 06:26 |
r1chardj0n3s | and now the version up on gerrit is ahead of my local branch and I have local changes to commit to the change | 06:27 |
r1chardj0n3s | I *think* if I "git pull ssh://richard@review.openstack.org:29418/openstack/horizon refs/changes/32/139532/5" I can merge from that | 06:28 |
tqtran | r1chardj0n3s: lol ok, i'm gonna log off for the night then. since my patch depends on yours, i'll have to wait until you sort it all out | 06:29 |
tqtran | nite richard and sam | 06:29 |
*** tqtran has quit IRC | 06:29 | |
r1chardj0n3s | night! | 06:30 |
openstackgerrit | Merged openstack/horizon: Improving more projects link in context selection https://review.openstack.org/138501 | 06:40 |
*** russellb has quit IRC | 06:43 | |
*** russellb has joined #openstack-horizon | 06:44 | |
openstackgerrit | Richard Jones proposed openstack/horizon: REST API for angular front end. https://review.openstack.org/136676 | 06:46 |
*** rdobosz has joined #openstack-horizon | 06:54 | |
*** rdobosz is now known as _gryf | 06:55 | |
*** dsneddon has quit IRC | 06:55 | |
*** _gryf has quit IRC | 06:55 | |
*** dsneddon has joined #openstack-horizon | 06:55 | |
*** lhcheng has quit IRC | 06:56 | |
*** _gryf has joined #openstack-horizon | 06:56 | |
*** Longgeek has joined #openstack-horizon | 06:57 | |
*** k4n0 has joined #openstack-horizon | 07:15 | |
*** dsneddon has quit IRC | 07:15 | |
*** dsneddon has joined #openstack-horizon | 07:17 | |
*** e0ne has joined #openstack-horizon | 07:27 | |
*** den9ie has quit IRC | 07:31 | |
*** den9ie has joined #openstack-horizon | 07:31 | |
*** mrunge has joined #openstack-horizon | 07:33 | |
*** sayan has joined #openstack-horizon | 07:45 | |
*** jtomasek has joined #openstack-horizon | 07:52 | |
*** tnovacik has joined #openstack-horizon | 07:58 | |
*** jprovazn has joined #openstack-horizon | 08:04 | |
*** qba73 has joined #openstack-horizon | 08:07 | |
*** wuhg has joined #openstack-horizon | 08:09 | |
*** nlahouti has quit IRC | 08:09 | |
*** dkorn has joined #openstack-horizon | 08:16 | |
*** aberezin has quit IRC | 08:32 | |
openstackgerrit | Jiri Tomasek proposed openstack/horizon: Reorganized scss imports https://review.openstack.org/133703 | 08:32 |
*** jcoufal has joined #openstack-horizon | 08:33 | |
*** akrivoka has joined #openstack-horizon | 08:39 | |
nikunj2512 | jtomasek: Hi.. This related to the bug you filed- https://bugs.launchpad.net/horizon/+bug/1399126 | 08:43 |
*** MaxV has joined #openstack-horizon | 08:44 | |
*** den9ie has quit IRC | 08:45 | |
*** markus_z has joined #openstack-horizon | 08:47 | |
openstackgerrit | Richard Jones proposed openstack/horizon: REST API for angular front end. https://review.openstack.org/136676 | 08:48 |
openstackgerrit | Richard Jones proposed openstack/horizon: Keystone REST API for angular front end. https://review.openstack.org/139532 | 08:50 |
*** ala_ has joined #openstack-horizon | 08:51 | |
jtomasek | nikunj2512: Hi, great that you're looking at that issue | 08:52 |
nikunj2512 | jtomasek: Can you tell which identity link you are talking about | 08:52 |
nikunj2512 | ? | 08:52 |
*** e0ne has quit IRC | 08:53 | |
jtomasek | nikunj2512: it is in header - sorry for the missinformation in the bug summary | 08:54 |
jtomasek | nikunj2512: /home/stack/horizon/openstack_dashboard/templates/_header.html line 20 | 08:54 |
openstackgerrit | Richard Jones proposed openstack/horizon: Keystone REST API for angular front end. https://review.openstack.org/139532 | 08:55 |
nikunj2512 | jtomasek: Ok | 08:55 |
*** jcoufal_ has joined #openstack-horizon | 08:55 | |
nikunj2512 | jtomasek: But in the UI, when you open the horizon the browser, where it comes>?? Can u tell me that?/ | 08:56 |
*** sayan has quit IRC | 08:56 | |
jtomasek | nikunj2512: in the topbar - project dropdown at the bottom below the line | 08:57 |
jtomasek | nikunj2512: it says "More Projects" | 08:58 |
nikunj2512 | Yes | 08:58 |
nikunj2512 | jtomasek: Got it | 08:58 |
nikunj2512 | jtomasek: Thank you | 08:58 |
jtomasek | np! | 08:58 |
nikunj2512 | jtomasek: will it be possible for you to include this info in the bug details | 08:58 |
nikunj2512 | ? | 08:58 |
*** jcoufal has quit IRC | 08:59 | |
jtomasek | nikunj2512: ok, I'll add it there | 08:59 |
*** romainh has joined #openstack-horizon | 09:02 | |
*** den9ie has joined #openstack-horizon | 09:05 | |
*** aberezin has joined #openstack-horizon | 09:08 | |
*** ygbo has joined #openstack-horizon | 09:12 | |
openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/140239 | 09:19 |
*** gerchardon has joined #openstack-horizon | 09:24 | |
*** athomas has joined #openstack-horizon | 09:28 | |
*** Longgeek has quit IRC | 09:32 | |
*** oro has joined #openstack-horizon | 09:34 | |
*** Longgeek has joined #openstack-horizon | 09:35 | |
*** aix has joined #openstack-horizon | 09:35 | |
openstackgerrit | Merged openstack/horizon: wrong message while deleting non empty pseudo folder https://review.openstack.org/120755 | 09:37 |
*** sbfox has quit IRC | 09:39 | |
*** e0ne has joined #openstack-horizon | 09:44 | |
*** openstack295 has joined #openstack-horizon | 09:49 | |
*** openstack295 has quit IRC | 09:50 | |
*** cedrics has joined #openstack-horizon | 09:52 | |
*** cedrics has quit IRC | 09:59 | |
*** cedrics has joined #openstack-horizon | 10:02 | |
*** katyafervent has left #openstack-horizon | 10:06 | |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Update project list in the header bar. https://review.openstack.org/137369 | 10:20 |
*** MaxV has quit IRC | 10:26 | |
*** MaxV has joined #openstack-horizon | 10:26 | |
*** MaxV has quit IRC | 10:33 | |
*** MaxV has joined #openstack-horizon | 10:33 | |
*** MaxV has quit IRC | 10:33 | |
*** MaxV has joined #openstack-horizon | 10:33 | |
openstackgerrit | LIU Yulong proposed openstack/horizon: Add help text to BatchAction https://review.openstack.org/139908 | 10:35 |
*** den9ie has quit IRC | 10:38 | |
*** john-davidge has joined #openstack-horizon | 10:39 | |
*** cedrics has quit IRC | 10:44 | |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Update project list in the header bar. https://review.openstack.org/137369 | 10:46 |
*** NikitaKonovalov has quit IRC | 10:48 | |
*** NikitaKonovalov has joined #openstack-horizon | 10:49 | |
*** den9ie has joined #openstack-horizon | 10:50 | |
openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Add a scale-out dialog https://review.openstack.org/135583 | 10:53 |
*** Longgeek has quit IRC | 10:54 | |
*** Longgeek has joined #openstack-horizon | 10:56 | |
*** ZZelle has quit IRC | 10:57 | |
sambetts | night tqtran | 10:57 |
*** ZZelle has joined #openstack-horizon | 10:57 | |
*** MaxV has quit IRC | 11:10 | |
*** romainh has quit IRC | 11:16 | |
*** alexpilotti has joined #openstack-horizon | 11:17 | |
openstackgerrit | Merged openstack/tuskar-ui: Add a scale-out dialog https://review.openstack.org/135583 | 11:19 |
*** aix has quit IRC | 11:19 | |
*** MaxV has joined #openstack-horizon | 11:22 | |
*** tosky has joined #openstack-horizon | 11:27 | |
*** aix has joined #openstack-horizon | 11:32 | |
*** yingjun has joined #openstack-horizon | 11:33 | |
*** yingjun has quit IRC | 11:34 | |
*** htruta has joined #openstack-horizon | 11:41 | |
*** MaxV has quit IRC | 11:44 | |
nikunj2512 | Is anyone knows how to get to know if a panel is disabled or not? | 11:45 |
*** vkmc has joined #openstack-horizon | 11:47 | |
*** vkmc has quit IRC | 11:47 | |
*** vkmc has joined #openstack-horizon | 11:47 | |
*** e0ne has quit IRC | 11:49 | |
*** cedrics has joined #openstack-horizon | 11:52 | |
*** romainh has joined #openstack-horizon | 11:53 | |
*** jtomasek has quit IRC | 11:54 | |
*** e0ne has joined #openstack-horizon | 11:55 | |
*** qba73 has quit IRC | 11:57 | |
openstackgerrit | Jamie Lennox proposed openstack/django_openstack_auth: Use standard test loading features https://review.openstack.org/140200 | 11:58 |
openstackgerrit | Jamie Lennox proposed openstack/django_openstack_auth: Use keystone auth plugins https://review.openstack.org/140308 | 11:58 |
*** tnovacik has quit IRC | 11:58 | |
*** nikunj2512 has quit IRC | 11:58 | |
*** MaxV has joined #openstack-horizon | 12:00 | |
*** colinmcnamara has joined #openstack-horizon | 12:05 | |
*** cedricss has joined #openstack-horizon | 12:06 | |
*** cedrics has quit IRC | 12:09 | |
*** bradjones has joined #openstack-horizon | 12:20 | |
*** raildo has joined #openstack-horizon | 12:25 | |
*** colinmcnamara has quit IRC | 12:25 | |
*** jamielennox is now known as jamielennox|away | 12:29 | |
*** akrivoka_ has joined #openstack-horizon | 12:30 | |
*** e0ne has quit IRC | 12:31 | |
*** akrivoka has quit IRC | 12:32 | |
*** colinmcnamara has joined #openstack-horizon | 12:38 | |
*** e0ne has joined #openstack-horizon | 12:40 | |
*** romainh has left #openstack-horizon | 12:41 | |
*** alexpilotti has quit IRC | 12:46 | |
*** colinmcnamara has quit IRC | 12:51 | |
*** Longgeek has quit IRC | 12:58 | |
*** Longgeek has joined #openstack-horizon | 13:04 | |
openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Data_processing] fix job_executions table https://review.openstack.org/125927 | 13:07 |
*** _crobertsrh is now known as crobertsrh | 13:07 | |
*** jtomasek has joined #openstack-horizon | 13:08 | |
*** john-davidge has quit IRC | 13:10 | |
*** jtomasek has quit IRC | 13:10 | |
*** jtomasek has joined #openstack-horizon | 13:11 | |
*** radez_g0n3 is now known as radez | 13:18 | |
*** doug-fish has joined #openstack-horizon | 13:18 | |
*** alexpilotti has joined #openstack-horizon | 13:25 | |
*** tnovacik has joined #openstack-horizon | 13:48 | |
*** tnovacik has quit IRC | 13:48 | |
*** tnovacik has joined #openstack-horizon | 13:48 | |
*** jacalcat has joined #openstack-horizon | 13:49 | |
*** tzumainn has joined #openstack-horizon | 13:49 | |
*** Longgeek_ has joined #openstack-horizon | 13:52 | |
*** Longgeek has quit IRC | 13:52 | |
*** oro has quit IRC | 13:58 | |
*** julim has joined #openstack-horizon | 13:58 | |
*** nikunj2512_ has joined #openstack-horizon | 13:58 | |
*** Sukhdev has joined #openstack-horizon | 13:59 | |
nikunj2512_ | Does anyone knows how to find out where a panel is disabled or not? | 13:59 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Prevent user from disabling her current project https://review.openstack.org/138383 | 14:06 |
*** oro has joined #openstack-horizon | 14:10 | |
*** peristeri has joined #openstack-horizon | 14:10 | |
*** cedricss has quit IRC | 14:11 | |
*** dkorn has quit IRC | 14:15 | |
*** tnovacik has quit IRC | 14:19 | |
*** k4n0 has quit IRC | 14:21 | |
*** Longgeek_ has quit IRC | 14:22 | |
*** nikunj2512_ has quit IRC | 14:26 | |
*** jacalcat has quit IRC | 14:28 | |
*** Longgeek has joined #openstack-horizon | 14:29 | |
openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Data_processing] fix job_executions table https://review.openstack.org/125927 | 14:29 |
openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Data_processing] fix job_executions table https://review.openstack.org/125927 | 14:29 |
*** mattfarina has joined #openstack-horizon | 14:33 | |
*** tnovacik has joined #openstack-horizon | 14:37 | |
*** yingjun has joined #openstack-horizon | 14:39 | |
*** Longgeek has quit IRC | 14:39 | |
*** athomas has quit IRC | 14:39 | |
*** jtomasek has quit IRC | 14:41 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: [WIP]Allowing editing of node group templates https://review.openstack.org/139705 | 14:43 |
*** akrivoka_ has quit IRC | 14:44 | |
*** Longgeek has joined #openstack-horizon | 14:44 | |
*** jtomasek has joined #openstack-horizon | 14:44 | |
*** jtomasek has quit IRC | 14:46 | |
*** jtomasek has joined #openstack-horizon | 14:46 | |
*** athomas has joined #openstack-horizon | 14:47 | |
*** e0ne has quit IRC | 14:49 | |
*** e0ne has joined #openstack-horizon | 14:51 | |
*** ericpeterson has joined #openstack-horizon | 14:51 | |
ericpeterson | hi | 14:51 |
*** nikunj2512_ has joined #openstack-horizon | 14:52 | |
*** yingjun has quit IRC | 14:54 | |
*** alexpilotti_ has joined #openstack-horizon | 14:54 | |
*** yingjun has joined #openstack-horizon | 14:54 | |
*** lhcheng has joined #openstack-horizon | 14:55 | |
*** tnovacik has quit IRC | 14:56 | |
*** alexpilotti has quit IRC | 14:57 | |
*** alexpilotti_ is now known as alexpilotti | 14:57 | |
*** yingjun has quit IRC | 14:59 | |
openstackgerrit | Eric Peterson proposed openstack/django_openstack_auth: Horizon login page contains DOS attack mechanism https://review.openstack.org/140352 | 14:59 |
openstackgerrit | Eric Peterson proposed openstack/horizon: Horizon login page contains DOS attack mechanism https://review.openstack.org/140353 | 15:00 |
*** dboik has joined #openstack-horizon | 15:00 | |
*** k4n0 has joined #openstack-horizon | 15:01 | |
*** jprovazn has quit IRC | 15:06 | |
*** yingjun has joined #openstack-horizon | 15:08 | |
*** tnovacik has joined #openstack-horizon | 15:09 | |
*** vijendar has quit IRC | 15:10 | |
*** woodm1979 has joined #openstack-horizon | 15:11 | |
*** yingjun has quit IRC | 15:11 | |
*** yingjun has joined #openstack-horizon | 15:11 | |
*** david-lyle has joined #openstack-horizon | 15:21 | |
*** gokrokve has joined #openstack-horizon | 15:21 | |
*** Sukhdev has quit IRC | 15:22 | |
*** yingjun has quit IRC | 15:23 | |
*** gokrokve has quit IRC | 15:32 | |
*** gokrokve has joined #openstack-horizon | 15:33 | |
*** wuhg has quit IRC | 15:33 | |
*** ericpeterson has quit IRC | 15:34 | |
*** trown has quit IRC | 15:35 | |
*** trown has joined #openstack-horizon | 15:36 | |
*** tnovacik has quit IRC | 15:37 | |
*** ericpeterson has joined #openstack-horizon | 15:37 | |
*** rebelagentm has joined #openstack-horizon | 15:37 | |
*** tnovacik has joined #openstack-horizon | 15:38 | |
*** jpomero has joined #openstack-horizon | 15:38 | |
*** sayan has joined #openstack-horizon | 15:41 | |
*** dboik has quit IRC | 15:41 | |
*** vijendar has joined #openstack-horizon | 15:42 | |
*** ongk has joined #openstack-horizon | 15:45 | |
openstackgerrit | LIU Yulong proposed openstack/horizon: Add Content-Length to swift object upload header https://review.openstack.org/140376 | 15:45 |
*** neelashah has joined #openstack-horizon | 15:46 | |
*** jprovazn has joined #openstack-horizon | 15:50 | |
*** lhcheng_ has joined #openstack-horizon | 15:50 | |
*** lhcheng_ has quit IRC | 15:50 | |
*** lhcheng_ has joined #openstack-horizon | 15:51 | |
*** lhcheng has quit IRC | 15:53 | |
openstackgerrit | Brianna Poulos proposed openstack/horizon: Add volume type encryption delete https://review.openstack.org/140055 | 15:53 |
*** sivy has joined #openstack-horizon | 15:56 | |
sivy | mornin all | 15:56 |
sivy | anyone ever tried to make cross-region api calls within horizon? | 15:56 |
sivy | i'm trying to auto-create a failover server during create instance, in a different region to the current region | 15:58 |
*** sayan has quit IRC | 15:58 | |
sivy | most api calls within horizon take the already-authentcated request as the basis | 15:58 |
*** rebelagentm has quit IRC | 15:59 | |
sivy | which already has the region set | 15:59 |
*** tqtran has joined #openstack-horizon | 16:00 | |
*** jcoufal_ has quit IRC | 16:02 | |
david-lyle | sivy, yes | 16:02 |
*** rebelagentm has joined #openstack-horizon | 16:02 | |
david-lyle | there is a patch you'll be interested in | 16:02 |
david-lyle | let me dig it up, just a sec | 16:03 |
sivy | hit me | 16:03 |
sivy | thanks | 16:03 |
*** masco has quit IRC | 16:03 | |
david-lyle | https://review.openstack.org/111854 | 16:03 |
*** Sukhdev has joined #openstack-horizon | 16:03 | |
david-lyle | that makes cross region calls | 16:04 |
david-lyle | I foresee more cross region calls in the future | 16:05 |
david-lyle | so either we need to add the region parameter to a lot more api calls, or come up with a cleaner mechanism | 16:06 |
david-lyle | I prefer the latter, but haven't had time to come up with anything yet | 16:06 |
sivy | yeah | 16:07 |
*** dboik has joined #openstack-horizon | 16:08 | |
david-lyle | sivy, so I'm open to ideas :) | 16:08 |
sivy | really, i feel like the project should be the top-level concept, with regions unde that | 16:08 |
*** oro has quit IRC | 16:08 | |
sivy | we should be able to see all instances for a project, across regions | 16:09 |
david-lyle | sivy, the reason we only show one region is due to response time | 16:09 |
sivy | so fix response time :P | 16:10 |
david-lyle | page loads are already slow, making those same API calls by X regions, ugh | 16:10 |
sivy | yeah i know | 16:10 |
david-lyle | sivy, ideally this will be helped by moving the data load to the client side and doing it asynchronously | 16:10 |
david-lyle | then we can try to fetch more data, but not block the page load on it | 16:11 |
*** regebro has joined #openstack-horizon | 16:12 | |
openstackgerrit | Kevin Benton proposed openstack/horizon: Provide tenant_id in Neutron create requests https://review.openstack.org/133884 | 16:12 |
*** ttrifonow is now known as zz_ttrifonow | 16:13 | |
david-lyle | sivy, in the mean time, as general rule, we need to be judicious with how much data we attempt to load at once | 16:14 |
sivy | understood. | 16:14 |
*** colinmcnamara has joined #openstack-horizon | 16:14 | |
*** cbader has joined #openstack-horizon | 16:15 | |
sivy | whoa that's a hella patch | 16:15 |
openstackgerrit | Chad Roberts proposed openstack/horizon: [WIP]Allowing editing of cluster templates https://review.openstack.org/139707 | 16:15 |
sivy | bit more than i can easily integrate | 16:15 |
david-lyle | I was just pointing to it for the mechanism | 16:15 |
david-lyle | that's for cross region instance search | 16:16 |
sivy | gotcha | 16:16 |
sivy | i'll review it. I'd be happy right now to have an easy-ish way to fire off api calls for a diff region | 16:16 |
david-lyle | the api/nova.py is something we have for other api calls already | 16:17 |
david-lyle | passing the region value as a param is going to be the easiest right now | 16:17 |
*** nlahouti has joined #openstack-horizon | 16:17 | |
*** david-lyle has quit IRC | 16:20 | |
openstackgerrit | Merged openstack/django_openstack_auth: Horizon login page contains DOS attack mechanism https://review.openstack.org/140352 | 16:21 |
*** tnovacik has joined #openstack-horizon | 16:25 | |
tristanC | Hello folks, just to inform you we are about to send an advisory for https://launchpad.net/bugs/1394370, and only stable/icehouse is missing a +2 ( https://review.openstack.org/140356 ) | 16:28 |
sivy | david-lyle: is there a sample patch for that pass-region-to-the-api thing | 16:28 |
*** Piet has quit IRC | 16:29 | |
*** k4n0 has quit IRC | 16:34 | |
*** gokrokve has quit IRC | 16:36 | |
sivy | huh, that has to patch all the clients and client calls | 16:40 |
sivy | looks like I can construct the client with request.user, request.tokenid | 16:42 |
sivy | and the correct region | 16:42 |
sivy | in the authurl | 16:42 |
*** devlaps has joined #openstack-horizon | 16:42 | |
*** ayoung has quit IRC | 16:44 | |
*** ayoung has joined #openstack-horizon | 16:44 | |
*** markus_z has quit IRC | 16:46 | |
*** tosky has quit IRC | 16:47 | |
openstackgerrit | Merged openstack/horizon: Horizon login page contains DOS attack mechanism https://review.openstack.org/140353 | 16:47 |
* ericpeterson has used up all his attempts at getting gates to pass on the first try for this decade | 16:48 | |
*** bpokorny has joined #openstack-horizon | 16:51 | |
*** jacalcat has joined #openstack-horizon | 16:54 | |
*** lhcheng_ has quit IRC | 16:58 | |
*** crobertsrh has quit IRC | 17:06 | |
*** MaxV_ has joined #openstack-horizon | 17:09 | |
*** MaxV has quit IRC | 17:09 | |
*** dboik has quit IRC | 17:10 | |
*** ala_ has quit IRC | 17:10 | |
*** masco has joined #openstack-horizon | 17:13 | |
*** dboik has joined #openstack-horizon | 17:17 | |
*** jacalcat has quit IRC | 17:19 | |
*** lhcheng has joined #openstack-horizon | 17:21 | |
*** sayan has joined #openstack-horizon | 17:21 | |
*** woodm1979 has quit IRC | 17:23 | |
*** gokrokve has joined #openstack-horizon | 17:25 | |
*** MaxV_ has quit IRC | 17:26 | |
*** MaxV has joined #openstack-horizon | 17:27 | |
*** MaxV has quit IRC | 17:27 | |
*** MaxV has joined #openstack-horizon | 17:27 | |
*** MaxV has quit IRC | 17:30 | |
*** ygbo has quit IRC | 17:31 | |
*** e0ne has quit IRC | 17:31 | |
*** nikunj2512_ has quit IRC | 17:31 | |
*** nikunj2512_ has joined #openstack-horizon | 17:31 | |
*** ayoung is now known as ayoung-lunch | 17:35 | |
openstackgerrit | Gary W. Smith proposed openstack/horizon: Add horizon support for multi-attached volumes https://review.openstack.org/108165 | 17:48 |
*** aberezin has quit IRC | 17:48 | |
*** nikunj2512_ has quit IRC | 17:50 | |
*** dboik has quit IRC | 17:52 | |
*** sbfox has joined #openstack-horizon | 17:52 | |
*** gokrokve has quit IRC | 17:52 | |
*** gokrokve has joined #openstack-horizon | 17:53 | |
*** cedrics has joined #openstack-horizon | 17:54 | |
*** david-lyle_afk is now known as david-lyle | 17:58 | |
*** packet has joined #openstack-horizon | 17:59 | |
*** Piet has joined #openstack-horizon | 18:00 | |
*** Sukhdev has quit IRC | 18:03 | |
*** masco has quit IRC | 18:07 | |
*** jamielennox|away is now known as jamielennox | 18:09 | |
*** clu_ has joined #openstack-horizon | 18:11 | |
*** athomas has quit IRC | 18:13 | |
openstackgerrit | Gloria Gu proposed openstack/horizon: No delete volume action for volume with snapshots https://review.openstack.org/136431 | 18:14 |
*** sivy has quit IRC | 18:15 | |
*** crobertsrh has joined #openstack-horizon | 18:16 | |
*** jamielennox is now known as jamielennox|away | 18:16 | |
*** radez is now known as radez_g0n3 | 18:24 | |
openstackgerrit | Shilla Saebi proposed openstack/horizon: changes to settings.rst file in dev docs https://review.openstack.org/140425 | 18:28 |
*** bpokorny_ has joined #openstack-horizon | 18:31 | |
*** cedrics has quit IRC | 18:31 | |
*** mrunge has quit IRC | 18:31 | |
*** cedrics has joined #openstack-horizon | 18:32 | |
*** bpokorn__ has joined #openstack-horizon | 18:33 | |
*** bpokorny has quit IRC | 18:34 | |
*** dkorn has joined #openstack-horizon | 18:35 | |
*** kumartin has joined #openstack-horizon | 18:36 | |
*** bpokorny_ has quit IRC | 18:36 | |
*** dboik has joined #openstack-horizon | 18:37 | |
*** Sukhdev has joined #openstack-horizon | 18:39 | |
*** cedricss has joined #openstack-horizon | 18:40 | |
*** bpokorny has joined #openstack-horizon | 18:41 | |
*** cedrics has quit IRC | 18:42 | |
*** e0ne has joined #openstack-horizon | 18:43 | |
*** dkorn has quit IRC | 18:44 | |
*** bpokorn__ has quit IRC | 18:44 | |
*** ZZelle_ has joined #openstack-horizon | 18:45 | |
*** sbfox has quit IRC | 18:45 | |
*** dkorn has joined #openstack-horizon | 18:46 | |
*** dkorn has joined #openstack-horizon | 18:49 | |
*** sbfox has joined #openstack-horizon | 18:55 | |
*** cedricss has quit IRC | 18:59 | |
*** vijendar has quit IRC | 19:01 | |
*** radez_g0n3 is now known as radez | 19:03 | |
*** dkorn has quit IRC | 19:08 | |
*** jprovazn has quit IRC | 19:08 | |
*** bpokorny has quit IRC | 19:12 | |
*** bradjones has quit IRC | 19:16 | |
*** bpokorny has joined #openstack-horizon | 19:17 | |
*** aix has quit IRC | 19:20 | |
*** Longgeek has quit IRC | 19:20 | |
*** vkmc has quit IRC | 19:20 | |
*** fischerw has joined #openstack-horizon | 19:24 | |
*** dkorn has joined #openstack-horizon | 19:26 | |
*** bradjones has joined #openstack-horizon | 19:29 | |
*** zul has quit IRC | 19:31 | |
*** dkorn has quit IRC | 19:31 | |
*** jacalcat has joined #openstack-horizon | 19:34 | |
*** zul has joined #openstack-horizon | 19:34 | |
*** zul has quit IRC | 19:35 | |
*** cedrics has joined #openstack-horizon | 19:35 | |
*** zul has joined #openstack-horizon | 19:37 | |
*** vkmc has joined #openstack-horizon | 19:41 | |
*** vkmc has quit IRC | 19:41 | |
*** vkmc has joined #openstack-horizon | 19:41 | |
*** MaxV has joined #openstack-horizon | 19:41 | |
*** kumartin has quit IRC | 19:41 | |
openstackgerrit | Gloria Gu proposed openstack/horizon: Fixed issue of progress bars in resize instance https://review.openstack.org/117053 | 19:45 |
*** exploreshaifali has joined #openstack-horizon | 19:47 | |
*** cedrics has quit IRC | 19:51 | |
*** dkorn has joined #openstack-horizon | 19:52 | |
*** vijendar has joined #openstack-horizon | 19:54 | |
*** vijendar has quit IRC | 19:55 | |
*** vijendar has joined #openstack-horizon | 19:55 | |
*** ayoung-lunch is now known as ayoung | 20:00 | |
*** dkorn has quit IRC | 20:02 | |
r1chardj0n3s | morning | 20:03 |
*** colinmcnamara has quit IRC | 20:06 | |
openstackgerrit | Amogh proposed openstack/horizon: Integration tests - Instances tests https://review.openstack.org/117091 | 20:07 |
*** jtomasek has quit IRC | 20:09 | |
*** ericpeterson has quit IRC | 20:12 | |
*** jrist has quit IRC | 20:14 | |
*** colinmcnamara has joined #openstack-horizon | 20:14 | |
*** MaxV has quit IRC | 20:15 | |
*** Longgeek has joined #openstack-horizon | 20:20 | |
*** MaxV has joined #openstack-horizon | 20:23 | |
openstackgerrit | Amogh proposed openstack/horizon: Integration tests - 3 new form fields https://review.openstack.org/133095 | 20:23 |
openstackgerrit | Amogh proposed openstack/horizon: Add navigation among pages https://review.openstack.org/110425 | 20:23 |
openstackgerrit | Amogh proposed openstack/horizon: Integration tests - Instances tests https://review.openstack.org/117091 | 20:23 |
openstackgerrit | Amogh proposed openstack/horizon: Add TabbedFormRegion to Integration tests https://review.openstack.org/126478 | 20:23 |
*** colinmcnamara has quit IRC | 20:23 | |
*** Piet has quit IRC | 20:24 | |
*** jpomero_ has joined #openstack-horizon | 20:25 | |
openstackgerrit | Merged openstack/horizon: Change arrow transparent borders to inset borders https://review.openstack.org/138098 | 20:26 |
*** jrist has joined #openstack-horizon | 20:26 | |
*** Longgeek has quit IRC | 20:26 | |
*** jpomero has quit IRC | 20:27 | |
*** dkorn has joined #openstack-horizon | 20:32 | |
*** Sukhdev has quit IRC | 20:38 | |
openstackgerrit | Randy Bertram proposed openstack/horizon: With angular hz module, use strict & avoid globals https://review.openstack.org/112654 | 20:40 |
rbertram | tqtran: rebased as requested: https://review.openstack.org/#/c/112654/ | 20:42 |
*** dsneddon has quit IRC | 20:48 | |
*** dsneddon has joined #openstack-horizon | 20:49 | |
*** dkorn has quit IRC | 20:49 | |
*** bradjones has quit IRC | 20:52 | |
*** Piet has joined #openstack-horizon | 20:53 | |
Piet | There is an update to the "Select a Flavor" step in the Launch Instance workflow. Feel free to leave comments. http://invis.io/EF1UDBY6M | 20:56 |
*** Sukhdev has joined #openstack-horizon | 20:56 | |
*** bpokorny_ has joined #openstack-horizon | 20:58 | |
*** sbfox has quit IRC | 20:59 | |
*** jamielennox|away is now known as jamielennox | 20:59 | |
*** bpokorny has quit IRC | 21:00 | |
tqtran | rbertram: done! | 21:00 |
SlickNik | would appreciate some eyeballs on https://review.openstack.org/#/c/122939/ when folks get a chance. Thanks! | 21:01 |
*** akrivoka has joined #openstack-horizon | 21:02 | |
tqtran | Piet: i like the circles at the top, looks really nice | 21:05 |
*** sayan has quit IRC | 21:06 | |
Piet | Yeah I know! Chris gets credit for that! | 21:06 |
openstackgerrit | Andrew Lazarev proposed openstack/horizon: [Sahara] Fixed display of nodegroup template service parameters https://review.openstack.org/140476 | 21:07 |
*** dkorn has joined #openstack-horizon | 21:11 | |
Piet | Just a heads-up, we're getting ready to run a large sample card sort starting next week. Looking for both operator/admins and end users (both horizon and non-horizon users) HP will be giving away three tablets as a sweepstakes. | 21:12 |
*** akrivoka has quit IRC | 21:12 | |
openstackgerrit | George Peristerakis proposed openstack/horizon: Generating a rdp file for a windows instance https://review.openstack.org/91394 | 21:15 |
*** dkorn has quit IRC | 21:16 | |
*** MaxV has quit IRC | 21:16 | |
*** MaxV has joined #openstack-horizon | 21:17 | |
lhcheng | Piet: Is there an invite I can forward to our folks here that might be interested. | 21:17 |
*** julim has quit IRC | 21:18 | |
Piet | I'm hoping to send something to the group next week | 21:18 |
openstackgerrit | Neill Cox proposed openstack/horizon: WIP - Single page navigation - angular https://review.openstack.org/137980 | 21:18 |
lhcheng | Piet: cool, thanks for that | 21:19 |
*** colinmcnamara has joined #openstack-horizon | 21:19 | |
Piet | Yup - no problem! It will be cool to see the results. Melissa Meingast will be doing the analysis for us. | 21:20 |
Piet | Melissa is a Human Factors Engineer with HP and very good with stats. | 21:20 |
*** Longgeek has joined #openstack-horizon | 21:22 | |
r1chardj0n3s | Piet: that sounds like a Good Thing, great to see! | 21:22 |
ekarlso- | Piet: card sort ? :p | 21:23 |
Piet | Here's an example of a card sort - http://www.optimalworkshop.com/optimalsort-demo | 21:24 |
Piet | We're running one to understand the information architecture in Horizon | 21:25 |
*** colinmcnamara has quit IRC | 21:25 | |
*** TravT has quit IRC | 21:25 | |
*** Longgeek has quit IRC | 21:26 | |
*** colinmcnamara has joined #openstack-horizon | 21:30 | |
openstackgerrit | George Peristerakis proposed openstack/horizon: Attach a floating ip to an created instance https://review.openstack.org/132486 | 21:31 |
*** alexpilotti has quit IRC | 21:35 | |
openstackgerrit | George Peristerakis proposed openstack/horizon: [WIP] Standardize the exception handling thrown by services. https://review.openstack.org/134058 | 21:35 |
openstackgerrit | Andrew Lazarev proposed openstack/horizon: [Sahara] Moved security options to separate tab of ng template https://review.openstack.org/140485 | 21:38 |
*** Sukhdev_ has joined #openstack-horizon | 21:39 | |
*** Sukhdev has quit IRC | 21:39 | |
david-lyle | SlickNik: is there a bug to link that too? | 21:40 |
david-lyle | s/too/to/ | 21:40 |
SlickNik | david-lyle: Let me check. I'll create one if it doesn't already exist. | 21:41 |
david-lyle | thanks, otherwise, LGTM | 21:41 |
*** TravT has joined #openstack-horizon | 21:42 | |
*** TravT has quit IRC | 21:42 | |
*** TravT has joined #openstack-horizon | 21:43 | |
*** dkorn has joined #openstack-horizon | 21:44 | |
*** peristeri has quit IRC | 21:44 | |
*** EmilyW has joined #openstack-horizon | 21:44 | |
*** neelashah has quit IRC | 21:45 | |
*** dboik has quit IRC | 21:46 | |
*** jrist is now known as knowncitizen | 21:54 | |
*** knowncitizen is now known as jrist | 21:55 | |
*** jpomero_ has quit IRC | 21:55 | |
*** dkorn1 has joined #openstack-horizon | 21:56 | |
*** dkorn has quit IRC | 21:58 | |
*** crobertsrh has quit IRC | 21:58 | |
*** exploreshaifali has quit IRC | 22:06 | |
*** mattfarina has quit IRC | 22:06 | |
*** dkorn1 has quit IRC | 22:07 | |
*** alexpilotti has joined #openstack-horizon | 22:11 | |
*** dboik has joined #openstack-horizon | 22:12 | |
*** kumartin has joined #openstack-horizon | 22:13 | |
*** dboik_ has joined #openstack-horizon | 22:14 | |
*** dboik has quit IRC | 22:16 | |
*** KurtMartin is now known as kmartin | 22:17 | |
*** neelashah has joined #openstack-horizon | 22:21 | |
*** dkorn has joined #openstack-horizon | 22:26 | |
*** colinmcnamara has quit IRC | 22:37 | |
*** colinmcnamara has joined #openstack-horizon | 22:39 | |
Piet | We are also planning to run a usability test on the proposed Launch Instance design. | 22:44 |
Piet | In that case, we are looking for ~12 people that can spare 1.5 hrs for a remote study. | 22:44 |
*** bpokorny has joined #openstack-horizon | 22:45 | |
Piet | HP will be giving a away away one tablet as a sweepstakes to the participants. | 22:45 |
r1chardj0n3s | tqtran: nice catch on the keystone API, thanks! | 22:46 |
Piet | We are looking for end users (not operators or administrators) who are cloud devs - do not necessarily need to have experience with OpenStack. | 22:46 |
openstackgerrit | Thai Tran proposed openstack/horizon: WIP angularize identity users. Most things are broken. https://review.openstack.org/133767 | 22:47 |
Piet | Let me know if you know of anyone that would be interested in participating. | 22:47 |
*** bpokorny_ has quit IRC | 22:48 | |
r1chardj0n3s | Piet: I'll ask around! | 22:48 |
tqtran | Piet: ooo tablet, too bad im not cloud devs | 22:49 |
r1chardj0n3s | tqtran: I'm seriously considering splitting the four classes in the keystone api into eight, and have the /id/ path stuff go to a separate class so the path element isn't optional (and silliness like the delete "if id is none" branch goes away) | 22:50 |
openstackgerrit | Gloria Gu proposed openstack/horizon: Fixed issue of progress bars in resize instance https://review.openstack.org/117053 | 22:51 |
r1chardj0n3s | tqtran: on the {data: []} return from the GET methods, how would {items: []} sound as a slightly clearer noun? | 22:53 |
tqtran | i like data more, since its more generic | 22:53 |
tqtran | there might be times where we are not sending items back | 22:53 |
r1chardj0n3s | hang on, this is setting the specific pattern from GET-returning-list-of-things | 22:54 |
r1chardj0n3s | I'm not wrapping GET-a-single-thing in {data: object} | 22:54 |
r1chardj0n3s | and I loathe too-generic names :) | 22:54 |
tqtran | well... you might need to | 22:54 |
tqtran | say your API has paging | 22:55 |
tqtran | how does client know there are more data it needs to fetch? | 22:55 |
tqtran | if all you're returning is a list of items? | 22:55 |
r1chardj0n3s | how does that apply to GET-a-single-thing? | 22:55 |
r1chardj0n3s | no, I agree that GET-a-list-of-things must return {items: []} with the option of a has_more if it's supported | 22:55 |
*** ongk has quit IRC | 22:55 | |
tqtran | i like having a consistent data format. makes client code a bit easier to write. | 22:56 |
tqtran | but im fine either way, you can decide. | 22:56 |
tqtran | i dont think there are ever instances were we get only a single item? | 22:57 |
r1chardj0n3s | GET /users/<id> | 22:57 |
r1chardj0n3s | GET /users/current | 22:57 |
r1chardj0n3s | etc | 22:57 |
*** devlaps has quit IRC | 22:58 | |
*** gokrokve has quit IRC | 22:58 | |
tqtran | ok, im fine with it. | 22:59 |
*** gokrokve has joined #openstack-horizon | 22:59 | |
tqtran | as for splitting the classes, not sure how that will help? the amount of code will be roughly the same, and its already pretty simple to follow | 23:00 |
*** kumartin has quit IRC | 23:00 | |
*** freyes has quit IRC | 23:00 | |
tqtran | but again, its up to you, i'm sure we'll get feedback once you put it up | 23:00 |
*** dkorn has quit IRC | 23:01 | |
*** colinmcnamara has quit IRC | 23:01 | |
r1chardj0n3s | I don't like the overloading of the methods, and I don't like the confusion in the docstrings. | 23:01 |
*** freyes has joined #openstack-horizon | 23:02 | |
tqtran | ok SGTM | 23:02 |
*** lhcheng has quit IRC | 23:02 | |
*** alexpilotti has quit IRC | 23:02 | |
*** lhcheng_ has joined #openstack-horizon | 23:02 | |
*** jamielennox is now known as jamielennox|away | 23:05 | |
*** neelashah has quit IRC | 23:06 | |
*** rebelagentm has quit IRC | 23:06 | |
*** Longgeek has joined #openstack-horizon | 23:10 | |
openstackgerrit | Andrew Lazarev proposed openstack/horizon: [Sahara] Added links to security groups https://review.openstack.org/140518 | 23:11 |
*** e0ne has quit IRC | 23:14 | |
*** e0ne has joined #openstack-horizon | 23:15 | |
*** Longgeek has quit IRC | 23:15 | |
*** mikedillion has joined #openstack-horizon | 23:16 | |
*** jacalcat has quit IRC | 23:17 | |
*** bpokorny has quit IRC | 23:18 | |
*** Piet has quit IRC | 23:19 | |
*** fischerw has quit IRC | 23:19 | |
*** mikedillion has quit IRC | 23:23 | |
*** dkorn has joined #openstack-horizon | 23:23 | |
*** mikedillion has joined #openstack-horizon | 23:23 | |
*** jamielennox|away is now known as jamielennox | 23:24 | |
*** e0ne has quit IRC | 23:26 | |
*** dkorn has quit IRC | 23:31 | |
*** bpokorny has joined #openstack-horizon | 23:33 | |
*** aberezin has joined #openstack-horizon | 23:33 | |
*** lhcheng_ has quit IRC | 23:36 | |
*** sbfox has joined #openstack-horizon | 23:36 | |
*** lhcheng has joined #openstack-horizon | 23:37 | |
*** lhcheng_ has joined #openstack-horizon | 23:39 | |
*** lhcheng_ has quit IRC | 23:39 | |
*** Sukhdev_ has quit IRC | 23:39 | |
*** lhcheng_ has joined #openstack-horizon | 23:40 | |
*** kumartin has joined #openstack-horizon | 23:41 | |
*** lhcheng has quit IRC | 23:41 | |
*** rebrego has joined #openstack-horizon | 23:41 | |
*** regebro has quit IRC | 23:41 | |
*** rebrego is now known as regebro | 23:41 | |
*** lhcheng has joined #openstack-horizon | 23:42 | |
*** dboik_ has quit IRC | 23:43 | |
*** lhcheng_ has quit IRC | 23:44 | |
*** MaxV has quit IRC | 23:47 | |
*** jrist is now known as knowncitizen | 23:48 | |
*** knowncitizen is now known as jrist_ | 23:49 | |
*** jrist_ is now known as jrist | 23:50 | |
*** dkorn has joined #openstack-horizon | 23:50 | |
*** jrist is now known as jrist_ | 23:50 | |
*** jrist_ is now known as jrist | 23:51 | |
*** raildo_ has joined #openstack-horizon | 23:53 | |
*** aberezin has quit IRC | 23:55 | |
*** dkorn has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!